toga-ai 1.0.655 → 1.0.656

package/knowledge/2.0/apps/_underscore/features/acl-permission-chain.md

@@ -65,6 +65,13 @@ writable). Without it the field is rejected on write **and** is unreadable:
   VISIBILITY too.** Concrete symptom (TRUE-79191): `Measures.measureType` was registered but ungranted,
   so it came back absent and the frontend unit dropdowns were empty. When a field renders blank with no
   error, check for a missing `AclFieldPermissions` grant before suspecting the selector or the data.
+- **⚠ Sibling columns of the SAME table routinely carry DIFFERENT role sets, so verify per field
+  before you add one to a `fields=` list — and verify as the LEAST-privileged role.** Concrete case
+  (`Client_Quad.Currencies`, 2026-08-26): `code` (1424) and `symbol` (1425) are granted to roles
+  1/7/8/9, but `position` (1997) only to 7/8/9. Adding `currency.position` to an existing read would
+  have 403'd the **whole** request for every user holding only role 1 — while working perfectly for a
+  developer whose own account also carries role 7. **A dev/admin account hides this class of bug
+  completely**; a "just one more field" addition is a permission change, not a display change.
 - **`AclFieldPermissions` is `UNIQUE (recordFieldId, roleId)`** (Client blank DDL) — guard inserts
   with `NOT EXISTS`. For a **read-only, server-written** field (one populated by a `postPost`
   interceptor rather than the API caller), grant `isWritable = 0`.
@@ -403,6 +410,12 @@ hardcoded `Core.RecordFields` id literals instead of a subselect.
       and every repo is on the **same branch** so the generated model matches the DB.
 
 ## Change history
+- 2026-08-26 - Added the **verify-per-sibling-field, verify-as-the-least-privileged-role** rule:
+  columns of the same table often carry different role sets, so adding one more field to a `fields=`
+  list is a permission change. `Client_Quad.Currencies` grants `code` (1424) and `symbol` (1425) to
+  roles 1/7/8/9 but `position` (1997) only to 7/8/9, so requesting `currency.position` would have
+  403'd the whole read for role-1-only users while looking fine to a developer who also holds role 7 -
+  a dev/admin account hides this class of bug entirely. (bala)
 - 2026-08-26 - Added the **action-flag gate** (`Core.AclActions` + `Client_*.AclActionPermissions`),
   a third gate alongside record CRUD and record scripts: `Page.php` (~L1285-1302) defaults every
   action flag to `false` and only a matching `AclActionPermissions` row flips it true, so a missing

package/knowledge/2.0/apps/toga-blox/INDEX.md

@@ -7,7 +7,7 @@
 | [AdvancedSelect (virtualized single/multi select)](features/advanced-select.md) | `AdvancedSelect<T>` is a **fully controlled, virtualized** single/multi select built from scratch (not react-select) on **`@tanstack/react-virtual`**, for large | toga-blox/src/components/AdvancedSelect/AdvancedSelect.tsx, toga-blox/src/components/AdvancedSelect/AdvancedSelect.types.ts, toga-blox/src/components/AdvancedSelect/AdvancedSelect.module.css |
 | [API client (axios wrapper, auth, table-data fetchers)](features/api-client.md) | `src/api/` is a thin **axios** wrapper that standardizes the **2.0 API envelope**, manages auth (Bearer + refresh), serializes complex query options, and provid | toga-blox/src/reactQuery/queryHelpers.ts, toga-blox/src/api/index.ts, toga-blox/src/api/axiosInstance.ts, toga-blox/src/api/apiFunctions.ts, toga-blox/src/api/auth.ts, toga-blox/src/api/genericApi.ts, toga-blox/src/api/types.ts, toga-blox/src/api/tableData |
 | [BaseInput (react-hook-form field factory)](features/base-input.md) | `BaseInput` is a **form-field factory** driven by react-hook-form. | toga-blox/src/components/BaseInput/BaseInput.tsx, toga-blox/src/components/BaseInput/BaseInput.types.ts, toga-blox/src/components/BaseInput/BaseInput.module.css, toga-blox/src/components/BaseInput/components |
-| [Primary Table templates (server/client, sizing, virtualization)](features/primary-table-templates.md) | `src/templates/PrimaryTable/` is the **production, wired-up table** built on the [Table component](table.md). | toga-blox/src/templates/PrimaryTable/PrimaryTable.tsx, toga-blox/src/templates/PrimaryTable/PrimaryTableServerTemplate.tsx, toga-blox/src/templates/PrimaryTable/PrimaryTableClientTemplate.tsx, toga-blox/src/templates/PrimaryTable/PrimaryTableHeaderCell.tsx, toga-blox/src/templates/PrimaryTable/PrimaryTableBodyCell.tsx, toga-blox/src/templates/PrimaryTable/PrimaryTableRow.tsx, toga-blox/src/templates/PrimaryTable/PrimaryTableExpandableRow.tsx, toga-blox/src/templates/PrimaryTable/types.ts |
+| [Primary Table templates (server/client, sizing, virtualization)](features/primary-table-templates.md) | `src/templates/PrimaryTable/` is the **production, wired-up table** built on the [Table component](table.md). | toga-blox/src/components/Table/themeConfig/toga.module.css, toga-blox/src/templates/PrimaryTable/PrimaryTable.tsx, toga-blox/src/templates/PrimaryTable/PrimaryTableServerTemplate.tsx, toga-blox/src/templates/PrimaryTable/PrimaryTableClientTemplate.tsx, toga-blox/src/templates/PrimaryTable/PrimaryTableHeaderCell.tsx, toga-blox/src/templates/PrimaryTable/PrimaryTableBodyCell.tsx, toga-blox/src/templates/PrimaryTable/PrimaryTableRow.tsx, toga-blox/src/templates/PrimaryTable/PrimaryTableExpandableRow.tsx, toga-blox/src/templates/PrimaryTable/types.ts |
 | [TableRecordModal (record-detail modal shell)](features/table-record-modal.md) | `TableRecordModal` is a **generic, presentational modal shell** for showing a single table record (row) in detail — typically opened from a table row click. | toga-blox/src/components/TableRecordModal/TableRecordModal.tsx, toga-blox/src/components/TableRecordModal/index.ts, toga-blox/src/components/TableRecordModal/tableRecordModal.module.css |
 | [Table component (cells, action cells, filters & sorts, hooks, theming)](features/table.md) | The `Table` component (`src/components/Table/`) is the **TanStack Table v8** building block behind the [Primary Table templates](primary-table-templates.md). | toga-blox/src/components/Table/hooks/useFetchTablePageMeta.ts, toga-blox/src/api/types.ts, toga-blox/src/components/Table/index.ts, toga-blox/src/components/Table/types.ts, toga-blox/src/components/Table/utils/buildTanstackColumns.tsx, toga-blox/src/components/Table/utils/resolveCellType.tsx, toga-blox/src/components/Table/components/cellTypes, toga-blox/src/components/Table/components/actionCells, toga-blox/src/components/Table/components/columnFiltersAndSorts, toga-blox/src/components/Table/hooks, toga-blox/src/components/Table/themeConfig |
 | [Talos AI-Assistant Component (launcher + slide-out chat panel)](features/talos-assistant.md) | `Talos` is a **shared, pure-UI** AI-assistant component in `@agilant/toga-blox`: a header launcher button (`TalosLauncher`) plus a slide-out chat panel (`TalosP | toga-blox/src/components/Talos/TalosLauncher.tsx, toga-blox/src/components/Talos/TalosPanel.tsx, toga-blox/src/components/Talos/TalosMessage.tsx, toga-blox/src/components/Talos/types.ts, toga-blox/src/components/Talos/theme.ts, toga-blox/src/components/Talos/helpers.tsx, toga-blox/src/components/Talos/stub.ts, toga-blox/src/components/Talos/Talos.module.css, toga-blox/src/components/Talos/index.ts, toga-blox/src/components/index.ts |

package/knowledge/2.0/apps/toga-blox/features/primary-table-templates.md

@@ -6,9 +6,10 @@ project: TOGa Blox
 client: shared
 type: feature
 status: active
-updated: 2026-08-17
+updated: 2026-08-26
 owners: [apeterson]
 files:
+  - toga-blox/src/components/Table/themeConfig/toga.module.css
   - toga-blox/src/templates/PrimaryTable/PrimaryTable.tsx
   - toga-blox/src/templates/PrimaryTable/PrimaryTableServerTemplate.tsx
   - toga-blox/src/templates/PrimaryTable/PrimaryTableClientTemplate.tsx
@@ -82,8 +83,29 @@ spacer rows computed from the virtualizer item `.start`/`.end` minus `scrollMarg
 `supply-modal-table` skin **disables virtualization** (renders all rows, min-height 300px).
 Sticky columns use a `--sticky-offset` CSS variable summed from neighboring column widths.
 
+## The "Show more" hover affordance is CSS-driven, not JS-driven
+
+A truncated body cell reveals its "Show more" toggle **on hover via CSS only**:
+`.bodyCell:hover .showMoreWrapper:not(.expandedWrapper) button` in
+`themeConfig/toga.module.css` (plus a `:focus-visible` rule so keyboard users can reach it).
+`Cellstyles.module.css` already shipped `.toggle { opacity: 0 }` + a hover rule — the CSS
+hover-reveal was the original design. `PrimaryTableBodyCell` must **not** inline-set the collapsed
+`opacity`; inline styles beat the cascade and hand visibility back to React state. Layout props
+(flex/sizing) stay inline; visibility does not. The React `isTruncated` state is now for
+**capability detection only** (does this cell need a toggle at all), and `clearTruncationHint`
+runs unconditionally — it no longer no-ops while `isExpanded`.
+
 ## Gotchas
 
+- **Never gate a hover affordance on a JS `mouseleave` inside a virtualized table.** `mouseleave`
+  is not guaranteed to fire: a virtualized row can translate out from under a stationary cursor on
+  wheel-scroll, and any early-return in the clear handler strands the "hovered" flag set. The toggle
+  then stays visible on cells the mouse is nowhere near. Drive visibility from CSS `:hover`, which
+  **cannot** get stuck, and keep JS state for capability detection.
+- **Residual (accepted):** a stale `isTruncated` still keeps the flex wrapper mounted, so that one
+  cell's text ellipsizes marginally earlier until the next `mouseleave`. Cosmetically invisible;
+  clearing it properly would need a per-cell scroll listener.
+
 - Frozen widths measure only **mounted** rows; virtualized tables size from the first paint set.
 - **Header labels must never abbreviate or overlap.** The full header width is a hard floor
   (above `maxColumnWidth`, `minColumnWidth`, and pinned `columnWidths`). Measure header width
@@ -98,6 +120,15 @@ Sticky columns use a `--sticky-offset` CSS variable summed from neighboring colu
   not the column set.
 
 ## Change history
+- 2026-08-26 — Fixed: the "Show more" toggle got stuck visible on cells the mouse was not hovering.
+  `.toggle` already had `opacity: 0` + a CSS hover rule, but `PrimaryTableBodyCell` inline-set
+  `opacity: 1` unconditionally (inline beats the cascade), so visibility depended entirely on the
+  `isTruncated` state set on `mouseenter`/cleared on `mouseleave` — and `mouseleave` is not
+  guaranteed to fire (virtualized row translating out from under a stationary cursor on wheel-scroll;
+  `clearTruncationHint` no-opping while `isExpanded`). Visibility is now CSS `:hover`-driven
+  (`.bodyCell:hover .showMoreWrapper:not(.expandedWrapper) button` + `:focus-visible`), the collapsed
+  inline `opacity` was removed, and the `isExpanded` guard dropped from `clearTruncationHint`.
+  Shipped in `1.0.334-sandbox-client.136`. (apeterson)
 - 2026-08-17 — Fixed clipped/abbreviated headers: full header width is now a hard floor for every
   column (not capped by max-width, not overridden by `minColumnWidth`, applied even to pinned
   `columnWidths` — the old `return def.size` bypass left pinned columns clipped). Added a

package/knowledge/2.0/apps/toga-blox/features/table.md

@@ -6,7 +6,7 @@ project: TOGa Blox
 client: shared
 type: feature
 status: active
-updated: 2026-08-25
+updated: 2026-08-26
 owners: [apeterson]
 files:
   - toga-blox/src/components/Table/hooks/useFetchTablePageMeta.ts
@@ -60,6 +60,15 @@ alignment (CVA `cellWrapperVariants`), expandable, and copyable behavior. Empty/
 render `EmptyCell`. If `imageUrlField` is set, the URL is resolved separately and passed to
 `ImageCell`.
 
+**The expandable wrap is destructive, and is now denied for status types.** When the table-meta
+flag `isExpandableCell` is set on a field, the expandable branch does **not** wrap the
+already-rendered `content` — it discards it and re-renders the **raw `value`** inside
+`<ExpandableCell maxLength={40} expandable>`. Any rich cell type loses its component that way
+(a status column rendered as truncated text with a "Show more" toggle instead of a badge).
+`NEVER_EXPANDABLE_TYPES` (`STATUS`, `STATUS_BADGE`) now gates that branch, so status columns keep
+their badge regardless of the meta flag. Fixing it in the renderer covers every client and
+environment instead of chasing per-client `isExpandableCell` data rows.
+
 ## Cell types (`components/cellTypes/`)
 
 | Component | Type | Renders |
@@ -153,6 +162,16 @@ layer and emits it — see
 
 ## Gotchas
 
+- **`isExpandableCell` still clobbers every other rich cell type.** Only `STATUS`/`STATUS_BADGE`
+  are protected today. `URGENCY`, `BOOLEAN`, `CURRENCY`, `DATE`, `AVATAR` and `CLIENT` carry the
+  **same latent defect** — set the flag on one of those fields and the cell degrades to raw
+  truncated text. The fuller fix is inverting the deny-list into an **allowlist** (expandable only
+  for free-text/default cells); deliberately not done yet.
+- **A cell-rendering difference between local and a deployed environment is usually DB data, not
+  code.** `isExpandableCell` is a per-field flag in the **server's table meta**, so the same blox
+  build renders differently against two databases. Diff the branches over the cell-rendering files
+  **first** (`git diff <feature> origin/_sandbox-client -- src/components/Table/...`); if that comes
+  back empty, stop reading code and go look at the table-meta rows.
 - `MIN_COLUMN_WIDTH = 120` is the shrink floor only for columns with **no** explicit width.
 - **Never truncate header labels.** `truncateCells` (`.truncateCells .headerCellLabel` in
   `toga.module.css`) is for **body** values only; it must apply only `white-space: nowrap` to
@@ -198,6 +217,15 @@ layer and emits it — see
   requires `npm run build` before it takes effect at runtime.
 
 ## Change history
+- 2026-08-26 — Fixed: status columns rendered as truncated text with a "Show more" toggle instead of
+  a badge. Root cause was in `resolveCellType` — the `isExpandableCell` branch **discards** the
+  rendered `content` and re-renders the raw `value` in `ExpandableCell`. Added
+  `NEVER_EXPANDABLE_TYPES` (`STATUS`, `STATUS_BADGE`) to gate it. Recorded that the same defect is
+  latent for `URGENCY`/`BOOLEAN`/`CURRENCY`/`DATE`/`AVATAR`/`CLIENT` (an allowlist is the fuller
+  fix, not done). Also recorded the debugging lesson: the "works locally, broken on deployed
+  `_sandbox-client`" symptom was **not** a code difference — the branch diff over the cell-rendering
+  files was empty; `isExpandableCell` was set in the sandbox-client DB and unset locally. Shipped in
+  `1.0.334-sandbox-client.136`. (apeterson)
 - 2026-08-25 — `useFetchTablePageMeta` now prefers **server-supplied `filterOptions`** and skips the
   `recordRoute` fetch for those fields (query list + index lookup share one `needsFetchedOptions`
   predicate so they can't skew); `filterOptions[].uuid` made optional and `surfaceSlug` declared on

package/knowledge/2.0/apps/toga-blox/features/toaster.md

@@ -30,8 +30,9 @@ declaration is invalid-at-computed-value-time and dropped.
 
 As of 2026-08-26 the component ships **default values via `var(--token, fallback)`**, so it renders
 fully styled with no host configuration, while any host-defined `--toaster-*` token still wins.
-*(All Toaster changes below are working-tree on blox `feature-new-table` and commerce `TRUE-80707` —
-not yet merged or published; verify against the installed version before relying on them.)*
+The blox-side changes are **merged and published** as of 2026-08-26 in
+`@agilant/toga-blox@1.0.334-sandbox-client.136` (dist-tag `sandbox-client`). The commerce-side
+rewiring (`TRUE-80707`) is still a separate branch — verify that half against the installed app.
 
 ## How it works
 
@@ -90,6 +91,9 @@ visually in a browser**.
 
 ## Change history
 
+- 2026-08-26 — The blox-side fallback work above was committed, merged to `_sandbox-client` and
+  **published** as `1.0.334-sandbox-client.136`; superseded the earlier "working-tree, not yet
+  merged or published" caveat. (apeterson)
 - 2026-08-26 — Toaster now ships **default styling** via `var(--token, fallback)` on every custom
   property (renders styled with zero host config; host tokens still win) and gained the missing
   `border-style`/`border-radius`/`font-family`/`font-size`/`margin-block` on `.base`. Fixed two

package/knowledge/2.0/apps/toga-blox/workflows/dynamic-publish-pipeline.md

@@ -6,7 +6,7 @@ project: TOGa Blox
 client: shared
 type: workflow
 status: active
-updated: 2026-08-04
+updated: 2026-08-26
 owners: [jcardinal, apeterson]
 files:
   - toga-blox/.github/workflows/publish.yml
@@ -109,11 +109,36 @@ environment needs its own maintained `_<mode>` branch in `toga-blox-npm`.
   `react-router-dom` appeared in blox's `peerDependencies` but only three files referenced it, two of
   them tests; the single production reference was a **dead `import { Link }`** on line 1 of
   `src/components/old/BaseButton/BaseButton.tsx` (the component renders an injected `linkComponent`
-  prop instead). The peer declaration and the dead import were removed *(working-tree on
-  `feature-new-table` — not yet merged or published)*; `react-router-dom` stays a
+  prop instead). The peer declaration and the dead import were removed and are **published** as of
+  2026-08-26 in `1.0.334-sandbox-client.136`; `react-router-dom` stays a
   **devDependency** (`^6.30.1`) for the tests' `MemoryRouter`. Verified clean build, zero
   `react-router-dom` references in `dist/`, and vitest identical to baseline. This peer was the
   stated reason consumers pass `--legacy-peer-deps` against a router-7 app.
+- **A feature branch that never touches the version line merges without a version conflict —
+  and that is why the bump has to happen afterwards.** Observed 2026-08-26: `feature-new-table` sat
+  at base `1.0.322` while `_sandbox-client` was at `1.0.332`. The merge auto-resolved the `version`
+  line to `1.0.332` with **no conflict**, because only `_sandbox-client` had ever edited it (the
+  "47 behind" commits are that same release plumbing — see the gotcha above). The bump to `1.0.333`
+  was then made **on `_sandbox-client`**, at the developer's explicit direction. That **deviates
+  from the `deploy-sandbox-client` skill's "never commit the bump directly to `_sandbox-client`"
+  rule.** It was safe *only* because the feature branch does not carry the version line, so nothing
+  could be clobbered — **record this as a one-off, not a new default.** CI then published base+1 →
+  `1.0.334-sandbox-client.136`.
+- **`gh` is not installed on every dev machine.** The skill's `gh run watch` monitoring step simply
+  does not work there. Fall back to polling the registry:
+  `npm view @agilant/toga-blox@sandbox-client version` (or `npm dist-tag ls @agilant/toga-blox`)
+  until the new version appears — the registry is the authoritative confirmation anyway.
+- **Consuming apps pin exactly, so a publish is only half the deploy.** After
+  `1.0.334-sandbox-client.136` shipped, `toga25-supply` on `_sandbox-client` was still pinned to
+  `1.0.333-sandbox-client.134` and needed a pin bump + reinstall. Likewise the feature branch stays
+  at its old base version after the bump lands on `_sandbox-client` — expect the two to be out of
+  step and don't read it as a problem.
+- **⚠ Credentials have been found in the local git remote URL.** Verified 2026-08-26: the `origin`
+  remote for the `toga-blox-npm` checkout had a **GitHub PAT embedded in plaintext in the URL**
+  (visible to anything that runs `git remote get-url origin`, and to any tool that reads
+  `.git/config`). Check for this and re-point the remote at SSH or a credential helper; treat any
+  token found this way as compromised and rotate it. This is the local-config sibling of the
+  committed-`.npmrc` violation already recorded in `../../../standards/frontend.md`.
 - **FontAwesome v7 `style`-prop TS2322** (fixed 2026-07-21 in `getFontAwesomeIcon.tsx`, and a
   reusable pattern for any consumer). FA v7 types the `FontAwesomeIcon` `style` prop as
   `CSSProperties & CSSVariables`, where `CSSVariables` requires a `--fa-*` custom-property index
@@ -143,6 +168,16 @@ environment needs its own maintained `_<mode>` branch in `toga-blox-npm`.
   the pattern the consuming apps should follow (see the commerce workflow's secret-hygiene note).
 
 ## Change history
+- 2026-08-26 — Deployed `1.0.334-sandbox-client.136` (`feature-new-table` → `_sandbox-client`, 6
+  files, no conflicts) and recorded three workflow gotchas from it: (1) a feature branch that never
+  touches the `version` line merges without a version conflict, which is why the bump lands on
+  `_sandbox-client` afterwards — a documented **deviation** from the `deploy-sandbox-client` skill's
+  "never bump on `_sandbox-client`" rule, safe here only because of that, not a new default;
+  (2) `gh` is not installed on every machine, so verify the publish by polling
+  `npm view @agilant/toga-blox@sandbox-client version` instead of `gh run watch`; (3) consuming apps
+  pin exactly and need a separate pin bump + reinstall. Also flagged that a **GitHub PAT was found
+  in plaintext in the local `origin` remote URL** (rotate + re-point at SSH/credential helper), and
+  marked the phantom `react-router-dom` peer removal as merged and published. (apeterson)
 - 2026-08-26 — Corrected the branch-topology misreading: `feature-new-table`'s "0 ahead / 47 behind"
   is release plumbing generated on `_sandbox-client`, not staleness — it remains the active dev
   branch and correct base (real source delta: 2 files). Noted the `publish.yml` divergence is a

package/knowledge/2.0/apps/toga2-supply/INDEX.md

@@ -3,7 +3,7 @@
 | Doc | Summary | Files |
 |-----|---------|-------|
 | [TOGa Supply (toga2-supply) Architecture](architecture.md) | `toga2-supply` is the **React + Vite frontend** for TOGa Supply — warehouse fulfillment tooling (shipment selection, fulfill & ship against carrier APIs, NetSui | toga2-supply/src/api/toga.ts, toga2-supply/src/pages/ShipmentItems/view/ShipmentItemsPage.tsx, toga2-supply/src/pages/EditShipment/view/EditShipmentPage.tsx, toga2-supply/src/pages/EditShipment/api/UpdateShipmentApi.ts, toga2-supply/src/pages/Shipments/view/components/ShipmentsCardTableForm/ShipmentsCardTableForm.tsx |
-| [Per-currency amount lines (CurrencyAmountLines / CurrencyAmountList) and child-row diffing](features/currency-amount-lines-editor.md) | The shared UI for "one amount per currency" on a parent record — an item's prices, a vendor item's costs. | toga2-supply/src/components/ui/CurrencyAmountLines.tsx, toga2-supply/src/pages/Items/api/itemsApi.ts, toga2-supply/src/pages/VendorItems/api/vendorItemsApi.ts |
+| [Per-currency amount lines (CurrencyAmountLines / CurrencyAmountList) and child-row diffing](features/currency-amount-lines-editor.md) | The shared UI for "one amount per currency" on a parent record — an item's prices, a vendor item's costs. | toga2-supply/src/components/ui/CurrencyAmountLines.tsx, toga2-supply/src/pages/Items/api/itemsApi.ts, toga2-supply/src/pages/VendorItems/api/vendorItemsApi.ts, toga2-supply/src/pages/Items/view/modals/viewEdit/ItemsModalContentTemplate.tsx, toga2-supply/src/pages/VendorItems/view/modals/edit/VendorItemsModalContentTemplate.tsx, toga2-supply/src/utils/formatCurrency.tsx |
 | [Fulfill & Ship](features/fulfill-and-ship.md) | Fulfill & Ship lets a warehouse user select sales-order line items, enter serials, pick a carrier/method, and in one action: create the Item Fulfillment records | _underscore/Trait/Netsuite/SalesOrder.php, dbchanges2/Client_Growrk/2026-08-10e - GrowrkUpsServiceMethodCodes.sql, toga2-supply/src/pages/EditShipment/view/EditShipmentPage.tsx, _underscore/Model/Client/Measure.php, _underscore/Model/Client/TrackingNumber.php, toga2-supply/src/pages/EditShipment/helpers/ShipmentDetailsForm/getEditShipmentFormOptions.ts, toga2-supply/src/pages/EditShipment/helpers/ShipmentDetailsForm/validateFormOnSubmit.ts, toga2-supply/src/pages/EditShipment/helpers/ShipmentDetailsForm/checkDimensions.ts, toga2-supply/src/components/ui/Tables/BasicTable/BasicTable.tsx, toga2-supply/src/components/ui/Tables/types.ts, toga2-supply/src/components/ui/GoogleMapsLink.tsx, toga2-supply/src/pages/ShipmentItems/view/forms/ShipmentItemsTable.tsx, toga2-supply/src/pages/ShipmentItems/api/ShipmentItemsApi.ts, toga2-supply/src/pages/ShipmentItems/types.ts, toga2-supply/src/pages/EditShipment/viewModel/FIELDS/RETURNLABELFIELDS.json, toga2-supply/src/pages/EditShipment/view/components/forms/EditShipmentForm.tsx, toga2-supply/src/components/ui/BaseInput/UnitSelect.tsx, toga2-supply/src/pages/EditShipment/view/modals/SerialNumbersModal.tsx, toga2-supply/src/pages/ShipmentItems/view/ShipmentItemsPage.tsx, toga2-supply/src/pages/EditShipment/view/EditShipmentPage.tsx, toga2-supply/src/pages/EditShipment/view/components/forms/EditShipmentForm.tsx, toga2-supply/src/pages/EditShipment/view/components/SelectedShipmentItemsTable.tsx, toga2-supply/src/pages/EditShipment/view/helpers/ShipmentDetailsForm/renderEditShipmentFormInput.tsx, toga2-supply/src/pages/EditShipment/viewModel/FIELDS/DUMMYUPDATESHIPMENTFIELDS.json, toga2-supply/src/pages/EditShipment/helpers/ShipmentDetailsForm/renderEditShipmentFormInput.tsx, toga2-supply/tailwind.config.cjs, toga2-supply/src/pages/EditShipment/view/modals/ReturnShippingModal.tsx, toga2-supply/src/styles/index.scss, toga2-supply/src/components/ui/BaseInput/BaseInput.tsx, toga2-supply/src/pages/EditShipment/api/UpdateShipmentApi.ts, toga2-supply/src/pages/EditShipment/viewModel/signatureTypes.ts, toga2-supply/src/pages/EditShipment/view/modals/SelectReturnAddressModal.tsx, toga2-supply/src/pages/EditShipment/helpers/ShipmentDetailsForm/formatShipmentData.ts, toga2-supply/src/pages/EditShipment/types.ts, toga2-supply/src/pages/Shipments/view/ShipmentsPage.tsx, toga2-supply/src/pages/Shipments/view/components/ShipmentsCardTableForm/ShipmentsCardTableForm.tsx, toga2-supply/src/pages/Shipments/api/ShipmentsApi.ts, toga2-supply/src/pages/Shipments/types.ts, toga2-supply/src/pages/FulfilledShipments/view/FulfilledShipmentsPage.tsx, toga2-supply/src/components/ui/CardTable/CardTable.tsx, toga2-supply/src/components/ui/CardTable/types.ts, toga2-supply/src/assets/pen-line.svg, _underscore/Model/Client/ItemFulfillment.php, _underscore/Trait/Netsuite/ItemFulfillment.php, _underscore/Component/Library/Carriers/Ups/Ups.php |
 | [Order-details field config (valueKey resolution) & the hardcoded Customer name](features/order-detail-field-config-and-customer-name.md) | The supply order-details modal is **config-driven**: each host has a JSON field list under `src/pages/Orders/view/OrderView/viewModel/FIELDS/<HOST>/`, and every | toga2-supply/src/utils/formatCustomerName.tsx, toga2-supply/src/pages/Orders/view/OrderView/components/invoices/OrderContentSection.tsx, toga2-supply/src/pages/Orders/view/OrderView/viewModel/FIELDS/, toga2-supply/src/pages/Orders/view/OrderView/viewModel/useOrderDetailsViewModel.ts, toga2-supply/src/api/toga.ts |
 | [Table-data request filters (`additionalData` → `getDataTableData`)](features/table-data-additional-filters.md) | A listing page adds its own row filters to a table-view data request by passing an **`additionalData`** prop down to the shared `useFetchData` hook, which forwa | toga2-supply/src/components/ui/Tables/hooks/useFetchData.tsx, toga2-supply/src/api/toga.ts, toga2-supply/src/pages/VendorItems/VendorItemsPage.tsx |

package/knowledge/2.0/apps/toga2-supply/features/currency-amount-lines-editor.md

@@ -12,10 +12,14 @@ files:
   - toga2-supply/src/components/ui/CurrencyAmountLines.tsx
   - toga2-supply/src/pages/Items/api/itemsApi.ts
   - toga2-supply/src/pages/VendorItems/api/vendorItemsApi.ts
+  - toga2-supply/src/pages/Items/view/modals/viewEdit/ItemsModalContentTemplate.tsx
+  - toga2-supply/src/pages/VendorItems/view/modals/edit/VendorItemsModalContentTemplate.tsx
+  - toga2-supply/src/utils/formatCurrency.tsx
 related:
   - ../architecture.md
   - ../workflows/client-host-scoping.md
   - ../../api2/features/nested-relationship-writes.md
+  - ../../_underscore/features/acl-permission-chain.md
   - ../../../../clients/quad/features/multi-currency-item-pricing.md
 ---
 
@@ -25,8 +29,9 @@ The shared UI for "one amount per currency" on a parent record — an item's pri
 costs. Two components: **`CurrencyAmountLines`** (editable, `useFieldArray`) for the create/edit
 modals, and **`CurrencyAmountList`** (read-only) for the detail views. First consumer is Quad's
 multi-currency item pricing, gated by host (`localStorage` `hostName === 'QUAD'`), but the
-components and — more importantly — the **save/diff rules below are generic**: they apply to any
-parent whose children are unique per `(parent, type, currency)`.
+components and — more importantly — the **save/diff and load-baseline rules below are generic**:
+they apply to any parent whose children are unique per `(parent, type, currency)` and are fetched
+by a request of their own.
 
 ## How it works
 
@@ -43,6 +48,63 @@ parent whose children are unique per `(parent, type, currency)`.
   issues explicit child writes (see the rules below). Existing rows carry their `uuid`; new lines
   do not.
 
+## The load baseline has THREE states, and all three must stay distinguishable
+
+The child rows arrive from their own `GET`, so the modal holds a **baseline** to diff against. The
+whole correctness story is telling apart *not read yet* / *read and empty* / *read failed* —
+`getItemPricesForItem` / `getVendorItemCostsForVendorItem` therefore return `null` for a failed read
+and `[]` for a genuinely empty one, never `[]` for both.
+
+- `null` (**not read yet, or the read failed**) — render "Loading..." / the error, and **refuse the
+  save.** An absent baseline makes every submitted line look new, so the creates collide on the
+  unique key.
+- `[]` (**read, no rows**) — render "None set." and allow the save.
+- A separate `hasLoadFailed` flag distinguishes the two `null` cases for the message.
+
+**Guard the save on `baseline === null` as well as on the failed flag** — not only on the flag. The
+still-loading window is just as destructive as the failed one.
+
+### Clear the baseline BEFORE every read, and reset the failed flag with it
+
+```
+setOriginalCostLines(null);
+setCostLoadFailed(false);
+formMethods.setValue('costs', []);   // then fetch
+```
+
+Three defects live in skipping this:
+
+1. **Not clearing on a record switch** keeps the previous record's rows in *both* the form and the
+   baseline, so a save in that window writes against the previous record's uuids.
+2. **Never resetting the failed flag** lets one record's failed read poison **every later record**
+   opened in the same mounted modal — the section shows the error forever.
+3. **A post-save refresh that returns `null` must invalidate the baseline** (set it back to `null`
+   and raise the failed flag), not silently do nothing. Leaving the pre-save baseline in place is
+   exactly the stale diff a retry then re-sends.
+
+## Two independent reads feeding one save need a save-time invariant
+
+The vendor-item modal reads its **details** (`getSingleVendorItem(activeUuid)`) in one effect and
+its **cost rows** in another. `activeUuid` comes from `useDataTableContext`, so **clicking a
+different row changes it WITHOUT remounting the modal** — every effect keyed on it re-runs against a
+live component still holding the previous record's state.
+
+- **Reject stale responses** in *both* effects (`let isStillMounted = true`, cleanup sets it false).
+  Without it a slow response for the previous record lands after the newer record's costs and
+  overwrites the details.
+- **⚠ That is necessary and NOT sufficient.** It does not close the window where the newer record's
+  **costs arrive before its details**, leaving the details on the old record with a fresh cost
+  baseline. The save then pairs one record's uuid with the other record's lines — destructive,
+  because the child `PUT` / `DELETE` address rows by their **own** uuids. Close it with an explicit
+  invariant at save time, which no request ordering can defeat:
+
+```
+if (isQuad && uuid !== activeUuid) { toast('still loading'); return; }
+```
+
+The **items** modal does not need this: it receives its record as a `parentData` prop and never
+fetches it, so there is only one read that can go stale.
+
 ## ⚠ Diffing rules — a currency change is a DELETE + CREATE, never an UPDATE
 
 The child tables are UNIQUE on `(parentId, priceTypeId, currencyId)`, and that unique key is what
@@ -63,6 +125,46 @@ makes the naive diff fail:
 5. **Refresh the diff baseline after ANY save attempt, not only a fully successful one.** Otherwise
    a retry re-sends writes that already landed (duplicate creates, deletes of rows that are gone).
 
+### ⚠ A nullable `currencyId` makes "incomplete line" and "removed line" look identical
+
+`ItemPrices.currencyId` and `VendorItemCosts.currencyId` are **NULLABLE** (while `price` / `cost`
+are `NOT NULL`). A row with a null `currencyId` returns `currency: null` from the API, so it maps to
+a line with an **empty currency code** through no fault of the user.
+
+**Build the "kept" uuid set from EVERY submitted line, not just the complete ones:**
+
+```
+// correct
+const submittedUuids = new Set(input.lines.map(l => l.uuid).filter(Boolean));
+// wrong: input.lines.filter(isCompleteLine) — an incomplete row falls out and is DELETED
+```
+
+Built from only the complete lines, that row is absent from the set, is classified as **removed**,
+and is **DELETED** even though the user never touched it. Worse than a stray delete, because the
+`_unitPrice` / `_unitCost` calculated fields **INNER JOIN `Currencies`**: such a row is **invisible
+in the grid** while the modal quietly destroys it.
+
+The state is real in production — **Compass has 1568 `ItemPrices` rows with a null `currencyId`**
+(Quad happens to have 0 today). **Rule: classify a delete on the row being REMOVED from the
+submitted array, never on the row being incomplete.**
+
+## Display conventions for the read-only list
+
+To sit flush with the rest of a detail modal, a hand-rolled label/value row must **mirror
+`OldBaseDetailRow`**, not invent its own geometry:
+
+- The label div carries padding on the **right only** (`pr-4`, no left padding), inside a
+  `flex w-full`, wrapped in `mb-1`. A fixed-width label box instead pushes the label off the left
+  edge that every other section label sits on.
+- Amounts go through the repo's existing **`utils/formatCurrency`** (2 dp + thousand separators).
+  The API returns the amount as a JSON **number**, so a trailing `.00` is dropped and one row would
+  show decimals while the next did not. `formatCurrency` throws on non-numeric input — fall back to
+  the raw amount rather than rendering nothing.
+- Final format: **code in the label column, then symbol + amount separated by `gap-1`**, with the
+  symbol **conditionally rendered** so a currency without one leaves no stray gap.
+- A host-gated branch that **replaces** a `ModalContentSection` must carry **that section's own
+  `sectionContainerClasses`**, or it sits at a different offset from every other section.
+
 ## Gotchas
 
 - A read-only currency list that reaches for form context works in the edit modal and throws in the
@@ -70,9 +172,46 @@ makes the naive diff fail:
 - A calculated field that returns the concatenated per-currency text must be declared as plain
   `FIELD_SQL` on the model, or the value is cast to `0` before it ever reaches the grid — see
   [FIELD_SQL calculated fields](../../_underscore/features/calculated-sql-fields.md).
+- **`Currencies.symbol` is requestable; `Currencies.position` may not be.** Grants differ between
+  sibling columns of the same table, and one unreadable field **403s the WHOLE `GET`** — so adding
+  `currency.position` to a fields list can blank the entire price/cost read for a low-privilege role
+  while looking fine to a developer whose account also holds an admin role. Check the grant before
+  requesting it; the concrete Quad ids are in
+  [Quad multi-currency item pricing](../../../../clients/quad/features/multi-currency-item-pricing.md).
+- **Map the amount defensively: test `null` AND `undefined`.** A `=== null`-only check renders the
+  literal string `"undefined"` as an amount when the field is missing from the response — which is
+  the normal shape for an ungranted field, see
+  [ACL permission chain](../../_underscore/features/acl-permission-chain.md).
+
+## Verified NOT applicable (do not re-raise)
+
+- **Pagination on the price/cost read is not needed.** The unique key is
+  `owner + priceType + currency` and the query filters `priceType.slug = 'each'`, so the ceiling is
+  one row per currency the client trades in — 7 for Quad, against `recordsPerPage: 100` (observed
+  max 3 for items, 1 for vendor items). Revisit only for a client with dozens of currencies or more
+  than one price type.
+- **A row cannot load with an empty amount from a null value.** `ItemPrices.price` and
+  `VendorItemCosts.cost` are both `NOT NULL`; the reachable variant is the nullable **`currencyId`**
+  above. And clearing an amount in the UI cannot silently delete a row: the amount input is
+  registered `required` and the submit handler is only reachable through `handleSubmit`, which
+  validates first.
 
 ## Change history
 
+- 2026-08-26 — CodeRabbit-review pass on the same build. Fixed a **data-loss diff**: the "kept" uuid
+  set was built from the complete lines only, so a row with a **null `currencyId`** (nullable column;
+  1568 such rows in Compass) was classified as removed and deleted unseen — invisible in the grid
+  because `_unitPrice` / `_unitCost` INNER JOIN `Currencies`. Every submitted line now counts. Added
+  the **three-state load baseline** rules (clear baseline + form + failed flag before each read;
+  invalidate the baseline when a post-save refresh returns null; refuse the save on
+  `baseline === null`, not only on the failed flag) after finding that a record switch kept the
+  previous rows and one failed read poisoned every later record. Added the **two-reads-one-save**
+  rule: `activeUuid` from `useDataTableContext` changes without remounting, so both effects reject
+  stale responses **and** the save asserts `uuid === activeUuid`, because rejecting stale responses
+  alone cannot stop the costs arriving before the details. Recorded the read-only display conventions
+  (mirror `OldBaseDetailRow`, `formatCurrency`, conditional symbol, carry `sectionContainerClasses`),
+  the `Currencies.position` field-grant trap, the `null`-vs-`undefined` amount mapper, and the two
+  review findings verified not applicable (pagination ceiling, `NOT NULL` amounts). (bala)
 - 2026-08-26 — First capture. Added the shared `CurrencyAmountLines` (editable, `useFieldArray`) and
   `CurrencyAmountList` (read-only, intentionally context-free because view mode renders outside the
   `FormProvider`) components, wired into the item / vendor-item create and edit modals behind

package/knowledge/2.0/standards/frontend.md

@@ -426,9 +426,9 @@ for **pin drift** between branches (commerce's `TRUE-80707` was 11 versions behi
 will not necessarily install them for you: verified 2026-08-18 they include `react-hook-form`,
 `@tanstack/react-query`, `@tanstack/react-table`, `framer-motion`, and `axios` (pinned exactly by
 blox at `1.8.4`). **`react-router-dom` was removed as a peer on 2026-08-26** — it was phantom (its
-only production reference was a dead `Link` import in `old/BaseButton`); *(change staged on blox
-`feature-new-table`, not yet merged/published — verify against the installed version before relying
-on it)*. A missing peer surfaces as a runtime "undefined is not a component," **or**, because a
+only production reference was a dead `Link` import in `old/BaseButton`); *(published in
+`@agilant/toga-blox@1.0.334-sandbox-client.136`, dist-tag `sandbox-client` — apps on an older pin
+still see the old peer until they bump)*. A missing peer surfaces as a runtime "undefined is not a component," **or**, because a
 **barrel import pulls blox's whole index**, as a Rollup `failed to resolve import` for a component
 you never referenced.
 
@@ -589,9 +589,8 @@ Work **around** these shared-lib defects; do **not** imitate them in app code:
   stacks** (`react-table` v7 + `@tanstack/react-table` v8) — verified 2026-08-18 in blox's peer
   deps. Know which one a given component uses before you wire it.
 - **Phantom/unused peer deps in blox's manifest** — confirmed and one now removed:
-  `react-router-dom` (dead `Link` import in `old/BaseButton`; removal staged 2026-08-26 on
-  `feature-new-table`, not yet merged/published — it stays a devDependency for the tests'
-  `MemoryRouter`). Verify a declared peer is actually reachable in `src/` before adding it to your
+  `react-router-dom` (dead `Link` import in `old/BaseButton`; removed and **published 2026-08-26 in
+  `1.0.334-sandbox-client.136`** — it stays a devDependency for the tests' `MemoryRouter`). Verify a declared peer is actually reachable in `src/` before adding it to your
   app or reaching for `--legacy-peer-deps`.
 - Supply/commerce business logic has leaked into the shared lib.
 - **No custom-validator passthrough on `BaseInput`** — hence the app-side validator layer in §7.
@@ -643,9 +642,11 @@ app work.** In a consuming app, guard against them and move on.
 
 - 2026-08-26 — Recorded commerce's missing `resolve.dedupe` (+ the blox-symlink second-React
   hazard), its caret blox pin and cross-branch pin drift, the barrel-import missing-peer trigger,
-  and the removal of blox's phantom `react-router-dom` peer. All the underlying code changes are
-  working-tree only (blox `feature-new-table`, commerce `TRUE-80707`) — unmerged and unpublished.
-  (apeterson)
+  and the removal of blox's phantom `react-router-dom` peer. The blox half is now merged and
+  published (`1.0.334-sandbox-client.136`); the commerce `TRUE-80707` half remains working-tree
+  only. (apeterson)
+- 2026-08-26 — Corrected §13(b) and §22: blox's phantom `react-router-dom` peer removal is no
+  longer "staged/unpublished" — it shipped in `1.0.334-sandbox-client.136`. (apeterson)
 - 2026-08-18 — Initial front-end (React) coding standard: universal React/TS layer + TOGA 2.0
   platform-conventions layer, mined from @agilant/toga-blox, toga25-supply, and toga25-desk; per-rule
   convergence tagging; testing/a11y/error-reporting/React-19 flagged as open. (jcardinal)

package/knowledge/clients/quad/features/multi-currency-item-pricing.md

@@ -59,6 +59,34 @@ This is why the vendor-items grid **looks** broken and is not:
   filters on (single-object filter form — see
   [table-data request filters](../../../2.0/apps/toga2-supply/features/table-data-additional-filters.md)).
 
+### `currencyId` is NULLABLE on both child tables
+
+`ItemPrices.currencyId` and `VendorItemCosts.currencyId` are nullable (the amount columns are
+`NOT NULL`). **Quad has 0 such rows today, Compass has 1568 in `ItemPrices`** — so the state is
+reachable and any diff-based editor must not treat a currency-less row as removed. A row like that
+is also **invisible in the grid**, because `_unitPrice` / `_unitCost` INNER JOIN `Currencies`. Rule
+and fix: [per-currency amount lines](../../../2.0/apps/toga2-supply/features/currency-amount-lines-editor.md).
+
+## ⚠ `Currencies` field grants — `symbol` yes, `position` no
+
+`Client_Quad.AclFieldPermissions` does **not** grant the `Currencies` columns uniformly:
+
+| Field | id | Granted to roles |
+|---|---|---|
+| `code` | 1424 | 1, 7, 8, 9 |
+| `symbol` | 1425 | 1, 7, 8, 9 |
+| `position` | **1997** | **7, 8, 9 only — not 1** |
+
+Requesting a field the caller cannot read fails the **whole request**, so putting
+`currency.position` in a `fields=` list **403s the entire price/cost read** for any user holding only
+role **1** (Base — which every Quad UI user has). It looks fine to a developer whose account also
+carries role 7, which is exactly why it is invisible in dev. `currency.symbol` is safe to request;
+`position` needs id 1997 granted to role 1 first.
+
+Not needed today: **all seven Quad currencies are `position = LEFT`**, so rendering the symbol as a
+prefix is faithful without reading the column. Mechanism:
+[ACL permission chain](../../../2.0/apps/_underscore/features/acl-permission-chain.md).
+
 ## Backend — `_unitPrice` and `_unitCost`
 
 - **`_Model_Quad_Item::_unitPrice`** returns the persona-scoped **single amount** when a
@@ -94,9 +122,16 @@ for a custom column is never read by the grid; labels must come from
 
 One shared editable component (`CurrencyAmountLines`, `useFieldArray`) plus a read-only
 `CurrencyAmountList`, wired into the item and vendor-item **create and edit** modals behind
-`localStorage` `hostName === 'QUAD'`. The save/diff rules (a currency change is a delete + create;
-all deletes before all creates; never a nested `PUT`) are generic and live in
-[per-currency amount lines](../../../2.0/apps/toga2-supply/features/currency-amount-lines-editor.md).
+`localStorage` `hostName === 'QUAD'`. The save/diff and load-baseline rules are generic and live in
+[per-currency amount lines](../../../2.0/apps/toga2-supply/features/currency-amount-lines-editor.md)
+— a currency change is a delete + create, all deletes before all creates, never a nested `PUT`, the
+"kept" uuid set is built from every submitted line (nullable `currencyId`), the child-row baseline is
+cleared before each read and refuses a save while absent, and the vendor-item save asserts
+`vendorItem.uuid === activeUuid` because its details and its cost rows come from two separate reads.
+
+Quad specifics: the item modal is fed by `parentData` (one read), the vendor-item modal fetches its
+own details (two reads), and **every change is gated on `isQuad`** — the shared table hook touched
+during the build was reverted and is byte-identical to its pre-work state.
 
 ## Vendor-items Add / Edit buttons were hidden (fixed)
 
@@ -126,6 +161,15 @@ import was never broken, only the UI was.
 
 ## Change history
 
+- 2026-08-26 — Review pass on the same build. Recorded the **`Currencies` field-grant asymmetry** in
+  `Client_Quad`: `code` (1424) and `symbol` (1425) are granted to roles 1/7/8/9 but `position` (1997)
+  only to 7/8/9, so requesting `currency.position` would have 403'd the entire price/cost read for a
+  role-1-only user while working fine for a developer who also holds role 7 — all seven Quad
+  currencies are `position = LEFT`, so a prefix symbol is faithful without it. Recorded that
+  `currencyId` is **nullable** on both child tables (Quad 0 rows, Compass 1568), which made a
+  currency-less row look "removed" to the save diff and get deleted while being invisible in the grid.
+  Measured the read ceiling (7 currencies x 1 price type ⇒ no pagination needed) and confirmed the
+  amount columns are `NOT NULL`. (bala)
 - 2026-08-26 — First capture. Built Quad per-currency item prices and vendor item costs end to end:
   `_Model_Quad_Item::_unitPrice` now returns a persona-scoped amount with a `personaId` and a
   `GROUP_CONCAT` of `'CODE amount'` pairs without one (it previously returned SQL `NULL`, so the

package/knowledge/clients/quad/profile.md

@@ -110,6 +110,12 @@ Client-specific DB change-sets live in `dbchanges2/Client_Quad/`.
   concatenated `'CODE amount'` text from `_unitPrice` / `_unitCost`, with those columns retyped
   `CURRENCY → STRING` for `Client_Quad` only. See
   [Quad multi-currency item pricing](./features/multi-currency-item-pricing.md).
+- **`Currencies.position` is NOT readable by role 1 (2026-08-26).** `Client_Quad` grants `code`
+  (1424) and `symbol` (1425) to roles 1/7/8/9 but `position` (1997) only to 7/8/9 — and one
+  unreadable field 403s the **whole** request, so putting `currency.position` in a `fields=` list
+  blanks the entire read for a role-1-only user while working for a developer who also holds role 7.
+  All seven Quad currencies are `position = LEFT`. See
+  [Quad multi-currency item pricing](./features/multi-currency-item-pricing.md).
 - **BLOCKER (2026-08-26): UI item creation 403s in prod.** `Core` record 21 (`Items`) has
   `allowCreate = 0` for every Supply role (role 1 appId 1, roles 7/8/9 appId 5); only role 3 (API)
   may create, so `POST /items` fails for a UI user. Vendor items (19), item prices (117) and vendor

package/knowledge/sessions/2026-08-26-blox-toaster-peer-deps-apeterson.md

@@ -0,0 +1,86 @@
+---
+type: session
+slug: blox-toaster-peer-deps
+title: Blox peer-dep ERESOLVE fix + Toaster host-token styling for commerce
+author: apeterson
+repos: [toga-blox, toga2-commerce, toga25-supply]
+framework: "2.0"
+client: shared
+status: active
+created: 2026-08-26
+updated: 2026-08-26
+---
+
+# Session: blox-toaster-peer-deps
+**Date:** 2026-08-26
+**Project/Repo:** toga-blox (`feature-new-table`), toga2-commerce (`TRUE-80707`), toga25-supply (reference) — 2.0
+**Task:** Unblock `npm i` in toga2-commerce (ERESOLVE on blox's `react-router-dom` peer), then fix the blox Toaster rendering unstyled in commerce by giving blox default host-token styling and adding commerce's missing token layer.
+
+---
+
+## What WORKED
+
+- **`legacy-peer-deps=true` in `toga2-commerce/.npmrc`** — resolved the ERESOLVE. Root cause was NOT the peer range: `toga25-supply/.npmrc` already had the flag and commerce did not, at the *same* blox version and *same* router major. `npm i` then succeeded ("added 4 packages, removed 6, changed 70"). `.npmrc` is git-tracked, so this reaches the Amplify build too.
+- **Added blox's two missing peers to commerce** — `@fortawesome/free-solid-svg-icons@^6.7.2` and `react-multi-select-component@^4.3.4`. Required because `legacy-peer-deps` stops npm auto-installing peers. `vite build --mode sandbox-client` went from failing to green.
+- **Removed blox's phantom `react-router-dom` peer + the dead `import { Link }`** in `src/components/old/BaseButton/BaseButton.tsx`. Verified: `npm run build` clean; `grep -rl "react-router-dom" dist/` returns **nothing**; `BaseButton.js` still renders the injected `linkComponent` prop. Tests unchanged from baseline (see below).
+- **Fixed two invalid CSS declarations in blox `Toaster.module.css`** — `min-width: (--toaster-min-width)` and `max-width:` were missing `var()`, so the parser dropped both. supply masked this by re-declaring `min-width` in `.supplyToaster`; commerce had nothing to mask it.
+- **Gave the blox Toaster default styling via `var(--token, fallback)`** on every custom property, plus `border-style`/`border-radius`/`font-family`/`font-size`/`margin-block` on `.base` (it previously set `border-width`/`border-color` with **no** `border-style`, so no border rendered at all). Component now renders fully styled with zero host config; host tokens still win.
+- **Added commerce's missing `--toaster-*` token layer + `.commerceToaster--{success,error,restricted,default}`** to `src/styles/index.css`, and rewired `ToasterList.tsx` to supply's mechanism (variant class remaps `--toaster-default-*`, which blox's `.base` reads). Verified in emitted CSS: `--toaster-success-bg: #f3fdf1` present, all four variant classes present.
+- **Added `resolve.dedupe` to `toga2-commerce/vite.config.ts`** (it had none; frontend.md §11 makes it a MUST). Confirmed `toga-blox-npm/node_modules/` ships its own `react@18.3.1` + `react-dom@18.3.1`, so symlinked blox resolves a second React copy.
+- **Regression checks all green:** blox build clean; blox vitest `12 failed / 11 passed (23)`, `40 failed / 160 passed (200)`, 3 errors — **byte-identical to the stashed baseline**, so zero regression (those 40 failures are pre-existing). toga25-supply `tsc -b` + `vite build` clean. toga2-commerce `tsc -b` + `vite build` clean.
+- **`/capture` published 6 docs** to `_main` (`validate: OK (30 repos)`, index 425 docs), including two elevated standards edits to `frontend.md` and `frontend-deploy.md`.
+
+## What did NOT work — DO NOT RETRY THESE
+
+- **Do NOT conclude `feature-new-table` is stale from the behind-count.** It reports `0 ahead / 47 behind` `_sandbox-client` and `git merge-base --is-ancestor` says fully contained — which reads as "already merged, wrong base". **This is wrong.** Those 47 commits are almost entirely `Merge branch 'feature-new-table' into _sandbox-client` and `chore: bump version to 1.0.3xx` — release plumbing generated *on* `_sandbox-client` and never merged back. Real source diff is 2 files (`src/global.css`, `src/index.ts`); the rest of the 334-file diff is `.claude/knowledge/` docs and `publish.yml`. `feature-new-table` is the **active** dev branch (tip 2026-08-24, `feat: prefer server-supplied filter options in table meta`) and is the correct base. I asserted the opposite mid-session and had to retract it.
+- **Do NOT cite toga25-supply's local symlink as evidence about the deployed path.** My local supply checkout was on `launch-aug26` with `node_modules/@agilant/toga-blox -> ../../../toga-blox-npm`. That is a **local dev artifact only**. On `_sandbox-client` supply consumes the *published channel*, pinned exact at `1.0.333-sandbox-client.134`, with `legacy-peer-deps=true` and `npm ci`. I used the symlink as an isolation argument and it did not apply.
+- **Do NOT add `color` to `.prefixIcon` or `.closeBtn` in blox `Toaster.module.css`.** I tried it and reverted. The host's `iconColor` / `closeIconColor` classes land on those **same elements at equal specificity**, so a `color` declared there is resolved by stylesheet source order and can silently beat the host's class (supply's mint/crimson icons losing to a grey default). They must inherit from `.base`. In-code comments now record this — do not "helpfully" re-add it.
+- **Do NOT use `Edit` with hand-typed indentation on `toga2-commerce/src/components/Toasters/ToasterList.tsx`.** Two `Edit` calls failed with "String to replace not found" — the repo indents with **TABS** (7 tabs for the destructure, 8 for members). Verified via `sed 's/\t/<TAB>/g'`. Worked around with a `node -e` script doing exact string replacement with `"\t".repeat(n)`.
+- **Do NOT test the toaster by placing an order in commerce.** No success toaster exists on that path. `useSubmitOrder.ts` calls `addToaster` **only in its `catch` block** (`status: 'error'`). Success paths navigate away: cart → `createNewSalesOrderSubmit()` → `navigate("/order-details?uuid=…&type=orderPlaced")` (no `addToaster` anywhere in it); editOrder → `window.location.href = getSupplyRedirectLink(orderUuid)`. The developer tested this way, saw nothing, and it was **expected behavior, not a regression** — I initially mis-diagnosed it as a rendering failure and chased `resolve.dedupe` for a symptom that did not exist.
+- **Typo to watch:** I emitted a full-width paren `）` inside the commerce `--toaster-default-boxShadow` value. Caught and fixed, but it built "fine" beforehand because the whole declaration was just invalid.
+
+## Not tried yet (candidates for next session)
+
+- **Visual verification in a browser** — nothing here has been seen rendered. Only `tsc -b`, `vite build`, and emitted-CSS inspection.
+- **The error variant specifically** — its colors changed to match supply (bg `crimson-50`→`crimson-300`, text `crimson-500`→`crimson-700`). Needs a forced submit failure to hit the catch block.
+- **Committing anything** — all changes in blox and commerce are working-tree only.
+- **Merging `feature-new-table` → `_sandbox-client`** to publish a new blox channel version.
+- **Reconciling commerce's pin drift** — `TRUE-80707` is on `^1.0.322-sandbox-client.117`; `_sandbox-client` is on `1.0.333-sandbox-client.134` (11 versions apart), and the caret violates frontend.md §13(a).
+- **Dropping `legacy-peer-deps` from commerce** once it consumes a blox build without the router peer — the flag would then be unnecessary for this conflict.
+- **Rotating the committed `.npmrc` credentials** in both commerce and supply (npm + FontAwesome Pro tokens live in the tracked `.npmrc` in each repo — values not recorded here). Flagged unremediated in frontend.md Part 3.
+
+## Current file state
+
+| File | Status | Notes |
+|------|--------|-------|
+| `toga-blox/package.json` | Modified | `react-router-dom` removed from `peerDependencies`; still a devDependency `^6.30.1` for tests' `MemoryRouter` |
+| `toga-blox/src/components/old/BaseButton/BaseButton.tsx` | Modified | Dead `import { Link } from "react-router-dom"` removed (line 1); component unchanged otherwise |
+| `toga-blox/src/components/Toaster/Toaster.module.css` | Modified | Rewritten: `var(--token, fallback)` throughout, `border-style`/`border-radius`/font/margin added to `.base`, **no `color`** on `.prefixIcon`/`.closeBtn` (commented why) |
+| `toga2-commerce/.npmrc` | Modified | `legacy-peer-deps=true` appended |
+| `toga2-commerce/package.json` | Modified | Added `@fortawesome/free-solid-svg-icons@^6.7.2`, `react-multi-select-component@^4.3.4` |
+| `toga2-commerce/package-lock.json` | Modified | Regenerated |
+| `toga2-commerce/vite.config.ts` | Modified | Added `resolve.dedupe` (react, react-dom, react-hook-form, react-router-dom, framer-motion, @tanstack/react-query, @tanstack/react-table) |
+| `toga2-commerce/src/styles/index.css` | Modified | Added `:root` `--toaster-*` token block (mirrors supply's `themeConfig.json`) + `.commerceToaster` and four variant classes |
+| `toga2-commerce/src/components/Toasters/ToasterList.tsx` | Modified | `getToasterStyles` now returns `{icon, variant}`; Tailwind color utilities replaced by `commerceToaster--${variant}` / `commerceToasterIcon--${variant}` |
+| `toga25-supply` | **Unchanged** | Reference implementation only — nothing modified |
+| `~/toga-tech/knowledge/**` | Committed + pushed | 6 docs published to `_main` via `/capture` |
+
+## Decisions made
+
+- **Fix the ERESOLVE with `.npmrc` `legacy-peer-deps`, not by widening the peer range.** Rationale: the asymmetry vs supply was the actual defect, and this unblocks immediately with zero blox republish. Rejected: widening to `^6 || ^7` (still needs a republish to reach commerce); adding a `package.json` `overrides` entry (hides the problem from the next dev).
+- **Delete blox's `react-router-dom` peer entirely rather than widening it.** Rationale: it is genuinely phantom — the only production reference was a dead import; the component takes `linkComponent` by prop. Widening would preserve a false declaration. Tests keep working via the existing devDependency.
+- **Ship defaults as `var(--token, fallback)` inside the CSS Module, not a `:root` block in blox.** Rationale: blox ships no token block by design, and `dist/main.css` is uncompiled and unimportable (frontend.md §13f), so fallbacks are the only mechanism needing no stylesheet import. Rejected: adding `:root` to blox (new pattern, leak/conflict risk, requires an import).
+- **Commerce mirrors supply's variant-remap mechanism** (variant class remaps `--toaster-default-*`) rather than styling with Tailwind utilities. Rationale: Tailwind utilities and blox's `.base` are both single-class selectors on the same element, so source order decides — inherently fragile. Rejected: keeping Tailwind classes on the wrapper div.
+- **Qualify all knowledge-base claims as working-tree state.** Rationale: the KB would otherwise assert a peer removal that has not shipped; frontend.md §13(b)/§22 would be wrong if the blox change never lands.
+
+## Blockers
+
+- **Ticket number needed for the blox commit.** CI enforces `TRUE-{ticketNumber}: {Subject}`. It is unknown whether this blox cleanup belongs under `TRUE-80707` (the commerce ticket) or its own. **This is the only hard blocker on committing.**
+- **No visual confirmation of the Toaster.** Everything is build-verified only, so a purely visual defect would not have been caught.
+
+## Exact next step
+
+> In `~/Agilant/toga2-commerce` (blox currently symlinked, `node_modules/.vite` already cleared), run `npm run sandbox-client`, log in, then go to **Account → add or edit a shipping address** and confirm the success toaster renders with supply's mint styling (bg `#f3fdf1`, border `#2cb224`, text `#075a11`, 400px min-width, 1rem radius). If it does not appear, check the browser console and whether `[data-testid="toaster"]` exists in the DOM — if the element is absent there is no styling bug and the problem is upstream in `contexts/ToasterContext`, not in any CSS changed this session.
+
+---
+_Saved by /session-save on 2026-08-26_

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "toga-ai",
-  "version": "1.0.655",
+  "version": "1.0.656",
   "description": "TOGA Technology Team Claude Knowledge System — shared AI coding harness with skills, knowledge base CLI, and project installer for Claude Code.",
   "keywords": [
     "claude",