toga-ai 1.0.598 → 1.0.599

package/knowledge/1.0/apps/togadesk/features/managed-service-order-create.md

@@ -6,7 +6,7 @@ project: TOGa Desk
 client: shared
 type: feature
 status: active
-updated: 2026-07-09
+updated: 2026-08-17
 owners: ["mhammontree"]
 files:
   - desk/includes/controllers/actions/tickets/add.php
@@ -52,6 +52,32 @@ downstream repair-order lifecycle (dispatch, scheduling, status) lives in
    `RepairOrder`. In the `TYPE_ONSITESERVICE` branch it reads optional per-asset fields
    (`installation`, `access-instructions`) — see the getVar gotcha below.
 
+### Schedule dates are mandatory for INSTALLATION (analyst workflow — TRUE-80338)
+**Creating an Installation MSO now requires both Delivery Date (`duedate`) and Installation Date
+(`install-date`).** Analysts can no longer create an unscheduled installation.
+
+- **The Schedule toggle is not offered for installation tickets.** The installation ticket-type
+  handler (`addNew.php` ~L1919–1928) force-checks `#scheduler`, adds `.required` to `#duedate` and
+  `#install-date`, shows `.schedule-required-indicator`, and **hides** `.schedule-toggle` (a class
+  on both the "Schedule" caption label and the switch label). Picking Support / New Equipment /
+  Repair restores the toggle, hides the indicator, and removes `.required` — those types keep the
+  dates optional.
+- **The asterisk is a toggled `<span class="schedule-required-indicator"> *</span>`**, not label
+  text, because the same Schedule block is shared with Repair, where the dates stay optional.
+- **Server-side backstop, before the first `save()`.** `add.php` ~L49–55 computes
+  `$scheduleDatesRequired` from the ticket type and `$scheduleDatesProvided` from the two dates,
+  and folds the guard into the existing `if (isset($ticketType) && …)` — the single `if` that
+  encloses **every** `save()`. Rejection reuses the existing generic status code `21`
+  (add-failed); a precise message would need a `statuscodes` migration and was left out of scope.
+- **The date writes no longer depend on `scheduler` being posted:** ~L361 is
+  `if ($scheduleDatesRequired || (App_Page::varIsSet('scheduler') && …))`, and both dates are read
+  with `getVarIfSet()`, per the getVar gotcha below.
+- **Support Department (`#departmentid`) is genuinely required** and its label now says
+  "Support Department *". It is enforced three ways: `class="required"` on the select feeds the
+  `.required` sweep that gates the disabled Create button; that sweep carries an extra explicit
+  `$('#departmentid').val() != 0` check (~L1821); and `add.php` reads it with the **throwing**
+  `getVar('departmentid')`.
+
 ### Address sourcing — per-person vs. client location (important)
 There are **two** address sources, and they come from different tables:
 - **End User Address dropdown (`#userlocation`)** is per **person**. `getinfo.php` (uid branch,
@@ -96,11 +122,40 @@ End User dropdown. Dropping that UNION is **long-standing, not a recent regressi
   deadlock. **Fix:** the validator now also reads `newAddressCount = parseInt($('#newAddressCount')
   .val())||0` and only blocks when `selectedValue == 0 AND newAddressCount == 0`, since the server
   already supports the inline address.
+- **Never `disable` a checkbox you still need posted.** For the forced-on Schedule case, `#scheduler`
+  is kept **checked and enabled** while hidden. A disabled checkbox does not post, so disabling it
+  would have silently stopped `scheduler=1` from reaching the server while everything still looked
+  correct in the UI. Hide, don't disable.
+- **Validate before the first `save()`, not where the value is consumed.** The create block in
+  `add.php` writes people → addresses → managed service order → assets → repair orders in sequence
+  inside one `if`. Rejecting later (e.g. inside the per-asset loop at the `TYPE_ONSITESERVICE`
+  branch, where the dates are actually used) leaves **orphaned partial records**. There is no
+  transaction wrapping this flow.
+- **`.required` classes toggled per ticket type must be cleared on every branch.** A pre-existing
+  leak added `.required` to `#duedate`/`#install-date` when Installation was picked but never
+  removed it, so it persisted after switching ticket type and wrongly gated the Create button. All
+  three non-installation handlers now `removeClass("required")`. Any new conditional required field
+  needs a matching clear in **every** sibling branch.
+- **Label convention in this modal:** always-required fields append a literal `" *"` in the label
+  text (Ticket Type *, Contract *, End User *, Asset *, Repair Type *, First Name *, Support
+  Department *). **Conditionally**-required fields must instead use a toggled indicator span (see
+  `.schedule-required-indicator`) so the asterisk disappears with the requirement.
+- **Known cosmetic bug (unfixed):** the Client radio-group label (`addNew.php` ~L27) is
+  `for="departmentid"` — a copy-paste leftover — so clicking "Client" moves focus to the Support
+  Department dropdown. A11y/cosmetic only; candidate follow-up ticket.
 - The addNew modal has **no `<form>` tag of its own** — it depends entirely on the global
   `#formModal` in `footer.php` and `$("form").submit()`. Anything that alters that global wrapper
   (attributes, nesting) affects this flow.
 
 ## Change history
+- 2026-08-17 — TRUE-80338: **Delivery Date + Installation Date are now required for INSTALLATION
+  MSOs** (analyst workflow change — demoed to Skyler and approved). The Schedule toggle is hidden
+  and force-checked for installation tickets; the asterisks are a toggled
+  `.schedule-required-indicator` span; a server-side backstop in `add.php` validates both dates
+  before the first `save()` (reusing status code 21) so a rejection cannot orphan partial records.
+  Also fixed a pre-existing `.required` leak on the two date fields when switching ticket type, and
+  added the missing required asterisk to Support Department. Recorded the "hide, don't disable a
+  checkbox you need posted" trap and the modal's required-label convention. (mhammontree)
 - 2026-07-09 — TRUE-80100: documented the MSO create flow (entry, server action, per-person vs.
   client-location address sourcing) and folded in three fixes: `getVar` → `getVarIfSet` for
   optional request vars in the `TYPE_ONSITESERVICE` branch (server crash); `autocomplete` on

package/knowledge/INDEX.md

@@ -19,7 +19,7 @@ _Auto-generated by `knowledge.js index`. Do not hand-edit._
 ## 2.0 framework
 
 - **_underscore** (_Underscore) _(framework core)_ — 58 doc(s) → [2.0/apps/_underscore/INDEX.md](2.0/apps/_underscore/INDEX.md)
-- **worker2** (Worker) — 50 doc(s) → [2.0/apps/worker2/INDEX.md](2.0/apps/worker2/INDEX.md)
+- **worker2** (Worker) — 51 doc(s) → [2.0/apps/worker2/INDEX.md](2.0/apps/worker2/INDEX.md)
 - **api2** (API) — 24 doc(s) → [2.0/apps/api2/INDEX.md](2.0/apps/api2/INDEX.md)
 - **dbchanges2** (Database Changes) _(framework core)_ — 8 doc(s) → [2.0/apps/dbchanges2/INDEX.md](2.0/apps/dbchanges2/INDEX.md)
 - **toga2-supply** (TOGa Supply) — 6 doc(s) → [2.0/apps/toga2-supply/INDEX.md](2.0/apps/toga2-supply/INDEX.md)

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "toga-ai",
-  "version": "1.0.598",
+  "version": "1.0.599",
   "description": "TOGA Technology Team Claude Knowledge System — shared AI coding harness with skills, knowledge base CLI, and project installer for Claude Code.",
   "keywords": [
     "claude",