toga-ai 1.0.512 → 1.0.513

package/knowledge/1.0/apps/tools/features/errors-curation-console.md

@@ -49,6 +49,26 @@ happening and were deliberately never ticketed. Nobody had that view before.
 Filesystem routing (1.0 Tools MVC): `mvc/errors/` = **`/errors`** (the listing) and
 `mvc/errors/issue/` = **`/errors/issue`** (the detail page).
 
+**`/errors/issue` takes two parameters, one meaning each** (2026-08-04):
+
+| Parameter | Means | Use |
+| --- | --- | --- |
+| `?issue=4KP` | `Issue.reference` — the identifier everything else quotes (ClickUp title, escalation email, neglect digest, production error page) | **all new links**, including the listing rows and worker2's `buildToolsIssueUrl()` |
+| `?issueId=9` | `Issue.id` | the original form, kept working **indefinitely** |
+
+`?issueId=` is never removed: links built from it are already sitting in ClickUp tasks and emails
+sent months ago that cannot be rewritten.
+
+> **Why two parameters instead of one that accepts either.** References are **base 32 over an
+> alphabet that includes digits**, so an ordinary reference — `'68'`, `'137'`, `'400'` — is all
+> digits and **cannot be distinguished from a primary key by inspection**. A combined parameter
+> would have to guess; naming the parameter after the column removes the ambiguity. An earlier
+> combined `?issue=` with reference-first/id-fallback precedence was written and then replaced.
+
+`?issue=` also accepts the **event** form (`?issue=4KP-12` strips the event half), because that is
+what people copy out of an error page or ClickUp comment. An unknown reference leaves the id at 0
+and renders the existing "no such issue" view.
+
 **Listing** — 25 per page with a filtered `COUNT` (it was previously a silent `LIMIT 200`, so
 older issues simply did not exist as far as a curator could tell); bold monospace Issue ID; an
 **EB Environment** column read from the newest event's context; a **Type** column showing
@@ -75,6 +95,22 @@ curated text, affected clients) right, with an always-present Type chip.
 - Header chip order is **Issue / Environment / Type / Urgency** — Type was moved ahead of Urgency so
   urgency finishes the row at the far right.
 
+### Neglect indicator (2026-08-04)
+
+Both pages now surface the **neglect** contribution to urgency: the listing computes
+`openTaskAgeHours` as a correlated subquery and renders a `$describeNeglect` amber note
+(`.neglect-note`, `#8a5a00`) **under the urgency badge**; the detail page's *Acknowledged* fact row
+reads "not yet — waiting 3 days" alongside a NORMAL/HIGH neglect chip.
+
+**Why:** the urgency badge alone is genuinely misleading. A **HIGH beside "Lifetime 1"** is a
+statement about *response time*, not about the error, and nothing on the page let a reader tell
+those apart. **Nothing renders while the clock is running but under 24h** — below that the clock
+contributes nothing to urgency, so saying "neglect" would overstate it.
+
+**Deliberately scoped to the neglect contribution only.** The console never claims *which* axis is
+winning: computing the full driving axis in Tools would mean copying the volume, sustained and
+release-band thresholds too, and that much duplicated policy would rot.
+
 ### Table presentation rules (established 2026-08-04)
 
 **Stacked datetimes in every table on both pages** — listing *Last seen*; detail *Events → When*,
@@ -143,6 +179,17 @@ They were renamed from plural on 2026-08-01, after the pipeline was already in p
 
 ## Gotchas / known issues
 
+- **⚠ OPEN BUG (found 2026-08-04, deliberately left unfixed pending the developer's go-ahead):
+  `tools/mvc/errors/post.php` ~line 181, the merge-fingerprint action, will merge into the WRONG
+  issue.** It takes a reference **or** a numeric id in **one** field and disambiguates with
+  `ctype_digit()`. That was safe under the old **base-26** scheme, where every reference contained a
+  letter. Under the new **base-32** alphabet an all-digit reference like `'68'` is treated as **id
+  68** and silently repoints the fingerprint at the wrong Issue. Fix is either reference-first-then-id
+  precedence or two separate inputs (as `/errors/issue` now does).
+- **The 24/48 neglect thresholds are duplicated as plain numbers in both Tools views.** Tools is
+  1.0 and cannot read worker2's `NEGLECT_NORMAL_HOURS` / `NEGLECT_HIGH_HOURS`; both sites carry a
+  comment naming those constants as the source of truth. **Changing the policy means changing three
+  places** (worker2 + both Tools views).
 - **A 2.0 table rename breaks this page silently until it is run.** This console has **no model
   layer** — `get.php` and `post.php` interpolate table names into hand-written `App_Database`
   SQL (40+ literal occurrences between them). Nothing here fails at deploy time; it fails when
@@ -170,6 +217,22 @@ They were renamed from plural on 2026-08-01, after the pipeline was already in p
 
 ## Change history
 
+- 2026-08-04 (latest, **uncommitted/undeployed** at time of writing) — **Built:** a **neglect
+  indicator** on both pages — listing gained an `openTaskAgeHours` correlated subquery and a
+  `$describeNeglect` amber note (`.neglect-note`, `#8a5a00`) under the urgency badge; the detail
+  page's *Acknowledged* row now reads "not yet — waiting 3 days" with a NORMAL/HIGH neglect chip.
+  The urgency badge alone was misleading (a HIGH beside "Lifetime 1" describes response time, not
+  the error) and nothing distinguished the two; nothing renders under 24h since the clock is
+  contributing nothing yet. Scoped to the neglect contribution only — computing the winning axis
+  would mean duplicating the volume/sustained/release-band thresholds as well. **Built:**
+  `/errors/issue` now accepts **`?issue=<reference>`** (also tolerating the `4KP-12` event form) and
+  the listing links by reference; `?issueId=<id>` is kept working **indefinitely** for links already
+  sitting in old ClickUp tasks and emails. Two parameters rather than one, because base-32
+  references can be all digits and are indistinguishable from a primary key. **Recorded two
+  maintenance hazards:** the 24/48 thresholds are now duplicated as literals in both Tools views
+  (Tools is 1.0 and cannot read worker2's constants — three places to change), and an **open bug** in
+  `post.php`'s merge-fingerprint `ctype_digit()` disambiguation, which under base-32 will merge into
+  the wrong Issue (flagged, left unfixed). (jcardinal)
 - 2026-08-04 (later, **uncommitted/undeployed** at time of writing) — UI pass on both `/errors`
   pages: **stacked datetimes** in every table via a shared `$datetime` closure emitting
   `.dt`/`.dt-date`/`.dt-time` (a naturally wrapping datetime broke inside the day of the month), and

package/knowledge/2.0/apps/worker2/INDEX.md

@@ -18,7 +18,7 @@
 | [Compass VIP Support Importer (worker2)](features/compass-vip-support-importer.md) | A worker2 action that ingests Compass's quarterly VIP spreadsheet and assigns each VIP user's support technician by setting `Users.c_supportedByUserId` in `Clie | worker2/Worker/Client/Compass/VipSupport.php |
 | [Creating Worker Actions](features/creating-worker-actions.md) | How to add a new callable Worker action — a PHP class whose `public static` methods are invoked as background jobs (via webhook, cron, or `_Worker::runTask()`). | worker2/Worker/, worker2/Controller/Index.php, _underscore/Worker.php |
 | [Elite Freshservice Sync (worker2)](features/elite-freshservice-sync.md) | `_Worker_Elite` processes Freshservice webhook events and syncs them into TOGA 2. | worker2/Worker/Elite.php, worker2/Config/dev-kmaramreddy-laptop.ini |
-| [Error Escalation Cron (Errors::Escalate → ClickUp / email)](features/error-escalation-cron.md) | `_Worker_Infrastructure_Errors::Escalate` (renamed from `SyncWithClickup`) is the sole owner of **escalation, de-escalation, ClickUp ticketing, reminders, busin | worker2/Worker/Infrastructure/Errors.php, worker2/Worker/Notification/Email.php, worker2/Worker/Notification/EmailTemplate.php, worker2/Worker/Client/True.php, worker2/Worker/Clickup/ErrorTask.php, worker2/Worker/Clickup.php, worker2/Controller/Index.php, worker2/Config/production.ini, _underscore/Model/Core/Logs/Issue.php, dbchanges2/Core/2026-07-30a - Error escalation cron job.sql, dbchanges2/Logs/2026-08-03a - Issue clickupPriority.sql |
+| [Error Escalation Cron (Errors::Escalate → ClickUp / email)](features/error-escalation-cron.md) | `_Worker_Infrastructure_Errors::Escalate` (renamed from `SyncWithClickup`) is the sole owner of **escalation, de-escalation, ClickUp ticketing, reminders, busin | worker2/Worker/Infrastructure/Errors.php, worker2/Worker/Notification/Email.php, worker2/Worker/Notification/EmailTemplate.php, worker2/Worker/Client/True.php, worker2/Worker/Clickup/ErrorTask.php, worker2/Worker/Clickup.php, worker2/Controller/Index.php, worker2/Config/production.ini, _underscore/Model/Core/Logs/Issue.php, dbchanges2/Core/2026-07-30a - Error escalation cron job.sql, dbchanges2/Logs/2026-08-03a - Issue clickupPriority.sql, dbchanges2/Core/2026-08-04a - Error neglect digest cron job.sql |
 | [Etilize Catalog Item Import & Refresh](features/etilize-catalog-item-import.md) | Client-generic catalog onboarding from an S3 CSV plus an Etilize re-pull. | worker2/Worker/Etilize/Items.php |
 | [Etilize Item Translation Import](features/etilize-item-translation-import.md) | The abstract worker class `_Worker_Etilize_ItemTranslations` imports **non-English** item text from Etilize into the client's `ItemTranslations` table. | worker2/Worker/Etilize/ItemTranslations.php |
 | [Monitoring Framework (Orchestrator + Child Monitors)](features/monitoring-framework.md) | A unified, DB-driven monitoring framework for business-critical data flows (Compass POs, Prudential asset imports, AIG closed claims, …). | worker2/Worker/Monitor.php, worker2/Worker/Monitors/, worker2/Worker/Monitors/RateEntitlement.php, worker2/Worker/Notification/Email.php, worker2/Worker/Rate.php, dbchanges2/Core/2026-05-21 - Monitors.sql, dbchanges2/Core/2026-06-29a - Rate Entitlement Contract Monitor.sql |

package/knowledge/2.0/apps/worker2/features/error-escalation-cron.md

@@ -20,6 +20,7 @@ files:
   - _underscore/Model/Core/Logs/Issue.php
   - dbchanges2/Core/2026-07-30a - Error escalation cron job.sql
   - dbchanges2/Logs/2026-08-03a - Issue clickupPriority.sql
+  - dbchanges2/Core/2026-08-04a - Error neglect digest cron job.sql
 related:
   - ../../_underscore/features/error-reporting-issue-event.md
   - ../../../1.0/apps/tools/features/errors-curation-console.md
@@ -47,13 +48,93 @@ through this one action, so there is exactly one place to mute or debug alerting
 - **Volume** — occurrences in a **1-hour** window: **NORMAL 5 / HIGH 10 / URGENT 20** (retuned
   2026-08-04 from 20/50/100 over 10 minutes — a 10-minute window never fired for the
   low-and-steady failures that actually matter).
-- **Neglect** — hours an *unacknowledged* ClickUp task has sat: **1 / 4 / 24**.
+- **Neglect** — hours an *unacknowledged* ClickUp task has sat: **NORMAL 24 / HIGH 48. Capped at
+  HIGH — there is no URGENT rung.**
 - **Sustained-24h** — an issue still occurring a day later escalates on duration alone.
 - **Floor** — the Issue's declared `minimumUrgency` applies under *all* axes.
 
 The neglect axis exists because volume alone cannot see a rare-but-serious error, nor a serious
 error that everyone is ignoring.
 
+#### ⚠ Neglect is capped at HIGH and slowed to 24h/48h (decided + fixed 2026-08-04)
+
+`NEGLECT_NORMAL_HOURS` 1 → **24**, `NEGLECT_HIGH_HOURS` 4 → **48**, and
+**`NEGLECT_URGENT_HOURS` and its branch were removed** from `resolveNeglectUrgency()`. This
+**supersedes** the earlier 1/4/24 ladder with an URGENT rung.
+
+**Why:** neglect answers *"is anyone on this"* — a question about the **team's response**, never
+about how much damage the error is doing. Only the volume axes measure damage, so only they may
+claim URGENT. Left uncapped on the old clock, any error that fired once and went unacknowledged
+for an afternoon became HIGH, then URGENT the next day. That is how the queue filled up:
+**48 of 68 issues sat at HIGH**, and issue **3H (id 60) was HIGH off a single lifetime
+occurrence** — volume 0 in the 60-minute window, sustained 1 against a threshold of 50,
+`minimumUrgency` LOW, with the entire HIGH coming from its ClickUp task sitting unacknowledged
+for 4.93 hours.
+
+**The neglect axis is a FLOOR, not a ceiling.** `resolveNeglectUrgency()` is one of four inputs
+to `highestUrgency()`, which takes the **max** — so a neglected issue that starts firing still
+escalates on volume: two days unacknowledged contributes HIGH, and 20 occurrences in the window
+take it straight to URGENT regardless. Capping the axis lowers the floor *neglect alone* can
+raise; it takes nothing away from the occurrence count. Upward moves apply the same run (only
+**downward** moves go through the `REQUIRED_QUIET_RUNS` dwell), so volume takeover is same-run.
+
+**Intended side effect, accepted:** `SPRINT_PROMOTION_URGENCY` is `'URGENT'`, so with neglect
+capped at HIGH, **neglect alone can no longer promote an issue into the sprint** — only a genuine
+occurrence rate can.
+
+**Deploy effect.** All 50 then-HIGH issues had open unacknowledged tasks younger than 24h, so
+their neglect contribution becomes LOW and they recompute from volume/sustained/floor within ~3
+runs of the worker2 deploy. Expect a **burst of ClickUp priority PUTs** on the first runs as
+`clickupPriority` re-syncs.
+
+### Daily neglect digest email (`Infrastructure/Errors/NeglectDigest`)
+
+A second worker action — `public NeglectDigest()`, with `loadNeglectedIssues()` and
+`buildNeglectDigestBody()` — registered in `Core.CronJobs` as action
+`Infrastructure/Errors/NeglectDigest` at **`0 8 * * *`** (08:00 CT: after the overnight cleanup
+jobs, before the working day), `maxExecutionTime` 300. Migration:
+`dbchanges2/Core/2026-08-04a - Error neglect digest cron job.sql`.
+
+**Why a digest exists at all — the governing principle:** neglect means *"nobody is looking"*, so
+**every signal that requires somebody to look is self-defeating.** It is also the necessary
+counterpart to capping the axis: with neglect slowed and capped, an ignored issue no longer
+announces itself by climbing the urgency scale, so something has to come and tell you.
+
+Sends via `_Worker::runTask('Notification/EmailTemplate/Send')` with the TOGA Technology stored
+template — the **same path as the technical escalation email**. Recipient is `[_underscore]
+error_escalation_email`, gated by the same `error_escalation_enabled` key, so non-production mails
+nobody. The body is a **fragment** for the template's `{body}` (600px cell; the template owns font
+and width), exactly like `buildTechnicalEmailBody()`.
+
+Three design decisions, each load-bearing:
+
+- **It sends even when the list is empty.** An empty digest states *"nothing is neglected"*;
+  silence cannot be distinguished from a broken notifier — which is precisely the failure that hid
+  the escalation email being dead for days while every run reported success. The **subject
+  reflects the state** ("No neglected error issues" vs "2 error issues nobody has picked up") so
+  it is triageable from the inbox list without opening it.
+- **One email covering every issue, never one per issue.** A per-issue alert for a condition that
+  by nature affects many issues at once is how a channel becomes wallpaper — and the reminder
+  ladder already carries the per-issue nagging.
+- **Floored at `NEGLECT_NORMAL_HOURS`**, not "everything open". That constant is where the cron
+  itself starts treating an issue as neglected, so the digest reports only things that have
+  crossed a line. A task opened this morning is not neglected, it is new. Ordered **oldest
+  first** so the worst case is the first line read.
+
+Verified against production: the query returns **2 rows** today (1B and 1I, both 24h
+unacknowledged).
+
+**Rejected alternatives:**
+
+- *Mutating the ClickUp task **title** to say "neglected"* — the title is deliberately just the
+  reference and is never rewritten; rewriting churns the activity feed and breaks the
+  quote-the-reference contract, and it only helps someone already looking at the task.
+- *A new `Issue` column (`dtNeglectedSince`, `neglectLevel`)* — fully derivable from
+  `IssueClickupTask.dtCreated` + `Issue.dtAcknowledged`, so storing it is denormalised state that
+  can drift, and it still needs something to read it out.
+- *A ClickUp custom field* — **deferred, not rejected**: it writes every run and duplicates what
+  the digest says. Revisit only if the digest proves insufficient.
+
 ### Fast up, slow down
 
 Escalation applies **the same run** a band is crossed. De-escalation requires the count to sit
@@ -108,6 +189,15 @@ ClickUp is the acknowledge/resolve system — developers already live there, and
 Tools would just be ignored. **Any** status change on an error task counts as acknowledgement,
 which is safe only because the automation never sets status itself.
 
+> **`dtAcknowledged` is set by a status change OR by an assignee being added** — both, and this was
+> already implemented (confirmed 2026-08-04, no change needed). `worker2/Worker/Clickup.php:856`
+> routes the ClickUp `taskUpdated` webhook into
+> `_Worker_Clickup_ErrorTask::handleAssigneeChange()`, which calls `markAcknowledged()` (and also
+> feeds the per-area ownership learner). Both routes are subject to the 60-second creation grace
+> window below. Production: 8 of 71 issues acknowledged. **Worth stating explicitly, because the
+> acknowledgement definition is what both the neglect axis and the daily digest key off**, and it
+> is not visible from the escalation-cron side.
+
 > **60-second creation grace window (fix, 2026-08-04).** ClickUp fires a status webhook for a
 > task's *initial* status, so the automation was acknowledging its **own** newly created tasks —
 > stamping `dtAcknowledged` ~1s after `dtCreated` and permanently disabling the neglect axis for
@@ -176,6 +266,32 @@ healthy — cannot recur silently.
 - **Occurrences** and **Last Occurrence** custom fields are synced, and task bodies open with a
   **"Debug in Tools"** deep link.
 
+#### Tools deep links address the issue by REFERENCE, not id
+
+`TOOLS_ISSUE_PATH` changed from `'/errors/issue?issueId='` to **`'/errors/issue?issue='`**, and
+`buildToolsIssueUrl()` now emits the **reference**, `rawurlencode`d, falling back to the id only
+when a row has no reference. **Two parameters, one meaning each** — deliberately not one parameter
+that accepts either:
+
+| Parameter | Means | Use |
+| --- | --- | --- |
+| `?issue=4KP` | `Issue.reference` — what everything else quotes (ClickUp title, escalation email, digest, production error page) | **all new links** |
+| `?issueId=9` | `Issue.id` | the original form, kept working **indefinitely** |
+
+`?issueId=` stays supported forever because links built from it are already sitting in ClickUp
+tasks and emails sent months ago that cannot be rewritten.
+
+> **Why separate parameters rather than one that accepts either.** References are **base 32 over
+> an alphabet that includes digits**, so an ordinary reference — `'68'`, `'137'`, `'400'` — is all
+> digits and **cannot be told apart from a primary key by inspection**. A single combined parameter
+> would have to guess; naming the parameter after the column removes the ambiguity entirely. (An
+> earlier combined `?issue=` with reference-first / id-fallback precedence was written and then
+> replaced by this.)
+
+`?issue=` also accepts the **event** form — `?issue=4KP-12` strips the event half and lands on the
+issue — because that is what people copy out of an error page or a ClickUp comment. An unknown
+reference leaves the id at 0 and renders the existing "no such issue" view.
+
 ### Area-level owner learning (observation only)
 
 `IssueAreaOwner` learns an owner after **5 in a row** and ships **observation-only** — a hint in
@@ -232,6 +348,12 @@ this controller needs the same treatment.**
 
 ## Gotchas / known issues
 
+- **An issue held at HIGH purely by neglect never de-escalates on its own.**
+  `applyDeEscalationDwell()` needs the computed target to sit **below** the stored urgency for
+  `REQUIRED_QUIET_RUNS` (3) consecutive runs, but the neglect axis keeps recomputing the target
+  **at** the stored level — so the dwell counter never starts. That is why issue 3H showed
+  `consecutiveQuietWindows = 0` after five hours of total silence. **Acknowledging the ClickUp task
+  is what releases it**, and it then drops within 3 cron runs (~3 min).
 - **Never send email inline inside this cron's open transaction — enqueue it.** `_Email::send()`
   registers a second connection and toggles the read host, and a throw from in there was only ever
   `error_log`'d. Use `_Worker::runTask` so a failure becomes a visible failed `WorkerJobs` row.
@@ -299,6 +421,29 @@ this controller needs the same treatment.**
   **non-retroactive** — the first email lands on the next live occurrence. Also noted that prod
   `Logs.IssueEmailAddress` was still empty, making Compass's MITS rejection the platform's first
   business-routed issue. No code change. (dfranks)
+- 2026-08-04 (latest, **uncommitted/undeployed** at time of writing) — **Decided + fixed: the
+  neglect urgency axis is capped at HIGH and slowed to 24h/48h**, superseding the 1/4/24 ladder
+  recorded earlier the same day (`NEGLECT_NORMAL_HOURS` 1→24, `NEGLECT_HIGH_HOURS` 4→48,
+  `NEGLECT_URGENT_HOURS` and its branch removed). Neglect measures the **team's response**, not the
+  damage the error is doing, so only the volume axes may claim URGENT; uncapped on the old clock a
+  single-occurrence error became HIGH in an afternoon and URGENT the next day — 48 of 68 issues were
+  at HIGH and issue 3H (id 60) was HIGH off one lifetime occurrence. The axis remains a **floor, not
+  a ceiling** (`highestUrgency()` takes the max, so volume still escalates immediately). Accepted
+  side effect: `SPRINT_PROMOTION_URGENCY` is URGENT, so neglect alone can no longer promote into the
+  sprint. **Built:** a **daily neglect digest** (`Infrastructure/Errors/NeglectDigest`,
+  `Core.CronJobs` at `0 8 * * *`, migration `dbchanges2/Core/2026-08-04a`) — the counterpart to the
+  cap, since a capped axis no longer announces an ignored issue; it **sends even when empty** (a
+  broken notifier is indistinguishable from silence), is **one email for all issues**, and floors at
+  `NEGLECT_NORMAL_HOURS`, oldest first. Rejected: rewriting the ClickUp title, a derived
+  `dtNeglectedSince`/`neglectLevel` column; deferred: a ClickUp custom field. **Built:**
+  `TOOLS_ISSUE_PATH` now emits `?issue=<reference>` (rawurlencoded, id fallback) with `?issueId=`
+  kept working indefinitely — separate parameters because base-32 references can be all digits and
+  are indistinguishable from a primary key. **Discovered:** assignee-based acknowledgement was
+  already implemented (`Clickup.php:856` → `handleAssigneeChange()` → `markAcknowledged()`), and
+  that a neglect-held HIGH never de-escalates until the task is acknowledged. Verification:
+  `php -l` clean on every changed file; the digest SQL run against production (2 rows); neglect
+  impact quantified across all 68 issues; `0 8 * * *` checked against existing daily job
+  conventions. (jcardinal)
 - 2026-08-04 (later, **uncommitted/undeployed** at time of writing) — **Fixed: escalation email had
   never been sent, ever**, for two independent reasons. (A) `processTechnicalIssue()` returned early
   when the ClickUp task would read identically, and that return sat *above* the `if ($shouldNotify)`

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "toga-ai",
-  "version": "1.0.512",
+  "version": "1.0.513",
   "description": "TOGA Technology Team Claude Knowledge System — shared AI coding harness with skills, knowledge base CLI, and project installer for Claude Code.",
   "keywords": [
     "claude",