toga-ai 1.0.463 → 1.0.464

package/knowledge/1.0/apps/library/features/toga2-api-client-and-bridge.md

@@ -6,8 +6,8 @@ project: Library
 client: shared
 type: feature
 status: active
-updated: 2026-06-23
-owners: [jcardinal]
+updated: 2026-07-28
+owners: [jcardinal, mhammontree]
 files:
   - library/app/api/toga2.php
   - worker/crons/toga2/aig/sync_togasupply_aig.php
@@ -90,6 +90,17 @@ bool $enabled2to1, bool $enabled1to2)`. When `enabled2to1`:
 - Pages 2.0 **`/contacts`** (for AIG, only those with `c_togaCustomerId IS NULL`) and upserts each
   into the 1.0 client DB `Customers`/`Addresses` via `syncContactToToga1Customer`, then **writes
   the new 1.0 id back** to the 2.0 contact's `c_togaCustomerId` (PUT `/contacts/{uuid}`).
+- **Email storage (`syncContactToToga1Customer`, TRUE-79401):** the 1.0 `Customers.emailAddress`
+  column stores the contact's **full** list of 2.0 email addresses joined by the class constant
+  `CUSTOMER_EMAIL_DELIMITER = '; '`, not just the primary. The list is built from
+  `array_column((array)($togaContact->contactEmailAddresses ?? []), 'emailAddress')` →
+  trim / `array_filter` / `array_unique` → `implode` → `App_Database::sqlEscape` (escape **after**
+  imploding); an empty collection falls back to the single primary email (no regression). A
+  separately-escaped `$primaryEmailAddress` is retained **only** for the customer-dedupe lookup
+  (`WHERE Customers.emailAddress LIKE '$primaryEmailAddress'`) so storing a list doesn't break
+  record matching — dedupe is authoritatively keyed on **`c_togaCustomerId`**, with the primary-email
+  `LIKE` as a legacy fallback. Consuming the `contactEmailAddresses.emailAddress` collection required
+  adding it to the `/contacts` fetch `fields` whitelist (see gotcha).
 - Pages 2.0 **`/entitlements`** without a `c_togaServiceRequestId` and inserts 1.0
   `ServiceRequests` (+ a `Contacts` row if needed) via `syncEntitlementToToga1ServiceRequest`.
 - The 1→2 direction (`enabled1to2`) is a stub (not yet implemented).
@@ -154,11 +165,37 @@ enable flags** and an optional `$monitorTogadeskDepartmentIds[]`:
   the `App_Model` layer; follow the surrounding escaping discipline when modifying.
 - **Per-record error isolation** in the TOGaDesk sync is via `try/catch` → `\Sentry\captureException`;
   a thrown exception elsewhere (transport, checkpoint read) still aborts the whole run.
+- **A reverse hasMany collection is only returned if you add it to the fetch `fields` whitelist.**
+  The `/contacts` fetch requests an **explicit** `fields` list from the 2.0 metadata API; a reverse
+  hasMany collection (e.g. `contactEmailAddresses.emailAddress`) is **not** returned unless it is
+  added to that list — so consuming a related collection means editing **both** the fetch field list
+  **and** the consuming code. (The general 2.0-side metadata behavior — reverse relations resolved via
+  the child model's `FOREIGNKEY_MODEL` and named as the camelCase plural of the child model — is a
+  framework-level fact captured separately.)
+- **`TOGA_AIG.Customers.emailAddress` is `varchar(255)`** (V1 legacy, latin1_swedish_ci) — wide
+  enough to hold several `'; '`-joined emails, so TRUE-79401 needed **no** schema/dbchanges migration
+  (the earlier fear that it was ~VARCHAR(55) was wrong). `TOGA_AIG` is the 1.0 legacy DB;
+  `Client_Aig` is the 2.0 prod tenant.
+- **The multi-email path is not yet exercised (open, TRUE-79401).** As of 2026-07-28 all 20
+  `Client_Aig.ContactEmailAddresses` rows are one-per-contact, and **no** api2/`_underscore` code
+  references `UserDefined3`/`UserDefined4` or creates `ContactEmailAddresses` rows. Whether an api2
+  intake mapping is still needed depends on how Staples / SA.com sends the extra emails: if they POST
+  nested `contactEmailAddresses` records to the V2 API the library change is complete; if they send
+  flat `UserDefined3`/`UserDefined4` fields expecting us to map them into email rows, an api2 intake
+  mapping must be built. Open question owned by **Paulina**.
 - **PHP 7.2** target (prod worker/library) — no arrow functions, typed properties, `??=`, `match`.
   Lint with `C:\xampp7\php\php.exe -l`.
 
 ## Change history
 
+- 2026-07-28 — TRUE-79401: `syncContactToToga1Customer` now stores a contact's **full** email list in
+  1.0 `TOGA_AIG.Customers.emailAddress` as a `CUSTOMER_EMAIL_DELIMITER` (`'; '`)-joined, deduped,
+  escaped string (was primary-only) for AIG/Staples support lookup. Added
+  `contactEmailAddresses.emailAddress` to the `/contacts` fetch `fields` whitelist; kept a separate
+  escaped primary email for the dedupe `LIKE` (dedupe stays keyed on `c_togaCustomerId`); empty list
+  falls back to primary. No migration needed (`Customers.emailAddress` is `varchar(255)`). Scope stayed
+  library-only. Multi-email path not yet exercised — payload shape (nested `contactEmailAddresses` vs
+  flat `UserDefined3/4`) is open, owner Paulina. (mhammontree)
 - 2026-06-23 — Initial documentation of the `App_Api_Toga2` transport (auth/token caching, options
   DSL) and the 1.0↔2.0 bridge routines `syncWithToga` (Contacts/Entitlements → Customers/ServiceRequests)
   and `syncWithTogadesk` (bi-directional ticket/repair-order/people/asset sync with dual checkpoint

package/knowledge/2.0/apps/api2/INDEX.md

@@ -18,5 +18,6 @@
 | [TableView field/column metadata (TableViewFields, hidden projected columns)](features/tableview-field-metadata.md) | The columns of a 2.0 table view are defined by DB metadata, not code. | _underscore/Model/Client/TableView.php, api2/Component/Api/V2/V2.php, dbchanges2/Client/2026-07-20 - ItemsUuidForPurchaseOrderItemsTableView.sql |
 | [Tickets API (/v2/tickets)](features/tickets-api.md) | The generic ticket endpoint of the 2.0 REST API. | Component/Api/V2/V2.php |
 | [V2 API error/message codes (EV/EZ troubleshooting map)](features/v2-api-error-codes.md) | The V2 JSON engine (`Component/Api/V2/V2.php`) returns short **message codes** in the response `error` field, grouped by family: `EN-*` authentication, `EZ-*` a | api2/Component/Api/V2/V2.php, _underscore/Model/Client/TrackingNumber.php |
+| [V2 reverse hasMany collections must be named in the fetch fields whitelist](features/v2-reverse-hasmany-fields-whitelist.md) | In the V2 JSON engine, a **reverse hasMany** relationship — the collection of child records that foreign-key back to a parent (e.g. | api2/Component/Api/V2/V2.php |
 | [AWS CodePipeline Deployment via CodeConnections (GitHub → Elastic Beanstalk)](workflows/codepipeline-codeconnections-deploy.md) | 2.0 apps (`api2`, `_underscore`) are deployed through **AWS CodePipeline**. | api2/.platform/hooks/postdeploy/060_register_instance_to_shared_application_load_balancer.sh, api2/ebs/register_instance_to_shared_application_load_balancer.php |
 | [New Environment Configuration & Provisioning (api2)](workflows/environment-configuration-and-provisioning.md) | What it takes for a 2.0 API environment (e.g. | api2/Config/<environment>.ini, api2/Controller/Index.php, dbchanges2/Core/2026-06-16a - DatabaseHosts for new QA QC stage demo environments.sql, dbchanges2/Logs/, _underscore/Route.php |

package/knowledge/2.0/apps/api2/features/v2-reverse-hasmany-fields-whitelist.md

@@ -0,0 +1,77 @@
+---
+title: V2 reverse hasMany collections must be named in the fetch fields whitelist
+framework: "2.0"
+repo: api2
+project: API
+client: shared
+type: feature
+status: active
+updated: 2026-07-28
+owners: [mhammontree]
+files:
+  - api2/Component/Api/V2/V2.php
+related:
+  - nested-fk-acl-embedding.md
+  - ../../../../1.0/apps/library/features/toga2-api-client-and-bridge.md
+---
+
+## What it is
+
+In the V2 JSON engine, a **reverse hasMany** relationship — the collection of child records that
+foreign-key back to a parent (e.g. a Contact's many `ContactEmailAddresses`) — is **not** included
+in a response by default. It is only serialized when the caller **explicitly names it in the fetch
+`fields` list**. A parent GET that does not list the reverse collection comes back with that key
+absent — no error, no warning `message`, still HTTP 200 / `isSuccess: true`. This is a framework-level
+fact about how the 2.0 metadata layer resolves and names reverse relations; it is the general form of
+the AIG-specific `contactEmailAddresses.emailAddress` gotcha in the 1.0 `App_Api_Toga2` bridge.
+
+## How it works
+
+- **Reverse relations are metadata-resolved, not implicit.** The V2 engine builds the set of
+  embeddable relations for a model from the model metadata. A **forward** FK (parent points at one
+  child) resolves from the parent model's own FK field. A **reverse** hasMany (many children point
+  back at this parent) is resolved by scanning **child** models for a `FOREIGNKEY_MODEL` constant that
+  targets this model — the engine walks the child side to discover "who points at me".
+- **Naming convention — camelCase plural of the child model.** A discovered reverse collection is
+  exposed under the **camelCase plural of the child model name**. So children modeled as
+  `ContactEmailAddress` (with `FOREIGNKEY_MODEL` → `Contact`) surface on the parent as
+  `contactEmailAddresses`; a nested field of that collection is dotted, e.g.
+  `contactEmailAddresses.emailAddress`. Get the pluralization/casing exactly right — a mismatched name
+  is treated as an unknown field and simply yields nothing rather than an error.
+- **Whitelist-gated serialization.** The engine only serializes a reverse collection that appears in
+  the requested `fields` list (for the library options DSL, the nested-array form
+  `['contactEmailAddresses' => ['emailAddress']]`). Omit it and the collection is silently skipped —
+  it is opt-in, not opt-out. There is no default depth that pulls reverse hasMany collections in for
+  you.
+- **Consuming a reverse collection is therefore a two-part change.** Any code that wants to read a
+  related collection off a parent must (1) add the collection (and the specific child fields) to the
+  **fetch `fields` whitelist**, and (2) add the **consuming code** that reads it. Adding only the
+  consumer leaves the key absent at runtime; adding only the field silently fetches data nobody uses.
+
+## Relationship to ACL embedding
+
+This whitelist gate is **orthogonal to** the child-record ACL gate documented in
+[nested-fk-acl-embedding.md](nested-fk-acl-embedding.md). Naming a reverse collection in `fields` is
+necessary but not sufficient: each embedded child record is still re-checked against its own
+`AclRecordPermissions`, and an ungranted child is silently dropped. A missing nested collection can be
+caused by **either** an omitted `fields` entry **or** a missing child-record ACL grant — check both.
+
+## Gotchas
+
+- **Silent, not erroring.** An unlisted (or misspelled) reverse collection produces no `messages[]`
+  entry — the symptom is purely a missing key in `data`. Confirm the exact camelCase-plural name from
+  the child model before assuming a data problem.
+- **The 1.0 bridge hit this concretely.** TRUE-79401 needed
+  `contactEmailAddresses.emailAddress` added to the `/contacts` fetch `fields` list in
+  `App_Api_Toga2` before the 1.0 sync could read a contact's full email list — see
+  [App_Api_Toga2 — TOGa2 API Client & bridge](../../../../1.0/apps/library/features/toga2-api-client-and-bridge.md).
+
+## Change history
+
+- 2026-07-28 — Captured the framework-level rule (split out of the TRUE-79401 library gotcha): V2
+  reverse hasMany collections are resolved via the child model's `FOREIGNKEY_MODEL`, exposed under the
+  camelCase plural of the child model, and are **only** serialized when explicitly named in the fetch
+  `fields` whitelist — otherwise the key is silently absent (200 / `isSuccess:true`, no message).
+  Orthogonal to, and stacks with, the child-record ACL embedding gate. (mhammontree)
+</content>
+</invoke>

package/knowledge/INDEX.md

@@ -19,7 +19,7 @@ _Auto-generated by `knowledge.js index`. Do not hand-edit._
 
 - **_underscore** (_Underscore) _(framework core)_ — 40 doc(s) → [2.0/apps/_underscore/INDEX.md](2.0/apps/_underscore/INDEX.md)
 - **worker2** (Worker) — 34 doc(s) → [2.0/apps/worker2/INDEX.md](2.0/apps/worker2/INDEX.md)
-- **api2** (API) — 18 doc(s) → [2.0/apps/api2/INDEX.md](2.0/apps/api2/INDEX.md)
+- **api2** (API) — 19 doc(s) → [2.0/apps/api2/INDEX.md](2.0/apps/api2/INDEX.md)
 - **dbchanges2** (Database Changes) _(framework core)_ — 3 doc(s) → [2.0/apps/dbchanges2/INDEX.md](2.0/apps/dbchanges2/INDEX.md)
 - **toga2-supply** (TOGa Supply) — 3 doc(s) → [2.0/apps/toga2-supply/INDEX.md](2.0/apps/toga2-supply/INDEX.md)
 - **saml** (SAML SSO Gateway) — 3 doc(s) → [2.0/apps/saml/INDEX.md](2.0/apps/saml/INDEX.md)

package/knowledge/clients/aig/profile.md

@@ -5,11 +5,12 @@ apps:
   - _underscore
   - api2
   - dbchanges2
+  - library
 project: API
 client: aig
 type: profile
 status: active
-updated: 2026-06-19
+updated: 2026-07-28
 owners: ["mhammontree"]
 files: []
 related:
@@ -35,6 +36,10 @@ go out under the Staples Protection Plan brand and link to `staplesprotection.to
   NetSuite item/SO/invoice traits).
 - **`dbchanges2`** — `Client_Aig/` schema + reference-data migrations (e.g. the SaleItem code
   catalog in `Client_Aig.Items`).
+- **`library` (1.0)** — the `App_Api_Toga2` bridge syncs 2.0 AIG contacts/entitlements down into the
+  legacy 1.0 `TOGA_AIG` DB (`Customers`/`ServiceRequests`), run by a worker cron every ~10 min. Note
+  the two AIG databases: **`TOGA_AIG`** = V1 legacy sync target; **`Client_Aig`** = V2 prod tenant. See
+  [App_Api_Toga2 bridge](../../1.0/apps/library/features/toga2-api-client-and-bridge.md).
 
 See [entitlement-intake.md](features/entitlement-intake.md) for how a payload becomes an
 entitlement and how to load new sale-item codes.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "toga-ai",
-  "version": "1.0.463",
+  "version": "1.0.464",
   "description": "TOGA Technology Team Claude Knowledge System — shared AI coding harness with skills, knowledge base CLI, and project installer for Claude Code.",
   "keywords": [
     "claude",