toga-ai 1.0.409 → 1.0.411

package/knowledge/2.0/apps/ai-bdr/features/web-funnel-app.md

@@ -87,7 +87,10 @@ to its ship state (trusted-IP position for X-Forwarded-For; O(1) LRU-capped limi
 `?hsCampaignId=` page-prime param now `isTogaUuid`-validated). All checks green: tsc, eslint,
 **104/104 Vitest**, `next build` (build output labels the proxy `ƒ Proxy (Middleware)`).
 
-- **Repo:** `agilantsolutions/BDR` on GitHub, working branch `BDR-Development`. The
+- **Repo:** `agilantsolutions/BDR` on GitHub, **source-of-truth branch `_dev-sandbox`**
+  (2026-07-21: `BDR-Phase-2` and `BDR-Development` are retired/behind — `_dev-sandbox`
+  holds enrichment `6a97dd1`, fast-dial/share/guard `6d52b53`, and the Amplify env fix
+  `e17d804`; a future `_production` branch is cut from `_dev-sandbox`). The
   machine-local `.claude/` harness is **gitignored** — committing it would snapshot
   the whole KB stale; devs get the harness via `npx toga-ai`, not from this repo.
 
@@ -371,25 +374,44 @@ PRODUCTION credential set (`TOGA_API_BASE_URL = https://api.togahub.com/v2`).
 - **Restart the dev server after creating `.env.local`** — Next reads env files only at
   server startup. `.env.*` is gitignored in BDR.
 
-## Deploy status (AWS Amplify — NOT yet deployed)
-
-The BDR site is **not deployed anywhere yet** (as of 2026-07-20). Go-live is blocked on the
-Amplify setup, tracked by ClickUp **868kdf4tj "BDR - create amplify and sandbox route"** (urgent,
-Sprint 82) — still `to do`. (ClickUp shows Alex Peterson as assignee; the team says Jeff picked it
-up — ClickUp is stale, confirm the real owner before assuming.)
-
-- **Deploy branch is `_dev-sandbox`** (underscore-prefix convention), **not** `BDR-Development` /
-  `BDR-Phase-2`. The primary-phone self-heal (commit `4ac579e`, see the phone-less bug above) is
-  already merged into `_dev-sandbox`, so **Amplify's first build ships the fix**.
+## Deploy status (AWS Amplify — app EXISTS, first build shipping)
+
+**The Amplify app now exists (2026-07-21):** branch `_dev-sandbox` deploys to
+**`dev-sandbox.d65bvvjrww97g.amplifyapp.com`** (supersedes the prior "no Amplify app yet"
+status). Go-live tracking: ClickUp **868kdf4tj "BDR - create amplify and sandbox route"**
+(urgent, Sprint 82). (ClickUp showed Alex Peterson as assignee; the team said Jeff picked it
+up — confirm the real owner before assuming.)
+
+- **CRITICAL — the build-spec must WRITE the console env vars into `.env.production` at build
+  time (Amplify Next-SSR recipe).** The first deployment surfaced a build-spec bug: the old
+  `amplify.yml` only had branch cases for `_production` / `_beta`, each doing
+  `cp .env.production .env.local` — which expects a **committed** `.env` file that (correctly)
+  does not exist (secrets are never committed). **No branch case matched `_dev-sandbox` at all**,
+  so every deploy shipped with **ZERO server env vars**. Amplify console env vars exist only at
+  **build time**; the Next SSR **runtime** reads `.env.production` from the build artifact — so the
+  build must materialize them. Fix (commit `e17d804`): during build,
+  `env | grep -E '^(HUBSPOT_|TOGA_|NEXT_PUBLIC_|RATE_LIMIT_)' >> .env.production`. The same broken
+  `cp` pattern would have bitten the `_production` launch too.
+- **Symptom chain when the env vars are missing (what "no vars" looks like end-to-end):**
+  page-prime's HubSpot fetch throws → lead ref comes back empty → the **anonymous-visit guard
+  notice shows even with a valid `?hsContactId`** → `GET /api/contact` returns
+  `500 {"error":"Failed to fetch contact"}`. If you see the guard notice on a deployed URL that
+  has a real entry link, suspect missing server-side env before anything else.
+- **OPERATIONAL — env vars saved AFTER a build starts do NOT reach that build.** They are baked in
+  at build time, so after adding/changing console vars you must **"Redeploy this version"** for
+  them to take effect — a fresh save alone does nothing for an in-flight or already-built deploy.
 - **Amplify must be configured for SSR hosting (NOT static export)** — the app is server-rendered
   (server components, route handlers, and the `proxy.ts` edge proxy all require the SSR/compute
   runtime). Point the app at branch `_dev-sandbox`.
-- **5 server-side env vars are required** (same set as local dev): `TOGA_API_BASE_URL`,
-  `TOGA_CLIENT_ID`, `TOGA_CLIENT_API_UUID`, `TOGA_CLIENT_API_SECRET`, `HUBSPOT_ACCESS_TOKEN`.
-  **Where the values live (never the values):** the `info` repo's `.env.local` (production
-  credential set). Add them in the Amplify console environment config — never commit them. Two
-  optional vars beyond the 5: `NEXT_PUBLIC_GA_MEASUREMENT_ID` (GA4) and **`TOGA_WORKER_URL`** (the
-  fast-dial gate — unset ⇒ cron-only). See the parity audit for the full 7-var accounting.
+- **7 env vars go in the Amplify console** (never the values — **values live in `info/.env.local`**,
+  the production credential set): the 5 server-side ones `HUBSPOT_ACCESS_TOKEN`,
+  `TOGA_API_BASE_URL`, `TOGA_CLIENT_ID`, `TOGA_CLIENT_API_UUID`, `TOGA_CLIENT_API_SECRET`, plus
+  `TOGA_WORKER_URL` (the fast-dial gate — unset ⇒ cron-only) and `NEXT_PUBLIC_GA_MEASUREMENT_ID`
+  (GA4). See the parity audit for the full 7-var accounting.
+- **Status at capture:** env fix pushed (`e17d804` on `_dev-sandbox`); awaiting the console vars +
+  a green build for the first successfully deployed page-prime. The primary-phone self-heal (commit
+  `4ac579e`, see the phone-less bug above) is already on `_dev-sandbox`, so the first good build
+  ships that fix too.
 - **Phase 8 WAF pairing.** `BDR/PLAN.md` Phase 8 specifies a **per-IP rate rule on the CloudFront
   distribution / WAF** that pairs with the in-app token-bucket limiter (the app limiter is
   defense-in-depth only; the edge WAF rule is the authoritative control — see the enumeration
@@ -520,10 +542,34 @@ up — ClickUp is stale, confirm the real owner before assuming.)
   lookup carries the email in the query. Do not reintroduce value logging.
 - **No Tailwind** — see Stack. The mockup CSS is the styling system; adding Tailwind
   risks pixel parity.
+- **Deployed-site triage — "guard notice shows despite a valid entry link."** The
+  anonymous-visit guard notice is always the **terminal** symptom of "no lead reference,"
+  regardless of the underlying cause, so probe the layer directly:
+  `GET /api/contact?hsContactId=<id>` on the deployed URL. **`500 "Failed to fetch contact"`**
+  ⇒ HubSpot env missing server-side (see the Deploy status env-var bug). **`400`** ⇒ the id
+  value/format. **Contact JSON returned** ⇒ env is fine — suspect the rate-limit proxy's
+  soft-degrade (it strips `hsContactId` when the per-IP bucket trips, so repeated test refreshes
+  can trigger the same symptom).
 - **`.claude/` is gitignored** in the BDR repo on purpose — do not commit the
   harness; pull it with `npx toga-ai`.
 
 ## Change history
+- 2026-07-21 — **First Amplify deployment** (app now EXISTS: branch `_dev-sandbox` →
+  `dev-sandbox.d65bvvjrww97g.amplifyapp.com`, superseding the "not deployed yet" status).
+  DISCOVERED + FIXED (`amplify.yml`, commit `e17d804`) an env-var build-spec bug: the old spec only
+  handled `_production`/`_beta` with `cp .env.production .env.local` (expecting committed `.env`
+  files that correctly don't exist) and had **no `_dev-sandbox` case**, so deploys shipped **zero
+  server env vars** — page-prime's HubSpot fetch threw → empty lead ref → anonymous-visit guard
+  showed even with a valid `?hsContactId` → `/api/contact` returned `500 "Failed to fetch contact"`.
+  Fix is the Amplify Next-SSR recipe: build-time
+  `env | grep -E '^(HUBSPOT_|TOGA_|NEXT_PUBLIC_|RATE_LIMIT_)' >> .env.production` (console vars exist
+  only at build time; the SSR runtime reads `.env.production` from the artifact). Recorded the
+  operational rule that **env vars saved after a build starts require "Redeploy this version,"** and
+  a **deployed-site triage gotcha** (probe `GET /api/contact?hsContactId=` — 500 ⇒ missing env, 400
+  ⇒ bad id, JSON ⇒ suspect the rate-limit soft-degrade). DECIDED the branch model: `BDR-Phase-2` is
+  retired and **`_dev-sandbox` is the source-of-truth branch** (holds `6a97dd1` enrichment,
+  `6d52b53` fast-dial/share/guard, `e17d804` env fix); a future `_production` is cut from it. Status:
+  fix pushed, awaiting console vars + a green build for the first deployed prime. (tcox)
 - 2026-07-21 — Go-live continuation. **The full AI-BDR call loop was proven end-to-end in
   production** (campaign 2, `26.05 - AI BDR - Ryan Nitti`): UI submit → funnel API → dialer → Vapi
   call → webhook write-back (test method now in `../workflows/safe-call-loop-testing.md`). BUILT:

package/knowledge/sessions/2026-07-21-bdr-vapi-golive-tcox.md

@@ -28,7 +28,9 @@ updated: 2026-07-21
 - **Share button made real** (src/lib/shareMailto.ts, CallSummary.tsx): Send opens the visitor's mail client via mailto: with recipient/subject/summary body. BDR suite 131 tests green, tsc + eslint clean.
 - **Parity audit (info → BDR)**: everything ported; enrichment was net-new in BOTH repos; visit route intentionally dropped; TOGA_PUBLIC_TOKEN_URL and NEXT_PUBLIC_ENV are dead even in info.
 - **Vapi API diagnostics work** with the bearer const at worker2/Worker/Ai/Bdr/Vapi.php:6 (GET /call/{id} endedReason, GET /assistant/{id} config).
-- /capture published 4 doc updates (web-funnel-app, safe-call-loop-testing, vapi-webhook-handler, vapi-integration).
+- /capture published 4 doc updates (web-funnel-app, safe-call-loop-testing, vapi-webhook-handler, vapi-integration) + a delta capture for the deploy findings below.
+- **Amplify app EXISTS now** (tcox deployed): branch `_dev-sandbox` at dev-sandbox.d65bvvjrww97g.amplifyapp.com. **Root cause of "guard notice despite valid ?hsContactId" found and fixed**: old amplify.yml only handled `_production`/`_beta` with `cp` of committed .env files (which rightly don't exist) and had no `_dev-sandbox` case — every deploy shipped with ZERO server env vars → HubSpot prefetch throws → empty lead ref → guard blocks. Fix committed (`e17d804`): official Amplify recipe `env | grep -E '^(HUBSPOT_|TOGA_|NEXT_PUBLIC_|RATE_LIMIT_)' >> .env.production` at build; the 7 vars live in the Amplify console (values: info/.env.local + TOGA_WORKER_URL=https://worker.togahub.com/ + GA id).
+- **Deployed-site triage method** proven: probe `GET <site>/api/contact?hsContactId=<id>` — 500 "Failed to fetch contact" = server env missing; 400 = bad id; contact JSON = env fine (then suspect the rate-limiter's hsContactId-stripping soft-degrade).
 
 ## What did NOT work — DO NOT RETRY THESE
 - **Answering the test call silently** → 8 seconds of mutual silence, Vapi `endedReason=customer-ended-call`, empty transcript. The healthcare assistant uses `firstMessageMode=assistant-waits-for-user` (deliberate: first-phoneme timing for voicemail/iPhone screening). **Testers must say "Hello?" first.**
@@ -48,8 +50,9 @@ updated: 2026-07-21
 ## Current file state
 | File | Status | Notes |
 |------|--------|-------|
-| BDR enrichment + prefill (hubspot/toga/leadSink/page + tests) | committed by tcox (BDR-Phase-2), merge state to _dev-sandbox unverified | live-proven on contact 248 |
-| BDR fast-dial + anon guard + share (workerDialer, callbackService, CallNow, Schedule, schema, default, shareMailto, CallSummary, .env.example + 3 test files) | UNCOMMITTED in C:\WWW\BDR | 131 tests green; suggested msg: "feat: fast dial, anonymous submit guard, real share via mailto" |
+| BDR enrichment + prefill | committed `6a97dd1` on `_dev-sandbox` | live-proven on contact 248 |
+| BDR fast-dial + anon guard + share | committed `6d52b53` on `_dev-sandbox` | 131 tests green |
+| BDR amplify.yml env fix | committed `e17d804` on `_dev-sandbox`, pushed (build triggered) | official env-passthrough recipe; branch model: **_dev-sandbox is source of truth, BDR-Phase-2 retired** |
 | BDR/.env.local | TOGA_WORKER_URL added (local only) | dev server restart needed to load |
 | dbchanges2 feature/ai-bdr-test-campaign (e99a367) | pushed; PR must be CLOSED UNMERGED | superseded + buggy (see above) |
 | Prod Client_True data | campaign 2 dateEnd=2026-07-28; all campaign-2 contacts isOkayToCall=0 EXCEPT 248 | restore = go-live switch; exclude ids 120/132/134/146/155 |
@@ -62,12 +65,12 @@ updated: 2026-07-21
 - **Anonymous submits blocked with notice** (matches info) per tcox's directive that anything diverging from info needs correcting.
 
 ## Blockers
-- **Amplify app still doesn't exist** (ClickUp 868kdf4tj, Jeff) — 7 env vars now: the 5 server-side + NEXT_PUBLIC_GA_MEASUREMENT_ID + TOGA_WORKER_URL.
+- **Amplify env vars must be saved in the console BEFORE a build starts** (vars added mid-build don't reach it — "Redeploy this version" required). At save time: awaiting tcox confirming the 7 vars are in the console + a green build of `e17d804`. Deployed `/api/contact` still returned 500 at last probe.
 - **ContactAttempts ACL grant** (backend, DB config only) — gates real summaries + live status.
-- **Business decision on the restore SQL** (resumes cold-calling ~70 prospects).
+- **Business decision on the restore SQL** (resumes cold-calling ~70 prospects; exclude DNC ids 120/132/134/146/155).
 
 ## Exact next step
-> In `C:\WWW\BDR`: commit the uncommitted batch ("feat: fast dial, anonymous submit guard, real share via mailto"), push to BDR-Phase-2, merge to _dev-sandbox. Then restart the dev server (`npm run dev`) and submit Call Now — the phone should ring within seconds (fast-dial's first live test). If it takes ~a minute instead, check the dev console for a `[workerDialer]` warning: that means the worker's direct-action endpoint rejected the trigger and the cron fallback placed the call.
+> Confirm the 7 env vars are saved in the Amplify console, then redeploy branch `_dev-sandbox` (build must START after the vars are saved). When green, probe `https://dev-sandbox.d65bvvjrww97g.amplifyapp.com/api/contact?hsContactId=131770626674` — contact JSON = fixed. Then open `https://dev-sandbox.d65bvvjrww97g.amplifyapp.com/?hsContactId=131770626674` and submit Call Now: this is simultaneously the deployed smoke test AND the fast-dial first live run (phone rings in seconds from +1 331-244-5958 — ANSWER AND SPEAK FIRST).
 
 ---
 _Saved by /session-save on 2026-07-21_

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "toga-ai",
-  "version": "1.0.409",
+  "version": "1.0.411",
   "description": "TOGA Technology Team Claude Knowledge System — shared AI coding harness with skills, knowledge base CLI, and project installer for Claude Code.",
   "keywords": [
     "claude",