toga-ai 1.0.401 → 1.0.402

package/knowledge/2.0/apps/toga2-supply/INDEX.md

@@ -3,5 +3,5 @@
 | Doc | Summary | Files |
 |-----|---------|-------|
 | [TOGa Supply (toga2-supply) Architecture](architecture.md) | `toga2-supply` is the **React + Vite frontend** for TOGa Supply — warehouse fulfillment tooling (shipment selection, fulfill & ship against carrier APIs, NetSui | toga2-supply/src/api/toga.ts, toga2-supply/src/pages/ShipmentItems/view/ShipmentItemsPage.tsx, toga2-supply/src/pages/EditShipment/view/EditShipmentPage.tsx, toga2-supply/src/pages/EditShipment/api/UpdateShipmentApi.ts, toga2-supply/src/pages/Shipments/view/components/ShipmentsCardTableForm/ShipmentsCardTableForm.tsx |
-| [Fulfill & Ship](features/fulfill-and-ship.md) | Fulfill & Ship lets a warehouse user select sales-order line items, enter serials, pick a carrier/method, and in one action: create the Item Fulfillment records | toga2-supply/src/components/ui/Tables/BasicTable/BasicTable.tsx, toga2-supply/src/pages/ShipmentItems/view/forms/ShipmentItemsTable.tsx, toga2-supply/src/pages/ShipmentItems/api/ShipmentItemsApi.ts, toga2-supply/src/pages/ShipmentItems/types.ts, toga2-supply/src/pages/EditShipment/viewModel/FIELDS/RETURNLABELFIELDS.json, toga2-supply/src/pages/EditShipment/view/components/forms/EditShipmentForm.tsx, toga2-supply/src/components/ui/BaseInput/UnitSelect.tsx, toga2-supply/src/pages/EditShipment/view/modals/SerialNumbersModal.tsx, toga2-supply/src/pages/ShipmentItems/view/ShipmentItemsPage.tsx, toga2-supply/src/pages/EditShipment/view/EditShipmentPage.tsx, toga2-supply/src/pages/EditShipment/view/components/forms/EditShipmentForm.tsx, toga2-supply/src/pages/EditShipment/view/components/SelectedShipmentItemsTable.tsx, toga2-supply/src/pages/EditShipment/view/helpers/ShipmentDetailsForm/renderEditShipmentFormInput.tsx, toga2-supply/src/pages/EditShipment/viewModel/FIELDS/DUMMYUPDATESHIPMENTFIELDS.json, toga2-supply/src/pages/EditShipment/helpers/ShipmentDetailsForm/renderEditShipmentFormInput.tsx, toga2-supply/tailwind.config.cjs, toga2-supply/src/pages/EditShipment/view/modals/ReturnShippingModal.tsx, toga2-supply/src/styles/index.scss, toga2-supply/src/components/ui/BaseInput/BaseInput.tsx, toga2-supply/src/pages/EditShipment/api/UpdateShipmentApi.ts, toga2-supply/src/pages/EditShipment/viewModel/signatureTypes.ts, toga2-supply/src/pages/EditShipment/view/modals/SelectReturnAddressModal.tsx, toga2-supply/src/pages/EditShipment/helpers/ShipmentDetailsForm/formatShipmentData.ts, toga2-supply/src/pages/EditShipment/types.ts, toga2-supply/src/pages/Shipments/view/ShipmentsPage.tsx, toga2-supply/src/pages/Shipments/view/components/ShipmentsCardTableForm/ShipmentsCardTableForm.tsx, toga2-supply/src/pages/Shipments/api/ShipmentsApi.ts, toga2-supply/src/pages/Shipments/types.ts, toga2-supply/src/pages/FulfilledShipments/view/FulfilledShipmentsPage.tsx, toga2-supply/src/components/ui/CardTable/CardTable.tsx, toga2-supply/src/components/ui/CardTable/types.ts, toga2-supply/src/assets/pen-line.svg, _underscore/Model/Client/ItemFulfillment.php, _underscore/Trait/Netsuite/ItemFulfillment.php, _underscore/Component/Library/Carriers/Ups/Ups.php |
+| [Fulfill & Ship](features/fulfill-and-ship.md) | Fulfill & Ship lets a warehouse user select sales-order line items, enter serials, pick a carrier/method, and in one action: create the Item Fulfillment records | toga2-supply/src/components/ui/Tables/BasicTable/BasicTable.tsx, toga2-supply/src/components/ui/Tables/types.ts, toga2-supply/src/components/ui/GoogleMapsLink.tsx, toga2-supply/src/pages/ShipmentItems/view/forms/ShipmentItemsTable.tsx, toga2-supply/src/pages/ShipmentItems/api/ShipmentItemsApi.ts, toga2-supply/src/pages/ShipmentItems/types.ts, toga2-supply/src/pages/EditShipment/viewModel/FIELDS/RETURNLABELFIELDS.json, toga2-supply/src/pages/EditShipment/view/components/forms/EditShipmentForm.tsx, toga2-supply/src/components/ui/BaseInput/UnitSelect.tsx, toga2-supply/src/pages/EditShipment/view/modals/SerialNumbersModal.tsx, toga2-supply/src/pages/ShipmentItems/view/ShipmentItemsPage.tsx, toga2-supply/src/pages/EditShipment/view/EditShipmentPage.tsx, toga2-supply/src/pages/EditShipment/view/components/forms/EditShipmentForm.tsx, toga2-supply/src/pages/EditShipment/view/components/SelectedShipmentItemsTable.tsx, toga2-supply/src/pages/EditShipment/view/helpers/ShipmentDetailsForm/renderEditShipmentFormInput.tsx, toga2-supply/src/pages/EditShipment/viewModel/FIELDS/DUMMYUPDATESHIPMENTFIELDS.json, toga2-supply/src/pages/EditShipment/helpers/ShipmentDetailsForm/renderEditShipmentFormInput.tsx, toga2-supply/tailwind.config.cjs, toga2-supply/src/pages/EditShipment/view/modals/ReturnShippingModal.tsx, toga2-supply/src/styles/index.scss, toga2-supply/src/components/ui/BaseInput/BaseInput.tsx, toga2-supply/src/pages/EditShipment/api/UpdateShipmentApi.ts, toga2-supply/src/pages/EditShipment/viewModel/signatureTypes.ts, toga2-supply/src/pages/EditShipment/view/modals/SelectReturnAddressModal.tsx, toga2-supply/src/pages/EditShipment/helpers/ShipmentDetailsForm/formatShipmentData.ts, toga2-supply/src/pages/EditShipment/types.ts, toga2-supply/src/pages/Shipments/view/ShipmentsPage.tsx, toga2-supply/src/pages/Shipments/view/components/ShipmentsCardTableForm/ShipmentsCardTableForm.tsx, toga2-supply/src/pages/Shipments/api/ShipmentsApi.ts, toga2-supply/src/pages/Shipments/types.ts, toga2-supply/src/pages/FulfilledShipments/view/FulfilledShipmentsPage.tsx, toga2-supply/src/components/ui/CardTable/CardTable.tsx, toga2-supply/src/components/ui/CardTable/types.ts, toga2-supply/src/assets/pen-line.svg, _underscore/Model/Client/ItemFulfillment.php, _underscore/Trait/Netsuite/ItemFulfillment.php, _underscore/Component/Library/Carriers/Ups/Ups.php |
 | [AWS Amplify Build & Deploy (non-prod environments)](workflows/amplify-build-and-deploy.md) | How `toga2-supply` (React + Vite) builds and deploys on **AWS Amplify**. | toga2-supply/amplify.yml, toga2-supply/.gitattributes, toga2-supply/.github/workflows/sync-stage-environments.yml, toga2-supply/.env.qc-security |

package/knowledge/2.0/apps/toga2-supply/features/fulfill-and-ship.md

@@ -10,6 +10,8 @@ updated: 2026-07-21
 owners: [mhammontree]
 files:
   - toga2-supply/src/components/ui/Tables/BasicTable/BasicTable.tsx
+  - toga2-supply/src/components/ui/Tables/types.ts
+  - toga2-supply/src/components/ui/GoogleMapsLink.tsx
   - toga2-supply/src/pages/ShipmentItems/view/forms/ShipmentItemsTable.tsx
   - toga2-supply/src/pages/ShipmentItems/api/ShipmentItemsApi.ts
   - toga2-supply/src/pages/ShipmentItems/types.ts
@@ -242,6 +244,17 @@ A field changed from its saved value shows a **mint-600 (`#2CB224`) border**; it
   for a user-meaningful prefill (e.g. the warehouse-address prefill) must pass `{ shouldDirty: true }`
   or RHF reports the field clean and the border never appears (see the RHF `isDirty` gotcha below).
 
+### BasicTable click-to-select rows — `onRowClick` (2026-07-21)
+
+`BasicTable` now accepts an optional **`onRowClick?: (row) => void`** (`components/ui/Tables/types.ts`,
+`components/ui/Tables/BasicTable/BasicTable.tsx`) — a reusable click-to-select-row pattern for any
+`BasicTable`. **The handler IGNORES clicks whose target is inside an interactive element**
+(`input,button,a,select,textarea,label`), so checkboxes / inputs / buttons keep their own behavior; a
+click anywhere ELSE on the row fires `onRowClick`. First consumer: Select Items
+(`ShipmentItemsTable.tsx`) — clicking a row toggles its checkbox. Requirements for that use: rows must
+carry a **`uuid`** and **disabled rows are skipped**. Reuse this for any `BasicTable` that wants
+row-level selection rather than only the checkbox hit area.
+
 ## Signature Type — 4-level enum (2026-07)
 
 Signature moved from a **boolean `requiresSignature`** to a **4-level `signatureType` enum**:
@@ -289,6 +302,27 @@ existing IF), `fulfillShipment` + `generateReturnLabel` (label), `saveShipmentTo
 (push-back). New pieces needed: the punch-out entry carrying an IF id, and a **label-only mode**
 (skip the create step). This is a separate feature/ticket — recorded as planned direction, not done.
 
+## Planned direction — persist package dimension + volume Units of Measure (design, 2026-07-21)
+
+**Design decision recorded for future work (not implemented this session).** Today the package
+dimension in./cm selector is **visual-only** and `TrackingNumbers` stores `length`/`width`/`height`
+with **no unit**. The plan is to persist the package **DIMENSION** unit (for L/W/H) and the **VOLUME**
+unit on the tracking record.
+
+- **Recommended design = ZERO new tables, only columns.** REUSE the existing client **`Measures`**
+  table + **`_Model_Client_Measure`** model (already referenced by `Items.defaultMeasureId`): add a
+  **`measureType` ENUM** (LENGTH / VOLUME / WEIGHT / COUNT — per Jeff the types are enumerators, so
+  **no separate `MeasureTypes` table**) plus a **`conversionFactorToBase`** column, and add
+  **`dimensionMeasureId` / `volumeMeasureId`** FK columns on **`TrackingNumbers`**.
+- **Carrier constraint drives the conversion factor.** FedEx/UPS ship APIs accept only **IN/CM**
+  dimension units and **LB/KG** weight units, so the chosen measure must map/convert to the carrier
+  enum — hence `conversionFactorToBase`. **Volume is NOT sent to carriers** (dimensional weight is
+  derived from L/W/H).
+- **Alternative (documented for opt-in):** two dedicated new tables instead of reusing `Measures`.
+- Spans `_underscore` (Measure/TrackingNumber models), `dbchanges2`, and `api2`; full plan + the
+  deployment order live in external working files (`package_units_of_measure_plan.md`,
+  `TRUE-79191_deployment_order.md`) — not mirrored into the KB.
+
 ## Sources — meeting notes / decision origins
 
 Fulfill & Ship meeting transcripts and notes live in the **Internal Knowledgebase MCP connector**
@@ -312,6 +346,25 @@ the call 403s and returns no label.
 
 ## Gotchas / known issues
 
+- **⚠ The shared `GoogleMapsLink` mapped the RECIPIENT, not the address.** The shared
+  `components/ui/GoogleMapsLink.tsx` built its query from `[addressee, line1, line2, city, zip]`,
+  which had two bugs: (a) it included the **`addressee` (recipient name)**, so Google surfaced the
+  *person* instead of the location; (b) it read **`line1`** but the shipment address object exposes
+  the street as **`street`** (not `line1`), so the street was missing. Fix: map the **physical address
+  ONLY** — `street || line1`, line2, city, `state.name`, zip; **exclude the addressee**. Two more
+  bugs fixed in the same component: an **always-true empty-part filter** (`!= null || != undefined` —
+  a value is always either not-null or not-undefined, so nothing was ever filtered), and a
+  **double-encoding bug** — it did `replace(/\s+/g,"+")` and *then* `encodeURIComponent`, so the `+`
+  was itself encoded to literal `%2B` and Maps got broken queries. Encode once. Separately, the Edit
+  Return Label modal's "Google Maps" link (`ReturnShippingModal.tsx`) had **no `onClick` handler at
+  all** — wired it to open the current return address.
+- **⚠ A viewport-relative `max-w-[NNvw]` truncation cap can itself force horizontal overflow on a WIDE
+  table.** The CSS-truncation pattern (`truncate max-w-[NNvw]` + native `title` — see the
+  `ExpandableCellContent` gotcha below) caps one column at `NN%` of the viewport, but on a
+  **many-column** table that capped column PLUS all the other columns can exceed the viewport width and
+  add a horizontal scrollbar. **Tune the `vw` per table by column count:** Select Items (13 columns)
+  uses `max-w-[20vw]`; Update Info (8 columns) keeps `max-w-[30vw]`. The truncation mechanism itself is
+  unchanged. (`ShipmentItemsTable.tsx`.)
 - **⚠ The item-image tables hardcoded the placeholder and never requested the image.** The Select
   Items (`ShipmentItemsTable`), Update Info, and Add-Serial (`SelectedShipmentItemsTable`) tables
   rendered `imageUrl={placeholderImage}` as a **constant**, so a real item image could never appear.
@@ -618,6 +671,17 @@ not the base `_Model_Client_ItemFulfillment`. Tested with GroWrk; UPS support wa
 for Compass and is not yet in prod.
 
 ## Change history
+- 2026-07-21 — TRUE-79191 (commit `651e9d9d0`, toga2-supply UI fixes + UoM design): fixed the shared
+  **`GoogleMapsLink`** mapping the recipient instead of the address (excluded `addressee`; read
+  `street || line1` not `line1`; killed an always-true empty-part filter and a `replace`+`encodeURIComponent`
+  **double-encoding** bug) and wired the Edit Return Label modal's previously dead "Google Maps" link.
+  Added **`BasicTable.onRowClick`** — a reusable click-to-select-row capability that ignores clicks on
+  interactive children (`input,button,a,select,textarea,label`); first used on Select Items to toggle a
+  row's checkbox. Documented the **`max-w-[NNvw]` truncation-cap causing horizontal overflow** on wide
+  tables (tune the vw per column count: 13-col Select Items `20vw`, 8-col Update Info `30vw`). Recorded
+  the **package Units-of-Measure design** (persist dimension + volume units on `TrackingNumbers` by
+  reusing the `Measures` table + `measureType` enum + `conversionFactorToBase`; zero new tables;
+  carriers accept only IN/CM + LB/KG) as a planned direction — implementation not started. (mhammontree)
 - 2026-07-21 — TRUE-79191 (commit `dc900ea4e`, toga2-supply item-image + table polish): fixed the
   **item image never rendering** — the Select Items / Update Info / Add-Serial tables hardcoded
   `imageUrl={placeholderImage}` and never requested the image; now request the two `_underscore` Item

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "toga-ai",
-  "version": "1.0.401",
+  "version": "1.0.402",
   "description": "TOGA Technology Team Claude Knowledge System — shared AI coding harness with skills, knowledge base CLI, and project installer for Claude Code.",
   "keywords": [
     "claude",