toga-ai 1.0.364 → 1.0.366

package/knowledge/1.0/apps/webhook/features/netsuite-clickup-opportunity-sync.md

@@ -6,7 +6,7 @@ project: Webhook
 client: shared
 type: feature
 status: active
-updated: 2026-06-15
+updated: 2026-07-17
 owners: ["dfranks"]
 files:
   - webhook/_/webhook/netsuite.php
@@ -74,6 +74,23 @@ the assignment fires 2493 in `edit` (full-record) context → proper name (see G
 None — single internal Agilant/True integration.
 
 ## Gotchas / known issues
+- **Create-only, NO dedup of any kind (confirmed 2026-07-17).** `Webhook_NetSuite::post()`
+  json-decodes the payload and calls `createTask()`, which POSTs a **new** task to ClickUp
+  list `901111987449` **unconditionally on every delivery** (writing link `db_client`). There
+  is no idempotency check whatsoever — so it double-creates a task on **any** repeat or
+  concurrent delivery, not only concurrent ones.
+- **Live payload carries no immutable opportunity identifier (confirmed 2026-07-17).** The
+  inbound body has **only**: `name`, `description`, `presalesLead`, `salesRepText`, `token`.
+  It has **no NetSuite opportunity internal id and no opportunity/customer number**, so there
+  is no stable key available in this handler to dedup on today. Any dedup fix must first get
+  NetSuite (script 2493) to include an immutable id in the payload, or derive one another way.
+- **Where the swapped Opp#/Cust# mapping actually lives.** The
+  `OPPORTUNITY_NUMBER ← customerNumber` / `CUSTOMER_NUMBER ← opportunityNumber` swap is in the
+  **dormant 2.0 port** `worker2/Worker/Netsuite.php` (class `_Worker_NetSuite`, ~lines 116–121),
+  which is **NOT live**. The live `webhook/_/webhook/netsuite.php` payload doesn't even carry
+  those number fields (see above). There is **no** `worker2/Worker/Netsuite/Opportunity.php` and
+  **no** `maybeCreateClickupTask()` method anywhere — earlier plans referencing those paths were
+  citing files that do not exist.
 - **`OPP <internalId>` degenerate tasks (root-caused & confirmed 2026-06-15).** A task named just
   `OPP 7147699` with no description/fields. The name is built by NetSuite and relayed verbatim;
   the opps are **fully populated** in NetSuite (so it's not missing data, not a TOGA bug). Cause:
@@ -131,6 +148,13 @@ Done 2026-06-15 for opps 7147699/7147698/7147472/6382879 → 4 proper tasks crea
 (task ids `868k0tr41`, `868k0tr16`, `868k0rwtp`, `868k0h44m`) were archived in ClickUp afterward.
 
 ## Change history
+- 2026-07-17 — Confirmed against live code: `createTask()` POSTs to list `901111987449`
+  **unconditionally with no dedup** (double-creates on any repeat/concurrent delivery); the
+  live payload carries only `name`/`description`/`presalesLead`/`salesRepText`/`token` — **no
+  opportunity internal id or number**, so no stable dedup key exists in the handler today. The
+  swapped Opp#/Cust# mapping lives in the **dormant** `worker2/Worker/Netsuite.php`
+  (`_Worker_NetSuite`, ~lines 116–121), not the live file; corrected fictional references to
+  `worker2/Worker/Netsuite/Opportunity.php` / `maybeCreateClickupTask()` (neither exists). (dfranks)
 - 2026-06-15 — **Fix deployed in NetSuite prod:** scheduled script 2412's presales-lead assignment
   switched from `submitFields` to full `load`/`setValue`/`save` → fires 2493 in `edit` (full-record)
   context → proper names. Residual: 2493 still latently `xedit`-vulnerable to other triggers; watch

package/knowledge/2.0/apps/toga2-supply/INDEX.md

@@ -3,5 +3,5 @@
 | Doc | Summary | Files |
 |-----|---------|-------|
 | [TOGa Supply (toga2-supply) Architecture](architecture.md) | `toga2-supply` is the **React + Vite frontend** for TOGa Supply — warehouse fulfillment tooling (shipment selection, fulfill & ship against carrier APIs, NetSui | toga2-supply/src/api/toga.ts, toga2-supply/src/pages/ShipmentItems/view/ShipmentItemsPage.tsx, toga2-supply/src/pages/EditShipment/view/EditShipmentPage.tsx, toga2-supply/src/pages/EditShipment/api/UpdateShipmentApi.ts, toga2-supply/src/pages/Shipments/view/components/ShipmentsCardTableForm/ShipmentsCardTableForm.tsx |
-| [Fulfill & Ship](features/fulfill-and-ship.md) | Fulfill & Ship lets a warehouse user select sales-order line items, enter serials, pick a carrier/method, and in one action: create the Item Fulfillment records | toga2-supply/src/pages/ShipmentItems/view/ShipmentItemsPage.tsx, toga2-supply/src/pages/EditShipment/view/EditShipmentPage.tsx, toga2-supply/src/pages/EditShipment/view/components/forms/EditShipmentForm.tsx, toga2-supply/src/pages/EditShipment/view/components/SelectedShipmentItemsTable.tsx, toga2-supply/src/pages/EditShipment/view/helpers/ShipmentDetailsForm/renderEditShipmentFormInput.tsx, toga2-supply/src/pages/EditShipment/viewModel/FIELDS/DUMMYUPDATESHIPMENTFIELDS.json, toga2-supply/src/pages/EditShipment/helpers/ShipmentDetailsForm/renderEditShipmentFormInput.tsx, toga2-supply/tailwind.config.cjs, toga2-supply/src/pages/EditShipment/view/modals/ReturnShippingModal.tsx, toga2-supply/src/styles/index.scss, toga2-supply/src/components/ui/BaseInput/BaseInput.tsx, toga2-supply/src/pages/EditShipment/api/UpdateShipmentApi.ts, toga2-supply/src/pages/EditShipment/viewModel/signatureTypes.ts, toga2-supply/src/pages/EditShipment/view/modals/SelectReturnAddressModal.tsx, toga2-supply/src/pages/EditShipment/helpers/ShipmentDetailsForm/formatShipmentData.ts, toga2-supply/src/pages/EditShipment/types.ts, toga2-supply/src/pages/Shipments/view/ShipmentsPage.tsx, toga2-supply/src/pages/Shipments/view/components/ShipmentsCardTableForm/ShipmentsCardTableForm.tsx, toga2-supply/src/pages/Shipments/api/ShipmentsApi.ts, toga2-supply/src/pages/Shipments/types.ts, toga2-supply/src/pages/FulfilledShipments/view/FulfilledShipmentsPage.tsx, toga2-supply/src/components/ui/CardTable/CardTable.tsx, toga2-supply/src/components/ui/CardTable/types.ts, toga2-supply/src/assets/pen-line.svg, _underscore/Model/Client/ItemFulfillment.php, _underscore/Trait/Netsuite/ItemFulfillment.php, _underscore/Component/Library/Carriers/Ups/Ups.php |
+| [Fulfill & Ship](features/fulfill-and-ship.md) | Fulfill & Ship lets a warehouse user select sales-order line items, enter serials, pick a carrier/method, and in one action: create the Item Fulfillment records | toga2-supply/src/components/ui/BaseInput/UnitSelect.tsx, toga2-supply/src/pages/EditShipment/view/modals/SerialNumbersModal.tsx, toga2-supply/src/pages/ShipmentItems/view/ShipmentItemsPage.tsx, toga2-supply/src/pages/EditShipment/view/EditShipmentPage.tsx, toga2-supply/src/pages/EditShipment/view/components/forms/EditShipmentForm.tsx, toga2-supply/src/pages/EditShipment/view/components/SelectedShipmentItemsTable.tsx, toga2-supply/src/pages/EditShipment/view/helpers/ShipmentDetailsForm/renderEditShipmentFormInput.tsx, toga2-supply/src/pages/EditShipment/viewModel/FIELDS/DUMMYUPDATESHIPMENTFIELDS.json, toga2-supply/src/pages/EditShipment/helpers/ShipmentDetailsForm/renderEditShipmentFormInput.tsx, toga2-supply/tailwind.config.cjs, toga2-supply/src/pages/EditShipment/view/modals/ReturnShippingModal.tsx, toga2-supply/src/styles/index.scss, toga2-supply/src/components/ui/BaseInput/BaseInput.tsx, toga2-supply/src/pages/EditShipment/api/UpdateShipmentApi.ts, toga2-supply/src/pages/EditShipment/viewModel/signatureTypes.ts, toga2-supply/src/pages/EditShipment/view/modals/SelectReturnAddressModal.tsx, toga2-supply/src/pages/EditShipment/helpers/ShipmentDetailsForm/formatShipmentData.ts, toga2-supply/src/pages/EditShipment/types.ts, toga2-supply/src/pages/Shipments/view/ShipmentsPage.tsx, toga2-supply/src/pages/Shipments/view/components/ShipmentsCardTableForm/ShipmentsCardTableForm.tsx, toga2-supply/src/pages/Shipments/api/ShipmentsApi.ts, toga2-supply/src/pages/Shipments/types.ts, toga2-supply/src/pages/FulfilledShipments/view/FulfilledShipmentsPage.tsx, toga2-supply/src/components/ui/CardTable/CardTable.tsx, toga2-supply/src/components/ui/CardTable/types.ts, toga2-supply/src/assets/pen-line.svg, _underscore/Model/Client/ItemFulfillment.php, _underscore/Trait/Netsuite/ItemFulfillment.php, _underscore/Component/Library/Carriers/Ups/Ups.php |
 | [AWS Amplify Build & Deploy (non-prod environments)](workflows/amplify-build-and-deploy.md) | How `toga2-supply` (React + Vite) builds and deploys on **AWS Amplify**. | toga2-supply/amplify.yml, toga2-supply/.gitattributes, toga2-supply/.github/workflows/sync-stage-environments.yml, toga2-supply/.env.qc-security |

package/knowledge/2.0/apps/toga2-supply/features/fulfill-and-ship.md

@@ -6,9 +6,11 @@ project: TOGa Supply
 client: shared
 type: feature
 status: active
-updated: 2026-07-15
+updated: 2026-07-17
 owners: [mhammontree]
 files:
+  - toga2-supply/src/components/ui/BaseInput/UnitSelect.tsx
+  - toga2-supply/src/pages/EditShipment/view/modals/SerialNumbersModal.tsx
   - toga2-supply/src/pages/ShipmentItems/view/ShipmentItemsPage.tsx
   - toga2-supply/src/pages/EditShipment/view/EditShipmentPage.tsx
   - toga2-supply/src/pages/EditShipment/view/components/forms/EditShipmentForm.tsx
@@ -135,8 +137,11 @@ bare string** — see the gotcha below before wiring a new select field.
 
 - **Renderer extension points (how to add a non-BaseInput control).** `renderEditShipmentFormInput.tsx`
   special-cases fields by boolean flags on the JSON field object (existing: `isClearAll`, `isReadOnly`;
-  added `isUnitSelector` = a native in./cm `<select>`, mirroring the Return Shipping modal — visual-only,
-  not persisted). **Reuse pattern for any custom control: add a flag to the JSON field + a branch in the
+  added `isUnitSelector` = the in./cm unit selector, mirroring the Return Shipping modal — visual-only,
+  not persisted). The `isUnitSelector` branch now renders the shared **`UnitSelect`** component
+  (`src/components/ui/BaseInput/UnitSelect.tsx`) — a react-select styled to match the compact
+  `BaseInput` dropdowns (white menu, checkmark, FA chevron) — instead of a native `<select>`, so its
+  menu matches the other dropdowns; `ReturnShippingModal` uses the same component. **Reuse pattern for any custom control: add a flag to the JSON field + a branch in the
   renderer** rather than forcing it through `BaseInput`. A per-section `sectionTitleContainerClasses` is
   also read by `EditShipmentForm.tsx`'s shared section-title wrapper (default unchanged) so a section can
   e.g. right-align its title (used to right-align the Item Count column's title + value to a shared edge).
@@ -281,6 +286,38 @@ the call 403s and returns no label.
 
 ## Gotchas / known issues
 
+- **⚠ A portaled react-select menu loses the control's inherited font size.** `BaseInput`'s
+  react-select menus now portal to `<body>` (`menuPortalTarget={document.body}` +
+  `styles.menuPortal` `zIndex 9999`, on both single- and multi-select) so the menu can't be
+  painted over by a sibling scroll box / stacking context (the symptom was the device-list
+  table clipping the dropdown). **Side effect:** once portaled, the menu is a child of `<body>`,
+  not the control, so it no longer inherits the control's font size and jumps to the browser
+  default (~16px). Fix: pin it back with `text-sm` on the react-select `menu` `classNames`.
+  Whenever you portal a react-select menu, re-assert font size on the menu.
+  (`src/components/ui/BaseInput/BaseInput.tsx`.)
+- **⚠ Sticky table headers need a z-index ABOVE `BaseToolTip`'s `z-[9999]`.** `BasicTable` gained
+  a `stickyHeaderZ` prop (default `z-10`). `BaseToolTip` wraps its children in a `z-[9999]`
+  layer, so a tooltip-wrapped cell (e.g. a trash/delete column) shows THROUGH a sticky header
+  while scrolling unless the header's z beats it. **But you can't just crank it globally:** an
+  in-page table's header must stay `z-10` so it can never paint above a modal; a table that lives
+  *inside* a modal can safely use a very high z (`z-[10000]`) because it's already inside the
+  modal's stacking context. Pick the z per table location, not one global value.
+- **⚠ Config-driven fixed-width form labels silently misalign when a label exceeds its width.**
+  Right-aligned label columns sized `w-[Npx] shrink-0` rely on every label fitting in `N`px —
+  flexbox `min-width:auto` will grow just the labels whose text is longer than `N` and shove
+  *their* inputs to the right, so only some rows misalign. Two rules: (1) size the label column to
+  the LONGEST label; (2) keep the label→input spacing identical on EVERY row — a stray double
+  space (`"items-center  pb-3"`) made one row miss a bulk `gap-2` sweep and sit 8px off. Concrete
+  fix: the Update Info address block was matched to the Edit Return Label block (labels `w-[70px]`,
+  ZIP `w-[36px]`, `flex items-center gap-2`), address column widened `col5 w-80`→`w-96`, and a
+  ZIP-favoring grid split `grid-cols-[1fr_1fr_1fr_1.25fr_1.25fr]` so a full ZIP+4 fits.
+- **Fixed-height modals overflow short viewports — size to the viewport, not to px.** The Add
+  Serial Numbers modal was `h-[822px]` and overflowed short screens. Reusable pattern that fixed
+  it: modal `max-h-[90vh] overflow-y-auto`, the inner scrolling list sized to the viewport
+  (`max-h-[40vh]`) rather than fixed px, drop the fixed `h-[90%]`/`h-[822px]` wrapper, and give the
+  in-modal sticky header a z above tooltips (see the `stickyHeaderZ` gotcha — modal tables can use
+  `z-[10000]`). Files: `src/pages/EditShipment/view/modals/SerialNumbersModal.tsx`,
+  `SelectedShipmentItemsTable.tsx`.
 - **⚠ Native `<datalist>` renders its OWN dropdown arrow, un-hideable by Tailwind.** An
   `<input list>` combobox (the Edit Return Label Addressee) shows a **second dark arrow** (the
   webkit calendar-picker indicator) that a Tailwind arbitrary variant can't reliably hide. Kill it
@@ -497,6 +534,23 @@ not the base `_Model_Client_ItemFulfillment`. Tested with GroWrk; UPS support wa
 for Compass and is not yet in prod.
 
 ## Change history
+- 2026-07-17 — TRUE-79191 (David design-review pass, toga2-supply UI): documented four durable,
+  app-wide component gotchas — (1) **`BaseInput` react-select menus now portal to `<body>`**
+  (`menuPortalTarget` + `menuPortal zIndex 9999`) so a sibling scroll box can't clip them, and the
+  side effect that a portaled menu loses the control's font size (re-pin with `text-sm` on the `menu`
+  classNames); (2) **`BasicTable` gained `stickyHeaderZ`** (default `z-10`) because sticky headers
+  must beat `BaseToolTip`'s `z-[9999]` to stop tooltip-wrapped cells showing through — but in-page
+  tables must stay `z-10` (never above a modal) while in-modal tables can use `z-[10000]`; (3) the
+  **fixed-width form-label misalignment** footgun (size the column to the longest label + keep
+  identical label→input spacing on every row); and (4) the **fixed-height-modal overflow** pattern
+  (modal `max-h-[90vh] overflow-y-auto` + inner list `max-h-[40vh]`, drop fixed px) via the Add Serial
+  Numbers modal. Also: new shared **`UnitSelect`** component (react-select styled to match the compact
+  dropdowns) replaced the native in./cm `<select>` in the renderer's `isUnitSelector` branch and in
+  `ReturnShippingModal`; `SupplyFormGuardrail` now renders a dimmed click-to-cancel backdrop
+  (`fixed inset-0 z-[9920] bg-black/40`) so it reads as a lightbox; and the Update Info address block
+  was aligned to the Edit Return Label block (labels `w-[70px]`/ZIP `w-[36px]`, address col `w-96`,
+  ZIP-favoring 5-col grid). The return-validation spinner (left of the modal's Cancel while validating)
+  and the Select Return Address Figma tuning were cosmetic — no separate doc change. (mhammontree)
 - 2026-07-17 — TRUE-79191: replaced the boolean `requiresSignature` with a **4-level `signatureType`
   enum** (None Specified / Indirect / Direct / Adult) — `viewModel/signatureTypes.ts` is the single
   source of truth (options, `signatureCardLabel`, `requiresSignatureFromLevel` back-compat,

package/knowledge/2.0/apps/worker2/features/talos-meeting-notes-integration.md

@@ -6,7 +6,7 @@ project: Worker
 client: shared
 type: feature
 status: active
-updated: 2026-06-26
+updated: 2026-07-17
 owners: [dfranks]
 files:
   - .claude/skills/plan-ticket/scripts/talos.js
@@ -79,6 +79,26 @@ The browser obtains the initial token pair via the `talos.togaiq.com` login. A d
 copy `accessToken` + `refreshToken` out of the browser session to seed a local tool, after
 which the tool refreshes on its own.
 
+## Gotcha — intermittent tool-selection failure (empty `{}` ≠ "no notes")
+
+DevCore is **nondeterministic** in which tool it picks for a meeting-notes query. On some
+runs it emits a tool call to **`search_knowledge_base`**, which is **no longer a registered
+tool** on the server. The runtime rejects it —
+`Error: search_knowledge_base is not a valid tool, try one of [toga_health,
+toga_list_environments, toga_list_clusters, toga_list_schemas, ...]` (the registry now
+exposes the TOGa Database Integration tools instead). On those runs the run produces **no
+final `ai` answer** and `talos.js` prints an empty `{}`. Other runs pick a valid KB-search
+tool and return real cited meeting notes.
+
+- **Do not read an empty `{}` as "no meeting notes found."** It is a transient
+  tool-selection failure — treating it as an answer leads to fabricated "no notes"
+  conclusions.
+- **Workaround:** retry the query until non-empty (a simple retry loop, ~4 attempts, clears
+  it in practice).
+- **Root fix is server-side:** whoever owns the DevCore assistant config should re-register
+  the meeting-notes KB-search tool (or update the assistant's system prompt to the current
+  tool name).
+
 ## Credential storage (location only)
 
 The consumer tool stores its token pair at **`~/.talos/credentials.json`** (user home,
@@ -94,4 +114,5 @@ mirrored into the knowledge base.
 
 ## Change history
 
+- 2026-07-17 — Added the intermittent tool-selection gotcha: DevCore nondeterministically calls the now-unregistered `search_knowledge_base` tool → run yields no `ai` answer and `talos.js` prints empty `{}`; treat empty as a transient failure (retry ~4x), not "no notes found"; root fix is re-registering the KB-search tool server-side (dfranks)
 - 2026-06-26 — Initial doc: consumer-side Talos meeting-notes access via DevCore assistant + the `/v2/auth/refresh` token-rotation flow; stateless `[talos]` config vs. assistant distinction; EV-2/EV-5 gotchas; credential location `~/.talos/credentials.json` (dfranks)

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "toga-ai",
-  "version": "1.0.364",
+  "version": "1.0.366",
   "description": "TOGA Technology Team Claude Knowledge System — shared AI coding harness with skills, knowledge base CLI, and project installer for Claude Code.",
   "keywords": [
     "claude",