toga-ai 1.0.345 → 1.0.347

package/knowledge/2.0/apps/toga2-supply/features/fulfill-and-ship.md

@@ -93,6 +93,32 @@ from the saved fulfillment; **Save UPDATES the existing records** instead of POS
 - `CardTable` was made reusable for this: optional `editIcon` + `isEditButtonDisabled` props
   (defaults preserve prior behavior; the shipments card is the only consumer today).
 
+## Delete a saved shipment from the Edit form (2026-07)
+
+The Edit Shipment form has a **"Delete Shipment"** button (bottom-left of the footer,
+**edit mode only** — there is no saved shipment to delete in create mode). It deletes the
+saved shipment and returns the user to the Select Items page
+(`/shipment-items?internalId=...`). Flow: opens a `SupplyFormGuardrail` **confirm** first
+(delete is irreversible), then shows a "Deleting shipment..." loading screen and toasts
+success/failure.
+
+- **Reuses the existing cascade delete** `deleteShipments(shipmentUuid,
+  itemFulfillmentPackageUuid?, trackingNumberUuid?)` from `Shipments/api/ShipmentsApi.ts` —
+  the **same** API the Pending Shipments trash icon uses. Cascade/delete order:
+  item-fulfillment-tracking-numbers (bridge) → tracking-numbers →
+  item-fulfillment-item-units → item-fulfillment-items → item-fulfillments.
+- **⚠ Bridge-vs-trackingNumber uuid footgun (see gotcha).** To fully delete without
+  orphaning the tracking bridge row, the **tracking-number BRIDGE uuid**
+  (`editShipment.itemFulfillmentTrackingNumbers[0].uuid`, i.e. the
+  `ItemFulfillments_TrackingNumbers` record) must be passed as the
+  `itemFulfillmentPackageUuid` arg — this is **distinct** from the trackingNumber uuid
+  (`...[0].trackingNumber.uuid`). The edit form's `EditShipmentContext`
+  (`UpdateShipmentApi.ts`) was extended with `itemFulfillmentTrackingNumberUuid`, and
+  rehydrate now captures it alongside `itemFulfillmentUuid` / `trackingNumberUuid` /
+  `shipToAddressUuid` / `returnAddressUuid`.
+- **Decision:** a confirmation dialog was added even though the Pending-card trash deletes
+  **without** one, because this is a large, explicit, destructive button.
+
 ## Update Info / Edit Shipment form (config-driven; Figma-alignment pass 2026-07)
 
 The New Shipment / Edit Shipment form is **config-driven**: fields come from
@@ -303,6 +329,24 @@ the call 403s and returns no label.
   rehydrate `signatureType` in `EditShipmentForm.tsx` to the option object `{uuid, name}` derived from
   `trackingNumber.requiresSignature` (`true`→`{uuid:"Required",name:"Required"}`, `false`→Not Required,
   `null`→None Specified). Reusable checklist for any NEW select field in these forms.
+- **⚠ react-select `unstyled` still renders its DEFAULT DropdownIndicator glyph — you can't fix a
+  glyph mismatch with `classNames` alone.** Native `<select>` elements in these forms (the modal's
+  Addressee warehouse selector, the in./cm unit selector) render an FA `chevronDown`, but
+  `BaseInput`'s react-select renders react-select's own default caret SVG — a different shape/weight
+  (Figma's "dropdown - single select" uses `chevron-down` everywhere, so the react-select caret is
+  the outlier). `classNames.dropdownIndicator` only recolors/resizes the existing SVG; to change the
+  **glyph** you must override `components.DropdownIndicator`. Fix (2026-07-15): added a
+  `CompactDropdownIndicator` (FA `chevronDown`, `text-xs text-supply-blue-400`) to `BaseInput` and
+  wired it into both react-select `components={{}}` blocks **only when `compact` is true**
+  (`...(compact ? { DropdownIndicator: CompactDropdownIndicator } : {})`) — scoped to compact to
+  limit blast radius to the shipment forms/modal and leave non-compact selects on the default caret.
+- **⚠ Bridge uuid vs trackingNumber uuid on delete — two different records.** `deleteShipments`'s
+  second arg `itemFulfillmentPackageUuid` is the **bridge** record uuid
+  (`itemFulfillmentTrackingNumbers[0].uuid` = the `ItemFulfillments_TrackingNumbers` join row), NOT
+  the tracking number's own uuid (`itemFulfillmentTrackingNumbers[0].trackingNumber.uuid`). Passing
+  the trackingNumber uuid there leaves the bridge join row orphaned. On the tracking-number-bridge
+  model these are always two distinct uuids — read the shape carefully before wiring any
+  create/update/delete against the bridge.
 - **The `/shipments` list is PER-SALES-ORDER (open product decision, Eric to decide).**
   `getShipments` filters by `SalesOrders.c_netsuiteInternalSalesOrderId = <internalId>`, so
   `/shipments` with no `internalId` shows the empty state — the tool is a per-SO **punch-out**
@@ -373,6 +417,20 @@ not the base `_Model_Client_ItemFulfillment`. Tested with GroWrk; UPS support wa
 for Compass and is not yet in prod.
 
 ## Change history
+- 2026-07-15 — TRUE-79191: unified the **dropdown chevron glyph** across the compact selects — added a
+  `CompactDropdownIndicator` (FA `chevronDown`) to `BaseInput` and wired it into both react-select
+  `components` blocks **only when `compact` is true**, so the react-select caret matches the native
+  `<select>` chevrons per Figma. Documented the reusable gotcha: react-select `unstyled` still renders
+  its default DropdownIndicator, so a glyph mismatch needs a `components.DropdownIndicator` override,
+  not `classNames`. (Footer button-row spacing `mt-12`→`mt-5` and the "Edit Return Label" modal header
+  divider were cosmetic Figma polish — no doc change.) (mhammontree)
+- 2026-07-15 — TRUE-79191: added a **"Delete Shipment"** button to the Edit Shipment form (edit-mode
+  only, footer bottom-left) — `SupplyFormGuardrail` confirm → "Deleting shipment..." screen → returns
+  to Select Items. Reuses the Pending-card cascade delete `deleteShipments` (`ShipmentsApi.ts`).
+  Documented the **bridge-vs-trackingNumber uuid** footgun: the bridge uuid
+  (`itemFulfillmentTrackingNumbers[0].uuid`, the `ItemFulfillments_TrackingNumbers` join row) must be
+  passed as `itemFulfillmentPackageUuid` or the bridge row orphans; `EditShipmentContext` gained
+  `itemFulfillmentTrackingNumberUuid` and rehydrate now captures it. (mhammontree)
 - 2026-07-15 — TRUE-79191 (Figma-alignment polish pass): documented two durable items on the
   config-driven form — (1) **Tailwind does not scan `viewModel/FIELDS/*.json`**, so a JSON-only utility
   class is silently inert (`!w-fit` footgun; surgical `safelist` fix, recommended clean fix = add the

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "toga-ai",
-  "version": "1.0.345",
+  "version": "1.0.347",
   "description": "TOGA Technology Team Claude Knowledge System — shared AI coding harness with skills, knowledge base CLI, and project installer for Claude Code.",
   "keywords": [
     "claude",