toga-ai 1.0.339 → 1.0.340

package/knowledge/2.0/apps/toga2-commerce/features/client-fields.md

@@ -6,7 +6,7 @@ project: TOGa Commerce
 client: shared
 type: feature
 status: active
-updated: 2026-07-14
+updated: 2026-07-15
 owners: ["apeterson", "tcox"]
 files:
   - src/fieldsConfig/index.ts
@@ -48,7 +48,8 @@ resolved per tenant, per language, and per role**. There are **two layers**:
 {
   "languageSwitcher": { "uuid": "1", "isEnabled": true|false },
   "userApiFields": ["firstName", "lastName", "email", "uuid", "_isAdmin", ...],
-  "fetchUsersApiFields": ["firstName", "lastName", "email", "uuid", ...]
+  "fetchUsersApiFields": ["firstName", "lastName", "email", "uuid", ...],
+  "fetchUserApiFields": ["firstName", "lastName", "email", "uuid", "supervisorUser.uuid", ...]
 }
 ```
 
@@ -65,12 +66,18 @@ resolved per tenant, per language, and per role**. There are **two layers**:
   (`fetchUsers()` in `src/pages/Cart/api/CartApi.ts`, driven from `NavIconList.tsx`). Distinct from
   `userApiFields` (which is the login fetch). COMPASS/COMPASSCANADA use the 14-field default list;
   **QUAD uses an 8-field list that intentionally omits `supervisorUser.*`** (see gotcha).
+- `fetchUserApiFields` — the allow-list of user columns fetched by the **singular detail fetch**
+  (`fetchUser()` in `src/pages/Cart/api/CartApi.ts`, driven from `NavIconList.tsx` and
+  `fetchUserByContactUuid()`). COMPASS/COMPASSCANADA use the 19-field default list;
+  **QUAD uses a 13-field list that — unlike the plural `fetchUsersApiFields` — *does* include
+  `supervisorUser.*`** (reporting-chain data comes from the detail fetch, not the search list;
+  see gotcha).
 
 Resolved by **`src/fieldsConfig/getClientLoginFields.ts`** — a `switch(client)` returning the JSON;
 **default is `COMPASS`** (not DEFAULT). Called from `AuthContext` as `getClientLoginFields(host)`.
 The `languageSwitcher.isEnabled` value feeds the login-settings branch in `getLoginSettings.ts`.
 
-### `fetchUsersApiFields` and the config-driven view-as search (C6)
+### `fetchUsersApiFields` / `fetchUserApiFields` and the config-driven Cart fetches (C6)
 
 `fetchUsers()` in `src/pages/Cart/api/CartApi.ts` no longer hardcodes its field list. It resolves it
 via `getClientLoginFields(fieldKey ?? "").fetchUsersApiFields`, replacing a former
@@ -82,9 +89,25 @@ tenant JSONs are **statically imported**, a tenant missing `fetchUsersApiFields`
 compile error — not a silent empty fetch — so the list is client-editable via config without
 touching Cart code.
 
-**Follow-up candidate (not yet done):** `fetchUser()` (singular, same `CartApi.ts`) still holds the
-same hardcoded QUAD-vs-default field-list pattern and is a candidate for the identical config
-treatment in a future ticket.
+**Singular `fetchUser()` — same treatment (TRUE-80016).** `fetchUser()` (the detail fetch, same
+`CartApi.ts`) now hoists its default field list from config too:
+
+```ts
+const fields = singleUserFields ?? getClientLoginFields(fieldKey).fetchUserApiFields;
+```
+
+The former hardcoded default lists moved byte-for-byte into `fetchUserApiFields` in each tenant JSON
+(COMPASS/COMPASSCANADA = the old 19-field default; QUAD = the old 13-field list). Precedence is
+preserved: a caller-supplied **`singleUserFields`** override (Layer B `fields?.getSingleUserFields?.fields`,
+passed by `useEditOrderViewModel.ts` and `useEditCartViewModel.ts`) still wins; `NavIconList.tsx` and
+`fetchUserByContactUuid()` take the config defaults.
+
+Unlike `fetchUsers`, the `fieldKey === "QUAD"` vs default **branch was retained** — it encodes
+genuine behavior differences beyond the field list: the default branch uses `depth: 5` and enriches
+the result with `fetchCostCenter()` (cost-center name); the QUAD branch does neither. Only the field
+*lists* were externalized to config; the structural difference stays in code. Naming convention now
+established: **`fetch<X>ApiFields` in `clientFields/<TENANT>.json` mirrors the CartApi function name**
+(`fetchUsers` → `fetchUsersApiFields`, `fetchUser` → `fetchUserApiFields`).
 
 ### `userApiFields` and the SAML post-auth fetch (`useAuthenticationFlow`)
 
@@ -232,6 +255,11 @@ Common field attributes: `uuid`, `label`, `valueKey` (path into the data object)
   `fetchUser()` after selection. QUAD also uses the `_isGlobalAdmin`/`_isBuyer`/`_isItShopper` role
   model, not the supervisor hierarchy. Aligning the two lists would smuggle a behavior change into a
   refactor.
+- **The two QUAD lists intentionally differ on `supervisorUser.*`.** QUAD's `fetchUserApiFields`
+  (singular detail fetch) **includes** `supervisorUser.*`, while its `fetchUsersApiFields` (plural
+  search list) **omits** them. This is the same fact from both directions: reporting-chain data is
+  loaded on the detail fetch, not the search list — so the asymmetry is correct, not a copy-paste
+  slip. Do not "reconcile" the two lists.
 
 ## Change history
 - 2026-06-23 — Initial: documented the two-layer field system (global `clientFields/<TENANT>.json`
@@ -249,4 +277,13 @@ Common field attributes: `uuid`, `label`, `valueKey` (path into the data object)
   TRUE-80015 `fetchUsers` refactor). All user-field lists now flow through config;
   COMPASSCANADA now resolves its own JSON rather than the generic `else`. Behavior-identical, `tsc`
   clean. (tcox)
+- 2026-07-15 — Completed the `fetchUser()` follow-up (TRUE-80016): added a `fetchUserApiFields` key
+  to each tenant JSON (COMPASS/COMPASSCANADA = former 19-field default, QUAD = former 13-field list,
+  byte-for-byte) and made the singular detail fetch hoist `singleUserFields ??
+  getClientLoginFields(fieldKey).fetchUserApiFields`. Caller override precedence preserved; the
+  `fieldKey === "QUAD"` branch retained (it also gates `depth: 5` + `fetchCostCenter()` enrichment,
+  not just fields). Established the `fetch<X>ApiFields` ↔ CartApi-function naming convention. Intended
+  refactor-only, no behavior change — not yet verified with `tsc`. Landed standalone on branch
+  TRUE-80016 (not stacked on the unmerged TRUE-80015); whichever PR merges second takes minor "keep
+  both" conflicts on the shared import line and adjacent JSON keys. (tcox)
 </content>

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "toga-ai",
-  "version": "1.0.339",
+  "version": "1.0.340",
   "description": "TOGA Technology Team Claude Knowledge System — shared AI coding harness with skills, knowledge base CLI, and project installer for Claude Code.",
   "keywords": [
     "claude",