toga-ai 1.0.335 → 1.0.336

package/knowledge/2.0/apps/toga2-supply/INDEX.md

@@ -3,5 +3,5 @@
 | Doc | Summary | Files |
 |-----|---------|-------|
 | [TOGa Supply (toga2-supply) Architecture](architecture.md) | `toga2-supply` is the **React + Vite frontend** for TOGa Supply — warehouse fulfillment tooling (shipment selection, fulfill & ship against carrier APIs, NetSui | toga2-supply/src/api/toga.ts, toga2-supply/src/pages/ShipmentItems/view/ShipmentItemsPage.tsx, toga2-supply/src/pages/EditShipment/view/EditShipmentPage.tsx, toga2-supply/src/pages/EditShipment/api/UpdateShipmentApi.ts, toga2-supply/src/pages/Shipments/view/components/ShipmentsCardTableForm/ShipmentsCardTableForm.tsx |
-| [Fulfill & Ship](features/fulfill-and-ship.md) | Fulfill & Ship lets a warehouse user select sales-order line items, enter serials, pick a carrier/method, and in one action: create the Item Fulfillment records | toga2-supply/src/pages/ShipmentItems/view/ShipmentItemsPage.tsx, toga2-supply/src/pages/EditShipment/view/EditShipmentPage.tsx, toga2-supply/src/pages/EditShipment/view/components/forms/EditShipmentForm.tsx, toga2-supply/src/pages/EditShipment/view/components/SelectedShipmentItemsTable.tsx, toga2-supply/src/pages/EditShipment/view/modals/ReturnShippingModal.tsx, toga2-supply/src/pages/EditShipment/api/UpdateShipmentApi.ts, toga2-supply/src/pages/EditShipment/types.ts, toga2-supply/src/pages/Shipments/view/ShipmentsPage.tsx, toga2-supply/src/pages/Shipments/view/components/ShipmentsCardTableForm/ShipmentsCardTableForm.tsx, toga2-supply/src/pages/Shipments/api/ShipmentsApi.ts, toga2-supply/src/pages/Shipments/types.ts, toga2-supply/src/pages/FulfilledShipments/view/FulfilledShipmentsPage.tsx, toga2-supply/src/components/ui/CardTable/CardTable.tsx, toga2-supply/src/components/ui/CardTable/types.ts, toga2-supply/src/assets/pen-line.svg, _underscore/Model/Client/ItemFulfillment.php, _underscore/Trait/Netsuite/ItemFulfillment.php, _underscore/Component/Library/Carriers/Ups/Ups.php |
+| [Fulfill & Ship](features/fulfill-and-ship.md) | Fulfill & Ship lets a warehouse user select sales-order line items, enter serials, pick a carrier/method, and in one action: create the Item Fulfillment records | toga2-supply/src/pages/ShipmentItems/view/ShipmentItemsPage.tsx, toga2-supply/src/pages/EditShipment/view/EditShipmentPage.tsx, toga2-supply/src/pages/EditShipment/view/components/forms/EditShipmentForm.tsx, toga2-supply/src/pages/EditShipment/view/components/SelectedShipmentItemsTable.tsx, toga2-supply/src/pages/EditShipment/view/helpers/ShipmentDetailsForm/renderEditShipmentFormInput.tsx, toga2-supply/src/pages/EditShipment/viewModel/FIELDS/DUMMYUPDATESHIPMENTFIELDS.json, toga2-supply/src/pages/EditShipment/view/modals/ReturnShippingModal.tsx, toga2-supply/src/components/ui/BaseInput/BaseInput.tsx, toga2-supply/src/pages/EditShipment/api/UpdateShipmentApi.ts, toga2-supply/src/pages/EditShipment/types.ts, toga2-supply/src/pages/Shipments/view/ShipmentsPage.tsx, toga2-supply/src/pages/Shipments/view/components/ShipmentsCardTableForm/ShipmentsCardTableForm.tsx, toga2-supply/src/pages/Shipments/api/ShipmentsApi.ts, toga2-supply/src/pages/Shipments/types.ts, toga2-supply/src/pages/FulfilledShipments/view/FulfilledShipmentsPage.tsx, toga2-supply/src/components/ui/CardTable/CardTable.tsx, toga2-supply/src/components/ui/CardTable/types.ts, toga2-supply/src/assets/pen-line.svg, _underscore/Model/Client/ItemFulfillment.php, _underscore/Trait/Netsuite/ItemFulfillment.php, _underscore/Component/Library/Carriers/Ups/Ups.php |
 | [AWS Amplify Build & Deploy (non-prod environments)](workflows/amplify-build-and-deploy.md) | How `toga2-supply` (React + Vite) builds and deploys on **AWS Amplify**. | toga2-supply/amplify.yml, toga2-supply/.gitattributes, toga2-supply/.github/workflows/sync-stage-environments.yml, toga2-supply/.env.qc-security |

package/knowledge/2.0/apps/toga2-supply/features/fulfill-and-ship.md

@@ -13,7 +13,10 @@ files:
   - toga2-supply/src/pages/EditShipment/view/EditShipmentPage.tsx
   - toga2-supply/src/pages/EditShipment/view/components/forms/EditShipmentForm.tsx
   - toga2-supply/src/pages/EditShipment/view/components/SelectedShipmentItemsTable.tsx
+  - toga2-supply/src/pages/EditShipment/view/helpers/ShipmentDetailsForm/renderEditShipmentFormInput.tsx
+  - toga2-supply/src/pages/EditShipment/viewModel/FIELDS/DUMMYUPDATESHIPMENTFIELDS.json
   - toga2-supply/src/pages/EditShipment/view/modals/ReturnShippingModal.tsx
+  - toga2-supply/src/components/ui/BaseInput/BaseInput.tsx
   - toga2-supply/src/pages/EditShipment/api/UpdateShipmentApi.ts
   - toga2-supply/src/pages/EditShipment/types.ts
   - toga2-supply/src/pages/Shipments/view/ShipmentsPage.tsx
@@ -87,6 +90,75 @@ from the saved fulfillment; **Save UPDATES the existing records** instead of POS
 - `CardTable` was made reusable for this: optional `editIcon` + `isEditButtonDisabled` props
   (defaults preserve prior behavior; the shipments card is the only consumer today).
 
+## Update Info / Edit Shipment form (config-driven; Figma-alignment pass 2026-07)
+
+The New Shipment / Edit Shipment form is **config-driven**: fields come from
+`viewModel/FIELDS/DUMMYUPDATESHIPMENTFIELDS.json`, are rendered by
+`view/helpers/ShipmentDetailsForm/renderEditShipmentFormInput.tsx` through the shared
+`EditShipmentForm.tsx`, and the individual inputs are `components/ui/BaseInput/BaseInput.tsx`
+(text/currency) plus react-select (State/Country). To change field layout, labels,
+required-ness, or ordering, edit the **config JSON**, not the component.
+
+- **Create vs Edit are distinct entry points (decision — kept, not merged).** Select Items →
+  Next = create a **New Shipment**; the pending-shipments pencil = **edit** an existing draft.
+  They are deliberately NOT merged and there is no auto-load from Select Items, because a Sales
+  Order can have **multiple** shipments (partial fulfillment — Select Items shows
+  Ordered/Fulfilled/Committed per line), so "the saved shipment" is not singular and auto-loading
+  would be ambiguous. Page title now signals the mode: create = **"New Shipment"**, edit =
+  **"Edit Shipment"** (create previously mis-titled "Update Info").
+- **Fulfillment Location is READ-ONLY (decision — Eric, Exec Dir Services Ops, authoritative).**
+  Sourced from the Sales Order's location and shown display-only; the value must **not** change
+  in the tool — any change happens back at the SO. Implemented as `getAddress` fetching
+  `location.name`, `EditShipmentPage` adding `fulfillmentLocation` to the transformed address, and
+  `renderEditShipmentFormInput` rendering it via `BaseDisabledInput` on an `isReadOnly` flag. **Not
+  persisted to `IF.locationId`** for now — persisting would be a separate backend "set from SO"
+  change plus a NetSuite-mapping check.
+- **Reference 1 / Reference 2 fields are placeholders (rendered, values NOT wired yet).**
+  Definitions are settled: **Reference 1 = NetSuite Sales Order #, Reference 2 = NetSuite Purchase
+  Order #** (Eric, authoritative — supersedes Skyler's earlier "Ref 1 = vendor account #, Ref 2 =
+  company name"). Value sourcing/persistence/carrier-wiring is intentionally deferred; when wiring,
+  verify: SO# = the document **ORDER #** (e.g. `281144`) vs the internal id (`7221433`, stored as
+  `c_netsuiteInternalSalesOrderId`); the PO# lives in NetSuite and may not be in the 2.0 DB (the
+  SO's `customerPurchaseOrder` field — already reused as the carrier `referenceString` — vs a
+  separate linked NetSuite PO document).
+- **Phone # is REQUIRED by design (verified, kept per Eric):** config `isRequired:true` +
+  `showRequiredIndicator`, enforced by `validateFormOnSubmit`.
+- **Address block layout (Figma):** inline **left** labels (Addressee / Attention / Address 1 /
+  Address 2 / City / State / ZIP / Country) — previously `sr-only`. Residential checkbox moved
+  **below** Country with the checkbox to the **right** of the label.
+- **Carrier section = two vertical stacks (Figma, was 3 horizontal columns):** col6 = Carrier /
+  Shipment Method / Carrier Account # / Declared Cost; col7 = Reference 1 / Reference 2 / Phone # /
+  Fulfillment Location. Row container is `justify-between` so the columns fill to the right edge.
+- **Verbiage (David):** "This shipment contains a battery" → "Contains a battery"; "This shipment
+  needs a return label" → "Needs a return label".
+- **Return-label affordance:** the "Edit" link is inline to the right of the "Needs a return label"
+  label, and the return-location text ("TOGA Technology") below it is also clickable — both open the
+  Edit Return Label modal.
+- **Input UX helpers (`BaseInput`):** per-field clear "X" on address text inputs (opt-in
+  `hasClearButton` flag, via `useFormContext` `setValue`/`watch`; State/Country already have
+  react-select's clear); a **"Clear All"** link in the address header (`ClearAllAddressButton`
+  resets every address field via `useFormContext`); Declared Cost formats to 2 decimals on blur
+  (`onBlur` when `field.isCurrency`). Return modal (`ReturnShippingModal.tsx`): compact selects
+  vertically centered; Carrier Account # widened to `w-[172px]` to match Carrier.
+
+## Planned direction — "Fulfill & Ship" from an existing Item Fulfillment (future, Eric)
+
+A **third entry mode** is planned (distinct from Select-Items-create and the pencil-edit): a
+"Fulfill & Ship" button on an **existing NetSuite Item Fulfillment** punches out to the tool,
+sources item/serial info from that existing fulfillment, uses the tool for the **shipping-label
+portion only**, then pushes label/tracking data back into the Item Fulfillment. Most plumbing
+already exists from TRUE-79191: `getShipmentForEdit`/rehydrate + read-only items (source from the
+existing IF), `fulfillShipment` + `generateReturnLabel` (label), `saveShipmentToNetsuite`
+(push-back). New pieces needed: the punch-out entry carrying an IF id, and a **label-only mode**
+(skip the create step). This is a separate feature/ticket — recorded as planned direction, not done.
+
+## Sources — meeting notes / decision origins
+
+Fulfill & Ship meeting transcripts and notes live in the **Internal Knowledgebase MCP connector**
+(AWS Bedrock KBs, slug `development-team`, client `general`/`toga-technology`), searchable via
+`kb_search` — e.g. "2026-05-20 - Fulfill and Ship Dev Sync", "2026-02-27 - Fulfill & Ship Process
+Review". Use it when a decision's origin needs tracing.
+
 ## Reprint (backend-combined, 2026-07)
 
 Fulfilled-shipments view (`FulfilledShipmentsPage` → `ShipmentsCardTableForm` with
@@ -180,6 +252,19 @@ the call 403s and returns no label.
   everywhere (and `overflow-y-auto` on the `max-h-[530px]` card list in `ShipmentsCardTableForm`),
   and the fulfilled-page outer → `h-full overflow-auto`.
 
+- **"Attention" wrote to the wrong field (fixed 2026-07).** The Attention input was bound to
+  `valueKey "addressee"` — the same key as the Address name — so both wrote to `addressee` and the
+  form showed the same value twice (e.g. "Eric" in both). Rebound Attention to `"attention"`. When a
+  config-driven field mirrors another field's value, suspect a duplicated `valueKey`.
+- **The `/shipments` list is PER-SALES-ORDER (open product decision, Eric to decide).**
+  `getShipments` filters by `SalesOrders.c_netsuiteInternalSalesOrderId = <internalId>`, so
+  `/shipments` with no `internalId` shows the empty state — the tool is a per-SO **punch-out**
+  (entered from a NetSuite SO). The hamburger "Shipments" nav link (no SO context) is therefore
+  misleading. Options pending Eric's model decision (nothing changed yet): (A) keep per-SO and
+  remove/relabel the nav link; (B) add a global "All Pending Shipments" view — drop the SO filter
+  (client scoping is automatic from the JWT), but each row must then carry its own SO `internalId`
+  for the edit/fulfill links.
+
 ## Remaining work
 
 - ~~Reprint rewire~~ — done (backend `reprintLabelsApi` combine; see Reprint section).
@@ -194,7 +279,19 @@ the call 403s and returns no label.
   unit add/remove diffing against the API (the edit route already carries the fulfillment uuid);
   (b) the return modal's weight/dims/carrier fields are an **edit-trap** — see the gotcha below.
 - UPS 35-char hardening, location-scoped inventory lookup, carrier/method on the NS IF,
-  responsiveness per Figma, FedEx + UPS end-to-end verification before prod.
+  FedEx + UPS end-to-end verification before prod.
+- **Responsiveness (phase 2/3 — explicitly NOT in original scope per the 2026-02-27 Process Review
+  and 2026-05-20 Dev Sync).** David Mancol's Figma annotation **is** the spec: reduce the in-box
+  column count by 1 on narrower screens; flexible gaps that scale with screen size (min 2px, max
+  50px); may explore stacking. Owners: David Mancol (design) + Alexandra Peterson (phase 2/3). Not
+  yet implemented.
+- **Reference 1/2 value wiring** — fields render but values aren't sourced/persisted; see the form
+  section (SO# vs internal id, PO# in NetSuite) before wiring.
+- **Global-vs-per-SO Shipments list** — pending Eric's model decision; see the gotcha above.
+- **"Fulfill & Ship from an existing Item Fulfillment"** third entry mode — see Planned direction.
+
+This is the **first testable iteration** of the Figma-aligned form; a change-request list is
+expected once QA/users start.
 
 ## Deploy / provisioning requirements (per environment)
 
@@ -228,6 +325,18 @@ not the base `_Model_Client_ItemFulfillment`. Tested with GroWrk; UPS support wa
 for Compass and is not yet in prod.
 
 ## Change history
+- 2026-07-14 — TRUE-79191 (Figma-alignment pass on the config-driven New/Edit Shipment form):
+  fixed the **Attention** field writing to `addressee` (rebound to `attention`); Figma layout
+  (inline left address labels, residential checkbox below Country, carrier section as two vertical
+  stacks with `justify-between`, David's verbiage trims); create-vs-edit titles clarified
+  ("New Shipment" vs "Edit Shipment"); added **Fulfillment Location** (read-only, sourced from the
+  SO — Eric); added **Reference 1/2** placeholder inputs (Ref1 = NetSuite SO#, Ref2 = NetSuite PO#,
+  values not wired yet — Eric); `BaseInput` per-field clear + "Clear All", Declared Cost 2-decimal
+  blur formatting; return-label "Edit" link inline + return-location text clickable. Recorded
+  decisions: create/edit entry points kept distinct (SO can have multiple shipments), Phone #
+  required, the `/shipments` list is per-SO (nav-link/global-view open item — Eric), the planned
+  **third entry mode** (Fulfill & Ship from an existing IF, label-only), David's responsiveness spec
+  (phase 2/3), and where the meeting transcripts live (`kb_search`). (mhammontree)
 - 2026-07-14 — TRUE-79191: added **edit-a-saved-pending-shipment-in-place** (pencil on `dtSubmitted==null` rows → `/edit-shipment`, `getShipmentForEdit`/`updateShipment` PUT existing records; item lines/serials read-only in v1; `CardTable` made reusable with `editIcon`/`isEditButtonDisabled`). Completed the Increment-3 **return-label** frontend (combined outbound+return PDF, return page captioned "Return Label" via a position-aligned `captions` CSV to `reprintLabelsApi`). Fixed the Declared Cost "$ -" column (field was never requested/mapped). Documented the return-modal edit-trap (only the return ADDRESS persists — weight/carrier/dims reuse outbound) and the per-env deploy/provisioning checklist + the "testing in prod = full prod release (real labels/NS IF)" decision. (mhammontree)
 - 2026-07-02 — Reprint rewired to the backend: `ShipmentsApi.ts` now calls `GET /v2/tracking-numbers/reprint` (`reprintLabelsApi`) for a combined base64 PDF built from the stored PNGs; removed the stale client-side `pdf-lib` merge. Return-label backend generation landed (`generateReturnLabel`, `returnTrackingNumberId` on the bridge). Ship-to address source resolved to `COALESCE(IF, SO)`. (mhammontree)
 - 2026-06-18 — PNG label-storage rework reflected on the frontend: labels now store as PNG and the PDF is built on the backend (`LabelPdf`), so the client-side `pdf-lib` reprint is stale and must be rewired to a backend generate endpoint. Fixed the Fulfilled Shipments responsiveness/clip bug (Reprint button unreachable at 100% zoom) — `overflow-scroll` → `overflow-auto` and gave `FulfilledShipmentsPage`'s outer its own scroll; documented the `/shipments` vs `/fulfilled-shipments` two-component trap and the `AuthLayout overflow-hidden` clip. (mhammontree)

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "toga-ai",
-  "version": "1.0.335",
+  "version": "1.0.336",
   "description": "TOGA Technology Team Claude Knowledge System — shared AI coding harness with skills, knowledge base CLI, and project installer for Claude Code.",
   "keywords": [
     "claude",