toga-ai 1.0.328 → 1.0.330

package/knowledge/1.0/apps/worker/INDEX.md

@@ -5,7 +5,7 @@
 | [Worker (1.0 Framework) Architecture](architecture.md) | `worker` is the legacy (**1.0** `App_` framework) **background-job tier**. | worker/index.php, worker/_/app/framework.php, worker/crons/, worker/schedules/, worker/ebs/cron.worker.php, worker/.ebextensions/035_cron.worker.config |
 | [Compass MA Sales Order Exception Report](features/compass-ma-sales-order-exception-report.md) | A worker cron that emails operations the "Compass Refresh Exception Report" — Compass `MA%` sales orders whose corresponding Office Depot (ODP) sales order has | worker/crons/toga2/compass/workflow/7_generate_ma_sales_order_exception_report.php |
 | [Compass Partial In-Transit & Delivered Emails (per package)](features/compass-partial-in-transit-delivered-emails.md) | Compass USA and Compass Canada send a **per-package** in-transit email (and a matching delivered email) instead of one email listing the whole order. | worker/crons/toga2/compass/update_salesorder_status_from_odp.php, worker/crons/toga2/compasscanada/workflow/3_update_salesorder_status_from_grand_and_toy.php |
-| [Forecast2 ↔ NetSuite Reconciliation & Trueup Tooling](features/forecast2-netsuite-reconciliation.md) | CLI tools to **audit** and **repair** drift between the production `Forecast` DB (core2) and NetSuite. | test/@dave/checker.php, _underscore/Component/Forecast/SaleImport/SaleImport.php, test/@dave/looper.php, test/@dave/reconcile_netsuite_totals.php, test/@dave/fixer.php, test/@dave/analyze_netsuite_forecast_diff.php, test/@dave/trueup_sales.php, test/@dave/trueup_open_orders.php, test/@dave/loop_trueup_open_orders.php, test/@dave/trueup_opportunities.php, test/@dave/probe_sales_gap_direct.php, test/@dave/probe_missing_oo_timing.php, test/@dave/probe_missing_oo_createdby.php, test/@dave/probe_drift_so_dates.php, test/@dave/probe_profit_invoices.php, test/@dave/probe_profit_gap.php, worker/crons/toga2/forecast2/common_import_sales_from_netsuite.php, worker/crons/toga2/forecast2/periodic_forecast_discrepancy_fix_open_orders.php, worker/crons/toga2/forecast2/import_open_orders.php, worker/schedules/cron.worker.infrastructure.json |
+| [Forecast2 ↔ NetSuite Reconciliation & Trueup Tooling](features/forecast2-netsuite-reconciliation.md) | CLI tools to **audit** and **repair** drift between the production `Forecast` DB (core2) and NetSuite. | test/@dave/checker.php, worker2/Component/Forecast/SaleImport/SaleImport.php, test/@dave/looper.php, test/@dave/reconcile_netsuite_totals.php, test/@dave/fixer.php, test/@dave/analyze_netsuite_forecast_diff.php, test/@dave/trueup_sales.php, test/@dave/trueup_open_orders.php, test/@dave/loop_trueup_open_orders.php, test/@dave/trueup_opportunities.php, test/@dave/probe_sales_gap_direct.php, test/@dave/probe_missing_oo_timing.php, test/@dave/probe_missing_oo_createdby.php, test/@dave/probe_drift_so_dates.php, test/@dave/probe_profit_invoices.php, test/@dave/probe_profit_gap.php, worker/crons/toga2/forecast2/common_import_sales_from_netsuite.php, worker/crons/toga2/forecast2/periodic_forecast_discrepancy_fix_open_orders.php, worker/crons/toga2/forecast2/import_open_orders.php, worker/schedules/cron.worker.infrastructure.json |
 | [NetSuite → TOGa Supply Per-Client Sync (thin wrappers)](features/netsuite-togasupply-per-client-sync.md) | Syncs NetSuite transactions (sales orders, purchase orders, invoices, item receipts, item fulfillments, inventory adjustments) into each TOGa Supply (2.0) clien | worker/crons/toga2/netsuite/common_sync_togasupply.php, worker/crons/toga2/netsuite/sync_togasupply_canon.php, worker/schedules/cron.worker.sync.json, dbchanges2/_modules/netsuite/2026-04-01 - Parameters.sql, library/app/api/netsuite/rest.php, library/app/systemmonitor/netsuiteintegration.php |
 | [OneUptime external uptime monitoring for 1.0 workers](features/oneuptime-worker-uptime-monitoring.md) | Every 1.0 worker box self-reports its liveness to an external OneUptime monitor once per minute by curl-POSTing to a per-worker "Incoming Request" heartbeat URL | library/app/worker.php, worker/crons/worker/worker_heartbeat.php |
 | [Prudential: Send Shipments for the Day report (daily cron)](features/send-shipments-for-the-day.md) | Daily cron (9:00 PM) that emails Prudential and Dell stakeholders an Excel report of all devices shipped that day, including tracking number, serial number, emp | worker/crons/notifications/reports/send_shipments_for_the_day.php |

package/knowledge/1.0/apps/worker/features/forecast2-netsuite-reconciliation.md

@@ -6,11 +6,11 @@ project: Worker
 client: shared
 type: feature
 status: active
-updated: 2026-06-30
+updated: 2026-07-14
 owners: [dfranks]
 files:
   - test/@dave/checker.php
-  - _underscore/Component/Forecast/SaleImport/SaleImport.php
+  - worker2/Component/Forecast/SaleImport/SaleImport.php
   - test/@dave/looper.php
   - test/@dave/reconcile_netsuite_totals.php
   - test/@dave/fixer.php
@@ -223,8 +223,8 @@ by reconciling a chosen tranDate range directly against NetSuite.
   `41100/41300/41500`, cost `51100/51200` (exact-number, never prefix — see the sale-import doc for the
   sub-account traps). `revenue = Σ(−foreignamount)` over revenue-acct lines; `profit = Σ(−foreignamount)`
   over **all** allowlisted lines (cost lines net profit down via debit-positive `foreignamount`). Group by
-  **(local salesRep, item)** → one Sales row per group; synthetic `lineNumber` from
-  `ksort(json_encode([salesRepId,itemId]))` then `1..N` — **fixer MUST key identically** or its upsert
+  **(local salesRep, item, customer)** → one Sales row per group; synthetic `lineNumber` from
+  `ksort(json_encode([salesRepId,itemId,customerId]))` then `1..N` — **fixer MUST key identically** or its upsert
   dupes against the webhook importer's rows. JE `foreignamount`s are **cent-precision**, so a per-JE
   sum-then-round equals the importer's per-salesRep round-then-sum **exactly** — this is what keeps
   checker's "in sync" == fixer's "nothing to fix" for JEs (the compute-identically invariant applied to JEs).
@@ -249,6 +249,35 @@ by reconciling a chosen tranDate range directly against NetSuite.
   correctly re-derives "no raw rep" from NetSuite. One-time cleanup =
   `fixer.php --commit --prod --category sales` over the JE window, then `checker.php` to confirm
   (in current prod this was a no-op — 0 no-rep JE rows — so the importer filter is preventative).
+- **`fixer.php` now resolves `customerId` on JE lines, mirroring the importer (TRUE-80129,
+  dfranks 2026-07-14).** Both `fixJournalEntries()` (the hand-maintained MIRROR of
+  `buildJournalEntryRows` — same account allowlist, same group key, same `ksort` ordering,
+  which must stay in lockstep or its upsert dupes against the webhook importer's rows) used to
+  hard-code `customerId = NULL` in its UPDATE and INSERT. The fix:
+  - Added a `Customers` lookup (reusing the exact pattern `fixOpportunities()` already uses in
+    the same file).
+  - Added **`tl.entity AS customer`** to the bulk-line SuiteQL SELECT. `tl.entity` is a
+    **NATIVE** column, so it needs **no** `> 0` / `IS NOT NULL` perf-trap workaround (unlike the
+    `custcol_*` salesRep/item columns — see the custom-column planner gotcha below); the comment
+    in-file notes native columns carry no such predicate risk.
+  - Extended the group key to `(salesRep, item, customer)` (`json_encode([$salesRepId, $itemId,
+    $customerId])`) to key **identically** to the importer.
+  - Added `customerId` to the **read-back SELECT + change-detection compare** (a deliberate guard
+    against the known "new column dropped from change-detection" footgun class), plus the UPDATE
+    and INSERT.
+  - New constant `JE_CUSTOMER_LINE_FIELD = 'entity'`. Non-Customer entities (vendor/employee
+    refs) resolve to null naturally — NetSuite internal ids are one global sequence across entity
+    subtypes, so a non-customer id simply misses `Customers`.
+- **Backfilling `customerId` onto existing JE rows is a MANUAL, all-time developer step — not
+  part of the code PR (TRUE-80129 decision).** Because the checker (`journalEntryNsTotals()`)
+  only detects **revenue/profit** drift per JE, a JE row with a correct total but a missing
+  `customerId` is **not** flagged discrepant, so a normal checker/fixer pass will never
+  repopulate it — shipping the code fix alone does **not** backfill history. The chosen backfill
+  (run once, manually, by the developer after deploy): **DELETE all**
+  `netsuiteTransactionType='journalEntry'` rows from `Sales` (**no date-window restriction**),
+  then run **`fixer.php --commit --prod --category sales`** over full JE history so
+  `fixJournalEntries()` takes the INSERT branch for every group and repopulates every JE row
+  including `customerId`. Explicitly **out of scope for the code PR**.
 - **JE item dimension is NULL today; here is how to enable it later.** `itemId` is null on JE Sales rows
   because the JE import path reads item **only** via the configurable `JE_LINE_ITEM_FIELD` (currently null)
   — it does **not** read native `transactionline.item`, so even a populated native `tl.item` would NOT flow
@@ -256,7 +285,8 @@ by reconciling a chosen tranDate range directly against NetSuite.
   `custcol_*` if a custom column is added) — `journalLineLookup` then resolves it via
   `lookupId('Items','netsuiteItemInternalId',…)` and the group key already carries the item slot; AND (2)
   update **`fixer.php`** to SELECT the item column in its JE SuiteQL, resolve NS item→local id (reuse
-  `createMissingForecastItemFromNetSuite` self-heal), and extend the group key to `(salesRep, item)`.
+  `createMissingForecastItemFromNetSuite` self-heal), and keep the group key `(salesRep, item, customer)`
+  (customer was added under TRUE-80129; the item slot is already present).
   **`checker.php` needs no change.** Consider whether item should self-heal (salesRep does **not** — see
   the sale-import doc). The salesRep dimension itself is the JE line custom column `custcol_sales_rep_line`
   (wired under TRUE-79862).
@@ -519,6 +549,20 @@ None — Forecast2 is a single shared dataset.
 
 ## Change history
 
+- 2026-07-14 — **`fixer.php` now resolves `customerId` on JE lines, mirroring the importer +
+  recorded the manual all-time backfill** (TRUE-80129, dfranks). `fixJournalEntries()` (the
+  hand-maintained mirror of `buildJournalEntryRows`) previously hard-coded `customerId = NULL`;
+  it now adds a `Customers` lookup (same pattern as `fixOpportunities()`), selects
+  **`tl.entity AS customer`** (a **native** column → no `> 0`/`IS NOT NULL` perf-trap workaround
+  needed), extends the group key to `(salesRep, item, customer)` — keying identically to the
+  importer or its upsert dupes — and adds `customerId` to the read-back SELECT + change-detection
+  compare (guarding the "column dropped from change-detection" footgun) + UPDATE + INSERT. New
+  const `JE_CUSTOMER_LINE_FIELD = 'entity'`. Also documented that the **backfill of existing JE
+  rows is a manual, all-time developer step** (DELETE all `journalEntry` Sales rows, then
+  `fixer.php --commit --prod --category sales` over full JE history) — the checker only flags
+  revenue/profit drift, so a missing-only `customerId` is never auto-detected. Corrected the
+  misattributed `files:` path: `_Component_Forecast_SaleImport` lives in **worker2**, not
+  `_underscore`. (dfranks)
 - 2026-07-07 — **Recorded that these reconcilers are the only backstop for NetSuite sublist
   line-field inline edits + added `Logs.Webhook` forensics** (SALES profit-drift forensics; invoice
   6715127, 2026-02-20, $3,392.70). A line-level inline edit (e.g. `TRANLINE.MCOSTESTIMATE`) fires no

package/knowledge/2.0/apps/_underscore/INDEX.md

@@ -14,7 +14,7 @@
 | [Client Email Template Sending](features/email-template-sending.md) | `_Model_Client_EmailTemplate` sends a stored, client-defined email template by UUID. | _underscore/Model/Client/EmailTemplate.php, _underscore/Model/Client/EmailTemplateOutgoingEmailAddress.php, _underscore/Email.php |
 | [Error Reporting — Issue/Event Aggregation (agreed POST-to-receiver design)](features/error-reporting-issue-event.md) | Platform-wide error-reporting infrastructure for TOGA 2.0, built around a two-table **Issue / Event** aggregation model in the shared **Core Logs DB**. | _underscore/Error.php, _underscore/Model/Core/Logs/Issue.php, _underscore/Model/Core/Logs/Event.php, dbchanges2/Logs/2026-07-06 - Issue and Event tables.sql |
 | [Record-Changed Event Publishing (_Event::publish to SQS)](features/event-publish-sqs.md) | `_Event::publish()` (in `_underscore/Event.php`) is the PHP side of the real-time event pipeline. | _underscore/Event.php |
-| [Forecast.Sales NetSuite import engine (real-time webhook)](features/forecast-sale-import.md) | Real-time importer that takes a NetSuite **sale** record and writes its lines into `Forecast.Sales` (the Forecast2 revenue table). | _underscore/Component/Forecast/SaleImport/SaleImport.php, _underscore/Component/Forecast/Db/Db.php, _underscore/Component/Api/Netsuite/Netsuite.php, worker2/Worker/Netsuite/Invoice.php, worker2/Worker/Netsuite/CashSale.php, worker2/Worker/Netsuite/CreditMemo.php, worker2/Worker/Netsuite/CashRefund.php, worker2/Worker/Netsuite/JournalEntry.php, worker2/Worker/Netsuite/Opportunity.php, worker2/Worker/Netsuite/SalesOrder.php, dbchanges2/Forecast/2026-06-26a - Add journalEntry to Sales transaction type enum.sql, test/@dave/test_invoice_lifecycle.php, test/@dave/test_je_lifecycle.php, test/@dave/test_creditmemo_lifecycle.php, test/@dave/test_cashsale_lifecycle.php, test/@dave/test_cashrefund_lifecycle.php, test/@dave/test_fetchrecord_routes.php, test/@dave/verify_je_classification.php, test/@dave/probe_je_accounts.php, test/@dave/probe_je_shape.php, test/@dave/fixer.php, test/@dave/Junk Drawer/NetSuite/api-message-queue/ue_api_msg_queue_enqueue.js, test/@dave/Junk Drawer/NetSuite/api-message-queue/dev_ue_api_msg_queue_enqueue.js |
+| [Forecast.Sales NetSuite import engine (real-time webhook)](features/forecast-sale-import.md) | Real-time importer that takes a NetSuite **sale** record and writes its lines into `Forecast.Sales` (the Forecast2 revenue table). | worker2/Component/Forecast/SaleImport/SaleImport.php, worker2/Component/Forecast/Db/Db.php, _underscore/Component/Api/Netsuite/Netsuite.php, worker2/Worker/Netsuite/Invoice.php, worker2/Worker/Netsuite/CashSale.php, worker2/Worker/Netsuite/CreditMemo.php, worker2/Worker/Netsuite/CashRefund.php, worker2/Worker/Netsuite/JournalEntry.php, worker2/Worker/Netsuite/Opportunity.php, worker2/Worker/Netsuite/SalesOrder.php, dbchanges2/Forecast/2026-06-26a - Add journalEntry to Sales transaction type enum.sql, test/@dave/test_invoice_lifecycle.php, test/@dave/test_je_lifecycle.php, test/@dave/test_creditmemo_lifecycle.php, test/@dave/test_cashsale_lifecycle.php, test/@dave/test_cashrefund_lifecycle.php, test/@dave/test_fetchrecord_routes.php, test/@dave/verify_je_classification.php, test/@dave/probe_je_accounts.php, test/@dave/probe_je_shape.php, test/@dave/fixer.php, test/@dave/Junk Drawer/NetSuite/api-message-queue/ue_api_msg_queue_enqueue.js, test/@dave/Junk Drawer/NetSuite/api-message-queue/dev_ue_api_msg_queue_enqueue.js |
 | [Item-Fulfillment Stage Lifecycle (picked/packed/shipped) & Order Status](features/item-fulfillment-stage-lifecycle-and-order-status.md) | Every ItemFulfillment (IF) now carries an explicit **stage** — picked → packed → shipped — resolved through `ItemFulfillmentStages → ItemFulfillmentStatuses` (m | _underscore/Model/Client/SalesOrder.php, _underscore/Model/Quad/SalesOrder.php, _underscore/Model/Compass/SalesOrder.php, _underscore/Model/Compass/SalesOrderStatus.php, _underscore/Model/Client/SalesOrderItem.php, _underscore/Model/Client/Item.php, _underscore/Model/Client/PurchaseOrderItem.php, library/app/api/toga2.php, dbchanges2/Client/2026-06-30a - BackfillNullStageItemFulfillmentsToShipped.sql, dbchanges2/Client/2026-06-30b - SalesOrderStatusesPickedPacked.sql, dbchanges2/Client/2026-06-30c - ItemFulfillmentStageIdNotNull.sql, dbchanges2/Client_CompassCanada/2026-06-30a - ItemFulfillmentLifecycleAndShippedBackfill.sql |
 | [_Model magic-field access (__get without __isset)](features/model-magic-field-access.md) | `_Model` exposes DB columns as "magic" properties via `__get()`, but it defines **no** `__isset()`. | _underscore/Model/Core/Model.php |
 | [NetSuite REST Client (_Component_Api_Netsuite) — record writes & SuiteQL](features/netsuite-rest-client.md) | `_Component_Api_Netsuite` is the **2.0 `_underscore` NetSuite REST client** — the shared primitive every worker2/api2 NetSuite caller uses for record GETs, Suit | _underscore/Component/Api/Netsuite/Netsuite.php |

package/knowledge/2.0/apps/_underscore/features/forecast-sale-import.md

@@ -6,11 +6,11 @@ project: _Underscore
 client: shared
 type: feature
 status: active
-updated: 2026-07-07
+updated: 2026-07-14
 owners: [dfranks]
 files:
-  - _underscore/Component/Forecast/SaleImport/SaleImport.php
-  - _underscore/Component/Forecast/Db/Db.php
+  - worker2/Component/Forecast/SaleImport/SaleImport.php
+  - worker2/Component/Forecast/Db/Db.php
   - _underscore/Component/Api/Netsuite/Netsuite.php
   - worker2/Worker/Netsuite/Invoice.php
   - worker2/Worker/Netsuite/CashSale.php
@@ -57,14 +57,20 @@ The shared engine is `_Component_Forecast_SaleImport`; thin worker2 handlers
 - **Sign convention differs from the cron** — the raw REST record is all-positive, so the
   webhook applies the sign factor **uniformly to every line**, not just shipping. Copying
   the cron's sign handling reintroduces the credit-memo sign bug. (See Sign convention.)
-- The engine is a `_Component_*` class and therefore **must live in `_underscore`**, not in
-  worker2 — the autoloader rejects a `_Component_*` loaded from a project path. (See Gotchas.)
+- **The engine is checked into the `worker2` repo, NOT `_underscore`** — despite its
+  `_Component_*` name. `_Component_Forecast_SaleImport` and `_Component_Forecast_Db` both
+  live under `worker2/Component/Forecast/…` and declare `namespace worker;` (the project-local
+  `_Component_*` requirement). The class-name convention alone does **not** imply an
+  `_underscore` home — planning/context tools repeatedly assert `_underscore` and are **wrong**;
+  a `git` checkout of `_underscore` has **no** `Component/Forecast/SaleImport/SaleImport.php`.
+  Only `_Component_Api_Netsuite` (the REST client, `fetchRecord`/`createRecord`) is genuinely in
+  `_underscore`. (See Gotchas.)
 
 ## Key files / entry points
 | File | Role |
 |---|---|
-| `_underscore/Component/Forecast/SaleImport/SaleImport.php` | the engine (shared body for all four types) |
-| `_underscore/Component/Forecast/Db/Db.php` | shared NS-REST + sublist-pagination helpers |
+| `worker2/Component/Forecast/SaleImport/SaleImport.php` | the engine (shared body for all four types); checked into **worker2**, declares `namespace worker;` |
+| `worker2/Component/Forecast/Db/Db.php` | shared NS-REST + sublist-pagination helpers (also **worker2**, `namespace worker;`) |
 | `worker2/Worker/Netsuite/Invoice.php` etc. | four sale-type thin handlers; `post`/`put` → `sync`, `delete` → `removeAll` |
 | `worker2/Worker/Netsuite/JournalEntry.php` | thin JE handler; `post`/`put` → `syncJournalEntry`, `delete` → `removeAllJournalEntry` |
 | `test/@dave/test_je_lifecycle.php` | JE lifecycle harness (direct-engine create/update/delete) |
@@ -237,8 +243,34 @@ item-line upsert/reconcile machinery (`syncLines`/`guardedInsert`/`deleteRows`).
   `51200→249` COGS Service. Read-only resolver tool: `test/@dave/probe_je_accounts.php`.
 - **Likely future one-line tweak:** if the Agent sub-accounts should count, add `41300.01` to
   the revenue list and `51200.01` to the cost list.
-- Group key uses `json_encode([salesRep, item])` (not a string-join) to stay collision-safe
-  once the fields go live — an empty-string separator would let `"5|" + null` collide.
+- **Customer is now resolved on JE lines and is a THIRD grouping dimension (TRUE-80129,
+  dfranks 2026-07-14).** `buildJournalEntryRows` previously hard-coded `customerId = null` on
+  every JE row. It now reads `JE_LINE_CUSTOMER_FIELD = 'entity'` — a **NATIVE JE-line reference
+  field**, unlike the `custcol_*` salesRep/item fields — via the same `journalLineLookup()`
+  bare-lookup helper, resolving against `Customers.netsuiteInternalId` (the identical
+  table/column the four sale-transaction types already use for `customerId`). `customerId` is
+  folded into the group key as a third dimension (see below), so JE lines sharing rep/item but
+  differing by customer now split into **separate** `Forecast.Sales` rows.
+  - **Non-Customer entities resolve to null with no explicit type check needed** — a JE line's
+    `entity` may be a vendor or employee ref, but NetSuite **internal ids are a single global
+    sequence across all entity subtypes** (customer/vendor/employee never share an id), so a
+    vendor/employee id simply misses `Customers.netsuiteInternalId` and yields null. No
+    `is-customer` guard required. (Reusable NetSuite fact: internal ids are globally unique
+    across record subtypes, not namespaced per subtype.)
+- Group key uses `json_encode([salesRep, item, customer])` (not a string-join) to stay
+  collision-safe — an empty-string separator would let `"5|" + null` collide. (The customer
+  slot was added under TRUE-80129; the fixer mirror MUST key identically — see the
+  reconciliation doc.)
+
+**Backfilling `customerId` onto existing JE rows requires a manual, all-time re-import — the
+code fix alone does NOT backfill (TRUE-80129 decision).** The checker/fixer only detect
+**revenue/profit** drift per JE, so an already-correct-total JE row that is merely **missing
+`customerId`** is **not** flagged discrepant and a normal fixer pass will never repopulate it.
+The chosen backfill (run **manually, once, by the developer after deploy — explicitly out of
+scope for the code PR**): `DELETE` **all** `netsuiteTransactionType='journalEntry'` rows from
+`Sales` (no date-window restriction), then run `fixer.php --commit --prod --category sales`
+over full JE history so `fixJournalEntries()` takes the INSERT branch for every group and
+repopulates all JE rows including `customerId`. (See the reconciliation doc for the fixer side.)
 
 **Reversal handling (a JE-only pattern):**
 - Setting a reversal date makes NetSuite auto-create a **paired reversing JE**, but **only
@@ -524,21 +556,40 @@ success from a `Forecast.Sales` row alone.
   webhook or the daily discrepancy-fix.
 - **Local _underscore boots on PHP 8.0.30 (xampp8)** — the floor enforced in `_underscore.php` is
   **8.0.0**, not 8.1.
-- **`_Component_*` classes must live under the `_underscore` framework root, never a project
-  repo.** The autoloader rejects a `_Component_*`/`_Model_*` loaded from a project path
-  (e.g. `./` under worker2) with "namespace … has not been defined" — at **class-load
-  (runtime), not `php -l`**. So this engine lives in `_underscore` next to
-  `_Component_Forecast_Db` even though only worker2 uses it; it references the worker2 class
-  `_Worker_Netsuite_Item`, resolved lazily at runtime in the worker2 context. **A
-  legitimately project-local `_Component_*`/`_Model_*` (e.g. the worker2 copies of these
-  classes) must still declare `namespace worker;` or it throws the same error at autoload —
-  and this exact global-namespace mistake caused the SALES drift (webhooks fatally threw
-  before writing, presenting as 7-month historical drift). See the
+- **This engine is a project-local `_Component_*` that lives in `worker2`, NOT `_underscore` —
+  correcting the earlier assumption.** `_Component_Forecast_SaleImport` and
+  `_Component_Forecast_Db` are checked into **`worker2/Component/Forecast/…`** and declare
+  `namespace worker;`. A `_Component_*`/`_Model_*` loaded from a project path is legal **only
+  when it declares its project namespace** — omit it and the autoloader throws "namespace …
+  has not been defined" at **class-load (runtime), not `php -l`** (this exact global-namespace
+  mistake caused the SALES drift: webhooks fatally threw before writing, presenting as 7-month
+  historical drift). So the naming convention does **not** put the file in `_underscore`; the
+  namespace declaration is what makes the worker2 location valid. It references the worker2
+  class `_Worker_Netsuite_Item`, resolved lazily at runtime. Only `_Component_Api_Netsuite`
+  (the REST client) is actually in `_underscore`. **Planning/context tooling has repeatedly
+  mis-asserted an `_underscore` home for this engine — verify against a `git` checkout, not the
+  class name.** See the
   [namespace-registration doc](./component-model-namespace-registration.md) for the
-  eval-bridge mechanism and the `catch`/`throw`/`extends` backslash-qualify traps.**
+  eval-bridge mechanism and the `catch`/`throw`/`extends` backslash-qualify traps.
 - The cron's sign handling is not portable here — see Sign convention.
 
 ## Change history
+- 2026-07-14 — **JE lines now resolve `customerId` (was hard-coded null) + corrected the
+  engine's repo location to worker2** (TRUE-80129, dfranks). `buildJournalEntryRows` reads
+  `JE_LINE_CUSTOMER_FIELD = 'entity'` — a **native** JE-line reference field (not a `custcol_*`,
+  unlike salesRep/item) — via `journalLineLookup()` against `Customers.netsuiteInternalId` (same
+  table/column the four sale types use), and folds `customerId` into the group key as a third
+  dimension: `json_encode([salesRep, item, customer])`. Non-Customer entities (vendor/employee
+  refs) resolve to null with no type check because **NetSuite internal ids are one global
+  sequence across all entity subtypes**. Recorded that the backfill of existing JE rows is a
+  **manual, all-time** developer step (DELETE all `journalEntry` Sales rows, then
+  `fixer.php --commit --prod --category sales` over full JE history) — the code fix alone does
+  NOT backfill because the checker only flags revenue/profit drift, not a missing customerId.
+  **Also corrected a long-standing misattribution:** `_Component_Forecast_SaleImport` and
+  `_Component_Forecast_Db` are checked into the **worker2** repo (`namespace worker;`), NOT
+  `_underscore` — the `_Component_*` name does not imply an `_underscore` home; a `git` checkout
+  of `_underscore` has no such file. Only `_Component_Api_Netsuite` is actually in `_underscore`.
+  (dfranks)
 - 2026-07-08 — **Added the webhook-vs-fixer diagnostic playbook** for proving whether inbound
   NetSuite webhooks actually wrote `Forecast.Sales`: correlate `Logs.Webhook` (prod-logs;
   receipt-only, NO status column) against `Core.WorkerJobs` (prod-core; `isSuccess`/

package/knowledge/sessions/2026-07-14-bdr-build-tcox.md

@@ -0,0 +1,78 @@
+---
+type: session
+slug: bdr-build
+title: BDR web funnel built through Phase 5 (scaffold to real backend)
+author: tcox
+repos: [bdr, ai-bdr]
+framework: "2.0"
+client: shared
+status: active
+created: 2026-07-14
+updated: 2026-07-14
+---
+
+# Session: bdr-build
+**Date:** 2026-07-14
+**Project/Repo:** bdr (2.0) — local `C:\WWW\BDR`, GitHub `agilantsolutions/BDR`, branch `BDR-Development`
+**Task:** Execute PLAN.md Phases 0-5 of the BDR web funnel: get the repo onto GitHub, scaffold the Next.js app, and build the content layer, component library, all screens/flow, and the real HubSpot/Toga backend.
+
+---
+
+## What WORKED
+- **Repo now on GitHub.** `C:\WWW\BDR` git-initialized, branched off remote `_main` (README preserved), pushed to `agilantsolutions/BDR` branch **`BDR-Development`** (developer renamed it from feature/initial-plan-and-mockup). 8 commits: `3a1db6b` plan+mockup import (323 files, `.claude/` gitignored), `08eaf65` PLAN.md path/registry fixes, then Phases 0-5.
+- **CLI git auth PERMANENTLY FIXED on this machine.** `git config --global credential.helper manager` + one interactive `git fetch` popped the GCM browser sign-in; credentials stored. Push/fetch now work from CLI for ALL repos incl. the knowledge repo (`/capture` pushes work). The old "push via GitHub Desktop" memory was deleted as obsolete.
+- **Phase 0** (`dcc3e30`): Next.js 16.2.3 + React 19.2.4 + TS scaffold mirroring `info`'s config. Mockup `styles.css` ported as `src/app/studio.css`. `resolveCampaignId` (?campaign= -> hsCampaignId map -> `default`, slug regex `^[a-z0-9][a-z0-9-]{0,63}$`). ESLint flat-config no-em-dash rule (Literal/TemplateElement/JSXText selectors) — proven to fire. amplify.yml + .env.example.
+- **Phase 1** (`960fe34`): `src/content/` schema.ts (CampaignBundle contract), provider.ts (`resolveCampaign` never throws; unknown slug serves DEFAULT content with requested id), hubspotProvider.ts stub (throws, gated on §9.10), useCampaign.tsx context hook, default.ts = mockup copy verbatim extracted by subagent. Vitest wired (server-only shimmed via alias).
+- **Phase 2** (`90fd7ed`): components.jsx ported to 16+ typed client modules (Ico 27-icon registry + iconFor, AgentArt/SmoothImg/TalkingPreview, VoiceDial+VoiceAudio, ColorSelector, SwapFade with settle guards verbatim, Particles, StepRail, SynapseButton...). `src/lib/agentData.ts` (only home for accent hexes) + `assetPath.ts` (replaces ASSET()/window.__resources, preloadAgentAssets). Assets pruned per §5.8 to 6.2MB (Alex slot-1 art+talk video, walkthrough, brand SVGs).
+- **Phase 3** (`64553b1`): Capabilities.tsx fully config-driven (Q&A pill rotation with mockup fade phases + same-tick click guard), thin AgentFlowRoot (accent -> :root, --mx/--my hover, scroll tint), RichText.tsx `agentize()` replaces `<agent>` token with bundle.agent.name. Schema calibrations: `chrome`, eyebrows, `qbank`, connectNote -> {label,value}.
+- **Phase 4** (`85a4772`): useAgentFlow state machine (go()/back map, stepFor, modal gates, aibdr.v2 localStorage — only voice survives refresh), AutoBuild (verbatim ms timeline, lands on CAMPAIGN agent not hardcoded Alex), CallNow, Schedule (12-month, 30-min slots), Success (calling simulation + summaries + AmbientQuestions), Welcome/WelcomeStep2/EarlyAccess modals, leadActions seam stubs. Creator + TweaksPanel deliberately NOT ported (parked, §9.3/§9.7).
+- **Phase 5** (`34a3910`): `src/server/` toga.ts + hubspot.ts ported from `info` with ALL PII logging stripped (identifier-only logs), validation.ts (16KB body cap, phone/uuid/ISO checks), leadSink.ts + callbackService.ts adapters, /api/call-now + /api/call-later + /api/contact route handlers (always envelope-shaped), page.tsx primes lead from ?hsContactId server-side and NEVER fails rendering, leadActions POST for real. info's dead 501 `visit` route dropped deliberately.
+- **Verification discipline held every phase:** tsc + eslint + vitest + next build + live SSR curl checks before each commit. Final: **67 tests / 7 files green**. Live checks: `?campaign=healthcare` -> data-campaign="healthcare"; POST /api/call-now `{}` -> 400 envelope (not 500); missing env -> 500 envelope, funnel still renders.
+- **Subagent pipeline worked well:** 4 background implementer agents (content extraction, component port, Capabilities, Phase 4 flow, Phase 5 backend) each verified before returning; main thread stayed conductor.
+
+## What did NOT work — DO NOT RETRY THESE
+- **`sed`/`perl` in-place replacement of literal `\n` escapes through the Bash tool failed silently** (file unchanged; the `\"` expression in the same sed call DID apply — escaping is mangled through the Windows Git Bash wrapper). Fix that worked: the **Edit tool** with exact old/new strings. The mockup's styles.css lines 759 + 840 contain literal `\n` / `\"` sequences (JS-string generation artifacts) that break the CSS parser — already fixed in `src/app/studio.css`; `mockup/styles.css` left pristine (still broken) on purpose.
+- **`pkill` does not kill Windows processes from Git Bash** — it exits quietly and the old `next start` keeps holding port 3000, serving a STALE build (looks like your new code didn't build). Kill via PowerShell `Get-NetTCPConnection -LocalPort 3000 | Stop-Process` or `taskkill //PID <pid> //F` (netstat to find PID).
+- **The Bash tool's cwd resets to `c:\WWW` between some calls** — `npm run <script>` then fails with "Missing script" because c:\WWW has no package.json. Always `cd /c/WWW/BDR &&` first.
+- **Pre-commit path scan regex missed `c:\WWW\...` single-backslash absolute paths** (pattern only matched escaped/forward-slash forms) — PLAN.md was pushed with machine paths in it (git-workflow violation), fixed in follow-up `08eaf65`. Scan for `[A-Za-z]:[\\/]` case-insensitively next time.
+- **ESLint linted `mockup/**` (110 errors)** until `mockup/**` was added to globalIgnores — the prototype is reference material, not shipped code.
+- **CLI push/fetch without GCM sign-in**: `fatal: could not read Username` — resolved permanently (see What WORKED); do not fall back to GitHub Desktop workflows.
+
+## Not tried yet (candidates for next session)
+- **§9.10 decision (gates Phase 6):** how campaign content is modeled in HubSpot (HubDB likely vs custom object; nested Q&A pool/sets/callSummaries are the hard part). Needs the HubSpot instance owner. Then: implement hubspotProvider (fetch by slug + map + revalidation cache + no-em-dash normalization), seed campaign 1 from default.ts, slim DEFAULT to engineering fallback.
+- **Phase 6:** second campaign (healthcare proof points already in the Q pool) proving zero-code campaign adds.
+- **Phase 7:** pixel-parity pass vs mockup screens/screenshots, GA4 (react-ga4 installed, not wired), accessibility.
+- **Phase 8:** Amplify SSR app creation + env vars (values from info's deployment), `togatech` integration mechanism (§9.6), PR + merge strategy for `BDR-Development` -> `_main`.
+- **Local run QA:** developer was about to `npm run dev` and walk the funnel; feedback may yield fidelity fixes.
+- Success screen consuming `submitOk` (currently exposed by useAgentFlow, not yet surfaced in UI).
+
+## Current file state
+| File | Status | Notes |
+|------|--------|-------|
+| `C:\WWW\BDR` (whole repo) | 8 commits pushed to `BDR-Development` | Working tree clean at `34a3910`. No PR opened (developer said "no PR to do yet"). |
+| `src/app/` | layout + page (server: resolve slug -> bundle -> lead prime) + studio.css (fixed) + api/{call-now,call-later,contact} | |
+| `src/content/` | schema.ts, default.ts (mockup copy interim), provider.ts, hubspotProvider.ts (throwing stub), useCampaign.tsx | |
+| `src/components/`, `src/flow/`, `src/server/`, `src/lib/` | Complete per phases 2-5 | Creator/TweaksPanel not ported (parked). |
+| `test/` (7 files, 67 tests) | All green | Includes route validation, CST formatting, slots, phone. |
+| `knowledge/2.0/apps/ai-bdr/*` (team repo) | NOT yet re-synced with Phase 3/4 schema calibrations or build progress | `/capture` pending — run it next session start or after QA. |
+
+## Decisions made
+- **No Tailwind** (deviation from mirroring info): Tailwind 4's preflight reset would fight the mockup's hand-authored CSS and threaten pixel parity; PLAN §5.1 makes it optional. Rejected: including it for config parity.
+- **DEFAULT bundle carries the mockup's copy verbatim as interim dev content** (documented in default.ts header) until HubSpot is seeded post-§9.10, then slim to engineering fallback. Rejected: building screens against lorem-ipsum minimal DEFAULT (no parity possible).
+- **Schema calibrated by building, not upfront:** Phase 3/4 added chrome, qbank, eyebrows, earlyAccess/phone/recap groups, connectNote {label,value}, template tokens `<agent>/<date>/<tz>/<time>/<detail>`. The §6 sketch was a starting point; the code schema is now the contract.
+- **AutoBuild lands on `bundle.agent`**, not hardcoded Alex — agent identity is campaign config (PLAN §2.2 design implication).
+- **info's `visit` route dropped** (permanent 501 stub, no caller): dead attack surface. Recorded in contact route header.
+- **PII logging stripped at port time** (info debt): identifier-only logs everywhere; Toga error paths strip query strings (contact lookup carries email in query).
+- **`.claude/` harness gitignored** in the BDR repo (machine-local, installed via npx toga-ai; committing snapshots the whole KB stale).
+- **GCM one-time sign-in** chosen over GitHub Desktop-only pushes: fixes CLI push machine-wide, permanently.
+
+## Blockers
+- **§9.10 HubSpot content mechanism undecided** — gates hubspotProvider + campaign seeding (Phase 6). Owner: whoever runs the HubSpot instance.
+- **First-campaign direction/copy from leadership** still pending (fills bundle 1, doesn't block engine work).
+- **Real-call testing needs env values** (HUBSPOT_ACCESS_TOKEN + 4 TOGA_* vars) from info's deployment — deliberate action, hits live Toga and can trigger an actual callback.
+
+## Exact next step
+> `cd C:\WWW\BDR && npm run dev`, open http://localhost:3000, walk the full funnel (Welcome -> Build my agent -> AutoBuild -> Capabilities -> Call Now/Schedule -> Success) side-by-side with `mockup/AI BDR (standalone).html`, and note fidelity gaps for the Phase 7 parity pass. Then run `/capture` to re-sync the ai-bdr knowledge docs (schema calibrations + build progress).
+
+---
+_Saved by /session-save on 2026-07-14_

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "toga-ai",
-  "version": "1.0.328",
+  "version": "1.0.330",
   "description": "TOGA Technology Team Claude Knowledge System — shared AI coding harness with skills, knowledge base CLI, and project installer for Claude Code.",
   "keywords": [
     "claude",