toga-ai 1.0.309 → 1.0.310

package/knowledge/1.0/apps/togadesk/features/email-to-ticket-intake.md

@@ -7,7 +7,7 @@ client: shared
 type: feature
 status: active
 updated: 2026-07-09
-owners: ["jcardinal", "dfranks"]
+owners: ["jcardinal", "dfranks", "mhammontree"]
 files:
   - crons/tickets.php
   - crons/tickets_prod.php
@@ -40,6 +40,19 @@ TOGa Desk ingests support email into tickets through a cron-driven IMAP poller
 3. **Parse & route (`emailToTicket()`):** extract from/to/cc/subject/body (with encoding fixes);
    match an existing ticket via `In-Reply-To` + `Message-ID` headers and **plus-addressing**
    (`support+<ticketnum>@…`). Matched ⇒ `addReply()`; otherwise ⇒ `add()`.
+   - **Noise suppression (before any ticket/attachment is created):** both feeders drop known
+     automated no-noise mail via the shared helper
+     `Ticket::isSuppressedNoiseEmail(?string $from, ?string $subject): bool` (static, in
+     `class.ticket.php`). It returns true only when the sender matches `/^no-?reply@/` **AND**
+     the subject starts with `staples po ` — both required so a real person is never blocked, and
+     the sender check is **domain-agnostic** (matches `noreply@togatech.com` /
+     `noreply@goagilant.com` and survives future sender-domain flips; the Staples PO alert sender
+     flipped `goagilant.com → togatech.com` on 2026-06-02). Wired into BOTH intake feeders:
+     `crons/tickets.php` adds it as one more `&&`-clause in the existing IMAP intake guard
+     (alongside the delivery-status / `MAILER-DAEMON` / Compass auto-reply filters);
+     `crons/pipe.php` uses it as an early guard-and-`exit(0)` right after the `$from`/`$subject`
+     parse. Each feeder logs a "suppressed" line. (TRUE-79975 — ~815 such alerts since Jun 2024,
+     ~704 of them landing in the dept-1 "Support Desk" catch-all and being closed by hand.)
 4. **Side effects:** auto-create a user when the sender domain maps to an existing client; assign
    to a department via the department email lookup; save attachments locally then push to **S3**
    (`App_Cloud::copyFileToS3()`, bucket `asifiles`); optionally generate Talos/TogaIQ summaries.
@@ -49,7 +62,12 @@ TOGa Desk ingests support email into tickets through a cron-driven IMAP poller
 ## Data model
 Writes `tickets`, `tickets_replies`, attachment `files`; reads config from the `config` table
 (`tickets_defaultdepartment`, `tickets_defaultclient`, `auto_close_tickets`,
-`email_from_address`, `timezone`). Department routing keys on `tickets_departments.email`.
+`email_from_address`, `timezone`). Department routing keys on a `tickets_departments.email`
+`LIKE` match against the To/CC addresses; **anything unmatched falls through to config
+`tickets_defaultdepartment` (= dept 1 "Support Desk" catch-all) and `tickets_defaultclient`** —
+which is why unrouted/automated mail piles into "Support Desk". There is **no allowlist/blocklist
+config framework**: noise filtering is ad-hoc inline guards in the crons (the hardcoded Compass
+"Automatic reply:" filter and now `isSuppressedNoiseEmail`).
 
 ## Gotchas / known issues
 - **`$processName` guard:** `tickets.php` throws if executed directly instead of via an env
@@ -59,7 +77,13 @@ Writes `tickets`, `tickets_replies`, attachment `files`; reads config from the `
 - **Loop prevention** only excludes FROM==department-TO addresses; CC/reply-all across multiple
   department addresses can still loop.
 - **Auto-reply filters** are partly hardcoded (e.g. ignore `TechHub@compass-usa.com`
-  "Automatic reply:" messages).
+  "Automatic reply:" messages), and now the `isSuppressedNoiseEmail` Staples-PO filter — there
+  is no config-driven allow/block list, so each new noise source is another inline guard.
+- **`Ticket::extractEmail()` returned an undefined offset on a no-match** (bare `$matches[0]`).
+  With a sender-less/malformed email this codebase promotes the warning to a thrown error
+  (`E_ALL` + `App_Error::handleError`), so an intake cron could **halt**. Hardened to
+  `return $matches[0] ?? '';` (TRUE-79975) — important because `isSuppressedNoiseEmail` routes
+  nullable/malformed sender input through `extractEmail`, putting this latent bug on the hot path.
 - Attachments are deleted locally immediately after the S3 upload with **no retry** if S3 fails.
 - **`adminid` clobber on reply routing:** after `emailToTicket()` sets `$data['adminid']` from
   the FROM address (~line 1407), an asset lookup (~line 1437-1442) overwrites it with the
@@ -69,6 +93,10 @@ Writes `tickets`, `tickets_replies`, attachment `files`; reads config from the `
   classification. See the ticket-lifecycle doc.
 
 ## Change history
+- 2026-07-09 — added `Ticket::isSuppressedNoiseEmail()` noise suppression (no-reply sender + "Staples PO"
+  subject) wired into both feeders before ticket creation; hardened `extractEmail()` no-match to
+  `''`; documented the `tickets_defaultdepartment` → "Support Desk" catch-all fall-through
+  (TRUE-79975) (mhammontree)
 - 2026-07-09 — documented the `emailToTicket()` adminid-overwrite reply misclassification
   (TRUE-80114 planning investigation) (dfranks)
 - 2026-06-15 — documented from a source read of `crons/tickets*.php` and `emailToTicket()` (jcardinal)

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "toga-ai",
-  "version": "1.0.309",
+  "version": "1.0.310",
   "description": "TOGA Technology Team Claude Knowledge System — shared AI coding harness with skills, knowledge base CLI, and project installer for Claude Code.",
   "keywords": [
     "claude",