toga-ai 1.0.294 → 1.0.295

package/knowledge/2.0/apps/api2/features/nested-relationship-writes.md

@@ -6,12 +6,13 @@ project: API
 client: shared
 type: feature
 status: active
-updated: 2026-07-07
-owners: ["bala"]
+updated: 2026-07-09
+owners: ["bala", "mhammontree"]
 files:
   - api2/Component/Api/V2/V2.php
 related:
   - ../architecture.md
+  - ../../../clients/aig/features/entitlement-intake.md
 ---
 
 ## Summary
@@ -57,6 +58,37 @@ rows on every write.
 If you need to link by a business key (like an employee XID), **resolve that key to a uuid in your
 caller first** (e.g. build a `key → uuid` map), then send `{uuid}`.
 
+## Per-API overrides (`Apis_RecordFields`)
+
+The base identifier flags above (`Core.RecordFields.isIdentifier`) can be **overridden per API**
+via rows in a tenant's `Apis_RecordFields` table, read by the V2 resolver's override block
+(`V2.php` ~6926–6936; child policy in `getChildPolicy()` ~8019–8041; loader ~8526–8538). Two
+columns matter:
+
+- **`overrideIsIdentifier`** — overrides whether the field is a searchable identifier for that API.
+- **`overrideChildPolicy`** — overrides link-vs-create for the nested record (e.g. `MATCH_CREATE`
+  = match an existing child by identifier, else create it).
+
+> **Trap: a `NULL` `overrideIsIdentifier` is read as "not an identifier", not "no opinion".**
+> The override block evaluates `!$row->overrideIsIdentifier`, so a `NULL` **unsets** the field
+> from the API's searchable identifiers even when the base `Core.RecordFields` row has
+> `isIdentifier=1`. Any `Apis_RecordFields` row created **only** to set a child policy
+> (leaving `overrideIsIdentifier` NULL) will silently strip that field as an identifier. The
+> nested object then has no searchable identifier and the write fails **EV-12 VALIDATION**
+> (`V2.php:7094`) — the `MATCH_CREATE` that should have saved it never runs on that path.
+> Correct the data with an explicit `overrideIsIdentifier = 1`, or (systemic fix, not yet done)
+> change the code so only an explicit `0` removes an identifier and `NULL` means "no override".
+
+**Build divergence warning.** The `Apis_RecordFields` override feature (reading
+`overrideIsIdentifier`/`overrideChildPolicy`) was introduced 2026-03-20 (api2 commit `624146d`
+"Cache custom fields and API override lookups"). Environments on **older** builds ignore the
+override and keep the base identifier, so a tenant with identical Core metadata + override rows +
+data can behave differently across environments purely by build version. A NULL-`overrideIsIdentifier`
+override row that works on prod (older build) will start throwing EV-12 once prod gets the newer
+build — audit such rows before/with the deploy. First seen in AIG (TRUE-79978): prod resolved,
+beta/QA threw EV-12 on the injected `entitlementFulfillmentType` — see
+[AIG entitlement intake](../../../clients/aig/features/entitlement-intake.md).
+
 ## Gotcha
 
 - **Nested write with only a non-identifier field silently creates duplicates.** This is a
@@ -68,6 +100,11 @@ caller first** (e.g. build a `key → uuid` map), then send `{uuid}`.
 
 ## Change history
 
+- 2026-07-09 — Documented the per-API `Apis_RecordFields` override layer (`overrideIsIdentifier`,
+  `overrideChildPolicy`) and the trap that a `NULL` `overrideIsIdentifier` is read as "not an
+  identifier" (`!$row->overrideIsIdentifier`) — an override row set only for a child policy
+  silently strips the field as an identifier → EV-12 at `V2.php:7094`. Added the build-divergence
+  warning (override feature added 2026-03-20, commit `624146d`). Surfaced by AIG TRUE-79978. (mhammontree)
 - 2026-07-07 — Documented that api2 nested-relationship writes match an existing child **only** by
   identifier (`uuid`); a non-unique custom field is not a match key and forces a new-record insert.
   Correct pattern is `contact: {uuid}` (resolve business keys to uuid in the caller). Surfaced by
@@ -78,3 +115,5 @@ caller first** (e.g. build a `key → uuid` map), then send `{uuid}`.
 - [api2 architecture](../architecture.md) — the V2 CRUD engine (`processRoutePairs`).
 - [Prudential device import + contact linking](../../../clients/prudential/features/device-information-import-and-contact-linking.md)
   — the production incident that exposed this behavior.
+- [AIG entitlement intake](../../../clients/aig/features/entitlement-intake.md) — the TRUE-79978
+  EV-12 that exposed the `Apis_RecordFields` NULL-`overrideIsIdentifier` trap + build divergence.

package/knowledge/clients/aig/features/entitlement-intake.md

@@ -5,12 +5,13 @@ project: API
 client: aig
 type: client-feature
 status: active
-updated: 2026-06-19
+updated: 2026-07-09
 owners: ["mhammontree"]
 files:
   - _underscore/Model/Aig/Entitlement.php
   - dbchanges2/Client_Aig/2026-06-18a - TRUE-79534 AIG SaleItem codes.sql
 related:
+  - 2.0/apps/api2/features/nested-relationship-writes.md
   - 2.0/apps/api2/architecture.md
   - 2.0/apps/dbchanges2/architecture.md
   - 2.0/apps/_underscore/architecture.md
@@ -42,7 +43,9 @@ the FK can't resolve and intake fails with **"Missing AIG item ID."** Keeping
    - reads `partNumber = payload->saleItem->partNumber` and runs
      `SELECT id FROM Items WHERE partNumber = '{partNumber}' LIMIT 1` to get `$itemId`;
    - uses `$itemId` to load fulfillment **types** (`Items_EntitlementFulfillmentTypes`) and
-     **methods** (`Items_EntitlementFulfillmentMethods`) and injects them into the payload.
+     **methods** (`Items_EntitlementFulfillmentMethods`) and injects them into the payload as
+     **name-only** related objects (e.g. `entitlementFulfillmentType: {name: "Repair"}`). AIG
+     never sends `entitlementFulfillmentType`; it is populated entirely by this interceptor.
 3. The V2 engine resolves `Entitlement.saleItemId` (FK → `_Model_Client_Item`) from that same
    `saleItem.partNumber`. **No matching `Items` row → unresolvable FK → "Missing AIG item ID".**
 4. `postPost` then emails the contact a Staples Protection Plan registration link
@@ -118,9 +121,28 @@ this interceptor or use this dual-purpose Items pattern.
   codes are **not** in the SaleItemID spreadsheet and must be sourced separately if missing.
 - **No unique key on `Items.partNumber`** — use an anti-join for idempotent loads, not
   `INSERT IGNORE`.
+- **An `entitlementFulfillmentType` EV-12 VALIDATION error is NOT a bad client payload —
+  it's this interceptor's injected field failing to resolve.** AIG never sends that field;
+  the interceptor injects it as `{name: "Repair"}`. The error means the V2 resolver could not
+  find a searchable identifier for the injected object. Root cause (TRUE-79978) was an
+  `Apis_RecordFields` override row that stripped `name` as an identifier — see
+  [api2 nested-relationship writes → Per-API overrides](../../../2.0/apps/api2/features/nested-relationship-writes.md).
+- **Empty `saleItem.partNumber` silently resolves to the wrong item.** The lookup is
+  `WHERE partNumber = '{$partNumber}' LIMIT 1`; when `partNumber` is `""`, it matches item
+  `id=10` ("2YR Tablet") — the first row with an empty part number — which carries a "Repair"
+  fulfillment type. So a blank part number does not fail loudly; it injects a spurious
+  name-only fulfillment type. The interceptor should guard an empty/failed lookup before
+  injecting (not yet fixed).
 
 ## Change history
 
+- 2026-07-09 — TRUE-79978: root-caused an `entitlementFulfillmentType` EV-12 on beta/QA. The
+  field is injected (name-only) by `prePost`; the beta `Client_Aig.Apis_RecordFields` override
+  row (apiId=2, recordFieldId=1202) had `overrideIsIdentifier=NULL` + `overrideChildPolicy=MATCH_CREATE`,
+  which the newer V2 build reads as "not an identifier", stripping `name` → no searchable id →
+  EV-12. Unblocked with a manual one-row beta data fix (`SET overrideIsIdentifier=1`); prod runs
+  an older build without the override feature so it still resolves. See the api2 feature doc for
+  the shared resolver behavior. (mhammontree)
 - 2026-06-19 — Documented intake flow; loaded 2,200 new SaleItem codes (1,700 STS `ASI-*`/`SM-*`
   + 500 unique numeric `SA`) into `Client_Aig.Items` via TRUE-79534, fixing "Missing AIG item ID"
   on the new `ASI-*` scheme. Follow-up to TRUE-79441. (mhammontree)

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "toga-ai",
-  "version": "1.0.294",
+  "version": "1.0.295",
   "description": "TOGA Technology Team Claude Knowledge System — shared AI coding harness with skills, knowledge base CLI, and project installer for Claude Code.",
   "keywords": [
     "claude",