toga-ai 1.0.259 → 1.0.260

package/knowledge/2.0/apps/_underscore/INDEX.md

@@ -14,6 +14,6 @@
 | [NetSuite REST Client (_Component_Api_Netsuite) — record writes & SuiteQL](features/netsuite-rest-client.md) | `_Component_Api_Netsuite` is the **2.0 `_underscore` NetSuite REST client** — the shared primitive every worker2/api2 NetSuite caller uses for record GETs, Suit | _underscore/Component/Api/Netsuite/Netsuite.php |
 | [Per-Client Database Connections & the Local Logs Trap](features/per-client-database-connections.md) | When `_underscore` serves a request for a client it opens **three distinct per-client database connections**, not one. | _underscore/Database.php, _underscore/ApiRequest.php, _underscore/Model/Client/Logs/Api.php |
 | [Recursive Item Fulfillments (upstream mirroring)](features/recursive-item-fulfillments.md) | In a multi-tier supply chain a sales order (SO) spawns a purchase order (PO) that becomes another SO downstream, and so on. | _underscore/Model/Client/ItemFulfillment.php, _underscore/Model/Client/ItemFulfillmentItem.php, _underscore/Model/Client/ItemFulfillmentItemUnit.php, _underscore/Model/Client/ItemFulfillmentPackage.php, _underscore/Model/Compass/AdvanceShippingNotice.php, dbchanges2/Core/2026-02-13 - 75601 - RecursiveItemFulfillmentCreation.sql, dbchanges2/Core/2026-06-04 - RecursiveItemFulfillmentPut.sql |
-| [Surface Resolver (_Model_Core_Surface::resolve — replaces Page::meta)](features/surface-resolver.md) | The runtime for the platform-wide **Surface** UI presentation layer: 9 `_underscore` models plus a cached resolver, `_Model_Core_Surface::resolve(&$api, string | _underscore/Model/Core/Surface.php, dbchanges2/Core/2026-06-30a - SurfaceMetaGroupAndSalesOrderSections.sql, dbchanges2/Client/2026-06-30a - SurfaceMetaGroupAcl.sql, dbchanges2/Core/2026-06-29b - SurfaceMetaPublicReadAcl.sql, dbchanges2/Client/2026-06-29c - SurfaceRecordScriptAcl.sql, dbchanges2/Core/2026-06-29c - SurfaceDebugPhpMethodFix.sql, _underscore/Model/Core/SurfaceElement.php, _underscore/Model/Core/Action.php, _underscore/Model/Core/Vocabulary.php, _underscore/Model/Core/VocabularyTerm.php, _underscore/Model/Core/Message.php, _underscore/Model/Client/SurfaceOverride.php, _underscore/Model/Client/MessageTranslation.php, _underscore/Model/Client/ThemeToken.php, _underscore/Model/Core/Page.php |
+| [Surface Resolver (_Model_Core_Surface::resolve — replaces Page::meta)](features/surface-resolver.md) | The runtime for the platform-wide **Surface** UI presentation layer: 9 `_underscore` models plus a cached resolver, `_Model_Core_Surface::resolve(&$api, string | _underscore/Model/Core/Surface.php, _underscore/Model/Client/AclRecordScript.php, _underscore/Model/Core/RecordScript.php, dbchanges2/Core/2026-06-30a - SurfaceMetaGroupAndSalesOrderSections.sql, dbchanges2/Client/2026-06-30a - SurfaceMetaGroupAcl.sql, dbchanges2/Client_Quad/2026-07-01a - GrantSurfacesMetaGroupScriptAcl.sql, dbchanges2/Client_CompassCanada/2026-07-01a - GrantSurfacesMetaGroupScriptAcl.sql, dbchanges2/Core/2026-06-29b - SurfaceMetaPublicReadAcl.sql, dbchanges2/Client/2026-06-29c - SurfaceRecordScriptAcl.sql, dbchanges2/Core/2026-06-29c - SurfaceDebugPhpMethodFix.sql, _underscore/Model/Core/SurfaceElement.php, _underscore/Model/Core/Action.php, _underscore/Model/Core/Vocabulary.php, _underscore/Model/Core/VocabularyTerm.php, _underscore/Model/Core/Message.php, _underscore/Model/Client/SurfaceOverride.php, _underscore/Model/Client/MessageTranslation.php, _underscore/Model/Client/ThemeToken.php, _underscore/Model/Core/Page.php |
 | [Tracking-Number Bridge Migration (ASN / Item Fulfillment / Item Receipt)](features/tracking-number-bridges.md) | Shipment tracking numbers used to live as **scalar FK columns** (`trackingNumberId`, `returnTrackingNumberId`) directly on the lowest-level "unit"/"item" tables | api2/Component/Api/V2/V2.php, _underscore/Model/Client/AdvanceShippingNoticeItemUnit.php, _underscore/Model/Client/AdvanceShippingNoticeItemUnits/TrackingNumber.php, _underscore/Model/Client/ItemFulfillmentItemUnits/TrackingNumber.php, _underscore/Model/Client/ItemFulfillment.php, _underscore/Model/Prudential/AdvanceShippingNotice.php, _underscore/Model/Compass/AdvanceShippingNotice.php, _underscore/Trait/Netsuite/ItemFulfillment.php, api2/Component/Api/Cxml/Cxml.php, dbchanges2/Client/2026-06-10 - TrackingNumberBridges.sql, dbchanges2/Core/2026-06-10 - TrackingNumberBridges.sql, dbchanges2/Client_Prudential/2026-06-15 - ItemFulfillmentTrackingNumberAclLogicGroups.sql, dbchanges2/Client_Quad/2026-06-18a - ItemFulfillmentItemReceiptTrackingNumberAclLogicGroups.sql, dbchanges2/Client_Nychh/2026-06-19b - ItemFulfillmentItemReceiptTrackingNumberAclLogicGroups.sql, dbchanges2/Client_Nychh/2026-06-19a - FixItemFulfillmentTableViewTrackingAndRoot.sql, dbchanges2/Client_Quad/2026-06-19a - FixItemFulfillmentTableViewTrackingAndRoot.sql |
 | [Units for Items for Purchase Orders — Data Structure](features/units-for-items-for-purchase-orders.md) | Describes how unit (serialized inventory) data is linked to sales-order and purchase-order line items behind the `units-for-items-for-purchase-orders` TableView |  |

package/knowledge/2.0/apps/_underscore/features/surface-resolver.md

@@ -6,12 +6,16 @@ project: _Underscore
 client: shared
 type: feature
 status: active
-updated: 2026-06-30
-owners: [jcardinal]
+updated: 2026-07-01
+owners: [jcardinal, apeterson]
 files:
   - _underscore/Model/Core/Surface.php
+  - _underscore/Model/Client/AclRecordScript.php
+  - _underscore/Model/Core/RecordScript.php
   - dbchanges2/Core/2026-06-30a - SurfaceMetaGroupAndSalesOrderSections.sql
   - dbchanges2/Client/2026-06-30a - SurfaceMetaGroupAcl.sql
+  - dbchanges2/Client_Quad/2026-07-01a - GrantSurfacesMetaGroupScriptAcl.sql
+  - dbchanges2/Client_CompassCanada/2026-07-01a - GrantSurfacesMetaGroupScriptAcl.sql
   - dbchanges2/Core/2026-06-29b - SurfaceMetaPublicReadAcl.sql
   - dbchanges2/Client/2026-06-29c - SurfaceRecordScriptAcl.sql
   - dbchanges2/Core/2026-06-29c - SurfaceDebugPhpMethodFix.sql
@@ -113,6 +117,32 @@ which surfaced latent resolution gaps in `_buildBundle`/`_resolveElement`:
   `_Model_<Client>_*` overrides + `Client_ApiPayloadInterceptor` hooks — the Surface layer does
   **not** absorb business logic.
 
+## How a surfaces scripted-API call is authorized (route-level gate)
+
+Authorizing a surfaces script (`meta`, `meta-group`, `debug`) is a **two-layer** check. Get the
+first layer wrong and you get a **403 `EZ-1 AUTHORIZATION`** before any element ACL runs.
+
+1. **Route-level dispatch gate — `Client_<tenant>.AclRecordScripts`.** The surfaces dispatcher
+   authorizes each API script (route + method + phpMethod) via the **CLIENT-tier**
+   `AclRecordScripts` table (cols `uuid`, `recordScriptId` → `Core.RecordScripts`, `roleId` →
+   `Client_<tenant>.Roles`). The check is keyed on the JWT's **`id.client.roles`** (client roles),
+   **NOT** the platform `core.roles` and **NOT** the Core `AclRecordPermissions` chain.
+   `Core.RecordScripts` maps route/method/phpMethod → an ACL "record" (`recordId`). The three
+   surfaces scripts: `meta` (GET, phpMethod `meta`), `meta-group` (GET, `metaGroup`), `debug` (GET,
+   `metaDebug`). `_Model_Core_Surface::resolve/metaGroup` read the caller's roles from
+   **`id.client.roles`** (Surface.php ~lines 56/87).
+2. **Element-level ACL (runs *inside* `meta`/`metaGroup`, AFTER the route gate passes)** — dropping
+   individual surface elements uses a **separate** client-tier table `_Model_Client_AclActionPermission`,
+   gated by each `SurfaceElement.aclActionId`. This is the "composition, not absorption" step in
+   `resolve()` step 4; it never causes the route-level 403.
+
+**Debugging a surfaces 403 EZ-1 (hard-won):** it is the route-level gate — a missing
+`Client_<tenant>.AclRecordScripts` grant resolved by **client role**. Do **not** chase
+`Core.AclRecordPermissions`, `appId` scoping, or `AclLogicGroups`/`AclRecordExpressions` — all were
+investigated and ruled out as red herrings: `appId = NULL` is the normal working pattern, and the
+Core record grants + their logic-group expressions all evaluate `all`/`"1"`. The gate is purely
+"does this client role have an `AclRecordScripts` row for this `recordScriptId`?"
+
 ## Gotchas
 
 - **A Core RecordScript needs `Client.AclRecordScripts` rows per role to be invokable — record-level
@@ -167,8 +197,33 @@ which surfaced latent resolution gaps in `_buildBundle`/`_resolveElement`:
   per-role `Client.AclRecordScripts` dispatch grant. Verified via toga-db — `meta` script id 25 was
   granted roles 1/3/4 but `meta-group` (id 27) had **none** until the grant ran. Any new surfaces
   scripted-API method repeats this: record READ never authorizes dispatch.
+- **The meta-group grant is seeded per-tenant, not globally — new tenants repeat the 403.** When
+  `meta-group` shipped, the `AclRecordScripts` grant was seeded **only** for `Client_Compass`
+  (recordScriptId → roles 1,3,4). `Client_Quad` and `Client_CompassCanada` had **no** grant for the
+  meta-group recordScriptId at all — their `meta` was granted to client role 1 (why `meta` worked but
+  `meta-group` 403'd for the same user/token). Same-user-different-script + same-script-different-tenant
+  is the fingerprint of this gap. Fix (2026-07-01): two `dbchanges2/Client_<tenant>/` migrations
+  granting meta-group to **client role 1** (parity with each tenant's existing `meta` grant),
+  id-agnostic (resolve `Core.RecordScripts` id by route/method/phpMethod, cross-DB read of `Core.*`
+  per the 2026-06-29c ACL pattern) and re-runnable via `NOT EXISTS`. Surface-layer DB changes ship to
+  the **beta** environment only. ⚠ **Root-cause not yet closed:** the meta-group grant should be
+  added to the `dbchanges2/Client/` **baseline (blank) seed** so newly-cut clients get it
+  automatically — otherwise the next migrated tenant hits the identical 403. Only Compass (already
+  correct), Quad, and CompassCanada are addressed. Also note **role breadth**: Compass exposes
+  surfaces to roles 1,3,4; Quad/CC got role 1 only (parity with their `meta`). If Quad/CC should
+  match Compass, a follow-up migration aligning both `meta` and `meta-group` to roles 1,3,4 is needed.
 
 ## Change history
+- 2026-07-01 — Documented the full route-level authorization mechanism (new section): the surfaces
+  script gate is `Client_<tenant>.AclRecordScripts` keyed on JWT `id.client.roles` (client roles,
+  not `core.roles`, not `Core.AclRecordPermissions`); element-drop is a separate
+  `_Model_Client_AclActionPermission`/`aclActionId` layer running inside `resolve()` after the route
+  gate; captured the red-herring list (`appId=NULL` is normal, Core grants all evaluate `all`/`"1"`).
+  Fixed the `meta-group` 403 EZ-1 for **Quad** and **Compass Canada** — the meta-group
+  `AclRecordScripts` grant had been seeded for Compass only; added two id-agnostic, NOT-EXISTS-guarded
+  `Client_<tenant>/` migrations granting meta-group to client role 1 (beta env only). Flagged the
+  open root-cause: add the grant to the `Client/` baseline seed, and decide role breadth (1 vs 1,3,4)
+  for Quad/CC. (apeterson)
 - 2026-06-30 — Added `metaGroup()` (`GET /v2/surfaces/meta-group?slugs=a,b,c`): batched composition
   over the existing per-slug `resolve()` cache, capped at `META_GROUP_MAX_SLUGS=25`, unknown slug →
   empty bundle (chosen over a `parentSurfaceId` GROUP row post-CTO-review). Fixed latent

package/knowledge/2.0/apps/toga25-supply/features/client-configurable-fields.md

@@ -6,7 +6,7 @@ project: TOGa 2.5 Supply
 client: shared
 type: feature
 status: active
-updated: 2026-06-25
+updated: 2026-07-01
 owners: [apeterson]
 files:
   - toga25-supply/src/fieldsConfig/index.ts
@@ -64,6 +64,22 @@ and the `useClientFields()` hook.
   `yourKey: BY_CLIENT[clientSlug] ?? DEFAULT_*`. Avoids editing all ~13 role bundles.
   `DEFAULT_CLIENT_FIELDS` must also carry the new key (ultimate fallback).
 
+### De-roling a client×role bundle to client-only
+
+Some bundles were role-keyed (`{ADMIN, MANAGER}`) only for historical reasons — the roles held
+byte-identical config. Those are being flattened to **client-only** (part of the ongoing
+backend-driven / de-role goal). `orderViewFields` is now client-only: `COMPASS` and `COMPASSCANADA`
+read their flat client JSON via `mergeOrderView(<client>OrderViewFields)` in
+`src/fieldsConfig/index.ts` instead of reading `.ADMIN`/`.MANAGER` off the file, and
+`FIELDS/COMPASSCANADA/orderViewFields.json` was flattened from `{ADMIN, MANAGER}` to a flat object.
+
+When de-roling, watch the read path: `COMPASS`'s JSON was **already flat** but was still being read
+via `.ADMIN` → `undefined` → the client silently fell back to `DEFAULT` and lost its
+`salesOrderDetailsConfig` joins. This is the flat-bundle trap from the gotcha below — the fix is to
+read the bundle itself, not a role key. `approvalViewFields` and `salesOrdersPageFields` remain
+role-keyed (their ADMIN/MANAGER genuinely differ); fully de-roling those and removing `resolveRole`
+is a separate pending task.
+
 ### Hydration (non-serializable bits)
 
 Keep JSON **serializable** — strings, enums, arrays. No JSX, no functions, no Tailwind classes.
@@ -143,6 +159,12 @@ modal's chrome from the same per-client JSON, not from the component:
   `vendorItemRecordViewFields` are record-modal-layout examples living under `src/layout/.../viewModel/FIELDS/`.
 
 ## Change history
+- 2026-07-01 — De-roled `orderViewFields` from client×role to **client-only**: COMPASS/COMPASSCANADA
+  now read a flat client JSON via `mergeOrderView(...)` in `fieldsConfig/index.ts` (COMPASSCANADA's
+  JSON flattened from byte-identical `{ADMIN,MANAGER}`). Fixed a latent bug where COMPASS's
+  already-flat JSON was read via `.ADMIN` → `undefined` → silent fallback to DEFAULT (lost its
+  `salesOrderDetailsConfig` joins). `approvalViewFields`/`salesOrdersPageFields` stay role-keyed;
+  full de-role + `resolveRole` removal remains pending. Type-check clean. (apeterson)
 - 2026-06-25 — SalesOrder action buttons render by presentation intent: `kind` (icon/text/viewLog) picks the renderer, `variant` a closed color set, `valueKey` is pure click-dispatch; a `componentRegistry` keyed by `kind` hydrates dedicated components (e.g. ViewLogButton). Added the `recordActionFields`-shape gotcha (per-persona blocks + sibling `poNumber` sub-config; walk `actionOptions` only). (apeterson)
 - 2026-06-25 — Extended to record-modal layouts: per-mode `*ViewFields`/`*EditFields` JSON under `src/layout/.../viewModel/FIELDS/`, JSON-driven modal `header` (modalTag/labelTemplate/statusBadge) + `editItem` button gated via the Flag/Rule engine, and the flat-bundle defensive-default gotcha. (apeterson)
 - 2026-06-23 — Documented from the `add-client-fields` skill during initial knowledge seed. (apeterson)

package/knowledge/clients/compass-canada/profile.md

@@ -15,12 +15,13 @@ client: compass-canada
 type: profile
 status: active
 updated: 2026-06-30
-owners: [jcardinal, bala, tcox]
+owners: [jcardinal, bala, tcox, apeterson]
 files: []
 related:
   - ../compass-usa/profile.md
   - ../../2.0/apps/toga2-commerce/features/expedited-shipping-gating.md
   - ../../2.0/apps/_underscore/features/item-fulfillment-stage-lifecycle-and-order-status.md
+  - ../../2.0/apps/_underscore/features/surface-resolver.md
 ---
 
 ## Summary
@@ -50,6 +51,12 @@ to but distinct from Compass USA. Like Compass USA it spans the **2.0** commerce
   see [Config-Driven Expedited Shipping Gating](../../2.0/apps/toga2-commerce/features/expedited-shipping-gating.md).
 
 ## Notes
+- **Surface layer (beta):** like Quad, `Client_CompassCanada` had **no** `AclRecordScripts` dispatch
+  grant for the surfaces `meta-group` script (only `meta`, to client role 1) → `GET /v2/surfaces/meta-group`
+  403'd EZ-1 while `meta` worked. Fixed 2026-07-01 via
+  `dbchanges2/Client_CompassCanada/2026-07-01a - GrantSurfacesMetaGroupScriptAcl.sql` (meta-group →
+  client role 1, id-agnostic + NOT-EXISTS-guarded, beta only). Exposes surfaces to role 1 only, vs
+  Compass USA's 1/3/4. See [Surface Resolver](../../2.0/apps/_underscore/features/surface-resolver.md).
 - Customer language preference: `UserGlobalSettings.settingId = 2` (`en` / `fr-CA`); customer-
   facing emails are sent in EN or FR accordingly.
 - Assortment (product-grouping) names are served in fr-CA via the `AssortmentTranslations` sidecar

package/knowledge/clients/quad/profile.md

@@ -14,11 +14,12 @@ client: quad
 type: profile
 status: active
 updated: 2026-06-30
-owners: ["jcardinal", "bala"]
+owners: ["jcardinal", "bala", "apeterson"]
 files: []
 related:
   - ../../2.0/apps/_underscore/features/tracking-number-bridges.md
   - ../../2.0/apps/_underscore/features/item-fulfillment-stage-lifecycle-and-order-status.md
+  - ../../2.0/apps/_underscore/features/surface-resolver.md
 ---
 
 ## Summary
@@ -48,6 +49,13 @@ Client-specific DB change-sets live in `dbchanges2/Client_Quad/`.
   (`_underscore/Model/Quad/SalesOrder.php`): non-SA orders use the inline machine, `SA%` orders
   delegate to the base `_Model_Client_SalesOrder`. Contrast Compass, which is shipped-only. See
   [IF stage lifecycle & order status](../../2.0/apps/_underscore/features/item-fulfillment-stage-lifecycle-and-order-status.md).
+- **Surface layer (beta):** the surfaces `meta-group` script had **no** `AclRecordScripts` dispatch
+  grant for `Client_Quad` (only `meta` was granted, to client role 1), so `GET /v2/surfaces/meta-group`
+  403'd (EZ-1) while `meta` worked. Fixed 2026-07-01 via
+  `dbchanges2/Client_Quad/2026-07-01a - GrantSurfacesMetaGroupScriptAcl.sql` (grants meta-group to
+  client role 1, id-agnostic + NOT-EXISTS-guarded, beta only). Quad exposes surfaces to role 1 only,
+  vs Compass's 1/3/4 — revisit if broader roles are needed. See
+  [Surface Resolver](../../2.0/apps/_underscore/features/surface-resolver.md).
 - Tracking data: record 318 (item-level) is currently empty for this client; their tracking
   populates the IF/shipment level (record 317, ~98% coverage) and unit level (record 319). The
   rebuilt views use 318 (per the Compass pattern) and will show tracking once item-level

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "toga-ai",
-  "version": "1.0.259",
+  "version": "1.0.260",
   "description": "TOGA Technology Team Claude Knowledge System — shared AI coding harness with skills, knowledge base CLI, and project installer for Claude Code.",
   "keywords": [
     "claude",