toga-ai 1.0.209 → 1.0.210

package/knowledge/2.0/apps/_underscore/INDEX.md

@@ -6,7 +6,7 @@
 | [ACL Permission Chain (Record & Field Authorization)](features/acl-permission-chain.md) | Authorization in the 2.0 API is **metadata-driven**: whether a role may Create/Read/Update/Delete a record is decided by rows across **four linked tables**, not | api2/Component/Api/V2/V2.php, _underscore/Model/Core/Page.php, dbchanges2/Client/2026-06-03- BLANK_CLIENT_DATABASE.sql, dbchanges2/Client/2026-06-23b - ItemTranslationsAcl.sql |
 | [Carrier Shipping Labels (UPS/FedEx) & NetSuite Item Fulfillment](features/carrier-shipping-labels.md) | Backend mechanics behind TOGa Supply's Fulfill & Ship: buying a carrier label (UPS/FedEx), persisting it, and creating the NetSuite Item Fulfillment with tracki | _underscore/Model/Client/ItemFulfillment.php, _underscore/Model/Client/ItemFulfillments/TrackingNumber.php, _underscore/Component/Library/LabelPdf/LabelPdf.php, _underscore/Component/Library/Carriers/Ups/Ups.php, _underscore/Component/Library/Carriers/Fedex/Fedex.php, _underscore/Trait/Netsuite/ItemFulfillment.php, _underscore/Trait/Netsuite/SalesOrder.php, _underscore/Component/Library/NetSuite/NetSuite.php, _underscore/Model/Client/TrackingNumber.php, _underscore/Model/Client/ShippingMethod.php, _underscore/Model.php, _underscore/Cloud.php |
 | [Client Email Template Sending](features/email-template-sending.md) | `_Model_Client_EmailTemplate` sends a stored, client-defined email template by UUID. | _underscore/Model/Client/EmailTemplate.php, _underscore/Model/Client/EmailTemplateOutgoingEmailAddress.php, _underscore/Email.php |
-| [Forecast.Sales NetSuite import engine (real-time webhook)](features/forecast-sale-import.md) | Real-time importer that takes a NetSuite **sale** record and writes its lines into `Forecast.Sales` (the Forecast2 revenue table). | _underscore/Component/Forecast/SaleImport/SaleImport.php, _underscore/Component/Forecast/Db/Db.php, worker2/Worker/Netsuite/Invoice.php, worker2/Worker/Netsuite/CashSale.php, worker2/Worker/Netsuite/CreditMemo.php, worker2/Worker/Netsuite/CashRefund.php, worker2/Worker/Netsuite/Opportunity.php, worker2/Worker/Netsuite/SalesOrder.php |
+| [Forecast.Sales NetSuite import engine (real-time webhook)](features/forecast-sale-import.md) | Real-time importer that takes a NetSuite **sale** record and writes its lines into `Forecast.Sales` (the Forecast2 revenue table). | _underscore/Component/Forecast/SaleImport/SaleImport.php, _underscore/Component/Forecast/Db/Db.php, worker2/Worker/Netsuite/Invoice.php, worker2/Worker/Netsuite/CashSale.php, worker2/Worker/Netsuite/CreditMemo.php, worker2/Worker/Netsuite/CashRefund.php, worker2/Worker/Netsuite/Opportunity.php, worker2/Worker/Netsuite/SalesOrder.php, test/@dave/test_invoice_lifecycle.php, test/@dave/NetSuite/api-message-queue/ue_api_msg_queue_enqueue.js, test/@dave/NetSuite/api-message-queue/dev_ue_api_msg_queue_enqueue.js |
 | [_Model magic-field access (__get without __isset)](features/model-magic-field-access.md) | `_Model` exposes DB columns as "magic" properties via `__get()`, but it defines **no** `__isset()`. | _underscore/Model/Core/Model.php |
 | [NetSuite REST Client (_Component_Api_Netsuite) — record writes & SuiteQL](features/netsuite-rest-client.md) | `_Component_Api_Netsuite` is the **2.0 `_underscore` NetSuite REST client** — the shared primitive every worker2/api2 NetSuite caller uses for record GETs, Suit | _underscore/Component/Api/Netsuite/Netsuite.php |
 | [Per-Client Database Connections & the Local Logs Trap](features/per-client-database-connections.md) | When `_underscore` serves a request for a client it opens **three distinct per-client database connections**, not one. | _underscore/Database.php, _underscore/ApiRequest.php, _underscore/Model/Client/Logs/Api.php |

package/knowledge/2.0/apps/_underscore/features/forecast-sale-import.md

@@ -6,7 +6,7 @@ project: _Underscore
 client: shared
 type: feature
 status: active
-updated: 2026-06-25
+updated: 2026-06-26
 owners: [dfranks]
 files:
   - _underscore/Component/Forecast/SaleImport/SaleImport.php
@@ -17,9 +17,14 @@ files:
   - worker2/Worker/Netsuite/CashRefund.php
   - worker2/Worker/Netsuite/Opportunity.php
   - worker2/Worker/Netsuite/SalesOrder.php
+  - test/@dave/test_invoice_lifecycle.php
+  - test/@dave/NetSuite/api-message-queue/ue_api_msg_queue_enqueue.js
+  - test/@dave/NetSuite/api-message-queue/dev_ue_api_msg_queue_enqueue.js
 related:
   - ../architecture.md
   - ../../worker2/architecture.md
+  - ../../worker2/features/netsuite-salesorder-open-orders-sync.md
+  - ./netsuite-rest-client.md
 ---
 
 ## Summary
@@ -144,7 +149,51 @@ events as specific **subtypes** (`inventoryItem`, `nonInventoryResaleItem`, `kit
 would be needed only for a future real-time item webhook, **not** for this Sales importer
 (which keeps items fresh via the hourly item pull cron plus the inline self-heal).
 
+## Local testing harness (`test/@dave/test_invoice_lifecycle.php`)
+A CLI that boots worker2/_underscore (chdir to `worker2/` then `require index.php`) and drives a
+**full NetSuite invoice lifecycle** through the live `_underscore` REST client
+(`_Component_Api_Netsuite`) to exercise this importer end-to-end against a local Forecast mirror.
+Actions: `check | create | get | update | delete | sync | recent | amq | deployments | locations`.
+
+- **Fixture:** customer **58** ("8 Test Company") + item **103741** ("Test Other Charge for Sale",
+  maps to local `Forecast.Items` id 25), **rate 0** → a **$0 invoice that still yields one Sales
+  row** (the engine does **not** skip a $0 line — revenue `0.00` is written; same as the cron's
+  Sales section). Confirms create→insert, edit→update (tracked-column change-detection), and
+  delete→`removeAll` all land in local `Forecast.Sales`.
+- It carries its **own** `createInvoiceRecord()` that POSTs via `_ApiRequest` and parses the
+  `Location` header with a **correct** regex (delimiter `~`) — a deliberate workaround for the live
+  `_Component_Api_Netsuite::createRecord()` `#`-delimiter bug (see the
+  [REST client doc](./netsuite-rest-client.md)); the framework was **not** edited this session.
+- `amq` action SuiteQLs the AMQ custom record; `deployments` SuiteQLs `scriptdeployment`+`script`
+  to show which enqueuer fires per record type (used to find the dual-deployment trap below).
+
 ## Gotchas / known issues
+- **Testing locally pollutes PROD unless you UNDEPLOY the prod AMQ enqueuer first.** Each sale
+  transaction type has **TWO** NetSuite UE enqueuer deployments: **"AMQ — Enqueuer"**
+  (`customscript_ue_amq_enqueue`, **RELEASED** → posts to **prod** `webhook.togahub.com`) and
+  **"AMQ development script"** (`customscript2619` → ngrok via `DEV_OVERRIDE`/`debugWrap`). A
+  **RELEASED** deployment fires for **all** actors **including the REST/M2M integration user**, so a
+  REST-driven test invoice hits **prod too**. Observed first run: test-invoice edits flowed to prod
+  and a $0 row was written to **prod** `Forecast.Sales` — by the **legacy 5-min pull cron**, NOT the
+  webhook (prod worker2 has no invoice handler deployed yet, so prod `Netsuite/Invoice/*` jobs
+  watchdog-timeout at 300s, `isSuccess=0`). **To isolate a local test, undeploy the prod enqueuer**
+  for the record types under test (invoice/cashSale/cashRefund/creditMemo/journalEntry); the second
+  full create→update→delete run was then cleanly isolated (zero prod `Logs.Webhook`/`Forecast.Sales`
+  for the test id). The **dev** enqueuer's `debugWrap` envelope
+  `{action,parameters:{payload,headers}}` is required because a local worker2 has no
+  `WebhookIngestion` Lambda to wrap the raw body.
+- **No local app logs for debug-path webhooks — verify arrival via the ngrok inspector, and decode
+  the body.** The legacy `{action,parameters}` debug path writes **no** `WorkerJobs`/`Logs.Webhook`
+  locally. Confirm inbound arrival at the ngrok request inspector
+  `http://127.0.0.1:4040/api/requests/http` — but its **raw body is base64**, so decode the body
+  (after the `\r\n\r\n`) before grepping for `internalId`/`eventType`. The inspector buffer is
+  **ephemeral** (rotates/clears) — watch it live while triggering.
+- **Sales create webhook races NetSuite REST read-after-write lag** — the handler GETs the invoice
+  before its line sublist materializes → **0 lines → 0 rows**. Same gotcha as the SalesOrder
+  open-orders sync (see that doc's read-after-write-lag gotcha); it self-heals on the next edit
+  webhook or the daily discrepancy-fix.
+- **Local _underscore boots on PHP 8.0.30 (xampp8)** — the floor enforced in `_underscore.php` is
+  **8.0.0**, not 8.1.
 - **`_Component_*` classes must live under the `_underscore` framework root, never a project
   repo.** The autoloader rejects a `_Component_*`/`_Model_*` loaded from a project path
   (e.g. `./` under worker2) with "namespace … has not been defined" — at **class-load
@@ -154,6 +203,19 @@ would be needed only for a future real-time item webhook, **not** for this Sales
 - The cron's sign handling is not portable here — see Sign convention.
 
 ## Change history
+- 2026-06-26 — **Verified the full create→update→delete webhook lifecycle end-to-end on a local box**
+  (ngrok tunnel → local worker2 → local `Forecast.Sales`), driving a real **$0** NetSuite invoice
+  through create→insert, edit→update (tracked-column change-detection), delete→`removeAll`; confirmed
+  a $0 line is **not** skipped (one revenue-`0.00` row). Built the reusable harness
+  `test/@dave/test_invoice_lifecycle.php` (boots worker2/_underscore, drives the lifecycle via
+  `_Component_Api_Netsuite`; `amq`/`deployments` SuiteQL actions). Recorded durable testing gotchas:
+  the **dual AMQ enqueuer** RELEASED-fires-for-the-REST-user prod-pollution trap (undeploy the prod
+  enqueuer to isolate; prod's $0 row came from the legacy 5-min pull cron, not a prod webhook —
+  prod has no invoice handler so its `Netsuite/Invoice/*` jobs watchdog-timeout `isSuccess=0`); no
+  local app logs on the debug `{action,parameters}` path (verify via the ngrok inspector at
+  `:4040`, body is base64, buffer ephemeral); the Sales create webhook shares the SalesOrder
+  read-after-write line-sublist race; and local _underscore's PHP floor is 8.0.0. No production code
+  change. (dfranks)
 - 2026-06-25 — **Verified `sync()` end-to-end across all four sale types** (prod NS reads, local Forecast
   writes; 40+ records spanning invoice/cashSale/creditMemo/cashRefund): revenue reconciled **to the penny**
   against an independent SuiteQL `SUM(-foreignamount)` oracle on every record; the uniform sign factor held

package/knowledge/2.0/apps/_underscore/features/netsuite-rest-client.md

@@ -57,10 +57,12 @@ through `_ApiRequest` directly (mirroring `send()`'s auth/endpoint/header setup)
 > reads the class-`#` as a premature closing delimiter and the whole pattern **always throws
 > `preg_match(): Unknown modifier ']'`**. This fires *after* the record is already created, so the
 > create succeeds in NetSuite but `createRecord()` raises and the caller never gets the new id —
-> it breaks the entire outbound create/push path. **Fix direction:** change the delimiter so `#`
+> it breaks the entire outbound create/push path **for any record type** (observed on `journalentry`
+> and again on `invoice` create). **Fix direction:** change the delimiter so `#`
 > isn't both delimiter and class member, e.g. `~/(\d+)(?:[?#]|$)~`. Interim workaround used in
-> probes: recover the new id by regex-parsing the thrown exception message (the `Location` value
-> is in it). Confirmed live 2026-06-25.
+> probes and in `test/@dave/test_invoice_lifecycle.php`: parse the new internalId off the `Location`
+> value carried in the thrown exception message (the lifecycle harness ships its own correct
+> `~`-delimited parse to sidestep this without editing the framework). Confirmed live 2026-06-26.
 
 ### Update — reuse `send('PATCH', $route, $body)`
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "toga-ai",
-  "version": "1.0.209",
+  "version": "1.0.210",
   "description": "TOGA Technology Team Claude Knowledge System — shared AI coding harness with skills, knowledge base CLI, and project installer for Claude Code.",
   "keywords": [
     "claude",