toga-ai 1.0.203 → 1.0.204

package/knowledge/2.0/apps/toga25-supply/INDEX.md

@@ -4,7 +4,7 @@
 |-----|---------|-------|
 | [TOGa 2.5 Supply — Architecture](architecture.md) | `toga25-supply` ("TOGa 2.5 Supply") is the **React/TypeScript frontend** for the 2.0 Supply application — an iteration and improvement of `toga2-supply`. | toga25-supply/src/main.tsx, toga25-supply/src/App.tsx, toga25-supply/src/routes.tsx, toga25-supply/src/fieldsConfig/index.ts, toga25-supply/src/fieldsConfig/useClientFields.ts, toga25-supply/src/layout/, toga25-supply/src/pages/, toga25-supply/src/hooks/useTableCellInteractions.ts |
 | [Action-Button Rule Engine (Flag / Rule grammar)](features/action-button-rule-engine.md) | A declarative, fully config-driven rule engine that resolves the boolean-ish flags (`isEnabled`, `isVisible`, `isComplete`) on SalesOrder action-button options. | toga25-supply/src/pages/SalesOrders/helpers/evaluateEnableRule.ts, toga25-supply/src/pages/SalesOrders/helpers/buildPatchedTenantFields.ts, toga25-supply/src/pages/SalesOrders/view/SalesOrderRecordModalLayout/viewModel/useSalesOrderRecordModalLayoutModel.tsx, toga25-supply/src/pages/SalesOrders/view/SalesOrderApprovalModalsLayout/viewModel/useApprovalModalViewModel.tsx |
-| [Client-Configurable Fields (useClientFields / fieldsConfig)](features/client-configurable-fields.md) | The mechanism for config that **varies by client** (or client × role) — field overrides, filter buttons, group-by options, column pickers, layout toggles — with | toga25-supply/src/fieldsConfig/index.ts, toga25-supply/src/fieldsConfig/useClientFields.ts, toga25-supply/src/pages/SalesOrders/viewModel/FIELDS/, toga25-supply/src/pages/Inventory/viewModel/FIELDS/, toga25-supply/src/pages/Inventory/README.md, toga25-supply/src/layout/ItemRecordModalLayout/viewModel/FIELDS/, toga25-supply/src/layout/VendorItemRecordModalLayout/viewModel/FIELDS/ |
+| [Client-Configurable Fields (useClientFields / fieldsConfig)](features/client-configurable-fields.md) | The mechanism for config that **varies by client** (or client × role) — field overrides, filter buttons, group-by options, column pickers, layout toggles — with | toga25-supply/src/fieldsConfig/index.ts, toga25-supply/src/fieldsConfig/useClientFields.ts, toga25-supply/src/pages/SalesOrders/viewModel/FIELDS/, toga25-supply/src/pages/Inventory/viewModel/FIELDS/, toga25-supply/src/pages/Inventory/README.md, toga25-supply/src/layout/ItemRecordModalLayout/viewModel/FIELDS/, toga25-supply/src/layout/VendorItemRecordModalLayout/viewModel/FIELDS/, toga25-supply/src/pages/SalesOrders/view/SalesOrderRecordModalLayout/view/sections/SalesOrderTopBar.tsx, toga25-supply/src/pages/SalesOrders/view/SalesOrderRecordModalLayout/viewModel/FIELDS/ |
 | [Column Visibility (URL-driven show/hide columns)](features/column-visibility.md) | A "Columns" header button that opens a modal listing every column from the table meta, lets the user show/hide columns, adjusts the table live, and persists the | toga25-supply/src/components/ColumnVisibilityModal/, toga25-supply/src/pages/SalesOrders/SalesOrders.tsx, toga25-supply/src/pages/SalesOrders/viewModel/useSalesOrdersPageViewModel.tsx, toga25-supply/src/pages/SalesOrders/hooks/useSalesOrdersTableData.tsx |
 | [Meta-Driven Page & Table Setup](features/meta-driven-table-data.md) | A page in this app is **meta-driven end to end**: the page view model fetches *page meta* (labels, sections, ACL) and *table meta* (the columns/fields + table s | toga25-supply/src/pages/SalesOrders/viewModel/useSalesOrdersPageViewModel.tsx, toga25-supply/src/pages/SalesOrders/hooks/useSalesOrdersTableState.ts, toga25-supply/src/hooks/useTablePageMeta.ts, toga-blox-npm/dist/hooks/useFetchPageMeta.d.ts, toga-blox-npm/dist/hooks/useFetchTablePageMeta.d.ts, toga-blox-npm/dist/hooks/useAssignTableFieldLabels.d.ts, toga-blox-npm/dist/components/Table/hooks/useTableData.d.ts |
 | [Record Modals & Nested Tables](features/record-modals-and-nested-tables.md) | The repo's family of modal + nested-table patterns layered over toga-blox `TableRecordModal` and `PrimaryTable*Layout`. | toga25-supply/src/layout/ItemRecordModalLayout/, toga25-supply/src/layout/SalesOrderRecordModalLayout/, toga25-supply/src/layout/SalesOrderItemsTableLayout/, toga25-supply/src/layout/ItemFulfillmentModal/, toga25-supply/src/layout/GenericNestedTables/, toga25-supply/src/hooks/useTableCellInteractions.ts |

package/knowledge/2.0/apps/toga25-supply/features/client-configurable-fields.md

@@ -16,6 +16,8 @@ files:
   - toga25-supply/src/pages/Inventory/README.md
   - toga25-supply/src/layout/ItemRecordModalLayout/viewModel/FIELDS/
   - toga25-supply/src/layout/VendorItemRecordModalLayout/viewModel/FIELDS/
+  - toga25-supply/src/pages/SalesOrders/view/SalesOrderRecordModalLayout/view/sections/SalesOrderTopBar.tsx
+  - toga25-supply/src/pages/SalesOrders/view/SalesOrderRecordModalLayout/viewModel/FIELDS/
 related:
   - ../architecture.md
   - column-visibility.md
@@ -70,6 +72,29 @@ registry that maps enum → real value (e.g. `MODAL_RENDERERS: Record<ModalKey,
 This is the one place app-owned JSX is grafted back onto client-authored config. Clients never
 author JSX.
 
+### Presentation intent: `kind` / `variant` (SalesOrder action buttons)
+
+SalesOrder record-modal action buttons (`recordActionFields.actionOptions[]`, rendered by
+`SalesOrderTopBar.tsx`) split **presentation** from **identity** so rendering is config-driven,
+not branch-on-`valueKey`:
+
+- **`kind`** chooses the renderer: `"icon"` (generic icon button), `"text"` (pill), or a
+  registry key like `"viewLog"` that maps to a dedicated component.
+- **`variant`** chooses color from a **closed set** — `approve` / `deny` / `approvalWorkflow` /
+  `neutral` — via a `variantClass` lookup. Keying on this small vocabulary (not on each business
+  key) is what makes it scale.
+- **`valueKey`** is decoupled: it is **only** the click-dispatch identity (`onActionClick(valueKey)`),
+  never a rendering switch. A new button reusing an existing `kind` + `variant` is **config-only** —
+  no edit to `SalesOrderTopBar.tsx`.
+
+A `componentRegistry: Record<kind, (opt) => ReactNode>` in `SalesOrderTopBar` is the hydration
+point for **whole components**: `const renderSpecial = componentRegistry[opt.kind]; if (renderSpecial)
+return renderSpecial(opt);` short-circuits the generic icon/text branches to render a dedicated
+component (e.g. `viewLog` → `<ViewLogButton label onOpenLog={onOpenLog} />`), with the handler wired
+in one place. Same enum→non-serializable boundary as `MODAL_RENDERERS`, applied to components — keep
+runtime-only signals (e.g. PO-complete) gated by config presence (`!!opt.completedLabel`) rather than
+by `valueKey`.
+
 ### Record-modal header & action config
 
 Record-modal layouts (`ItemRecordModalLayout`, `VendorItemRecordModalLayout`) now drive the
@@ -108,11 +133,17 @@ modal's chrome from the same per-client JSON, not from the component:
   `fieldsConfig/index.ts`, derive the default defensively rather than assuming the wrapper exists:
   `const DEFAULT_ORDER_VIEW_FIELDS = (defaultBundle as any).DEFAULT ?? (defaultBundle as any) ?? {};`
   — fall through to the bundle itself, then `{}`, so a flat JSON file does not resolve to `undefined`.
+- **`recordActionFields` shape.** A client `orderViewFields.json` can hold **multiple per-persona
+  `recordActionFields` blocks**, plus a sibling `recordActionFields.poNumber` object that configures
+  the Enter-PO modal fields — its nested `valueKey`s are **not** action buttons. `DEFAULT/orderViewFields.json`
+  has no `recordActionFields` at all. Any tooling that walks action buttons must scope strictly to the
+  `actionOptions` array.
 - Worked examples: `salesOrdersPageFields` (client × role) and `inventoryGroupings` (client-only +
   hydration; full write-up in `src/pages/Inventory/README.md`); `itemRecordViewFields` /
   `vendorItemRecordViewFields` are record-modal-layout examples living under `src/layout/.../viewModel/FIELDS/`.
 
 ## Change history
+- 2026-06-25 — SalesOrder action buttons render by presentation intent: `kind` (icon/text/viewLog) picks the renderer, `variant` a closed color set, `valueKey` is pure click-dispatch; a `componentRegistry` keyed by `kind` hydrates dedicated components (e.g. ViewLogButton). Added the `recordActionFields`-shape gotcha (per-persona blocks + sibling `poNumber` sub-config; walk `actionOptions` only). (apeterson)
 - 2026-06-25 — Extended to record-modal layouts: per-mode `*ViewFields`/`*EditFields` JSON under `src/layout/.../viewModel/FIELDS/`, JSON-driven modal `header` (modalTag/labelTemplate/statusBadge) + `editItem` button gated via the Flag/Rule engine, and the flat-bundle defensive-default gotcha. (apeterson)
 - 2026-06-23 — Documented from the `add-client-fields` skill during initial knowledge seed. (apeterson)
 - 2026-06-25 — Client field JSON also lives under `src/layout/<Modal>/viewModel/FIELDS/<CLIENT>/`

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "toga-ai",
-  "version": "1.0.203",
+  "version": "1.0.204",
   "description": "TOGA Technology Team Claude Knowledge System — shared AI coding harness with skills, knowledge base CLI, and project installer for Claude Code.",
   "keywords": [
     "claude",