toga-ai 1.0.164 → 1.0.165

package/knowledge/2.0/apps/worker2/features/netsuite-opportunity-sync.md

@@ -274,6 +274,26 @@ None — platform-wide Forecast sync.
     **add-only** on update (we don't read the prior assignee to remove it).
   - **Null guard:** the Presales Lead users field is omitted when the email has no matching ClickUp
     user — a `null` in the `add` array is a 400 from ClickUp.
+- **External/non-roster presales leads create a task with a BLANK "Presales Lead" user field — silently.**
+  The creation gate (`maybeCreateClickupTask`) tests the **email** (`$body->presalesLead === ''`), not a
+  resolved ClickUp user — so any opportunity whose `custbody_ctc_solution_architect` resolves to a non-empty
+  email **passes the gate and the task is created**. But `createTask()` then calls `resolvePresalesUserId()`
+  (cache → ClickUp team-roster scan by email), and `buildCustomFields()` **omits** the Presales Lead *users*
+  field whenever that returns `null` (a `null` in the `add` array is a 400 — see the Null-guard note above).
+  Result: the task has **"Presales Email" (text) populated but "Presales Lead" (users) empty**. This is a
+  **data/config gap, not a bug** — the integration assumes a presales lead is an internal ClickUp member.
+  When the NetSuite presales lead is an **external/partner employee** whose email domain has **no ClickUp
+  account** (confirmed live 2026-06-23: opps 54983/71879/71955/72024 with `@asisystem.com` leads Juan Acosta
+  / Peter Violini — **zero** `asisystem.com` members in the 72-person workspace), the user field is always
+  blank. **It does not self-heal:** `UPDATE_CLICKUP = false` means a later NetSuite edit never back-fills the
+  field, and the users field is add-only on update anyway — so onboarding the person into ClickUp later
+  requires a one-time backfill of the existing tasks. Diagnostic signature when triaging a "no presales lead"
+  report: NS **has** the lead set, the ClickUp task's **Presales Email is set** but **Presales Lead user is
+  empty**, and `creator` = the worker2 `[clickup] token` owner (`jcardinal@togatech.com`) — which also rules
+  out the NetSuite-side `OPP <id>` stub path (those are unnamed, empty-field tasks) and the legacy `webhook/`
+  copy (token `dfranks@togatech.com`). Read-only triage probe: `test/@dave/probe_presales_missing.php`
+  (maps opp# → internalId, reads `custbody_ctc_solution_architect`, resolves the email, and prints the gate
+  decision the worker would make). There is currently **no log/alert** when the email fails to resolve.
 - **Backfill legacy `Opportunity #` with `test/@dave/clickup/backfill_opportunity_numbers.php`.**
   Parses the opportunity number from the task title (the leading integer before the separator) and
   writes it to the `Opportunity #` field, **never overwriting** a set value. Two legacy title
@@ -317,6 +337,12 @@ same **skip-if-unchanged** compare on the extracted values, and **actor-identity
 trigger a CU→NS write. The NS→CU change-detection above is the complementary backstop, not a substitute.
 
 ## Change history
+- 2026-06-23 — **Root-caused "ClickUp opportunity tasks with no Presales Lead."** NetSuite HAD the lead set
+  on all four reported opps; the ClickUp Presales Lead *user* field was blank because the leads are external
+  (`@asisystem.com`) employees with no ClickUp account, so `resolvePresalesUserId()` returns null and
+  `buildCustomFields()` omits the users field (Presales Email text is still set). Not a code bug — the gate
+  keys on email presence, not user resolution. Added the "external/non-roster presales lead" gotcha + the
+  triage signature, and a read-only probe `test/@dave/probe_presales_missing.php`. (dfranks)
 - 2026-06-18 — Documented two NetSuite-client gotchas: **two `_Component_Api_Netsuite` copies** (worker2
   uses the global `_underscore` one; api2 has a separate `namespace api` copy — edit the right one), and
   `send()`'s `setLogging(false)` means **NetSuite calls aren't logged to `Logs.Api`** (no historical

package/knowledge/INDEX.md

@@ -4,7 +4,7 @@ _Auto-generated by `knowledge.js index`. Do not hand-edit._
 
 ## 1.0 framework
 
-- **library** (Library) _(framework core)_ — 7 doc(s) → [1.0/apps/library/INDEX.md](1.0/apps/library/INDEX.md)
+- **library** (Library) _(framework core)_ — 8 doc(s) → [1.0/apps/library/INDEX.md](1.0/apps/library/INDEX.md)
 - **worker** (Worker) — 10 doc(s) → [1.0/apps/worker/INDEX.md](1.0/apps/worker/INDEX.md)
 - **togadesk** (TOGa Desk) — 7 doc(s) → [1.0/apps/togadesk/INDEX.md](1.0/apps/togadesk/INDEX.md)
 - **togaview** (TOGa View) — 6 doc(s) → [1.0/apps/togaview/INDEX.md](1.0/apps/togaview/INDEX.md)

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "toga-ai",
-  "version": "1.0.164",
+  "version": "1.0.165",
   "description": "TOGA Technology Team Claude Knowledge System — shared AI coding harness with skills, knowledge base CLI, and project installer for Claude Code.",
   "keywords": [
     "claude",