toga-ai 1.0.129 → 1.0.130

package/knowledge/clients/compass-usa/INDEX.md

@@ -2,7 +2,7 @@
 
 | Doc | Framework | Summary | Files |
 |-----|-----------|---------|-------|
-| [Compass ASN → ItemFulfillment Auto-Creation](features/asn-to-item-fulfillment.md) | 2.0 | For Compass USA, posting an AdvanceShippingNotice (ASN) auto-creates the ItemFulfillment (IF) on the upstream SalesOrder. | _underscore/Model/Compass/AdvanceShippingNotice.php, _underscore/Model/Compass/PurchaseOrder.php, api2/Component/Api/Cxml/Cxml.php, dbchanges2/Client_Compass/2026-06-11 - AsnItemTrackingNumberAcl.sql, dbchanges2/Client_Compass/2026-06-15b - BackfillSA132781ItemFulfillmentTracking.sql, dbchanges2/Client_Compass/2026-06-16 - CleanupSA132763CrossLineTracking.sql, dbchanges2/Client_Compass/2026-06-16b - CleanupSA132743CrossLineTracking.sql, dbchanges2/Client_Compass/2026-06-16c - BackfillSA132763C40QYUCTracking.sql |
+| [Compass ASN → ItemFulfillment Auto-Creation](features/asn-to-item-fulfillment.md) | 2.0 | For Compass USA, posting an AdvanceShippingNotice (ASN) auto-creates the ItemFulfillment (IF) on the upstream SalesOrder. | _underscore/Model/Compass/AdvanceShippingNotice.php, _underscore/Model/Compass/PurchaseOrder.php, api2/Component/Api/Cxml/Cxml.php, dbchanges2/Client_Compass/2026-06-11 - AsnItemTrackingNumberAcl.sql, dbchanges2/Client_Compass/2026-06-15b - BackfillSA132781ItemFulfillmentTracking.sql, dbchanges2/Client_Compass/2026-06-16 - CleanupSA132763CrossLineTracking.sql, dbchanges2/Client_Compass/2026-06-16b - CleanupSA132743CrossLineTracking.sql, dbchanges2/Client_Compass/2026-06-16c - BackfillSA132763C40QYUCTracking.sql, dbchanges2/Client_Compass/2026-06-18a - CleanupSA132898DuplicateTracking.sql |
 | [Compass: Item-Fulfillment TableViews (for-sales-order-items & for-sales-orders, tracking via bridge)](features/item-fulfillment-tracking-tableview.md) | 2.0 | Two sibling Compass TableViews in `Client_Compass` display fulfilled items in toga2-supply, both driven by `TableViews` / `TableViewJoins` / `TableViewFields` c | dbchanges2/Client_Compass/2026-06-10 - ItemFulfillmentsForSalesOrderItemsTableView.sql, dbchanges2/Client_Compass/2026-06-11 - ItemFulfillmentsForSalesOrdersTableView.sql, dbchanges2/Client_Compass/2026-06-15a - FixItemFulfillmentTrackingNumberJoins.sql |
 | [Compass MITS PO → SO Item Linking](features/mits-po-to-so-item-linking.md) | 2.0 | MITS sends Compass inbound Purchase Orders (`POST /v2/purchase-orders`) against a Sales Order (`mitsSalesOrder`). | _underscore/Model/Compass/PurchaseOrder.php, worker/crons/toga2/compass/workflow/3a_import_office_depot_purchase_orders.php |
 | [Compass USA](profile.md) | 2.0 | Compass USA is a TOGA client running a multi-tier supply-chain commerce operation. |  |

package/knowledge/clients/compass-usa/features/asn-to-item-fulfillment.md

@@ -5,7 +5,7 @@ project: _Underscore
 client: compass-usa
 type: client-feature
 status: active
-updated: 2026-06-16
+updated: 2026-06-18
 owners: [jcardinal]
 files:
   - _underscore/Model/Compass/AdvanceShippingNotice.php
@@ -16,6 +16,7 @@ files:
   - dbchanges2/Client_Compass/2026-06-16 - CleanupSA132763CrossLineTracking.sql
   - dbchanges2/Client_Compass/2026-06-16b - CleanupSA132743CrossLineTracking.sql
   - dbchanges2/Client_Compass/2026-06-16c - BackfillSA132763C40QYUCTracking.sql
+  - dbchanges2/Client_Compass/2026-06-18a - CleanupSA132898DuplicateTracking.sql
 related:
   - ../../../2.0/apps/_underscore/features/recursive-item-fulfillments.md
 ---
@@ -54,6 +55,11 @@ the gotcha about already-fulfilled orders). Flow:
    - **`remaining <= 0`** (reconcile path, new): the tracking targets are the **existing IFIs**
      for that SOI (resolved via `ItemFulfillmentItems.salesOrderItemId` → their `itemFulfillmentId`),
      **not** an SO-number lookup — NetSuite/toga2-supply IFs are `F`-numbered, not SO-numbered.
+     As of **2026-06-18** an existing IFI that **already carries item-level tracking is skipped**
+     here (`itemFulfillmentItemHasTracking()`): reconcile only attaches onto untracked
+     out-of-band IFIs. An already-tracked, fully-fulfilled line revisited by a later ASN is a
+     vendor re-transmission and must not gain a second tracking number (see the duplicate-tracking
+     gotcha).
 4. Copy the ASN item's tracking (`AdvanceShippingNoticeItems_TrackingNumbers`) onto each target
    IFI via `POST /item-fulfillment-item-tracking-numbers` → `ItemFulfillmentItems_TrackingNumbers`
    — **idempotent** (skipped if the bridge row already exists; ASNs get re-POSTed).
@@ -176,8 +182,29 @@ Compass Canada (`Model/Compass/Canada/`) is a separate sub-client. The Compass c
   `NOT EXISTS`. ~116 PO items across other Compass orders share the off-by-one fingerprint and
   are not yet repaired — a broader reviewed backfill is still outstanding.
 
+- **Duplicate tracking from vendor ASN re-transmission (root cause, fixed forward 2026-06-18)
+  — DISTINCT from the cross-line contamination above.** Compass vendors (Office Depot, Strategic
+  Systems) re-send the **same** shipment ASN file for several days; one PO can receive many ASNs
+  (e.g. SA132898 / PO `50305272-1` got 6). The first ASN takes the create path and attaches its
+  tracking; a later ASN re-listing the same, now fully-fulfilled line takes the **reconcile path**
+  and — pre-fix — attached its *different* tracking number onto the existing IFI. On a qty-1 line
+  this yields two item-level tracking rows (plus a propagated package row). Unlike the cross-line
+  bug, **both** tracking numbers here map cleanly to the correct line via their own valid ASN
+  items, so the `NOT EXISTS (ASN item with matching VendorItems.itemId)` cleanup guard does **not**
+  catch it — diagnose instead by an IFI carrying more item-level tracking numbers than its
+  fulfilled quantity. Fix: the reconcile path now skips any IFI that already has item-level
+  tracking (`itemFulfillmentItemHasTracking()`), so only untracked out-of-band IFIs receive ASN
+  tracking. The legitimate out-of-band case (IFI has no tracking, one ASN arrives) is preserved.
+  Forward-only; SA132898 repaired by `2026-06-18a` (delete the later tracking + orphaned package
+  row, keep the original; no backfill needed since the correct number is already present).
+
 ## Change history
 Dated one-liners, newest first.
+- 2026-06-18 — Reconcile path now skips IFIs that already carry item-level tracking
+  (`itemFulfillmentItemHasTracking()`), stopping duplicate/different tracking numbers from
+  vendor ASN re-transmissions piling onto fully-fulfilled lines (qty-1 SA132898 / USB31CC1 had
+  2). Distinct root cause from the 2026-06-16 cross-line contamination. SA132898 repaired by
+  `2026-06-18a` (cleanup-only; original tracking already correct). (jcardinal)
 - 2026-06-16 — Identified cross-line tracking contamination root cause: bad
   `SalesOrderItems_PurchaseOrderItems` rows (PO-local lineNumber collision in
   `_Model_Compass_PurchaseOrder`, fixed forward 2026-06-11 `ec935478`; and the worker ODP-PO

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "toga-ai",
-  "version": "1.0.129",
+  "version": "1.0.130",
   "description": "TOGA Technology Team Claude Knowledge System — shared AI coding harness with skills, knowledge base CLI, and project installer for Claude Code.",
   "keywords": [
     "claude",