toga-ai 1.0.1149 → 1.0.1150

package/knowledge/2.0/apps/api2/features/v2-api-error-codes.md

@@ -6,7 +6,7 @@ project: API
 client: shared
 type: feature
 status: active
-updated: 2026-10-24
+updated: 2026-10-26
 owners: [mhammontree, tcox, jcardinal, ajean, bala, apeterson]
 files:
   - api2/Component/Api/V2/V2.php
@@ -145,6 +145,9 @@ This applies to `api2/Controller/Index.php` and to any `catch (_Exception_Valida
 - **⚠ 200 + `isSuccess: true` is not a write receipt** — a DB failure can ride along as an ERROR entry
   in `messages[]` (cause in `messages[].identifiers.error`). Scan `messages[]` for `type: ERROR`; a
   front end that trusts the status shows a false "saved".
+- **⚠ Warning `WZ-2` on a write = NOTHING was written.** The role may write none of the fields sent,
+  yet the response is 2xx. Treat an exact `WZ-2` code as a failed write (toga25-supply:
+  `src/utils/apiWriteResult.ts`).
 - **A 400 from an interceptor rule has a generic top-level message ("Operation Failed…").** The rule's
   own text is in `messages[].identifiers.message`. Front ends must show that one (Desk:
   `readApiRefusalMessage` in `src/api/recordApi.ts`), never the top-level text.
@@ -152,6 +155,7 @@ This applies to `api2/Controller/Index.php` and to any `catch (_Exception_Valida
 - **`c_` prefix is significant** — a mis-prefixed field name rejects the whole write with EV-12; verify native-vs-custom with `SHOW COLUMNS`.
 
 ## Change history
+- 2026-10-26 — Gotcha: a 2xx write with warning `WZ-2` wrote nothing (TRUE-83079). (tcox)
 - 2026-10-24 — Interceptor 400: the rule text is in `messages[].identifiers.message`, top-level message is generic (TRUE-82916). (jcardinal)
 - 2026-10-01 — Added note 17: a 200 / `isSuccess: true` envelope can still carry an ERROR entry in
   `messages[]` (DB cause in `messages[].identifiers.error`), so axios/blox never throws and a front end

package/knowledge/2.0/apps/toga-blox/features/api-client.md

@@ -6,7 +6,7 @@ project: TOGa Blox
 client: shared
 type: feature
 status: active
-updated: 2026-10-20
+updated: 2026-10-26
 owners: [apeterson, tcox]
 files:
   - toga-blox/src/reactQuery/queryHelpers.ts
@@ -59,6 +59,7 @@ blox axios/React-Query client — envelope, auth (Bearer + refresh), option seri
 ## Gotchas
 
 - **Must `setAxiosInstance` before use** — otherwise every call throws.
+- **⚠ `apiDelete` uses `validateStatus: status < 500`, so a 4xx delete RESOLVES** — the caller shows a false "deleted" toast. `apiPut`/`apiPost` do throw on 4xx. Check the envelope yourself (toga25-supply: `assertApiWriteSucceeded`, see [loading & save-error states](../../toga25-supply/features/loading-and-error-states.md)). Not fixed in blox (legacy, fixes-only).
 - Always check `response.isSuccess` before reading `data`; `data` keys are **camelCased slugs** (`/sales-orders` → `data.salesOrders`).
 - `TableViewField.slug` (URL-safe) ≠ `tableViewField` (DB column path); `getDataTableData` maps slug → DB field.
 - Only **401** auto-retries; other network errors need React Query `retry`.
@@ -92,4 +93,5 @@ blox axios/React-Query client — envelope, auth (Bearer + refresh), option seri
 
 ## Change history
 
+- 2026-10-26 — Gotcha: `apiDelete` resolves on 4xx (false success) (TRUE-83079) (tcox).
 - 2026-10-20 — Gotcha: axios-only refresh; raw `fetch` callers must refresh themselves (TRUE-82954) (tcox).

package/knowledge/2.0/apps/toga-blox/features/table.md

@@ -6,7 +6,7 @@ project: TOGa Blox
 client: shared
 type: feature
 status: active
-updated: 2026-10-05
+updated: 2026-10-26
 owners: [apeterson, tcox, bala]
 files:
   - toga-blox/src/components/Table/hooks/useFetchTablePageMeta.ts
@@ -133,6 +133,7 @@ This exists because an unscoped `GET /{recordRoute}` returns *every* row of a lo
 - **`isExpandableCell` still clobbers every other rich cell type.** Only `STATUS`/`STATUS_BADGE` are protected today. `URGENCY`, `BOOLEAN`, `CURRENCY`, `DATE`, `AVATAR` and `CLIENT` carry the **same latent defect** — set the flag on one of those fields and the cell degrades to raw truncated text. The fuller fix is inverting the deny-list into an **allowlist** (expandable only for free-text/default cells); deliberately not done yet.
 - **A cell-rendering difference between local and a deployed environment is usually DB data, not code.** `isExpandableCell` is a per-field flag in the **server's table meta**, so the same blox build renders differently against two databases. Diff the branches over the cell-rendering files **first** (`git diff <feature> origin/_sandbox-client -- src/components/Table/...`); if that comes back empty, stop reading code and go look at the table-meta rows.
 - **An action cell with no `onAction` used to be DEAD — the chevron is now a real button (2026-09-21).** `ChevronActionCell` rendered a `<div>` whose `onClick` called `onAction?.(row)`, and no consumer ever supplied `onAction` (toga25-supply's `chevronOnly` column sets only id/position/width/type), so the expand chevron was an indicator that did nothing. Tell-tale: the CSS already carried a `.chevronCell:disabled` rule, which can never match a `div`. It is now a `<button>` with `aria-expanded`, `aria-label` (new `expandLabel`/`collapseLabel` props, defaults "Expand row"/"Collapse row"), `disabled` and `stopPropagation`; `ActionCellContext` gained `onRowClick` so a column with no `onAction` falls back to toggling its own row. **That fallback is deliberately scoped to `type === "CHEVRON"`** — applying it to every action-cell type would make e.g. a `DOWNLOAD` column with no `onAction` start firing the row click. A button also needs an explicit CSS reset (`padding: 0; font: inherit`) plus a `:focus-visible` outline. Shipped in `1.1.10-sandbox-client.170`.
+- **⚠ Pin EVERY trailing action column sticky `"right"` — a non-sticky one breaks the column lines.** blox drops the right border of the column just before the **first** action column (`utils/isBeforeActionColumn` → `.beforeActionColumn { border-right: none }`), expecting that action column to be sticky and draw its own edge line; only the **first** right-sticky column draws that edge line (`utils/isEdgeStickyColumn`). So a non-sticky CUSTOM action column placed before a sticky one shows **no line on its left** and a **doubled (thick) line on its right**. Fix in the app: pin all trailing action columns `sticky: "right"`; `getStickyOffsets` stacks the right offsets. Seen in `@agilant/toga-blox` `1.1.4-production.196`, toga25-supply bundle line table (TRUE-83079).
 - `MIN_COLUMN_WIDTH = 120` is the shrink floor only for columns with **no** explicit width.
 - **Never truncate header labels.** `truncateCells` (`.truncateCells .headerCellLabel` in `toga.module.css`) is for **body** values only; it must apply only `white-space: nowrap` to the header (no `overflow:hidden`/`text-overflow:ellipsis`/wrapping) or headers show ellipses. Headers must render in full on one line, never abbreviated, never overlapping.
 - The filter `includes` mode treats comma-separated values as OR.
@@ -144,6 +145,7 @@ This exists because an unscoped `GET /{recordRoute}` returns *every* row of a lo
 - **Table/surface meta is cached with `Infinity` staleTime/gcTime** (`useFetchTablePageMeta`), so after a DB metadata change (`TableViewFields`, `Core.RecordFields`) a **hard reload** is required to see it. And the app consumes toga-blox's built **`dist/`**, not `src/` — editing blox source requires `npm run build` before it takes effect at runtime.
 
 ## Change history
+- 2026-10-26 — Gotcha: a non-sticky action column before a sticky one loses its left line and doubles its right line (TRUE-83079) (tcox)
 - 2026-10-05 — Storybook verify gotcha: blox's Storybook has no host tokens, components render unstyled (tcox)
 - 2026-09-28 — multi-select filter "Clear" now actually clears (calls `onClear`, page-1 guard); sort badge now points down for `desc` via CSS rotation (apeterson)
 

package/knowledge/2.0/apps/toga25-supply/INDEX.md

@@ -5,6 +5,7 @@
 | [TOGa 2.5 Supply — Architecture](architecture.md) | Architecture of toga25-supply — the React/TS Vite SPA frontend for 2.0 Supply, multi-client + meta-driven, built on `@agilant/toga-blox`; open before any struct |
 | [Action-Button Rule Engine (Flag / Rule grammar)](features/action-button-rule-engine.md) | Declarative config-driven Flag/Rule grammar that resolves `isEnabled`/`isVisible`/`isComplete` on SalesOrder action-button options and approval stage inputs (ev |
 | [Bundle item pricing (unit / lease rows, edit save path, duplicate rows)](features/bundle-item-pricing.md) | How a bundle item's unit/lease price is read, displayed and SAVED in supply — the two-call save (never nest the price in a PUT), `_unitPrice`/`_leasePrice` + `c |
+| [Retiring a kit line (bundle item Active toggle, Status column — never delete)](features/bundle-item-retire.md) | How Supply admins retire a kit (bundle) line — Active toggle in the line editor, trash button = retire behind a confirm, Inactive badge in the Status column; op |
 | [Client API-Fetch Fields (useClientApiFields / apiFields.json)](features/client-api-fetch-fields.md) | Resolves a client's API-fetch projection (`fields`/`ojoin`/`join`/`where`) from one colocated per-page `apiFields.json` keyed by client slug (useClientApiFields |
 | [Client-Configurable Fields (useClientFields / fieldsConfig)](features/client-configurable-fields.md) | Config that varies by client (or client × role) — field overrides, filter buttons, group-by, column pickers, layout toggles — resolved through `src/fieldsConfig |
 | [Column State (URL-driven show/hide, order & pinning)](features/column-visibility.md) | URL-driven "Columns" button + modal (`cols` param) for show/hide + order + pinning of table columns, client-configurable then Surface-driven; open for column-vi |

package/knowledge/2.0/apps/toga25-supply/features/bundle-item-pricing.md

@@ -6,8 +6,8 @@ project: TOGa 2.5 Supply
 client: shared
 type: feature
 status: active
-updated: 2026-10-06
-owners: ["apeterson", "bala"]
+updated: 2026-10-26
+owners: ["apeterson", "bala", "tcox"]
 files:
   - toga25-supply/src/layout/BundleItemRecordModalLayout/hooks/useBundleItemEditForm.tsx
   - toga25-supply/src/layout/BundleRecordModalLayout/types.ts
@@ -24,6 +24,7 @@ related:
   - ../../api2/features/v2-api-error-codes.md
   - ./record-modals-and-nested-tables.md
   - ../../../clients/compass-usa/workflows/changing-a-kit-line-item.md
+  - ./bundle-item-retire.md
 ---
 
 How a bundle item's unit/lease price is read, displayed and SAVED in supply — the two-call save (never nest the price in a PUT), `_unitPrice`/`_leasePrice` + `calcDepth: 2`, and the duplicate `BundleItemPrices` rows.
@@ -114,7 +115,8 @@ established it **creates a new row** rather than overwriting an unknown one. Nev
 - **⚠ A failed price save can report SUCCESS.** api2 returned `status: 200` / `isSuccess: true` while
   carrying the `EV-10` DB failure inside `messages[].identifiers.error`, so blox `apiPut` did not throw
   and the modal showed "Bundle item updated" on a write that never landed. Check `messages[]` for
-  `type: ERROR` — see [V2 error codes](../../api2/features/v2-api-error-codes.md).
+  `type: ERROR` — see [V2 error codes](../../api2/features/v2-api-error-codes.md). The bundle line
+  save now runs `assertApiWriteSucceeded` ([save-error handling](./loading-and-error-states.md)).
 - **⚠ A kit price change does NOT reprice orders (Compass/Canada).** A price edit inserts a new
   `BundleItemPrices` row; commerce reads the newest, but `SalesOrderItems.price` is a snapshot, so
   pending orders keep the old price. Some **new** orders also saved the old price after the update

package/knowledge/2.0/apps/toga25-supply/features/bundle-item-retire.md

@@ -0,0 +1,65 @@
+---
+title: Retiring a kit line (bundle item Active toggle, Status column — never delete)
+framework: "2.0"
+repo: toga25-supply
+project: TOGa 2.5 Supply
+client: shared
+type: feature
+status: active
+updated: 2026-10-26
+owners: ["tcox"]
+files:
+  - toga25-supply/src/layout/BundleItemRecordModalLayout/hooks/useRetireBundleItem.ts
+  - toga25-supply/src/layout/BundleItemRecordModalLayout/hooks/useBundleItemEditForm.tsx
+  - toga25-supply/src/layout/BundleItemRecordModalLayout/components/BundleItemRecordEdit.tsx
+  - toga25-supply/src/layout/BundleItemRecordModalLayout/viewModel/FIELDS/DEFAULT/bundleItemRecordFields.json
+  - toga25-supply/src/layout/BundleRecordModalLayout/components/BundleItemsTable.tsx
+  - toga25-supply/src/layout/BundleRecordModalLayout/viewModel/useBundleItemsTableViewModel.tsx
+  - toga25-supply/src/layout/BundleRecordModalLayout/viewModel/FIELDS/DEFAULT/bundleRecordViewFields.json
+  - _underscore/Model/Client/Bundle.php
+  - _underscore/Model/Compass/Bundle.php
+related:
+  - ./bundle-item-pricing.md
+  - ./loading-and-error-states.md
+  - ./record-modals-and-nested-tables.md
+  - ../../toga-blox/features/table.md
+  - ../../../../clients/compass-usa/workflows/changing-a-kit-line-item.md
+---
+
+How Supply admins retire a kit (bundle) line — Active toggle in the line editor, trash button = retire behind a confirm, Inactive badge in the Status column; open before adding any delete/remove action to bundle items.
+
+## Summary
+
+A kit line (`BundleItems` row) is **retired (`isActive = 0`), never deleted**, from Supply.
+`SalesOrderItems.bundleItemId` and `SalesQuoteItems.bundleItemId` point at old lines, so a real
+delete breaks placed orders/quotes and fails outright once a line has a price or an order.
+Retire needs the role's **UPDATE** grant + write on `isActive` — not DELETE.
+
+## How it works
+
+### Line editor (`BundleItemRecordModalLayout`)
+- **Active** toggle in the Settings section (`bundleItemRecordFields.json`). New line defaults Active; an existing line keeps its saved value.
+- Save sends the toggle value. (Before TRUE-83079 the save hardcoded `isActive: 1`, so any edit silently re-activated a retired line.)
+- **No Delete button.** Removed on purpose: it fired with no confirm and threw away unsaved edits. Retire in the editor = toggle off + Save.
+
+### Bundle line table (`BundleItemsTable`)
+- Trash button **retires**: `PUT /v2/bundle-items/{uuid}` `{ isActive: 0 }` behind a "Retire bundle item?" confirm dialog. Hidden on inactive lines.
+- **Status** column: blox CUSTOM action column showing an Inactive badge (blank when Active). Labels from `bundleRecordViewFields.json` → `bundleItemsStatusColumn { label, inactiveLabel }`; reuses the modal `.badge` CSS.
+- Every trailing action column is pinned sticky `"right"` — see the blox action-column border gotcha in [Table component](../../toga-blox/features/table.md).
+- Shared hook `useRetireBundleItem`; table refetches after retire.
+
+### Why a partial PUT `{ isActive: 0 }` is safe
+- V2 update writes only the sent fields.
+- `BundleItem` models have no save hooks.
+- Kit price totals in `_Model_Client_Bundle` and `_Model_Compass_Bundle` already filter `BundleItems.isActive = 1`, so a retired line drops out of the kit price.
+
+### Write result check
+Save and retire run the response through `assertApiWriteSucceeded()` — a 2xx can still be a failed write. See [save-error handling](./loading-and-error-states.md).
+
+## Gotchas
+- **⚠ Never add a hard delete for bundle items** — not in the table, not in the editor. Retire only.
+- A role with no write grant on `isActive` gets a 2xx with warning `WZ-2` and **nothing is written** — `assertApiWriteSucceeded` turns that into an error toast. The fix is an ACL grant, not front-end code.
+- **Compass test kits (client-sandbox, Base persona):** kit #82 "HP B/W LaserJet Printer" (bundle id 4); kit #115 "HP All-In-One Printer (9130b)" (bundle id 20) — #115 has **two active Primary lines** for the same printer (line 400 `4U555A#B1H`, line 2042 `4U555A-S`), the known duplicate-item pair; good for a retire test. Kit number = `Bundles.number`, not `id`.
+
+## Change history
+- 2026-10-26 — Supply can retire kit lines: Active toggle, trash = retire + confirm, Status column, editor Delete removed; save no longer forces `isActive: 1` (TRUE-83079). (tcox)

package/knowledge/2.0/apps/toga25-supply/features/loading-and-error-states.md

@@ -6,7 +6,7 @@ project: TOGa 2.5 Supply
 client: shared
 type: feature
 status: active
-updated: 2026-10-06
+updated: 2026-10-26
 owners: ["tcox"]
 files:
   - toga25-supply/src/components/TableSkeleton/TableSkeleton.tsx
@@ -18,8 +18,12 @@ files:
   - toga25-supply/src/layout/PrimaryTableClientLayout/PrimaryTableClientLayout.tsx
   - toga25-supply/src/pages/SalesOrders/view/SalesOrderRecordModalLayout/helpers/recordShapeMemory.ts
   - toga25-supply/src/utils/saveErrorToaster.ts
+  - toga25-supply/src/utils/apiWriteResult.ts
 related:
   - ./record-modals-and-nested-tables.md
+  - ./bundle-item-retire.md
+  - ../../api2/features/v2-api-error-codes.md
+  - ../../toga-blox/features/api-client.md
   - ./transfer-orders-page.md
   - ./persisted-query-cache.md
   - ../workflows/cypress-testing.md
@@ -50,6 +54,22 @@ Per-record shape (`itemCount`, `hasInvoices`, `hasShipments`) in `sessionStorage
 ### Save-error toaster — `src/utils/saveErrorToaster.ts`
 Item, vendor-item, bundle and bundle-item create/edit hooks call `useToaster().addToaster({ status: "error", ...SAVE_ERROR_TOASTER_MESSAGE })`. Raw error goes to the console, never to the user. New save hooks must use the same constant.
 
+### Write-result check — `src/utils/apiWriteResult.ts`
+An api2 write can answer 2xx and still fail. `assertApiWriteSucceeded(response)` throws `ApiWriteError` when:
+1. `isSuccess === false`, or
+2. any `messages[]` entry has `type: "ERROR"`, or
+3. a warning code is exactly `WZ-2` (role may write none of the sent fields → nothing written).
+
+`describeApiWriteError(error)` builds the toast text, in this order:
+1. `messages[].identifiers.message` (interceptor rule text),
+2. else the defined message with the `"Operation Failed: "` prefix stripped,
+3. plus `(code, ref <error.id>)`,
+4. fallback `SAVE_ERROR_TOASTER_MESSAGE`.
+
+Never shows `identifiers.error` (raw SQL + DB name). Used by bundle line save + retire ([bundle-item-retire](./bundle-item-retire.md)); new write hooks should use it.
+
+**Decision (TRUE-83079, tcox):** showing api2's curated defined/interceptor message is a deliberate exception to frontend standard §19 "no raw server string" — it is curated text, not raw.
+
 ### Visual review — temporary dev gallery
 To eyeball every state at once: restore the old gallery with `git show TRUE-79502:src/pages/DevLoadingStates/DevLoadingStatesPage.tsx`, register it in `src/routes.tsx` **inside `AllowedRoutes`** behind `import.meta.env.DEV` at `/dev/loading-states` (needs login). Newer blox `TablePagination` needs `recordsPerPage` inside `paginationMeta` — the old page must be patched. **Delete it before merge**; it is not shipped.
 
@@ -58,7 +78,9 @@ To eyeball every state at once: restore the old gallery with `git show TRUE-7950
 - **⚠ `isPageFetch` path in `PrimaryTableServerLayout` is dead code** (never true in practice). Open follow-up — do not build on it.
 - **⚠ Do not merge `_production` into the stale TRUE-79502 / TRUE-79505 branches** — it drops newer prod features. Cut a fresh branch from `_production` and port pieces by hand (done as TRUE-82385).
 - Old-branch pieces deliberately **not** ported: `ModalBanner` error variant + `DevErrorStates` page (TRUE-79505), `BulkProgressToast` (no consumers), `DevLoadingStatesPage` (demo), `SalesOrderItemsTableLayout` (deleted in `_production` 97d20ff). TRUE-79502-update's `useClientFields` / Prudential CSV-BOM edits are unrelated to loading. TRUE-79505-updated, TRUE-79505-prod and TRUE-79501 are already fully in `_production`. TRUE-79506 never existed.
+- **⚠ blox `apiDelete` resolves on a 4xx** (false "deleted" toast) — see [api-client](../../toga-blox/features/api-client.md). **OPEN:** `useBundleEditForm.tsx:34` (persona-bundle removal) still trusts `apiDelete`; run it through `assertApiWriteSucceeded`.
 - A disabled React Query v5 query reports `pending` forever — see [transfer-orders-page](./transfer-orders-page.md) before deriving a skeleton flag from one.
 
 ## Change history
+- 2026-10-26 — Added `apiWriteResult.ts` (2xx-but-failed write check + curated toast text, §19 exception) for bundle line save/retire (TRUE-83079). (tcox)
 - 2026-10-06 — Ported loading states (TRUE-79502-update) + save-error toaster onto fresh `_production` as TRUE-82385; Transfer Orders wired; Cypress expectations updated. (tcox)

package/knowledge/2.0/apps/toga25-supply/workflows/cypress-testing.md

@@ -6,7 +6,7 @@ project: TOGa 2.5 Supply
 client: shared
 type: workflow
 status: active
-updated: 2026-10-16
+updated: 2026-10-26
 owners: [apeterson, tcox, rgirish]
 files:
   - toga25-supply/cypress.config.ts
@@ -149,7 +149,8 @@ Writing the create specs turned up five real app defects. Recorded here because
 
 ### Rest of the repo's test state (for context)
 
-- **Vitest is the other half.** `npm test` (`vitest run`) currently has **one failing test file**: `src/hooks/useTalosSurface.test.ts` fails with `TypeError: Unknown file extension ".css"` on `@agilant/toga-blox/dist/global.css` — the suite fails to **load**, so it is silently skipped in full. **Pre-existing** — the file was last touched in commit `604a779` and the Cypress work changed neither it nor `vitest.config.ts`. Re-confirmed on a clean tree 2026-09-14, with every other file green (148/148 on `_sandbox-client`). Needs a separate fix (Vitest CSS handling for blox imports).
+- **Vitest is the other half.** `npm test` (`vitest run`) currently has **one failing test file**: `src/hooks/useTalosSurface.test.ts` fails with `TypeError: Unknown file extension ".css"` on `@agilant/toga-blox/dist/global.css` — the suite fails to **load**, so it is silently skipped in full. **Pre-existing** — the file was last touched in commit `604a779` and the Cypress work changed neither it nor `vitest.config.ts`. Re-confirmed on a clean tree 2026-09-14, with every other file green (148/148 on `_sandbox-client`). Needs a separate fix (Vitest CSS handling for blox imports). Still failing 2026-10-26.
+- **⚠ On Windows, vitest HANGS with the default `threads` pool** (no output, >5 min). Run `npx vitest run <files> --pool=forks` (~8s).
 - **Dozens of unrelated `tsc -p tsconfig.app.json` errors? Check `node_modules` against the lock first.** Seen 2026-10-16: installed blox `1.0.318-beta.40` vs pinned `1.1.4-production.196`. `npm ci --legacy-peer-deps` fixed it.
 - **No other mechanical guardrails exist in this repo:** no `.github/workflows`, no husky, no lint-staged. The only `.git/hooks/pre-commit` is a machine-local `code-review-graph` shim that always exits 0 and is not checked in.
 - **Green FE tests do not mean a client gets a feature.** Real rollout is a role-scoped `SurfaceOverrides IS_VISIBLE` row in `dbchanges2`; the fixture only simulates the grant.
@@ -174,3 +175,6 @@ Writing the create specs turned up five real app defects. Recorded here because
 - **⚠ Some lists are fetched TWICE when they open** (once as the unfiltered search source, once for the filtered options), so a `cy.wait('@alias')` can consume the wrong request and assert against the wrong body. Assert on **`cy.get('@alias.all')`** and pick the request you mean.
 - **⚠ After merging a branch off `_feature-cypress`, run `npm install` before anything else.** Those branches import Talos packages (`@assistant-ui/react`, `@assistant-ui/react-markdown`, `@langchain/langgraph-sdk`, `remark-gfm`); with a stale `node_modules` **every page** dies with *"Failed to resolve import"* and every spec fails for a reason that looks nothing like the cause. The lockfile already has them, so plain `npm install` fixes it. **Note:** `npm install` replaces a locally linked blox with the registry copy — relink afterwards if you were testing a local blox.
 - **Scrub captured payloads.** Copying a real body out of Chrome DevTools (Network → filter `/v2/` → Response → Copy response) is the fastest way to build a fixture — but those payloads carry **real customer data**. Remove emails, names, addresses and tokens before committing.
+
+## Change history
+- 2026-10-26 — Vitest on Windows: use `--pool=forks` (default pool hangs) (TRUE-83079). (tcox)

package/knowledge/INDEX.md

@@ -32,7 +32,7 @@ _Auto-generated by `knowledge.js index`. Do not hand-edit._
 - **toga2-view** (TOGa View Frontend) — 12 doc(s) → [2.0/apps/toga2-view/INDEX.md](2.0/apps/toga2-view/INDEX.md)
 - **toga2-hub** (TOGa Hub) — 2 doc(s) → [2.0/apps/toga2-hub/INDEX.md](2.0/apps/toga2-hub/INDEX.md)
 - **toga2-commerce** (TOGa Commerce) — 34 doc(s) → [2.0/apps/toga2-commerce/INDEX.md](2.0/apps/toga2-commerce/INDEX.md)
-- **toga25-supply** (TOGa 2.5 Supply) — 27 doc(s) → [2.0/apps/toga25-supply/INDEX.md](2.0/apps/toga25-supply/INDEX.md)
+- **toga25-supply** (TOGa 2.5 Supply) — 28 doc(s) → [2.0/apps/toga25-supply/INDEX.md](2.0/apps/toga25-supply/INDEX.md)
 - **toga25-iq** (TOGa IQ) — 1 doc(s) → [2.0/apps/toga25-iq/INDEX.md](2.0/apps/toga25-iq/INDEX.md)
 - **toga2-template** (TOGa App Template) — 1 doc(s) → [2.0/apps/toga2-template/INDEX.md](2.0/apps/toga2-template/INDEX.md)
 - **toga25-desk** (TOGa Desk 2.5) — 1 doc(s) → [2.0/apps/toga25-desk/INDEX.md](2.0/apps/toga25-desk/INDEX.md)

package/knowledge/clients/compass-usa/workflows/changing-a-kit-line-item.md

@@ -6,12 +6,14 @@ project: TOGa Commerce
 client: compass-usa
 type: workflow
 status: active
-updated: 2026-09-16
-owners: [bala]
+updated: 2026-10-26
+owners: [bala, tcox]
 files:
   - toga2-commerce/src/utils/checkIsItemPurchasable.ts
   - toga2-commerce/src/pages/BundleView/api/BundleApi.tsx
+  - toga25-supply/src/layout/BundleItemRecordModalLayout/hooks/useRetireBundleItem.ts
 related:
+  - ../../../2.0/apps/toga25-supply/features/bundle-item-retire.md
   - ./granting-persona-bundle-access.md
   - ./cross-kit-bundle-corruption.md
   - ./persona-refactor-migration.md
@@ -47,13 +49,13 @@ The request is usually phrased by the **hero item** ("every kit with the new iPa
 ### The write pattern: INSERT a mirror line, then deactivate the old one
 1. `INSERT` a new `BundleItems` row **mirroring the line it replaces** — same `bundleItemGroupId`, `sortOrder`, `isActive` / `isRequired` / `isVisible`, quantities and `measureId` — changing only `itemId`.
 2. `INSERT` the matching `BundleItemPrices` rows for the new line. This is the **only** child table that needs mirroring.
-3. `UPDATE` the old line to `isActive = 0`. It stays in the table forever.
+3. Retire the old line (`isActive = 0`). It stays in the table forever. **No SQL needed (since TRUE-83079):** a Supply admin turns off **Active** in the line editor, or uses the line table's trash button (retire + confirm) — see [Retiring a kit line](../../../2.0/apps/toga25-supply/features/bundle-item-retire.md). A retired line drops out of the kit price.
 
 ### Checklist for any "add an item to a kit" data change
 1. Resolve the hero by `BundleItems.itemId` (not part number) and list **every** matching bundle, allowing for multiple active primaries.
 2. Confirm which of those kits already carry the target line, so you change only the ones that need it.
 3. Insert the mirror `BundleItems` row, then its `BundleItemPrices` rows.
-4. Set `isActive = 0` on the replaced line. Never delete it.
+4. Retire the replaced line (`isActive = 0`) — in Supply, or in the same SQL file for a bulk change. Never delete it.
 5. **Diff `Personas_Items` for the new item against the item it replaces and backfill every missing `personaId` — persona 1 "All" above all.** This is the step that gets forgotten, and it is the one that decides whether anyone sees the change.
 6. Re-check `Personas_Bundles` only if the kit itself is new to a persona; an existing bundle grant needs no change.
 
@@ -77,7 +79,11 @@ Then the `Personas_Items` backfill above, without which only MITS Team would hav
 - **⚠ `BundleItemPrices` can already hold duplicate rows for the same `priceTypeId`** — old line **457** had **three** rows at `priceTypeId = 1`. Copy the source rows deliberately: do not assume one row per price type, and do not blindly reproduce the duplicates either.
 - **Open issue — bundle 27's lease pricing is partly stale.** Bundle **27** is the only one of the three carrying **lease-48 (`priceTypeId = 3`)** prices, and its **new** hero line **1990** has **no lease price at all**. Anyone quoting bundle 27 on a 48-month lease is reading incomplete pricing. Not fixed; needs a pricing decision before the missing rows are added.
 
+## Change history
+- 2026-10-26 — Retiring the old line no longer needs SQL: Supply has an Active toggle + retire button (TRUE-83079). Same flow for Compass Canada. (tcox)
+
 ## Related
+- [Retiring a kit line (Supply)](../../../2.0/apps/toga25-supply/features/bundle-item-retire.md)
 - [Granting persona bundle access](./granting-persona-bundle-access.md)
 - [Cross-kit bundle corruption](./cross-kit-bundle-corruption.md)
 - [Persona refactor migration](./persona-refactor-migration.md)

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "toga-ai",
-  "version": "1.0.1149",
+  "version": "1.0.1150",
   "description": "TOGA Technology Team Claude Knowledge System — shared AI coding harness with skills, knowledge base CLI, and project installer for Claude Code.",
   "keywords": [
     "claude",