toga-ai 1.0.1129 → 1.0.1130

package/knowledge/1.0/apps/library/features/app-cloud-aws-credentials.md

@@ -6,8 +6,8 @@ project: Library
 client: shared
 type: feature
 status: active
-updated: 2026-10-22
-owners: [jcardinal, mhammontree, bala, snaredla]
+updated: 2026-10-23
+owners: [jcardinal, mhammontree, bala, snaredla, rgirish]
 files:
   - library/app/cloud.php
   - library/app/systemmonitor/rdsproductioncluster.php
@@ -21,6 +21,7 @@ files:
   - toga/composer.json
   - vision/composer.json
   - store/composer.json
+  - walmart-activate/composer.json
   - library/app/database.php
 related:
   - ../../../../2.0/apps/worker2/features/cross-account-aws-access.md
@@ -74,7 +75,9 @@ CodePipeline `Worker` (502, us-west-2) sources `_production` of **both** `agilan
 - **`copyFileToS3()` (and the other CLI-based calls) never report failure.** `shell_exec('aws s3 cp ...')` then `return true` — bad credentials = silent lost upload. Uploads made while the old key was dead (repair photos, KB files, `BLOBSTORAGE` saves via `App_Model::save()`, email-intake attachments) may be missing from S3. Open, not fixed — CTO decision (TRUE-82935): fix it in library on its own ticket.
 - `togadesk` `ebs/check_s3fs.php` + `ebs/register_instance_to_shared_application_load_balancer.php` now assume `WorkloadsRuntime` (TRUE-82718, PR #622, merged 2026-10-13); togaview fix is PR #307 (opened). The s3fs **mount** cannot assume a role — it uses the instance role directly: see [asifiles s3fs mount](../../togadesk/features/s3fs-asifiles-file-storage.md).
 - **Every 1.0 app that bootstraps `library` needs `aws/aws-sdk-php` in its own `composer.json`** (since TRUE-82705). Without it any App_Cloud call fatals `Class 'Aws\Credentials\CredentialProvider' not found`. Hidden trigger: on prod/worker/bigworker, `App_Database::getDatabaseReaderHost()` (`library/app/database.php` ~156) calls `App_Cloud::getParameter('database_reader_endpoint')` whenever its cache file `databaseReadHost.txt` is older than 30-60 s. The fatal hits before the cache is rewritten, so the cache stays stale and **every** reader-DB request fails — the app looks fully down (TRUE-82793: Vision PunchOut for Canon / S&P Global via SAP Ariba returned HTTP 500). Fix = add `"aws/aws-sdk-php": "^3.328"` and pin `composer.lock` to worker's prod versions (aws-sdk-php 3.328.1, guzzle 7.9.2, promises 2.0.4, psr7 2.7.0, jmespath 2.8.0 — PHP 7.2 safe); EB runs `composer install --no-dev` on deploy (`vendor/` is gitignored).
-  - Has it (`_production`): worker, togadesk (`^3.337`), togaview, tools, toga (TRUE-82714, 63c5ed0; confirmed 2026-10-16), vision (TRUE-82793, merged + deployed 2026-10-15).
+  - Has it (`_production`): worker, togadesk (`^3.337`), togaview, tools, toga (TRUE-82714, 63c5ed0; confirmed 2026-10-16), vision (TRUE-82793, merged + deployed 2026-10-15), walmart-activate (TRUE-83161, d29cbb1, deployed 2026-10-23 — composer + `require_once 'vendor/autoload.php'` at the end of `App_Framework_Walmart::initialize()`).
+  - **Any new or moved 1.0 app: check composer first.** A move to a new EB env clones the *current* library, so an app with no `composer.json` breaks on the first DB page even if the old env worked (it ran pre-10/12 library). Pages with no DB query still work, so EB stays Green (walmart-activate `/register`, TRUE-83161).
+  - **Testing gotcha:** after one passing run, `databaseReadHost.txt` is fresh for 30-60 s, so a control run right after also passes. Wait > 60 s (or delete the cache file) before the control.
   - store: fixed on branch (TRUE-82856, ae1861f4f — same pins plus aws-crt-php 1.2.7, psr/http-client 1.0.3, polyfill-mbstring 1.31.0; verified on PHP 7.2.33); needs merge + deploy. Its `.ebextensions/015_install_composer.config` already runs `composer install --no-dev`.
   - **Missed by the audit (TRUE-82935): the 1.0 `api` repo** (no composer at all) and **togadesk's email cron** (`crons/tickets.php` loads only `desk/vendor/autoload.php`; the root togadesk composer with aws is not loaded there). Both stopped `App_Cloud`: [Talos ticket API](../../api/features/talos-ticket-endpoint.md), [email intake](../../togadesk/features/email-to-ticket-intake.md). Audit per **entry point**, not per repo: a CLI cron or sub-app can load a different autoloader than the web app.
   - The missing class throws **`Error`, not `Exception`** — `catch (Exception)` around an App_Cloud call does not catch it; use `\Throwable` where a fallback is meant.
@@ -84,6 +87,7 @@ CodePipeline `Worker` (502, us-west-2) sources `_production` of **both** `agilan
 - Every long-lived key still in code across repos (SES SMTP, s3fs, ALB scripts, other accounts): [audit 2026-10-13](../../../../2.0/apps/worker2/features/cross-account-aws-access.md#long-lived-keys-still-in-code-audit-2026-10-13).
 
 ## Change history
+- 2026-10-23 — walmart-activate added aws-sdk-php; moved-app check + read-host cache testing gotcha (TRUE-83161) (rgirish)
 - 2026-10-22 — Leaked key was abused (Bedrock LLM-jacking, GuardDuty, TRUE-82983) (jcardinal)
 - 2026-10-19 — aws-sdk-php audit missed `api` + togadesk email cron; `Error` not `Exception` (TRUE-82935) (jcardinal)
 - 2026-10-16 — aws-sdk-php: store fixed (TRUE-82856), vision deployed, walmarttechservices + webhook not changed (repo gone / reported inactive) (mhammontree)

package/knowledge/1.0/apps/walmart-activate/workflows/deploy-to-elastic-beanstalk-al2023.md

@@ -6,9 +6,11 @@ project: Walmart Activate
 client: shared
 type: workflow
 status: active
-updated: 2026-10-22
+updated: 2026-10-23
 owners: ["rgirish"]
 files:
+  - walmart-activate/composer.json
+  - walmart-activate/.gitignore
   - walmart-activate/.ebextensions/001_platform.config
   - walmart-activate/.ebextensions/005_php_cve_2026_mitigation.config
   - walmart-activate/.ebextensions/009_setup_phpini.config
@@ -22,6 +24,8 @@ files:
 related:
   - ../../tools/workflows/deploy-to-elastic-beanstalk-al2023.md
   - ../../library/features/php-8-5-runtime-compatibility.md
+  - ../../library/features/app-cloud-aws-credentials.md
+  - ../../../../clients/walmart/features/registration-route.md
   - ../../../../clients/walmart/profile.md
 ---
 
@@ -41,14 +45,18 @@ walmart-activate moved from AL1 to EB PHP 8.5 / Amazon Linux 2023 on TRUE-83059,
 6. `.platform/httpd/conf.d/http_to_https.conf` redirects on `X-Forwarded-Proto != https`.
 7. `App_Framework_Walmart::startSession()` (`_/app/framework.php`) sets rediscluster with `ini_set()`; if the extension is loaded but `session_start()` fails, it logs and falls back to file sessions. `reset.php` clears the session through the same method.
 8. `005_php_cve_2026_mitigation.config`: its file-watch cron skips while `/var/app/staging` (or `/var/app/ondeck`) exists, so it does not fire mid-deploy.
+9. `composer.json` requires `aws/aws-sdk-php ^3.328` (php `>=8.2 <8.6`, same as store); `composer.lock` committed, `/vendor/` gitignored. EB AL2023 PHP runs `composer install` itself. `App_Framework_Walmart::initialize()` ends with `require_once 'vendor/autoload.php';`. Without it every DB page fatals — see [App_Cloud aws-sdk requirement](../../library/features/app-cloud-aws-credentials.md#gotchas) (TRUE-83161).
 
 ## Gotchas
 
 - **No s3fs, no symlinks (decided TRUE-83059).** The AL1 s3fs mount, `links.*.json` (pointed at togadesk uploads) and old `ebs` scripts were removed. Walmart writes nothing to `storage_folder`/`export_folder`: the only signature save (`mvc/verify/get.php`) passes empty data, and `App_Model_ServiceRequestSignature::save` writes a file only when `signatureData` is truthy. **If a Walmart flow ever writes documents or exports, bring back s3fs or S3 first.**
+- **Errors are recorded nowhere.** No Sentry and no `db_toga2logs` link in `config.prod.ini`, so `App_Error` writes no `Logs.Issue` and no php-fpm log line — the user sees only "Oops! Something went wrong." To get the real error, run the page in PHP CLI on the instance via SSM: set `$_SERVER['SCRIPT_FILENAME']=/var/app/current/index.php`, `REQUEST_URI`, `$_GET`, and `ENVIRONMENT` (from `/opt/elasticbeanstalk/deployment/env`), then `include` `index.php`; CLI `renderErrorBox` prints the message.
+- **`/home` working does not mean the site is up.** `/home` makes no DB query; `/register` does. Smoke-test `/register?{enc}=` after every deploy (TRUE-83161: `/register` was down for every customer from the 2026-10-22 move until 2026-10-23, EB Green the whole time).
 - **Staging dir is `/var/app/staging`** on AL2023. `/var/app/ondeck` is AL1 only.
 - **File-session fallback is per instance.** With more than one instance, a Redis outage logs users out when the load balancer switches instance. Check `error_log` for `Redis session store unreachable`.
 - **PHP 8.5 deprecations are logged, not fatal** (library `_production`, PR #905); warnings and notices still exit. This app depends on the library fixes in [PHP 8.5 runtime compatibility](../../library/features/php-8-5-runtime-compatibility.md).
 - **OPEN security issue (pre-existing, not fixed):** `.htaccess` rewrites only when the file does not exist (`!-f`), so under Apache the committed `config.*.ini` (DB credentials) and `ebs/git.json` (GitHub clone token) are served as plain files. Fix: copy togaview's working `.platform/httpd/conf.d/deny.conf` ([TOGa View deploy](../../togaview/workflows/deploy-to-elastic-beanstalk-al2023.md)). Also `009` sets `display_errors = On` in prod. Never copy credential values out.
 
 ## Change history
+- 2026-10-23 — Added composer/aws-sdk-php (fixes `/register` Oops box after the move); no-error-capture debug method (TRUE-83161) (rgirish)
 - 2026-10-22 — Moved to PHP 8.5 / AL2023 (Apache proxy, bash git clone, Redis via `ini_set`); dropped s3fs/symlinks; logged open config-exposure issue (TRUE-83059) (rgirish)

package/knowledge/clients/walmart/features/registration-route.md

@@ -5,9 +5,10 @@ project: TOGa
 client: walmart
 type: client-feature
 status: active
-updated: 2026-09-16
-owners: []
+updated: 2026-10-23
+owners: ["rgirish"]
 files:
+  - toga/app/servicerequests/view.php
   - walmart-activate/mvc/register/get.php
   - walmart-activate/mvc/register/post.php
   - library/app/client/walmart.php
@@ -38,6 +39,8 @@ The `=` at the end is intentional — the encrypted string is the key, the value
 $link = 'https://walmart.truesolutions.com/register?' . App_String::encryptString($serviceRequestId) . '=';
 ```
 
+Entry points: the blast/reminder email, and the TOGa Retail work order page "Confirm Order" button (`toga/app/servicerequests/view.php` ~1978), which opens `requireRegistrationUrl` + `?{encryptString(serviceRequestId)}=`. Data: `TOGA_WalmartEComm.ServiceRequests` / `Contacts`.
+
 ### GET handler — parsing the key (`mvc/register/get.php`)
 
 Extracts the encrypted ID by iterating `$_GET` and taking the first key that is not `success` or `error`:
@@ -77,6 +80,7 @@ Then decrypts: `$serviceRequestId = (int) App_String::decrypt($encryptedServiceR
 - The encrypted ID is the **key**, not the value. `?enc=value` format would break parsing.
 - `App_String::encryptString()` and `App_String::decrypt()` are the inverse pair — do not mix with other encryption helpers.
 - Registration URL base comes from `TOGA.Clients.requireRegistrationUrl` for client id=7. If this DB field is wrong, all registration links break.
+- **"Oops! Something went wrong." for every customer = server error, not bad data.** walmart-activate records errors nowhere; see the [deploy doc](../../../1.0/apps/walmart-activate/workflows/deploy-to-elastic-beanstalk-al2023.md#gotchas) for the SSM CLI way to see the real message. TRUE-83161 cause: missing `aws/aws-sdk-php` after the move to toga-prod.
 - Image paths in the view must use absolute paths (`/assets/img/...`) — relative paths break on URLs with a trailing slash.
 
 ## Related

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "toga-ai",
-  "version": "1.0.1129",
+  "version": "1.0.1130",
   "description": "TOGA Technology Team Claude Knowledge System — shared AI coding harness with skills, knowledge base CLI, and project installer for Claude Code.",
   "keywords": [
     "claude",