toga-ai 1.0.1082 → 1.0.1083

package/knowledge/2.0/apps/_underscore/INDEX.md

@@ -63,8 +63,9 @@
 | [SO↔PO and TO↔PO bridge tables are TWO tables in OPPOSITE directions (upstream vs downstream)](features/sales-order-purchase-order-bridge-direction.md) | The two SO↔PO (and two TO↔PO) bridge tables mean opposite things (upstream = customer PO, downstream = vendor PO); open when an SO/TO↔PO query returns an empty |
 | [Per-client sales-order status filter (Surface FILTER_SET → table meta `filterOptions`)](features/sales-order-status-filter-surface.md) | Per-client status-filter dropdown on the sales-orders table, driven by a Surface `FILTER_SET`; open when the offered statuses are wrong for a tenant or when onb |
 | [Service request links (ServiceRequests_Tickets, ServiceRequests_ServiceRequests bridges)](features/service-request-links.md) | Many-to-many links from a service request to tickets and to other service requests; open before linking SRs, reading `_linkCount`, or touching the old `ServiceR |
+| [2.0 Service Request status (`_status`) is derived; stages are manual-only; standard schedule / crew / location columns](features/service-request-status-and-stages.md) | How a 2.0 service request's `_status` is computed, what stages are for, the standard SR columns, and the set-stage write; open when an SR shows the wrong status |
 | [Shipping Carriers & Carrier Account Numbers (records, matching, duplication, deletion)](features/shipping-carriers-and-accounts.md) | Per-client `ShippingCarriers` / `ShippingCarrierAccountNumbers` model, how the syncs match/create carrier rows, and the duplication + blank-carrier + pagination |
-| [Ticket SLA engine (_Component_Sla) — two clocks, per-stage effects, client switch + operator recompute](features/sla-engine.md) | How 2.0 ticket SLA due times, pauses and the per-client switch are computed and written (`_Component_Sla`); open when an SLA countdown is wrong, a stage does no |
+| [SLA engine (_Component_Sla) — record-generic (tickets + service requests), two clocks, per-stage effects, client switch + operator recompute](features/sla-engine.md) | How 2.0 SLA due times, pauses and the per-client switch are computed and written for tickets AND service requests (`_Component_Sla`); open when an SLA countdown |
 | [_String helpers — ASCII-safe HTML entity encoding (and the parseBetween trap)](features/string-html-entity-helpers.md) | `_String` static string utilities: use `encodeToAsciiHtmlEntities` for any dynamic text going into a 2.0 email; open when escaping email text or parsing substri |
 | [Surface FIELD ↔ RecordField binding (maxLength / validationType / isWritable fold-in)](features/surface-field-recordfield-binding.md) | Resolver capability that folds `Core.RecordFields` input-contract metadata (maxLength/validationType/isWritable) onto a surface FIELD element; open when a 2.5 s |
 | [DECLINED 2026-10-08 — re-key Client.SurfaceOverrides from numeric Core ids to uuids](features/surface-overrides-uuid-rekey.md) | **Decision 2026-10-08 (jcardinal): keep numeric ids; no uuid re-key.** The plan below is not scheduled; see the Layer boundary in [surface-resolver](surface-res |

package/knowledge/2.0/apps/_underscore/features/service-request-status-and-stages.md

@@ -0,0 +1,60 @@
+---
+title: 2.0 Service Request status (`_status`) is derived; stages are manual-only; standard schedule / crew / location columns
+framework: "2.0"
+repo: _underscore
+project: _Underscore
+client: shared
+type: feature
+status: active
+updated: 2026-10-19
+owners: [jcardinal]
+files:
+  - _underscore/Model/Client/ServiceRequest.php
+  - _underscore/Model/Client/ServiceRequestNote.php
+  - _underscore/Model/Client/User.php
+  - _underscore/Model/Client/Case.php
+  - _underscore/Model/Prudential/ServiceRequest.php
+  - _underscore/Model/Growrk/ServiceRequest.php
+  - _underscore/Model/Adyen/ServiceRequest.php
+  - _underscore/Model/Elite/ServiceRequest.php
+  - dbchanges2/Core/2026-10-19i - TRUE-82915 ServiceRequestInterceptors.sql
+  - dbchanges2/Client_Prudential/2026-10-19a - TRUE-82915 ServiceRequestStageStatusLinks.sql
+  - dbchanges2/Client_Growrk/2026-10-19a - TRUE-82915 ServiceRequestStageStatusLinks.sql
+related:
+  - ./ticket-status-from-stage.md
+  - ./case-status-and-stage-gate.md
+  - ./sla-engine.md
+  - ./service-request-links.md
+  - ../../api2/features/api-payload-interceptors.md
+---
+
+How a 2.0 service request's `_status` is computed, what stages are for, the standard SR columns, and the set-stage write; open when an SR shows the wrong status, you add a stage, or you add a base SR hook.
+
+## Summary
+
+`_Model_Client_ServiceRequest::_status` is a `FIELD_SQL` calculated field (same idea as Tickets and Cases). Status comes from the SR's own fields; stages hold only manual states that cannot be derived. Full detail: toga25-desk `docs/decisions/0166-sr-status-derived-from-fields-stages-manual-only.md` and `0167-sr-site-schedule-crew-tags-reported-by.md`.
+
+## How it works
+
+`_status` returns, in order:
+1. the linked status slug, when the stage has `serviceRequestStatusId`;
+2. `closed`, when the stage is unlinked and `isOpen = 0`;
+3. `in-progress`, when a Lead (`assignedToContactId`) or crew (`ServiceRequests_Users`) is set;
+4. `scheduled`, when `dtScheduledStart` is set;
+5. else `new`.
+
+- **Stages = manual, non-derivable states only:** blockers (roadblocked / on-hold / awaiting-user / awaiting-parts — each needs a reason note in `ServiceRequestNotes`), pending-client-approval, resolved, closed. No stage is the normal flow.
+- **Per-client stage → status links** go in `Client_<Name>/` files (e.g. `Client_Prudential` / `Client_Growrk` `2026-10-19a`), never a `Client/` fan-out.
+- **Standard columns:** `assignedToContactId` (Lead), `reportedByContactId`, `locationId` (the site — NOT `deliverToAddressId`, which is the shipping address), `isRemote`, `dtScheduledStart` / `dtScheduledEnd` (NOT `dateDelivery`). `ServiceRequestTypes`: `isSiteVisit`, `iconName`, `colorHex`. Bridges `ServiceRequests_Users` (crew), `_Tags`, `_Files` (Core.Records 422-424, RecordFields 3106-3152).
+- **Set stage** = table-based `PUT /v2/service-requests/{uuid}` with nested `serviceRequestNotes` (the reason note). A stage PUT without a uuid = 400 for signed-in users (CSO).
+- **Crew "required"** is a UI rule only — integration-created SRs send no crew.
+- **Base hooks** (`prePost` / `postPost` / `postPut` / `postPatch`) are registered for every client by `Core/2026-10-19i` (`clientId` / `apiId` NULL). They run the schedule check, the set-stage gate, and the [SLA engine](./sla-engine.md).
+
+## Gotchas
+
+- **⚠ Never delete or rename existing stage rows.** Client integrations match stage NAMES: Prudential `postPut` ('Cancelled' / 'Update'), Growrk ('Completed'), worker 1.0 cron ('Exception' + stage id 2).
+- **⚠ A client SR override must call `parent::` in every hook it overrides.** Before 2026-10-19 the Prudential / Growrk / Adyen / Elite `ServiceRequest` overrides did not, so every base SR hook was silently skipped for those clients. Adding a base hook? Check each `_Model_<Client>_ServiceRequest` calls `parent::` first (and that the parent declares the method — see [interceptors](../../api2/features/api-payload-interceptors.md#the-client-model-resolution-that-decides-which-class-must-define-the-method)).
+- **⚠ A NULL stage is now the normal case — never INNER JOIN the SR stage.** `User::_openWorkCount` and `Case::_resolvedCount` used INNER JOIN on stage + `isOpen` and dropped stageless SRs. Rule: open = no stage OR stage `isOpen = 1`; open work counts the SR's own crew.
+
+## Change history
+- 2026-10-19 — `_status` derived from fields; stages manual-only; schedule / crew / location / reported-by columns; client overrides call `parent::`; open counts include stageless SRs (TRUE-82915). (jcardinal)

package/knowledge/2.0/apps/_underscore/features/sla-engine.md

@@ -1,65 +1,76 @@
 ---
-title: Ticket SLA engine (_Component_Sla) — two clocks, per-stage effects, client switch + operator recompute
+title: SLA engine (_Component_Sla) — record-generic (tickets + service requests), two clocks, per-stage effects, client switch + operator recompute
 framework: "2.0"
 repo: _underscore
 project: _Underscore
 client: shared
 type: feature
 status: active
-updated: 2026-10-16
+updated: 2026-10-19
 owners: [jcardinal]
 files:
   - _underscore/Component/Sla/Sla.php
   - _underscore/Model/Client/Ticket.php
   - _underscore/Model/Client/TicketStage.php
   - _underscore/Model/Client/TicketNote.php
+  - _underscore/Model/Client/ServiceRequest.php
+  - _underscore/Model/Client/ServiceRequestNote.php
   - _underscore/Model/Core/Client.php
   - dbchanges2/Core/2026-10-16a - SlaReplyClockCore.sql
   - dbchanges2/Client/2026-10-16a - SlaReplyClockFanout.sql
   - dbchanges2/Client_True/2026-10-16a - SlaStageDataRepair.sql
-  - dbchanges2/Client_Elite/2026-10-16a - SlaReplyClockOpenStage.sql
+  - dbchanges2/Core/2026-10-19k - TRUE-82915 ServiceRequestSlaCore.sql
+  - dbchanges2/Client/2026-10-19i - TRUE-82915 ServiceRequestSla.sql
 related:
   - ./ticket-status-from-stage.md
+  - ./service-request-status-and-stages.md
   - ../../api2/features/api-payload-interceptors.md
   - ../../api2/features/tickets-api.md
   - ../../dbchanges2/features/rerunnable-additive-inserts.md
 ---
 
-How 2.0 ticket SLA due times, pauses and the per-client switch are computed and written (`_Component_Sla`); open when an SLA countdown is wrong, a stage does not pause, or you need to recompute a client.
+How 2.0 SLA due times, pauses and the per-client switch are computed and written for tickets AND service requests (`_Component_Sla`); open when an SLA countdown is wrong, a stage does not pause, you need to recompute a client, or you want SLA on another record type.
 
 ## Summary
 
-`_Component_Sla` (`_underscore/Component/Sla/Sla.php`) is the ONLY code that writes `Tickets.sla*` / `dtSla*` / `dtFirstResponse`. It is static, shared by every 2.0 app, and called from api2 payload interceptors (not model save hooks). Two clocks — resolution and reply (first response) — each with its own pause bookkeeping, driven by per-stage effects stored as client data.
+`_Component_Sla` (`_underscore/Component/Sla/Sla.php`) is the ONLY code that writes the stored SLA columns (`sla*` / `dtSla*` / `dtFirstResponse`). One engine, record-generic: every record-specific name comes from `_Component_Sla::descriptor($record)`. Static, shared by every 2.0 app, called from api2 payload interceptors (not model save hooks). Two clocks — resolution and reply (first response) — each with its own pause bookkeeping, driven by per-stage effects stored as client data.
 
 ## How it works
 
-- **Targets:** `TicketSlas (ticketTypeId, urgencyId)` → minutes (MINUTES ×1, HOURS ×60, DAYS ×1440). Any other unit (e.g. `BUSINESS_DAYS`) = no target. No business-day math.
+- **Descriptor:** `descriptor(RECORD_TICKET | RECORD_SERVICE_REQUEST)` (`'ticket'` / `'serviceRequest'`) returns `record, label, table, typeColumn, stageColumn, contactColumn, targetsTable, stagesTable, hasReplyEffectColumn, notesTable, noteRecordColumn, noteStageColumn, noteAuthorUserColumn`. `allRecordTypes()` = what the client switch and recompute cover. **New record type = a new descriptor + the same columns — never a copy of the engine** (decided, CTO). Detail: toga25-desk `docs/decisions/0168-sla-engine-record-generic.md`.
+- **Tickets (descriptor 1):** `TicketSlas`, `TicketStages.slaEffect` + `slaFirstResponseEffect`, `TicketNotes`, contact = `contactId`. Moving tickets onto the descriptor changed nothing (275-scenario old-vs-new harness and a live recompute replay: 0 diffs).
+- **Service requests (descriptor 2):** same 9 stored SLA columns + 11 calc fields on `ServiceRequests`; targets `ServiceRequestSlas`; effect `ServiceRequestStages.slaEffect`. No reply-effect column (`hasReplyEffectColumn = false`) — the reply clock follows `slaEffect`. Contact = `requestedForContactId`. First response = first external note with a signed-in author (`authorUserId`) OR a contact other than the requester.
+- **Targets:** `(typeColumn, urgencyId)` → minutes (MINUTES ×1, HOURS ×60, DAYS ×1440). Any other unit (e.g. `BUSINESS_DAYS`) = no target. No business-day math.
 - **Due:** `dtCreated + targetMinutes + pausedMinutes`, per clock.
-- **Resolution clock:** effect = `TicketStages.slaEffect` (`RUN`/`PAUSE`/`STOP`, no stage = RUN). Columns `dtSlaPaused`, `slaPausedMinutes`. STOP time is charged like pause time; `_slaState` shows `STOPPED`.
-- **Reply clock:** effect = `TicketStages.slaFirstResponseEffect` (`RUN`/`PAUSE`, column default `PAUSE`, no stage = RUN). Columns `dtSlaFirstResponsePaused`, `slaFirstResponsePausedMinutes`. Seeded RUN only for new / open / reopened stages. Keeps tracking after the first response so stamps stay right.
-- **`resolvePauseState(params)`** is clock-agnostic and called once per clock. Reuse it for the Service Request SLA clocks — do not fork the math.
-- **First response** = `MIN(TicketNotes.dtStamp)` of external notes by a contact other than the ticket's own contact. Authorless notes never count.
-- **Read side:** `_slaTime`, `_slaState`, `_slaPausedAt` (FIELD_SQL on `_Model_Client_Ticket`). `_slaPausedAt` returns the paused stamp of the clock being shown (reply while unanswered and a reply due exists, else resolution). The Desk countdown reads it, not the raw columns.
+- **Resolution clock:** stage `slaEffect` (`RUN`/`PAUSE`/`STOP`, no stage = RUN). Columns `dtSlaPaused`, `slaPausedMinutes`. STOP time is charged like pause time; `_slaState` shows `STOPPED`.
+- **Reply clock (tickets):** `TicketStages.slaFirstResponseEffect` (`RUN`/`PAUSE`, column default `PAUSE`, no stage = RUN). Columns `dtSlaFirstResponsePaused`, `slaFirstResponsePausedMinutes`. Seeded RUN only for new / open / reopened stages. Keeps tracking after the first response so stamps stay right.
+- **`resolvePauseState(params)`** is clock-agnostic, called once per clock. Do not fork the math.
+- **Ticket first response** = `MIN(TicketNotes.dtStamp)` of external notes by a contact other than the ticket's own contact. Authorless notes never count.
+- **Read side:** `_slaTime`, `_slaState`, `_slaPausedAt` (FIELD_SQL on the record model). `_slaPausedAt` returns the paused stamp of the clock being shown (reply while unanswered and a reply due exists, else resolution). UIs read it, not the raw columns.
 - **Time = DB clock** (`SELECT NOW()` on the client writer), read once, then advanced by PHP elapsed time.
-- **Client switch:** `Core.Clients.isSlaEnabled`. OFF = every SLA column NULL. Flipping it in `PUT /v2/clients/{uuid}` runs `applyClientSwitch` (backfill, skips STOP-stage tickets when turning on).
-- **Operator recompute (no OFF/ON):** `PUT /v2/clients/{uuid}` body `{"recomputeSla": true}`. `_Model_Core_Client::prePut` strips the key (not a column), requires boolean `true`, parks it on `$api->passThrough`; `postPut` runs `recomputeClient` (all tickets, STOP included). Allowed only for callers who can WRITE `Clients.isSlaEnabled` (same field ACL as the V2 write gate). A body that is empty after the strip becomes `{}` in V2.php and `postPut` still runs. Pattern: [command keys in interceptors](../../api2/features/api-payload-interceptors.md#passing-state-from-a-pre-hook-to-a-post-hook).
-- **One run per client:** the shared backfill takes `GET_LOCK('sla-recompute-<clientId>', 0)` on the SAME connection as its writes, `RELEASE_LOCK` in `finally`. Lock busy → `_Exception_Validation` 400. Any failure throws, so the API write rolls back. Reuse this shape for any "only one at a time per client" operation.
-- **Cross-client:** the switch/recompute path uses `DB_TARGET_CLIENT` (`registerTargetClientDatabase`), never the caller's `DB_CLIENT`. Core and client data are never joined.
+- **Client switch:** `Core.Clients.isSlaEnabled` covers every record type. OFF = every SLA column NULL. Flipping it in `PUT /v2/clients/{uuid}` runs `applyClientSwitch` (backfill, skips STOP-stage records when turning on).
+- **Operator recompute (no OFF/ON):** `PUT /v2/clients/{uuid}` body `{"recomputeSla": true}` — all record types. `_Model_Core_Client::prePut` strips the key (not a column), requires boolean `true`, parks it on `$api->passThrough`; `postPut` runs `recomputeClient` (STOP included). Allowed only for callers who can WRITE `Clients.isSlaEnabled`. A body empty after the strip becomes `{}` in V2.php and `postPut` still runs. Pattern: [command keys in interceptors](../../api2/features/api-payload-interceptors.md#passing-state-from-a-pre-hook-to-a-post-hook).
+- **One run per client:** the backfill takes `GET_LOCK('sla-recompute-<clientId>', 0)` on the SAME connection as its writes, `RELEASE_LOCK` in `finally`. Lock busy → `_Exception_Validation` 400. Any failure throws, so the API write rolls back. Reuse this shape for any "one at a time per client" operation.
+- **Cross-client:** switch/recompute use `DB_TARGET_CLIENT` (`registerTargetClientDatabase`), never the caller's `DB_CLIENT`. Core and client data are never joined.
 
 ## Gotchas
 
-- **⚠ A stage that "never pauses" is usually data, not code.** Check `TicketStages.slaEffect` / `slaFirstResponseEffect` per stage in that environment first. QA alpha `Client_True` (2026-10-16): every stage stayed RUN because the `Client/2026-09-29d` seed matched by slug before the slugs existed; fixed by `Client_True/2026-10-16a - SlaStageDataRepair.sql`. See [fan-out seed keyed on a slug](../../dbchanges2/features/rerunnable-additive-inserts.md#gotchas).
+- **⚠ A stage that "never pauses" is usually data, not code.** Check the stage table's `slaEffect` (and `slaFirstResponseEffect` for tickets) in that environment first. QA alpha `Client_True` (2026-10-16): every ticket stage stayed RUN because the `Client/2026-09-29d` seed matched by slug before the slugs existed; fixed by `Client_True/2026-10-16a - SlaStageDataRepair.sql`. See [fan-out seed keyed on a slug](../../dbchanges2/features/rerunnable-additive-inserts.md#gotchas).
+- **⚠ Writes that skip api2 skip the SLA.** worker 1.0 Prudential crons set `ServiceRequests.serviceRequestStageId = 2` by direct SQL — no pause is recorded until the next api2 write or a recompute. Accepted gap.
+- **⚠ Full recompute resets accrued paused minutes on records no longer paused** (both engines, pre-existing). Know this before running `recomputeSla` on a client with long past pauses.
 - **⚠ The lock is released before api2 commits.** A second recompute started right after can overlap the first's uncommitted writes. Accepted (operator-only, rare) — do not copy this gap into a high-traffic operation; hold the lock past commit there.
-- **No worker job for big clients** (decided). The recompute runs inside the request, so a very large client can hit the 300 s request cap. Paged at 500 tickets.
-- **`FIELD_LIST` does not validate ENUMs** — `TicketStage::save()` checks both effects explicitly. Keep that check when adding a value.
-- **Changing a stage's effect does not move existing tickets** until their next write or a recompute. Run `{"recomputeSla": true}` after a stage-effect data fix.
+- **No worker job for big clients** (decided). Recompute runs inside the request; a very large client can hit the 300 s request cap. Paged at 500 records.
+- **`FIELD_LIST` does not validate ENUMs** — `TicketStage::save()` checks both effects explicitly. Keep that check (and add it on any new stage model) when adding a value.
+- **Changing a stage's effect does not move existing records** until their next write or a recompute. Run `{"recomputeSla": true}` after a stage-effect data fix.
 
 ## Related
 
 - [Ticket status from stage](./ticket-status-from-stage.md)
+- [Service request status and stages](./service-request-status-and-stages.md)
 - [API payload interceptors](../../api2/features/api-payload-interceptors.md)
 - [Tickets API](../../api2/features/tickets-api.md)
 - [Re-runnable additive migrations](../../dbchanges2/features/rerunnable-additive-inserts.md)
 
 ## Change history
+- 2026-10-19 — Engine made record-generic via `descriptor()`; service requests are descriptor 2 (same columns, `ServiceRequestSlas`, reply clock follows `slaEffect`); tickets unchanged (0 diffs) (TRUE-82915). (jcardinal)
 - 2026-10-16 — Reply clock gets its own per-stage effect (`slaFirstResponseEffect`, pauses outside new/open/reopened); operator recompute via `{"recomputeSla": true}`; per-client named lock (TRUE-82849). (jcardinal)

package/knowledge/2.0/apps/api2/features/api-payload-interceptors.md

@@ -6,7 +6,7 @@ project: API
 client: shared
 type: feature
 status: active
-updated: 2026-10-18
+updated: 2026-10-19
 owners: ["mhammontree", "dfranks", "bala", "snaredla", "jcardinal", "rgirish"]
 files:
   - api2/Component/Api/V2/V2.php
@@ -50,6 +50,7 @@ related:
   - ./language-translation-layer.md
   - ../../_underscore/features/persona-nav-visibility-gate.md
   - ../../../clients/compass-usa/features/approval-decision-flow.md
+  - ../../_underscore/features/service-request-status-and-stages.md
 ---
 
 How `_Model` prePost/postPost/prePut/postPut hooks are dispatched by the api2 /v2 engine only when a metadata row exists — the missing-row silent no-op, the wrong-row hard fatal, and the persistence/transaction traps; open before writing, activating, or debugging any interceptor.
@@ -343,7 +344,8 @@ Refuse API-key callers when the rule is "the signed-in user" (no user on the tok
 - **⚠ Client behaviour never goes on `_Model_Client_X`.** Every tenant with a row for that record inherits it through `parent::` calls. Put it on `_Model_<Client>_X`.
 - **⚠ An own-row PRE guard that checks only `userId` is bypassable** — alias keys (`user`) map after PRE, and a parent-route POST overwrites the stamped FK. Allowlist keys + refuse parent routes. See [own-row guards](#own-row-guards-in-a-pre-interceptor).
 - **A client's rows may be in `Core` (with `clientId`), not in `Client_<X>`** — check both before concluding a client has no interceptors.
-- **⚠ The same hook in BOTH `Core` (with `clientId`) and `Client_<X>` fires TWICE** — both tables are read, nothing dedupes. Adyen (2026-10-08): Core ids 15–17 duplicated client rows 1, 2, 5 → double worker jobs and double NetSuite queueing; fixed by deactivating the Core rows. Keep each `(record, phase, method)` in one table only. See [Adyen reclaim flow](../../../clients/adyen/features/service-request-salesorder-netsuite.md#gotchas).
+- **Duplicate rows are de-duplicated (since 2026-10-19, TRUE-82915).** `registerApiPayloadInterceptorLookupEntry` (`V2.php`) keeps ONE entry per `(record, PRE|POST, httpMethod)` across Core and client tables; the highest `minDepth` wins (NULL lowest). So a generic row (`clientId` / `apiId` NULL) plus a client's own row dispatches once. Before this, both fired (Adyen 2026-10-08: double worker jobs; Elite / Adyen SR `postPost` → double sales-order tasks). **Rollback order:** deactivate generic rows that overlap client rows BEFORE rolling api2 back, or the double dispatch returns. Pre-release check query: header of `dbchanges2/Core/2026-10-19i - TRUE-82915 ServiceRequestInterceptors.sql`. Still keep each key in one table.
+- **⚠ A client override that skips `parent::` silently disables every base hook for that client.** Found 2026-10-19 on four `ServiceRequest` overrides — see [SR status and stages](../../_underscore/features/service-request-status-and-stages.md#gotchas). Adding a base hook = check every client subclass calls `parent::`.
 - **The method name is derived, so a typo'd enum silently misses.** A row with `prePostProcessing = 'PRE'`, `httpMethod = 'PUT'` resolves to `prePut`, not `prePost`; the engine finds no method and moves on.
 - **Registration is per-environment.** Like `RecordFields` / `RecordScripts` / ACL rows, this is metadata — "works in prod, not in beta/dev-sandbox" is the signature of drift, not of a bad deploy. See the [non-prod metadata drift repair workflow](../../dbchanges2/workflows/nonprod-metadata-drift-repair.md).
 - **⚠ An in-request read-after-write in an interceptor works on beta and fails 100% in production.** Reads default to the **reader** connection, which cannot see the request's own uncommitted row; dev-sandbox points writer and reader at the same endpoint, so it hides the bug. Pin with `setIsReadHostEnabled(false)` (restore in `finally`).
@@ -368,6 +370,7 @@ Refuse API-key callers when the rule is "the signed-in user" (no user on the tok
 - [Email template sending](../../_underscore/features/email-template-sending.md)
 - [Elite SalesOrder → NetSuite push](../../../clients/elite/features/salesorder-netsuite-push.md)
 - [Compass sales-order line renumbering](../../../clients/compass-usa/features/sales-order-line-renumbering.md)
+- [Service request status and stages](../../_underscore/features/service-request-status-and-stages.md)
 
 ## Change history
 - 2026-10-08 — `internalApiRequest` "[]" throw also fires on the OUTER request's warnings (e.g. WO-1); throw site now ~L2436; Core + client duplicate rows fire twice. (rgirish)
@@ -376,3 +379,4 @@ Refuse API-key callers when the rule is "the signed-in user" (no user on the tok
 - 2026-10-16 — Command keys: strip in `prePut`, park on `passThrough`, act in `postPut`; empty body → `{}` (TRUE-82849). (jcardinal)
 - 2026-10-18 — Write intent that writes another record via internal request (caller ACL, rollback, `addNote` after the call) (TRUE-82876). (jcardinal)
 - 2026-10-17 — "Action table" pattern for audited actions; write intents before a stage gate; new interceptor rows ship in a file run after the code deploy (TRUE-82889). (jcardinal)
+- 2026-10-19 — Lookup de-duplicates rows per record / PRE|POST / method (highest `minDepth` wins); client overrides must call `parent::` (TRUE-82915). (jcardinal)

package/knowledge/2.0/apps/api2/features/v2-rest-query-contract.md

@@ -49,7 +49,9 @@ controller.
 `fields`, `where`, `join` / `ojoin`, `sort`, `group`, `distinct`, `page`, `recordsPerPage`,
 `depth`, `calcDepth` (or one base64(JSON) `_` blob).
 
-- **Pagination is `page` + `recordsPerPage`. There is no `limit`/`offset`.** Defaults:
+- **Pagination is `page` + `recordsPerPage`. There is no `limit`/`offset`.** A `limit=5` on a
+  list GET is not ignored — it returns **404 `EV-14`** "Expecting one record ... multiple records
+  were found". Defaults:
   `recordsPerPage` **25**, `depth` **3**. Max `recordsPerPage` **10000** — exceeding it returns
   **`EV-13`** (HTTP 400).
 - **Sort:** `-field` = DESC, `+field` = ASC, bare `field` = ASC. All three are handled
@@ -656,6 +658,7 @@ If you need the behaviour, loop uuids client-side. Point 3 is the durable, non-o
   [V2 request logging](request-logging.md).
 
 ## Change history
+- 2026-10-19 — `limit` on a list GET = 404 `EV-14`, use `recordsPerPage` (TRUE-82915). (jcardinal)
 - 2026-10-19 — Self-join `where` needs an `ojoin` alias (`Locations@p`); `_` field ACL bypass does not apply cross-client (TRUE-82911). (jcardinal)
 - 2026-10-18 — Grouped queries: stored root group key now selected + ACL-gated; known gaps (joined key, total count, `ORDER BY uuid` under ONLY_FULL_GROUP_BY) (TRUE-82876). (jcardinal)
 - 2026-10-17 — Child-path `where` must start at an inherent child; FK-first path → TableView join alias (TRUE-82872). (jcardinal)
@@ -667,7 +670,6 @@ If you need the behaviour, loop uuids client-side. Point 3 is the durable, non-o
 - 2026-09-18 — `in` instead of an OR-chain of `contains` shortens SQL only, not speed. (apeterson)
 - 2026-09-17 — Bulk DELETE by `where`: exists, unused, unsafe; zero matches looks like an ACL denial. (rgirish)
 - 2026-09-14 — `where` on a calculated field works with the bare name; `calcDepth` does not gate a named calc field; list GET cost model. (apeterson)
-- 2026-09-08 — `depth` read-back cost (~830s at `depth=5` on a write). (jcardinal)
 - 2026-09-04 — URL-encoded `where` → 500/`EO-1` (`Logs.Issue` 97). (rgirish)
 - 2026-09-01/02 — `_` field in `fields=` is never ACL-checked; inherent-child keys govern writes; bridge `InherentRecordChildren` rows. (apeterson, bala)
 - 2026-07-29 → 08-30 — Created; then: `fields=` does not narrow SELECT, `depth` races deletes, sort `+`/DISTINCT, uuid-READ ignores `where`, joins drive filter not shape, `calcDepth` default 1, FK omitted at max depth, PUT echo can omit fields. (tcox, bala, apeterson, jcardinal)

package/knowledge/2.0/apps/dbchanges2/features/rerunnable-additive-inserts.md

@@ -6,7 +6,7 @@ project: Database Changes
 client: shared
 type: feature
 status: active
-updated: 2026-10-17
+updated: 2026-10-19
 owners: [bala, kyalamarthi, apeterson, ajean, jcardinal, rgirish]
 files:
   - dbchanges2/Client_Compass/2026-08-26a - CompassCreativeStudioPersona.sql
@@ -491,6 +491,7 @@ an INSERT that names only `uuid`/`tableViewId`/`recordFieldId`/`isVisible`/`inde
 - **⚠ `NOT NULL DEFAULT <value>` does not save a `_Model` column** — the ORM writes an explicit NULL,
   which skips the DEFAULT and errors 1048. Ship a model default with the ALTER.
 - **⚠ `col = 0` never matches a NULL** — guard flag-enabling UPDATEs with `COALESCE(col, 0) = 0`, or the migration reports success and changes nothing.
+- **⚠ A `WHERE col <> 'New text'` guard SKIPS a case-only change on a `_ci` column.** `'service request' <> 'Service Request'` is FALSE under `utf8mb4_general_ci`, so the copy UPDATE runs and changes nothing. Guard copy updates with `BINARY col <> 'New text'`. Bug `Core/2026-10-19j`; fixed in `Core/2026-10-19n`..`p` (TRUE-82915).
 - **⚠ An unguarded ACL grant migration duplicates silently — `AclRecordPermissions` has no unique key
   that stops it (found in prod 2026-09-15).** `_modules/netsuite/2026-09-11c - ItemClassRecordPermission.sql`
   is a plain `INSERT … VALUES` for `(recordId 105, roleId 3)` with **no `NOT EXISTS` guard**. Every
@@ -560,6 +561,7 @@ an INSERT that names only `uuid`/`tableViewId`/`recordFieldId`/`isVisible`/`inde
   [FIELD_SQL calculated fields](../../_underscore/features/calculated-sql-fields.md).
 
 ## Change history
+- 2026-10-19 — `<>` copy-update guard skips a case-only change on a `_ci` column; use `BINARY` (TRUE-82915). (jcardinal)
 - 2026-10-17 — `TicketTypes.code` has no UNIQUE and may hold duplicates; guard seeds on `code` (TRUE-82889). (jcardinal)
 - 2026-10-16 — Backfill an api2-identifier column before the deploy (seed file), stragglers + ALTER after (TRUE-82841). (jcardinal)
 - 2026-10-16 — NOT NULL alternative for big tables: strict session + `ALGORITHM=INPLACE, LOCK=NONE`

package/knowledge/INDEX.md

@@ -21,7 +21,7 @@ _Auto-generated by `knowledge.js index`. Do not hand-edit._
 
 ## 2.0 framework
 
-- **_underscore** (_Underscore) _(framework core)_ — 110 doc(s) → [2.0/apps/_underscore/INDEX.md](2.0/apps/_underscore/INDEX.md)
+- **_underscore** (_Underscore) _(framework core)_ — 111 doc(s) → [2.0/apps/_underscore/INDEX.md](2.0/apps/_underscore/INDEX.md)
 - **worker2** (Worker) — 91 doc(s) → [2.0/apps/worker2/INDEX.md](2.0/apps/worker2/INDEX.md)
 - **api2** (API) — 27 doc(s) → [2.0/apps/api2/INDEX.md](2.0/apps/api2/INDEX.md)
 - **dbchanges2** (Database Changes) _(framework core)_ — 22 doc(s) → [2.0/apps/dbchanges2/INDEX.md](2.0/apps/dbchanges2/INDEX.md)

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "toga-ai",
-  "version": "1.0.1082",
+  "version": "1.0.1083",
   "description": "TOGA Technology Team Claude Knowledge System — shared AI coding harness with skills, knowledge base CLI, and project installer for Claude Code.",
   "keywords": [
     "claude",