tldraw 3.16.0-next.4337ae1ab96d → 3.16.0-next.8eb6d5c2d8f4
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/dist-cjs/index.d.ts +100 -14
- package/dist-cjs/index.js +6 -2
- package/dist-cjs/index.js.map +2 -2
- package/dist-cjs/lib/defaultExternalContentHandlers.js +10 -0
- package/dist-cjs/lib/defaultExternalContentHandlers.js.map +2 -2
- package/dist-cjs/lib/shapes/arrow/arrow-types.js.map +1 -1
- package/dist-cjs/lib/shapes/arrow/arrowTargetState.js +3 -2
- package/dist-cjs/lib/shapes/arrow/arrowTargetState.js.map +2 -2
- package/dist-cjs/lib/shapes/arrow/toolStates/Pointing.js +1 -1
- package/dist-cjs/lib/shapes/arrow/toolStates/Pointing.js.map +2 -2
- package/dist-cjs/lib/shapes/bookmark/BookmarkShapeUtil.js +4 -4
- package/dist-cjs/lib/shapes/bookmark/BookmarkShapeUtil.js.map +2 -2
- package/dist-cjs/lib/shapes/frame/FrameShapeUtil.js +2 -1
- package/dist-cjs/lib/shapes/frame/FrameShapeUtil.js.map +2 -2
- package/dist-cjs/lib/shapes/frame/components/FrameLabelInput.js +8 -2
- package/dist-cjs/lib/shapes/frame/components/FrameLabelInput.js.map +2 -2
- package/dist-cjs/lib/shapes/geo/GeoShapeUtil.js +1 -0
- package/dist-cjs/lib/shapes/geo/GeoShapeUtil.js.map +2 -2
- package/dist-cjs/lib/shapes/note/NoteShapeUtil.js +2 -1
- package/dist-cjs/lib/shapes/note/NoteShapeUtil.js.map +2 -2
- package/dist-cjs/lib/shapes/shared/HyperlinkButton.js +4 -4
- package/dist-cjs/lib/shapes/shared/HyperlinkButton.js.map +2 -2
- package/dist-cjs/lib/shapes/shared/useEditablePlainText.js +3 -3
- package/dist-cjs/lib/shapes/shared/useEditablePlainText.js.map +2 -2
- package/dist-cjs/lib/shapes/text/PlainTextArea.js +3 -2
- package/dist-cjs/lib/shapes/text/PlainTextArea.js.map +2 -2
- package/dist-cjs/lib/shapes/text/RichTextArea.js +3 -3
- package/dist-cjs/lib/shapes/text/RichTextArea.js.map +2 -2
- package/dist-cjs/lib/tools/SelectTool/childStates/DraggingHandle.js +3 -1
- package/dist-cjs/lib/tools/SelectTool/childStates/DraggingHandle.js.map +2 -2
- package/dist-cjs/lib/ui/components/A11y.js +1 -1
- package/dist-cjs/lib/ui/components/A11y.js.map +2 -2
- package/dist-cjs/lib/ui/components/AccessibilityMenu.js +1 -1
- package/dist-cjs/lib/ui/components/AccessibilityMenu.js.map +2 -2
- package/dist-cjs/lib/ui/components/InputModeMenu.js +77 -0
- package/dist-cjs/lib/ui/components/InputModeMenu.js.map +7 -0
- package/dist-cjs/lib/ui/components/LanguageMenu.js +1 -0
- package/dist-cjs/lib/ui/components/LanguageMenu.js.map +2 -2
- package/dist-cjs/lib/ui/components/MainMenu/DefaultMainMenuContent.js +2 -0
- package/dist-cjs/lib/ui/components/MainMenu/DefaultMainMenuContent.js.map +2 -2
- package/dist-cjs/lib/ui/components/Minimap/DefaultMinimap.js +2 -1
- package/dist-cjs/lib/ui/components/Minimap/DefaultMinimap.js.map +2 -2
- package/dist-cjs/lib/ui/components/PageMenu/DefaultPageMenu.js +1 -1
- package/dist-cjs/lib/ui/components/PageMenu/DefaultPageMenu.js.map +2 -2
- package/dist-cjs/lib/ui/components/StylePanel/DefaultStylePanel.js +4 -2
- package/dist-cjs/lib/ui/components/StylePanel/DefaultStylePanel.js.map +2 -2
- package/dist-cjs/lib/ui/components/StylePanel/DefaultStylePanelContent.js +2 -2
- package/dist-cjs/lib/ui/components/StylePanel/DefaultStylePanelContent.js.map +2 -2
- package/dist-cjs/lib/ui/components/StylePanel/StylePanelButtonPicker.js +12 -3
- package/dist-cjs/lib/ui/components/StylePanel/StylePanelButtonPicker.js.map +2 -2
- package/dist-cjs/lib/ui/components/StylePanel/StylePanelContext.js +4 -2
- package/dist-cjs/lib/ui/components/StylePanel/StylePanelContext.js.map +2 -2
- package/dist-cjs/lib/ui/components/Toolbar/AltTextEditor.js +3 -2
- package/dist-cjs/lib/ui/components/Toolbar/AltTextEditor.js.map +2 -2
- package/dist-cjs/lib/ui/components/Toolbar/LinkEditor.js +5 -4
- package/dist-cjs/lib/ui/components/Toolbar/LinkEditor.js.map +2 -2
- package/dist-cjs/lib/ui/components/Toolbar/OverflowingToolbar.js +1 -1
- package/dist-cjs/lib/ui/components/Toolbar/OverflowingToolbar.js.map +2 -2
- package/dist-cjs/lib/ui/components/Toolbar/ToggleToolLockedButton.js +6 -2
- package/dist-cjs/lib/ui/components/Toolbar/ToggleToolLockedButton.js.map +2 -2
- package/dist-cjs/lib/ui/components/menu-items.js +6 -4
- package/dist-cjs/lib/ui/components/menu-items.js.map +2 -2
- package/dist-cjs/lib/ui/components/primitives/TldrawUiContextualToolbar.js +1 -1
- package/dist-cjs/lib/ui/components/primitives/TldrawUiContextualToolbar.js.map +2 -2
- package/dist-cjs/lib/ui/components/primitives/TldrawUiInput.js +5 -3
- package/dist-cjs/lib/ui/components/primitives/TldrawUiInput.js.map +2 -2
- package/dist-cjs/lib/ui/components/primitives/TldrawUiSlider.js +1 -1
- package/dist-cjs/lib/ui/components/primitives/TldrawUiSlider.js.map +2 -2
- package/dist-cjs/lib/ui/components/primitives/TldrawUiToolbar.js +1 -0
- package/dist-cjs/lib/ui/components/primitives/TldrawUiToolbar.js.map +2 -2
- package/dist-cjs/lib/ui/components/primitives/TldrawUiTooltip.js +68 -20
- package/dist-cjs/lib/ui/components/primitives/TldrawUiTooltip.js.map +2 -2
- package/dist-cjs/lib/ui/components/primitives/menus/TldrawUiMenuCheckboxItem.js +3 -0
- package/dist-cjs/lib/ui/components/primitives/menus/TldrawUiMenuCheckboxItem.js.map +2 -2
- package/dist-cjs/lib/ui/components/primitives/menus/TldrawUiMenuItem.js +8 -8
- package/dist-cjs/lib/ui/components/primitives/menus/TldrawUiMenuItem.js.map +2 -2
- package/dist-cjs/lib/ui/context/actions.js +11 -25
- package/dist-cjs/lib/ui/context/actions.js.map +2 -2
- package/dist-cjs/lib/ui/context/events.js.map +2 -2
- package/dist-cjs/lib/ui/hooks/useClipboardEvents.js +1 -1
- package/dist-cjs/lib/ui/hooks/useClipboardEvents.js.map +2 -2
- package/dist-cjs/lib/ui/hooks/useTranslation/TLUiTranslationKey.js.map +1 -1
- package/dist-cjs/lib/ui/hooks/useTranslation/defaultTranslation.js +11 -3
- package/dist-cjs/lib/ui/hooks/useTranslation/defaultTranslation.js.map +2 -2
- package/dist-cjs/lib/ui/version.js +3 -3
- package/dist-cjs/lib/ui/version.js.map +1 -1
- package/dist-esm/index.d.mts +100 -14
- package/dist-esm/index.mjs +11 -3
- package/dist-esm/index.mjs.map +2 -2
- package/dist-esm/lib/defaultExternalContentHandlers.mjs +10 -0
- package/dist-esm/lib/defaultExternalContentHandlers.mjs.map +2 -2
- package/dist-esm/lib/shapes/arrow/arrowTargetState.mjs +3 -2
- package/dist-esm/lib/shapes/arrow/arrowTargetState.mjs.map +2 -2
- package/dist-esm/lib/shapes/arrow/toolStates/Pointing.mjs +1 -1
- package/dist-esm/lib/shapes/arrow/toolStates/Pointing.mjs.map +2 -2
- package/dist-esm/lib/shapes/bookmark/BookmarkShapeUtil.mjs +4 -5
- package/dist-esm/lib/shapes/bookmark/BookmarkShapeUtil.mjs.map +2 -2
- package/dist-esm/lib/shapes/frame/FrameShapeUtil.mjs +2 -1
- package/dist-esm/lib/shapes/frame/FrameShapeUtil.mjs.map +2 -2
- package/dist-esm/lib/shapes/frame/components/FrameLabelInput.mjs +9 -3
- package/dist-esm/lib/shapes/frame/components/FrameLabelInput.mjs.map +2 -2
- package/dist-esm/lib/shapes/geo/GeoShapeUtil.mjs +1 -0
- package/dist-esm/lib/shapes/geo/GeoShapeUtil.mjs.map +2 -2
- package/dist-esm/lib/shapes/note/NoteShapeUtil.mjs +2 -1
- package/dist-esm/lib/shapes/note/NoteShapeUtil.mjs.map +2 -2
- package/dist-esm/lib/shapes/shared/HyperlinkButton.mjs +5 -5
- package/dist-esm/lib/shapes/shared/HyperlinkButton.mjs.map +2 -2
- package/dist-esm/lib/shapes/shared/useEditablePlainText.mjs +3 -4
- package/dist-esm/lib/shapes/shared/useEditablePlainText.mjs.map +2 -2
- package/dist-esm/lib/shapes/text/PlainTextArea.mjs +4 -3
- package/dist-esm/lib/shapes/text/PlainTextArea.mjs.map +2 -2
- package/dist-esm/lib/shapes/text/RichTextArea.mjs +3 -4
- package/dist-esm/lib/shapes/text/RichTextArea.mjs.map +2 -2
- package/dist-esm/lib/tools/SelectTool/childStates/DraggingHandle.mjs +3 -1
- package/dist-esm/lib/tools/SelectTool/childStates/DraggingHandle.mjs.map +2 -2
- package/dist-esm/lib/ui/components/A11y.mjs +1 -2
- package/dist-esm/lib/ui/components/A11y.mjs.map +2 -2
- package/dist-esm/lib/ui/components/AccessibilityMenu.mjs +3 -3
- package/dist-esm/lib/ui/components/AccessibilityMenu.mjs.map +2 -2
- package/dist-esm/lib/ui/components/InputModeMenu.mjs +57 -0
- package/dist-esm/lib/ui/components/InputModeMenu.mjs.map +7 -0
- package/dist-esm/lib/ui/components/LanguageMenu.mjs +1 -0
- package/dist-esm/lib/ui/components/LanguageMenu.mjs.map +2 -2
- package/dist-esm/lib/ui/components/MainMenu/DefaultMainMenuContent.mjs +2 -0
- package/dist-esm/lib/ui/components/MainMenu/DefaultMainMenuContent.mjs.map +2 -2
- package/dist-esm/lib/ui/components/Minimap/DefaultMinimap.mjs +2 -1
- package/dist-esm/lib/ui/components/Minimap/DefaultMinimap.mjs.map +2 -2
- package/dist-esm/lib/ui/components/PageMenu/DefaultPageMenu.mjs +1 -2
- package/dist-esm/lib/ui/components/PageMenu/DefaultPageMenu.mjs.map +2 -2
- package/dist-esm/lib/ui/components/StylePanel/DefaultStylePanel.mjs +4 -2
- package/dist-esm/lib/ui/components/StylePanel/DefaultStylePanel.mjs.map +2 -2
- package/dist-esm/lib/ui/components/StylePanel/DefaultStylePanelContent.mjs +2 -2
- package/dist-esm/lib/ui/components/StylePanel/DefaultStylePanelContent.mjs.map +2 -2
- package/dist-esm/lib/ui/components/StylePanel/StylePanelButtonPicker.mjs +12 -3
- package/dist-esm/lib/ui/components/StylePanel/StylePanelButtonPicker.mjs.map +2 -2
- package/dist-esm/lib/ui/components/StylePanel/StylePanelContext.mjs +4 -2
- package/dist-esm/lib/ui/components/StylePanel/StylePanelContext.mjs.map +2 -2
- package/dist-esm/lib/ui/components/Toolbar/AltTextEditor.mjs +3 -2
- package/dist-esm/lib/ui/components/Toolbar/AltTextEditor.mjs.map +2 -2
- package/dist-esm/lib/ui/components/Toolbar/LinkEditor.mjs +5 -4
- package/dist-esm/lib/ui/components/Toolbar/LinkEditor.mjs.map +2 -2
- package/dist-esm/lib/ui/components/Toolbar/OverflowingToolbar.mjs +1 -1
- package/dist-esm/lib/ui/components/Toolbar/OverflowingToolbar.mjs.map +2 -2
- package/dist-esm/lib/ui/components/Toolbar/ToggleToolLockedButton.mjs +6 -2
- package/dist-esm/lib/ui/components/Toolbar/ToggleToolLockedButton.mjs.map +2 -2
- package/dist-esm/lib/ui/components/menu-items.mjs +6 -4
- package/dist-esm/lib/ui/components/menu-items.mjs.map +2 -2
- package/dist-esm/lib/ui/components/primitives/TldrawUiContextualToolbar.mjs +1 -2
- package/dist-esm/lib/ui/components/primitives/TldrawUiContextualToolbar.mjs.map +2 -2
- package/dist-esm/lib/ui/components/primitives/TldrawUiInput.mjs +6 -4
- package/dist-esm/lib/ui/components/primitives/TldrawUiInput.mjs.map +2 -2
- package/dist-esm/lib/ui/components/primitives/TldrawUiSlider.mjs +1 -1
- package/dist-esm/lib/ui/components/primitives/TldrawUiSlider.mjs.map +2 -2
- package/dist-esm/lib/ui/components/primitives/TldrawUiToolbar.mjs +1 -0
- package/dist-esm/lib/ui/components/primitives/TldrawUiToolbar.mjs.map +2 -2
- package/dist-esm/lib/ui/components/primitives/TldrawUiTooltip.mjs +69 -20
- package/dist-esm/lib/ui/components/primitives/TldrawUiTooltip.mjs.map +2 -2
- package/dist-esm/lib/ui/components/primitives/menus/TldrawUiMenuCheckboxItem.mjs +3 -0
- package/dist-esm/lib/ui/components/primitives/menus/TldrawUiMenuCheckboxItem.mjs.map +2 -2
- package/dist-esm/lib/ui/components/primitives/menus/TldrawUiMenuItem.mjs +8 -8
- package/dist-esm/lib/ui/components/primitives/menus/TldrawUiMenuItem.mjs.map +2 -2
- package/dist-esm/lib/ui/context/actions.mjs +11 -25
- package/dist-esm/lib/ui/context/actions.mjs.map +2 -2
- package/dist-esm/lib/ui/context/events.mjs.map +2 -2
- package/dist-esm/lib/ui/hooks/useClipboardEvents.mjs +1 -2
- package/dist-esm/lib/ui/hooks/useClipboardEvents.mjs.map +2 -2
- package/dist-esm/lib/ui/hooks/useTranslation/defaultTranslation.mjs +11 -3
- package/dist-esm/lib/ui/hooks/useTranslation/defaultTranslation.mjs.map +2 -2
- package/dist-esm/lib/ui/version.mjs +3 -3
- package/dist-esm/lib/ui/version.mjs.map +1 -1
- package/package.json +3 -3
- package/src/index.ts +8 -1
- package/src/lib/defaultExternalContentHandlers.ts +14 -0
- package/src/lib/shapes/arrow/ArrowShapeOptions.test.ts +83 -13
- package/src/lib/shapes/arrow/ArrowShapeTool.test.ts +99 -5
- package/src/lib/shapes/arrow/ArrowShapeUtil.test.ts +41 -0
- package/src/lib/shapes/arrow/arrow-types.ts +3 -5
- package/src/lib/shapes/arrow/arrowTargetState.ts +34 -3
- package/src/lib/shapes/arrow/toolStates/Pointing.tsx +1 -1
- package/src/lib/shapes/bookmark/BookmarkShapeUtil.tsx +4 -5
- package/src/lib/shapes/frame/FrameShapeUtil.tsx +1 -0
- package/src/lib/shapes/frame/components/FrameLabelInput.tsx +10 -3
- package/src/lib/shapes/geo/GeoShapeUtil.tsx +1 -0
- package/src/lib/shapes/note/NoteShapeUtil.tsx +1 -0
- package/src/lib/shapes/shared/HyperlinkButton.tsx +5 -5
- package/src/lib/shapes/shared/useEditablePlainText.ts +3 -4
- package/src/lib/shapes/text/PlainTextArea.tsx +4 -3
- package/src/lib/shapes/text/RichTextArea.tsx +3 -4
- package/src/lib/tools/SelectTool/childStates/DraggingHandle.tsx +6 -2
- package/src/lib/ui/components/A11y.tsx +1 -2
- package/src/lib/ui/components/AccessibilityMenu.tsx +2 -2
- package/src/lib/ui/components/InputModeMenu.tsx +65 -0
- package/src/lib/ui/components/LanguageMenu.tsx +1 -0
- package/src/lib/ui/components/MainMenu/DefaultMainMenuContent.tsx +4 -0
- package/src/lib/ui/components/Minimap/DefaultMinimap.tsx +2 -1
- package/src/lib/ui/components/PageMenu/DefaultPageMenu.tsx +1 -2
- package/src/lib/ui/components/StylePanel/DefaultStylePanel.tsx +4 -2
- package/src/lib/ui/components/StylePanel/DefaultStylePanelContent.tsx +4 -2
- package/src/lib/ui/components/StylePanel/StylePanelButtonPicker.tsx +10 -3
- package/src/lib/ui/components/StylePanel/StylePanelContext.tsx +5 -3
- package/src/lib/ui/components/Toolbar/AltTextEditor.tsx +4 -3
- package/src/lib/ui/components/Toolbar/LinkEditor.tsx +6 -5
- package/src/lib/ui/components/Toolbar/OverflowingToolbar.tsx +1 -1
- package/src/lib/ui/components/Toolbar/ToggleToolLockedButton.tsx +9 -2
- package/src/lib/ui/components/menu-items.tsx +5 -3
- package/src/lib/ui/components/primitives/TldrawUiContextualToolbar.tsx +1 -2
- package/src/lib/ui/components/primitives/TldrawUiInput.tsx +6 -3
- package/src/lib/ui/components/primitives/TldrawUiSlider.tsx +2 -2
- package/src/lib/ui/components/primitives/TldrawUiToolbar.tsx +2 -1
- package/src/lib/ui/components/primitives/TldrawUiTooltip.tsx +65 -14
- package/src/lib/ui/components/primitives/menus/TldrawUiMenuCheckboxItem.tsx +4 -0
- package/src/lib/ui/components/primitives/menus/TldrawUiMenuItem.tsx +9 -9
- package/src/lib/ui/context/actions.tsx +18 -27
- package/src/lib/ui/context/events.tsx +2 -1
- package/src/lib/ui/hooks/useClipboardEvents.ts +1 -2
- package/src/lib/ui/hooks/useTranslation/TLUiTranslationKey.ts +10 -2
- package/src/lib/ui/hooks/useTranslation/defaultTranslation.ts +11 -3
- package/src/lib/ui/version.ts +3 -3
- package/src/lib/ui.css +25 -2
- package/src/test/TestEditor.ts +8 -2
- package/src/test/commands/setCamera.test.ts +13 -0
- package/src/test/frames.test.ts +15 -0
- package/src/test/getCulledShapes.test.tsx +71 -2
- package/tldraw.css +33 -5
|
@@ -47,13 +47,21 @@ describe('ArrowShapeOptions', () => {
|
|
|
47
47
|
it('should have correct default shouldBeExact behavior (alt key)', () => {
|
|
48
48
|
const util = editor.getShapeUtil<ArrowShapeUtil>('arrow')
|
|
49
49
|
|
|
50
|
-
// Test without alt key
|
|
50
|
+
// Test without alt key, not precise
|
|
51
51
|
editor.inputs.altKey = false
|
|
52
|
-
expect(util.options.shouldBeExact(editor)).toBe(false)
|
|
52
|
+
expect(util.options.shouldBeExact(editor, false)).toBe(false)
|
|
53
53
|
|
|
54
|
-
// Test
|
|
54
|
+
// Test without alt key, precise
|
|
55
|
+
editor.inputs.altKey = false
|
|
56
|
+
expect(util.options.shouldBeExact(editor, true)).toBe(false)
|
|
57
|
+
|
|
58
|
+
// Test with alt key, not precise
|
|
59
|
+
editor.inputs.altKey = true
|
|
60
|
+
expect(util.options.shouldBeExact(editor, false)).toBe(true)
|
|
61
|
+
|
|
62
|
+
// Test with alt key, precise
|
|
55
63
|
editor.inputs.altKey = true
|
|
56
|
-
expect(util.options.shouldBeExact(editor)).toBe(true)
|
|
64
|
+
expect(util.options.shouldBeExact(editor, true)).toBe(true)
|
|
57
65
|
})
|
|
58
66
|
|
|
59
67
|
it('should have correct default shouldIgnoreTargets behavior (ctrl key)', () => {
|
|
@@ -186,7 +194,7 @@ describe('ArrowShapeOptions', () => {
|
|
|
186
194
|
class CustomArrowShapeUtil extends ArrowShapeUtil {
|
|
187
195
|
override options = {
|
|
188
196
|
...baseUtil.options,
|
|
189
|
-
shouldBeExact: (editor: any) => editor.inputs.shiftKey, // Use shift instead of alt
|
|
197
|
+
shouldBeExact: (editor: any, _isPrecise: boolean) => editor.inputs.shiftKey, // Use shift instead of alt
|
|
190
198
|
}
|
|
191
199
|
}
|
|
192
200
|
|
|
@@ -195,12 +203,14 @@ describe('ArrowShapeOptions', () => {
|
|
|
195
203
|
// Test with shift key
|
|
196
204
|
editor.inputs.shiftKey = true
|
|
197
205
|
editor.inputs.altKey = false
|
|
198
|
-
expect(customUtil.options.shouldBeExact(editor)).toBe(true)
|
|
206
|
+
expect(customUtil.options.shouldBeExact(editor, false)).toBe(true)
|
|
207
|
+
expect(customUtil.options.shouldBeExact(editor, true)).toBe(true)
|
|
199
208
|
|
|
200
209
|
// Test without shift key
|
|
201
210
|
editor.inputs.shiftKey = false
|
|
202
211
|
editor.inputs.altKey = true // Alt key should not matter for custom implementation
|
|
203
|
-
expect(customUtil.options.shouldBeExact(editor)).toBe(false)
|
|
212
|
+
expect(customUtil.options.shouldBeExact(editor, false)).toBe(false)
|
|
213
|
+
expect(customUtil.options.shouldBeExact(editor, true)).toBe(false)
|
|
204
214
|
})
|
|
205
215
|
|
|
206
216
|
it('should allow customizing shouldIgnoreTargets behavior', () => {
|
|
@@ -232,9 +242,9 @@ describe('ArrowShapeOptions', () => {
|
|
|
232
242
|
class CustomArrowShapeUtil extends ArrowShapeUtil {
|
|
233
243
|
override options = {
|
|
234
244
|
...baseUtil.options,
|
|
235
|
-
shouldBeExact: (editor: any) => {
|
|
236
|
-
// Custom logic: exact when both alt and shift are pressed
|
|
237
|
-
return editor.inputs.altKey && editor.inputs.shiftKey
|
|
245
|
+
shouldBeExact: (editor: any, isPrecise: boolean) => {
|
|
246
|
+
// Custom logic: exact when both alt and shift are pressed, and only if precise
|
|
247
|
+
return editor.inputs.altKey && editor.inputs.shiftKey && isPrecise
|
|
238
248
|
},
|
|
239
249
|
shouldIgnoreTargets: (editor: any) => {
|
|
240
250
|
// Custom logic: ignore targets when any modifier key is pressed
|
|
@@ -245,15 +255,20 @@ describe('ArrowShapeOptions', () => {
|
|
|
245
255
|
|
|
246
256
|
const customUtil = new CustomArrowShapeUtil(editor)
|
|
247
257
|
|
|
248
|
-
// Test shouldBeExact with both keys
|
|
258
|
+
// Test shouldBeExact with both keys and precise
|
|
249
259
|
editor.inputs.altKey = true
|
|
250
260
|
editor.inputs.shiftKey = true
|
|
251
|
-
expect(customUtil.options.shouldBeExact(editor)).toBe(true)
|
|
261
|
+
expect(customUtil.options.shouldBeExact(editor, true)).toBe(true)
|
|
262
|
+
|
|
263
|
+
// Test shouldBeExact with both keys but not precise
|
|
264
|
+
editor.inputs.altKey = true
|
|
265
|
+
editor.inputs.shiftKey = true
|
|
266
|
+
expect(customUtil.options.shouldBeExact(editor, false)).toBe(false)
|
|
252
267
|
|
|
253
268
|
// Test shouldBeExact with only one key
|
|
254
269
|
editor.inputs.altKey = true
|
|
255
270
|
editor.inputs.shiftKey = false
|
|
256
|
-
expect(customUtil.options.shouldBeExact(editor)).toBe(false)
|
|
271
|
+
expect(customUtil.options.shouldBeExact(editor, true)).toBe(false)
|
|
257
272
|
|
|
258
273
|
// Test shouldIgnoreTargets with any key
|
|
259
274
|
editor.inputs.altKey = false
|
|
@@ -283,6 +298,61 @@ describe('ArrowShapeOptions', () => {
|
|
|
283
298
|
expect(editor.getCurrentToolId()).toBe('arrow')
|
|
284
299
|
})
|
|
285
300
|
|
|
301
|
+
it('should allow custom shouldBeExact logic based on isPrecise - example from arrow precise-exact', () => {
|
|
302
|
+
// This replicates the logic from the arrows-precise-exact example
|
|
303
|
+
const baseUtil = editor.getShapeUtil<ArrowShapeUtil>('arrow')
|
|
304
|
+
class ExampleArrowShapeUtil extends ArrowShapeUtil {
|
|
305
|
+
override options = {
|
|
306
|
+
...baseUtil.options,
|
|
307
|
+
shouldBeExact: (_editor: any, isPrecise: boolean) => isPrecise,
|
|
308
|
+
}
|
|
309
|
+
}
|
|
310
|
+
|
|
311
|
+
// Replace the util temporarily for testing
|
|
312
|
+
const customUtil = new ExampleArrowShapeUtil(editor)
|
|
313
|
+
const originalShouldBeExact = baseUtil.options.shouldBeExact
|
|
314
|
+
baseUtil.options.shouldBeExact = customUtil.options.shouldBeExact
|
|
315
|
+
|
|
316
|
+
try {
|
|
317
|
+
editor.setCurrentTool('arrow')
|
|
318
|
+
editor.inputs.ctrlKey = false // Allow binding
|
|
319
|
+
|
|
320
|
+
// Set up fast pointer velocity to ensure precise remains false
|
|
321
|
+
editor.inputs.pointerVelocity = { x: 2, y: 2, len: () => 2.8 } as any
|
|
322
|
+
|
|
323
|
+
const targetState = updateArrowTargetState({
|
|
324
|
+
editor,
|
|
325
|
+
pointInPageSpace: { x: 150, y: 150 },
|
|
326
|
+
arrow: undefined,
|
|
327
|
+
isPrecise: true, // Input precise
|
|
328
|
+
currentBinding: undefined,
|
|
329
|
+
oppositeBinding: undefined,
|
|
330
|
+
})
|
|
331
|
+
|
|
332
|
+
// With the custom logic, precise arrows should be exact
|
|
333
|
+
expect(targetState?.isExact).toBe(true)
|
|
334
|
+
expect(targetState?.isPrecise).toBe(true)
|
|
335
|
+
|
|
336
|
+
// Test with non-precise movement (and fast velocity to avoid auto-precise)
|
|
337
|
+
const nonPreciseTargetState = updateArrowTargetState({
|
|
338
|
+
editor,
|
|
339
|
+
pointInPageSpace: { x: 150, y: 150 },
|
|
340
|
+
arrow: undefined,
|
|
341
|
+
isPrecise: false, // Not precise
|
|
342
|
+
currentBinding: undefined,
|
|
343
|
+
oppositeBinding: undefined,
|
|
344
|
+
})
|
|
345
|
+
|
|
346
|
+
// Non-precise arrows should not be exact with this custom logic,
|
|
347
|
+
// but they might still become precise due to internal logic
|
|
348
|
+
// The key test is that shouldBeExact gets the final computed precise value
|
|
349
|
+
expect(nonPreciseTargetState).toBeDefined()
|
|
350
|
+
} finally {
|
|
351
|
+
// Restore original function
|
|
352
|
+
baseUtil.options.shouldBeExact = originalShouldBeExact
|
|
353
|
+
}
|
|
354
|
+
})
|
|
355
|
+
|
|
286
356
|
it('should respect shouldIgnoreTargets when starting arrow creation', () => {
|
|
287
357
|
editor.setCurrentTool('arrow')
|
|
288
358
|
|
|
@@ -1,6 +1,8 @@
|
|
|
1
1
|
import { IndexKey, TLArrowShape, TLShapeId, Vec, createShapeId } from '@tldraw/editor'
|
|
2
2
|
import { vi } from 'vitest'
|
|
3
3
|
import { TestEditor } from '../../../test/TestEditor'
|
|
4
|
+
import { defaultShapeUtils } from '../../defaultShapeUtils'
|
|
5
|
+
import { ArrowShapeUtil } from './ArrowShapeUtil'
|
|
4
6
|
import { getArrowTargetState } from './arrowTargetState'
|
|
5
7
|
import { getArrowBindings } from './shared'
|
|
6
8
|
|
|
@@ -26,8 +28,8 @@ function bindings(id: TLShapeId) {
|
|
|
26
28
|
return getArrowBindings(editor, editor.getShape(id) as TLArrowShape)
|
|
27
29
|
}
|
|
28
30
|
|
|
29
|
-
|
|
30
|
-
editor = new TestEditor()
|
|
31
|
+
function init(opts?: ConstructorParameters<typeof TestEditor>[0]) {
|
|
32
|
+
editor = new TestEditor(opts)
|
|
31
33
|
editor
|
|
32
34
|
.selectAll()
|
|
33
35
|
.deleteShapes(editor.getSelectedShapeIds())
|
|
@@ -36,7 +38,9 @@ beforeEach(() => {
|
|
|
36
38
|
{ id: ids.box2, type: 'geo', x: 300, y: 300, props: { w: 100, h: 100 } },
|
|
37
39
|
{ id: ids.box3, type: 'geo', x: 350, y: 350, props: { w: 50, h: 50 } }, // overlapping box2, but smaller!
|
|
38
40
|
])
|
|
39
|
-
}
|
|
41
|
+
}
|
|
42
|
+
|
|
43
|
+
beforeEach(init)
|
|
40
44
|
|
|
41
45
|
it('enters the arrow state', () => {
|
|
42
46
|
editor.setCurrentTool('arrow')
|
|
@@ -569,12 +573,102 @@ describe('reparenting issue', () => {
|
|
|
569
573
|
const arrow1BoundIndex = editor.getShape(arrow1Id)!.index
|
|
570
574
|
const arrow2BoundIndex = editor.getShape(arrow2Id)!.index
|
|
571
575
|
expect(arrow1BoundIndex).toBe('a1V')
|
|
572
|
-
expect(arrow2BoundIndex).toBe('
|
|
576
|
+
expect(arrow2BoundIndex).toBe('a1G')
|
|
573
577
|
|
|
574
578
|
// nudge everything around and make sure we all stay in the right order
|
|
575
579
|
editor.selectAll().nudgeShapes(editor.getSelectedShapeIds(), { x: -1, y: 0 })
|
|
576
580
|
expect(editor.getShape(arrow1Id)!.index).toBe('a1V')
|
|
577
|
-
expect(editor.getShape(arrow2Id)!.index).toBe('
|
|
581
|
+
expect(editor.getShape(arrow2Id)!.index).toBe('a1G')
|
|
582
|
+
})
|
|
583
|
+
})
|
|
584
|
+
|
|
585
|
+
describe('precision timeout configuration', () => {
|
|
586
|
+
it('uses a timeout when dragging arrow handles', () => {
|
|
587
|
+
// Create an arrow first
|
|
588
|
+
|
|
589
|
+
editor.setCurrentTool('arrow').pointerDown(0, 0)
|
|
590
|
+
// Use high velocity to avoid precise mode immediately
|
|
591
|
+
editor.inputs.pointerVelocity = new Vec(1, 1)
|
|
592
|
+
editor.pointerMove(100, 100)
|
|
593
|
+
|
|
594
|
+
const arrow = editor.getCurrentPageShapes()[
|
|
595
|
+
editor.getCurrentPageShapes().length - 1
|
|
596
|
+
] as TLArrowShape
|
|
597
|
+
|
|
598
|
+
editor.expectToBeIn('select.dragging_handle')
|
|
599
|
+
|
|
600
|
+
expect(bindings(arrow.id)).toMatchObject({
|
|
601
|
+
end: {
|
|
602
|
+
toId: ids.box1,
|
|
603
|
+
props: {
|
|
604
|
+
isPrecise: false,
|
|
605
|
+
},
|
|
606
|
+
},
|
|
607
|
+
})
|
|
608
|
+
|
|
609
|
+
vi.advanceTimersByTime(1000)
|
|
610
|
+
|
|
611
|
+
expect(bindings(arrow.id)).toMatchObject({
|
|
612
|
+
end: {
|
|
613
|
+
toId: ids.box1,
|
|
614
|
+
props: {
|
|
615
|
+
isPrecise: true,
|
|
616
|
+
},
|
|
617
|
+
},
|
|
618
|
+
})
|
|
619
|
+
})
|
|
620
|
+
|
|
621
|
+
it('allows configuring the pointingPreciseTimeout', () => {
|
|
622
|
+
init({
|
|
623
|
+
shapeUtils: [
|
|
624
|
+
...defaultShapeUtils.map((s) =>
|
|
625
|
+
s.type === 'arrow' ? ArrowShapeUtil.configure({ pointingPreciseTimeout: 2000 }) : s
|
|
626
|
+
),
|
|
627
|
+
],
|
|
628
|
+
})
|
|
629
|
+
// Create an arrow first
|
|
630
|
+
|
|
631
|
+
editor.setCurrentTool('arrow').pointerDown(0, 0)
|
|
632
|
+
// Use high velocity to avoid precise mode immediately
|
|
633
|
+
editor.inputs.pointerVelocity = new Vec(1, 1)
|
|
634
|
+
editor.pointerMove(100, 100)
|
|
635
|
+
|
|
636
|
+
const arrow = editor.getCurrentPageShapes()[
|
|
637
|
+
editor.getCurrentPageShapes().length - 1
|
|
638
|
+
] as TLArrowShape
|
|
639
|
+
|
|
640
|
+
editor.expectToBeIn('select.dragging_handle')
|
|
641
|
+
|
|
642
|
+
expect(bindings(arrow.id)).toMatchObject({
|
|
643
|
+
end: {
|
|
644
|
+
toId: ids.box1,
|
|
645
|
+
props: {
|
|
646
|
+
isPrecise: false,
|
|
647
|
+
},
|
|
648
|
+
},
|
|
649
|
+
})
|
|
650
|
+
|
|
651
|
+
vi.advanceTimersByTime(1000)
|
|
652
|
+
|
|
653
|
+
expect(bindings(arrow.id)).toMatchObject({
|
|
654
|
+
end: {
|
|
655
|
+
toId: ids.box1,
|
|
656
|
+
props: {
|
|
657
|
+
isPrecise: false,
|
|
658
|
+
},
|
|
659
|
+
},
|
|
660
|
+
})
|
|
661
|
+
|
|
662
|
+
vi.advanceTimersByTime(1000)
|
|
663
|
+
|
|
664
|
+
expect(bindings(arrow.id)).toMatchObject({
|
|
665
|
+
end: {
|
|
666
|
+
toId: ids.box1,
|
|
667
|
+
props: {
|
|
668
|
+
isPrecise: true,
|
|
669
|
+
},
|
|
670
|
+
},
|
|
671
|
+
})
|
|
578
672
|
})
|
|
579
673
|
})
|
|
580
674
|
|
|
@@ -579,3 +579,44 @@ describe("an arrow's parents", () => {
|
|
|
579
579
|
})
|
|
580
580
|
})
|
|
581
581
|
})
|
|
582
|
+
|
|
583
|
+
describe('Arrow export bounds', () => {
|
|
584
|
+
it('excludes labels from shape bounds for export', () => {
|
|
585
|
+
editor.selectAll().deleteShapes(editor.getSelectedShapeIds())
|
|
586
|
+
|
|
587
|
+
// Create shapes for the arrow to bind to
|
|
588
|
+
editor.createShapes([
|
|
589
|
+
{ id: ids.box1, type: 'geo', x: 100, y: 100, props: { w: 100, h: 100 } },
|
|
590
|
+
{ id: ids.box2, type: 'geo', x: 300, y: 100, props: { w: 100, h: 100 } },
|
|
591
|
+
])
|
|
592
|
+
|
|
593
|
+
// Create an arrow with a label
|
|
594
|
+
editor.createShapes([
|
|
595
|
+
{
|
|
596
|
+
id: ids.arrow1,
|
|
597
|
+
type: 'arrow',
|
|
598
|
+
x: 0,
|
|
599
|
+
y: 0,
|
|
600
|
+
props: {
|
|
601
|
+
start: { x: 0, y: 0 },
|
|
602
|
+
end: { x: 0, y: 100 },
|
|
603
|
+
richText: toRichText('Test Label'),
|
|
604
|
+
},
|
|
605
|
+
},
|
|
606
|
+
])
|
|
607
|
+
|
|
608
|
+
// Get the page bounds (should exclude labels due to excludeFromShapeBounds flag)
|
|
609
|
+
const pageBounds = editor.getShapePageBounds(ids.arrow1)
|
|
610
|
+
expect(pageBounds).toBeDefined()
|
|
611
|
+
|
|
612
|
+
// The bounds should be smaller than if labels were included
|
|
613
|
+
// Since the arrow has a label that's excluded, the bounds should be minimal
|
|
614
|
+
expect(pageBounds!.width).toBeLessThan(200) // Should not include label width
|
|
615
|
+
expect(pageBounds!.height).toBeLessThan(200) // Should not include label height
|
|
616
|
+
|
|
617
|
+
// Verify that the arrow has a label (which should be excluded from shape bounds)
|
|
618
|
+
const arrow = editor.getShape(ids.arrow1) as TLArrowShape
|
|
619
|
+
expect(arrow.props.richText).toBeDefined()
|
|
620
|
+
expect(arrow.props.richText).not.toBeNull()
|
|
621
|
+
})
|
|
622
|
+
})
|
|
@@ -81,7 +81,7 @@ export interface ArrowShapeOptions {
|
|
|
81
81
|
*/
|
|
82
82
|
readonly hoverPreciseTimeout: number
|
|
83
83
|
/**
|
|
84
|
-
* When pointing at a shape using the arrow tool or
|
|
84
|
+
* When pointing at a shape using the arrow tool or dragging an arrow terminal handle, how long
|
|
85
85
|
* should we wait before we assume the user is targeting precisely instead of imprecisely.
|
|
86
86
|
*/
|
|
87
87
|
readonly pointingPreciseTimeout: number
|
|
@@ -90,13 +90,11 @@ export interface ArrowShapeOptions {
|
|
|
90
90
|
* When creating an arrow, should it stop exactly at the pointer, or should
|
|
91
91
|
* it stop at the edge of the target shape.
|
|
92
92
|
*/
|
|
93
|
-
|
|
94
|
-
readonly shouldBeExact: (editor: Editor) => boolean
|
|
93
|
+
shouldBeExact(editor: Editor, isPrecise: boolean): boolean
|
|
95
94
|
/**
|
|
96
95
|
* When creating an arrow, should it bind to the target shape.
|
|
97
96
|
*/
|
|
98
|
-
|
|
99
|
-
readonly shouldIgnoreTargets: (editor: Editor) => boolean
|
|
97
|
+
shouldIgnoreTargets(editor: Editor): boolean
|
|
100
98
|
}
|
|
101
99
|
|
|
102
100
|
/** @public */
|
|
@@ -27,6 +27,11 @@ import {
|
|
|
27
27
|
ElbowArrowSideDeltas,
|
|
28
28
|
} from './elbow/definitions'
|
|
29
29
|
|
|
30
|
+
/**
|
|
31
|
+
* Options passed to {@link updateArrowTargetState}.
|
|
32
|
+
*
|
|
33
|
+
* @public
|
|
34
|
+
*/
|
|
30
35
|
export interface UpdateArrowTargetStateOpts {
|
|
31
36
|
editor: Editor
|
|
32
37
|
pointInPageSpace: VecLike
|
|
@@ -37,6 +42,13 @@ export interface UpdateArrowTargetStateOpts {
|
|
|
37
42
|
oppositeBinding: TLArrowBinding | undefined
|
|
38
43
|
}
|
|
39
44
|
|
|
45
|
+
/**
|
|
46
|
+
* State representing what we're pointing to when drawing or updating an arrow. You can get this
|
|
47
|
+
* state using {@link getArrowTargetState}, and update it as part of an arrow interaction with
|
|
48
|
+
* {@link updateArrowTargetState} or {@link clearArrowTargetState}.
|
|
49
|
+
*
|
|
50
|
+
* @public
|
|
51
|
+
*/
|
|
40
52
|
export interface ArrowTargetState {
|
|
41
53
|
target: TLShape
|
|
42
54
|
arrowKind: TLArrowShapeKind
|
|
@@ -63,14 +75,32 @@ function getArrowTargetAtom(editor: Editor) {
|
|
|
63
75
|
return arrowTargetStore.get(editor, () => atom('arrowTarget', null))
|
|
64
76
|
}
|
|
65
77
|
|
|
78
|
+
/**
|
|
79
|
+
* Get the current arrow target state for an editor. See {@link ArrowTargetState} for more
|
|
80
|
+
* information.
|
|
81
|
+
*
|
|
82
|
+
* @public
|
|
83
|
+
*/
|
|
66
84
|
export function getArrowTargetState(editor: Editor) {
|
|
67
85
|
return getArrowTargetAtom(editor).get()
|
|
68
86
|
}
|
|
69
87
|
|
|
88
|
+
/**
|
|
89
|
+
* Clear the current arrow target state for an editor. See {@link ArrowTargetState} for more
|
|
90
|
+
* information.
|
|
91
|
+
*
|
|
92
|
+
* @public
|
|
93
|
+
*/
|
|
70
94
|
export function clearArrowTargetState(editor: Editor) {
|
|
71
95
|
getArrowTargetAtom(editor).set(null)
|
|
72
96
|
}
|
|
73
97
|
|
|
98
|
+
/**
|
|
99
|
+
* Update the current arrow target state for an editor. See {@link ArrowTargetState} for more
|
|
100
|
+
* information.
|
|
101
|
+
*
|
|
102
|
+
* @public
|
|
103
|
+
*/
|
|
74
104
|
export function updateArrowTargetState({
|
|
75
105
|
editor,
|
|
76
106
|
pointInPageSpace,
|
|
@@ -87,8 +117,6 @@ export function updateArrowTargetState({
|
|
|
87
117
|
return null
|
|
88
118
|
}
|
|
89
119
|
|
|
90
|
-
const isExact = util.options.shouldBeExact(editor)
|
|
91
|
-
|
|
92
120
|
const arrowKind = arrow ? arrow.props.kind : editor.getStyleForNextShape(ArrowShapeKindStyle)
|
|
93
121
|
|
|
94
122
|
const target = editor.getShapeAtPoint(pointInPageSpace, {
|
|
@@ -165,7 +193,7 @@ export function updateArrowTargetState({
|
|
|
165
193
|
}
|
|
166
194
|
}
|
|
167
195
|
|
|
168
|
-
let precise = isPrecise
|
|
196
|
+
let precise = isPrecise
|
|
169
197
|
|
|
170
198
|
if (!precise) {
|
|
171
199
|
// If we're switching to a new bound shape, then precise only if moving slowly
|
|
@@ -186,6 +214,9 @@ export function updateArrowTargetState({
|
|
|
186
214
|
}
|
|
187
215
|
}
|
|
188
216
|
|
|
217
|
+
const isExact = util.options.shouldBeExact(editor, precise)
|
|
218
|
+
if (isExact) precise = true
|
|
219
|
+
|
|
189
220
|
const shouldSnapCenter = !isExact && precise && targetGeometryInTargetSpace.isClosed
|
|
190
221
|
// const shouldSnapEdges = !isExact && (precise || !targetGeometryInTargetSpace.isClosed)
|
|
191
222
|
const shouldSnapEdges =
|
|
@@ -163,7 +163,7 @@ export class Pointing extends StateNode {
|
|
|
163
163
|
const endHandle = handles.find((h) => h.id === 'end')!
|
|
164
164
|
const change = util.onHandleDrag?.(this.editor.getShape(shape)!, {
|
|
165
165
|
handle: { ...endHandle, x: point.x, y: point.y },
|
|
166
|
-
isPrecise:
|
|
166
|
+
isPrecise: this.isPrecise,
|
|
167
167
|
isCreatingShape: true,
|
|
168
168
|
initial: initial,
|
|
169
169
|
})
|
|
@@ -13,7 +13,6 @@ import {
|
|
|
13
13
|
debounce,
|
|
14
14
|
getHashForString,
|
|
15
15
|
lerp,
|
|
16
|
-
stopEventPropagation,
|
|
17
16
|
tlenv,
|
|
18
17
|
toDomPrecision,
|
|
19
18
|
useEditor,
|
|
@@ -132,9 +131,9 @@ function BookmarkShapeComponent({ shape }: { shape: TLBookmarkShape }) {
|
|
|
132
131
|
const [isFaviconValid, setIsFaviconValid] = useState(true)
|
|
133
132
|
const onFaviconError = () => setIsFaviconValid(false)
|
|
134
133
|
|
|
135
|
-
const
|
|
134
|
+
const markAsHandledOnShiftKey = useCallback<PointerEventHandler>(
|
|
136
135
|
(e) => {
|
|
137
|
-
if (!editor.inputs.shiftKey)
|
|
136
|
+
if (!editor.inputs.shiftKey) editor.markEventAsHandled(e)
|
|
138
137
|
},
|
|
139
138
|
[editor]
|
|
140
139
|
)
|
|
@@ -182,8 +181,8 @@ function BookmarkShapeComponent({ shape }: { shape: TLBookmarkShape }) {
|
|
|
182
181
|
target="_blank"
|
|
183
182
|
rel="noopener noreferrer"
|
|
184
183
|
draggable={false}
|
|
185
|
-
onPointerDown={
|
|
186
|
-
onPointerUp={
|
|
184
|
+
onPointerDown={markAsHandledOnShiftKey}
|
|
185
|
+
onPointerUp={markAsHandledOnShiftKey}
|
|
187
186
|
>
|
|
188
187
|
{isFaviconValid && asset?.props.favicon ? (
|
|
189
188
|
<img
|
|
@@ -1,4 +1,4 @@
|
|
|
1
|
-
import { TLFrameShape, TLShapeId,
|
|
1
|
+
import { TLFrameShape, TLShapeId, useEditor } from '@tldraw/editor'
|
|
2
2
|
import { forwardRef, useCallback } from 'react'
|
|
3
3
|
import { defaultEmptyAs } from '../FrameShapeUtil'
|
|
4
4
|
|
|
@@ -8,12 +8,19 @@ export const FrameLabelInput = forwardRef<
|
|
|
8
8
|
>(({ id, name, isEditing }, ref) => {
|
|
9
9
|
const editor = useEditor()
|
|
10
10
|
|
|
11
|
+
const handlePointerDown = useCallback(
|
|
12
|
+
(e: React.PointerEvent) => {
|
|
13
|
+
if (isEditing) editor.markEventAsHandled(e)
|
|
14
|
+
},
|
|
15
|
+
[editor, isEditing]
|
|
16
|
+
)
|
|
17
|
+
|
|
11
18
|
const handleKeyDown = useCallback(
|
|
12
19
|
(e: React.KeyboardEvent<HTMLInputElement>) => {
|
|
13
20
|
if (e.key === 'Enter' && !e.nativeEvent.isComposing) {
|
|
14
21
|
// need to prevent the enter keydown making it's way up to the Idle state
|
|
15
22
|
// and sending us back into edit mode
|
|
16
|
-
|
|
23
|
+
editor.markEventAsHandled(e)
|
|
17
24
|
e.currentTarget.blur()
|
|
18
25
|
editor.setEditingShape(null)
|
|
19
26
|
}
|
|
@@ -74,7 +81,7 @@ export const FrameLabelInput = forwardRef<
|
|
|
74
81
|
onKeyDown={handleKeyDown}
|
|
75
82
|
onBlur={handleBlur}
|
|
76
83
|
onChange={handleChange}
|
|
77
|
-
onPointerDown={
|
|
84
|
+
onPointerDown={handlePointerDown}
|
|
78
85
|
draggable={false}
|
|
79
86
|
/>
|
|
80
87
|
{defaultEmptyAs(name, 'Frame') + String.fromCharCode(8203)}
|
|
@@ -126,6 +126,7 @@ export class GeoShapeUtil extends BaseBoxShapeUtil<TLGeoShape> {
|
|
|
126
126
|
height: unscaledLabelHeight * shape.props.scale,
|
|
127
127
|
isFilled: true,
|
|
128
128
|
isLabel: true,
|
|
129
|
+
excludeFromShapeBounds: true,
|
|
129
130
|
isEmptyLabel: isEmptyRichText(shape.props.richText),
|
|
130
131
|
}),
|
|
131
132
|
],
|
|
@@ -1,4 +1,4 @@
|
|
|
1
|
-
import {
|
|
1
|
+
import { useEditor, useValue } from '@tldraw/editor'
|
|
2
2
|
import classNames from 'classnames'
|
|
3
3
|
import { PointerEventHandler, useCallback } from 'react'
|
|
4
4
|
|
|
@@ -8,9 +8,9 @@ const LINK_ICON =
|
|
|
8
8
|
export function HyperlinkButton({ url }: { url: string }) {
|
|
9
9
|
const editor = useEditor()
|
|
10
10
|
const hideButton = useValue('zoomLevel', () => editor.getZoomLevel() < 0.32, [editor])
|
|
11
|
-
const
|
|
11
|
+
const markAsHandledOnShiftKey = useCallback<PointerEventHandler>(
|
|
12
12
|
(e) => {
|
|
13
|
-
if (!editor.inputs.shiftKey)
|
|
13
|
+
if (!editor.inputs.shiftKey) editor.markEventAsHandled(e)
|
|
14
14
|
},
|
|
15
15
|
[editor]
|
|
16
16
|
)
|
|
@@ -22,8 +22,8 @@ export function HyperlinkButton({ url }: { url: string }) {
|
|
|
22
22
|
href={url}
|
|
23
23
|
target="_blank"
|
|
24
24
|
rel="noopener noreferrer"
|
|
25
|
-
onPointerDown={
|
|
26
|
-
onPointerUp={
|
|
25
|
+
onPointerDown={markAsHandledOnShiftKey}
|
|
26
|
+
onPointerUp={markAsHandledOnShiftKey}
|
|
27
27
|
title={url}
|
|
28
28
|
draggable={false}
|
|
29
29
|
>
|
|
@@ -5,7 +5,6 @@ import {
|
|
|
5
5
|
getPointerInfo,
|
|
6
6
|
noop,
|
|
7
7
|
preventDefault,
|
|
8
|
-
stopEventPropagation,
|
|
9
8
|
tlenv,
|
|
10
9
|
useEditor,
|
|
11
10
|
useValue,
|
|
@@ -129,14 +128,14 @@ export function useEditableTextCommon(shapeId: TLShapeId) {
|
|
|
129
128
|
// partially if we didn't dispatch/stop below.
|
|
130
129
|
|
|
131
130
|
editor.dispatch({
|
|
132
|
-
...getPointerInfo(e),
|
|
131
|
+
...getPointerInfo(editor, e),
|
|
133
132
|
type: 'pointer',
|
|
134
133
|
name: 'pointer_down',
|
|
135
134
|
target: 'shape',
|
|
136
135
|
shape: editor.getShape(shapeId)!,
|
|
137
136
|
})
|
|
138
137
|
|
|
139
|
-
|
|
138
|
+
e.stopPropagation() // we need to prevent blurring the input
|
|
140
139
|
},
|
|
141
140
|
[editor, shapeId]
|
|
142
141
|
)
|
|
@@ -161,7 +160,7 @@ export function useEditableTextCommon(shapeId: TLShapeId) {
|
|
|
161
160
|
handleFocus: noop,
|
|
162
161
|
handleBlur: noop,
|
|
163
162
|
handleInputPointerDown,
|
|
164
|
-
handleDoubleClick:
|
|
163
|
+
handleDoubleClick: editor.markEventAsHandled,
|
|
165
164
|
handlePaste,
|
|
166
165
|
isEditing,
|
|
167
166
|
isReadyForEditing,
|
|
@@ -1,4 +1,4 @@
|
|
|
1
|
-
import { preventDefault,
|
|
1
|
+
import { preventDefault, useEditor } from '@tldraw/editor'
|
|
2
2
|
import React from 'react'
|
|
3
3
|
import { TextAreaProps } from './RichTextArea'
|
|
4
4
|
|
|
@@ -21,6 +21,7 @@ export const PlainTextArea = React.forwardRef<HTMLTextAreaElement, TextAreaProps
|
|
|
21
21
|
},
|
|
22
22
|
ref
|
|
23
23
|
) {
|
|
24
|
+
const editor = useEditor()
|
|
24
25
|
const onChange = (e: React.ChangeEvent<HTMLTextAreaElement>) => {
|
|
25
26
|
handleChange({ plaintext: e.target.value })
|
|
26
27
|
}
|
|
@@ -46,8 +47,8 @@ export const PlainTextArea = React.forwardRef<HTMLTextAreaElement, TextAreaProps
|
|
|
46
47
|
onChange={onChange}
|
|
47
48
|
onKeyDown={(e) => handleKeyDown(e.nativeEvent)}
|
|
48
49
|
onBlur={handleBlur}
|
|
49
|
-
onTouchEnd={
|
|
50
|
-
onContextMenu={isEditing ?
|
|
50
|
+
onTouchEnd={editor.markEventAsHandled}
|
|
51
|
+
onContextMenu={isEditing ? (e) => e.stopPropagation() : undefined}
|
|
51
52
|
onPointerDown={handleInputPointerDown}
|
|
52
53
|
onPaste={handlePaste}
|
|
53
54
|
onDoubleClick={handleDoubleClick}
|
|
@@ -10,7 +10,6 @@ import {
|
|
|
10
10
|
TLRichText,
|
|
11
11
|
TLShapeId,
|
|
12
12
|
preventDefault,
|
|
13
|
-
stopEventPropagation,
|
|
14
13
|
useEditor,
|
|
15
14
|
useEvent,
|
|
16
15
|
useUniqueSafeId,
|
|
@@ -233,13 +232,13 @@ export const RichTextArea = React.forwardRef<HTMLDivElement, TextAreaProps>(func
|
|
|
233
232
|
tabIndex={-1}
|
|
234
233
|
data-testid="rich-text-area"
|
|
235
234
|
className="tl-rich-text tl-text tl-text-input"
|
|
236
|
-
onContextMenu={isEditing ?
|
|
235
|
+
onContextMenu={isEditing ? (e) => e.stopPropagation() : undefined}
|
|
237
236
|
// N.B. When PointerStateExtension was introduced, this was moved there.
|
|
238
237
|
// However, that caused selecting over list items to break.
|
|
239
238
|
// The handleDOMEvents in TipTap don't seem to support the pointerDownCapture event.
|
|
240
|
-
onPointerDownCapture={
|
|
239
|
+
onPointerDownCapture={(e) => e.stopPropagation()}
|
|
241
240
|
// This onTouchEnd is important for Android to be able to change selection on text.
|
|
242
|
-
onTouchEnd={
|
|
241
|
+
onTouchEnd={(e) => e.stopPropagation()}
|
|
243
242
|
// On FF, there's a behavior where dragging a selection will grab that selection into
|
|
244
243
|
// the drag event. However, once the drag is over, and you select away from the textarea,
|
|
245
244
|
// starting a drag over the textarea will restart a selection drag instead of a shape drag.
|