tldraw 3.16.0-canary.2e83e38fb91b → 3.16.0-canary.344cec0354f3

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (197) hide show
  1. package/dist-cjs/index.d.ts +99 -13
  2. package/dist-cjs/index.js +6 -2
  3. package/dist-cjs/index.js.map +2 -2
  4. package/dist-cjs/lib/defaultExternalContentHandlers.js +10 -0
  5. package/dist-cjs/lib/defaultExternalContentHandlers.js.map +2 -2
  6. package/dist-cjs/lib/shapes/arrow/arrow-types.js.map +1 -1
  7. package/dist-cjs/lib/shapes/arrow/arrowTargetState.js +3 -2
  8. package/dist-cjs/lib/shapes/arrow/arrowTargetState.js.map +2 -2
  9. package/dist-cjs/lib/shapes/arrow/toolStates/Pointing.js +1 -1
  10. package/dist-cjs/lib/shapes/arrow/toolStates/Pointing.js.map +2 -2
  11. package/dist-cjs/lib/shapes/bookmark/BookmarkShapeUtil.js +1 -1
  12. package/dist-cjs/lib/shapes/bookmark/BookmarkShapeUtil.js.map +2 -2
  13. package/dist-cjs/lib/shapes/frame/components/FrameLabelInput.js +8 -2
  14. package/dist-cjs/lib/shapes/frame/components/FrameLabelInput.js.map +2 -2
  15. package/dist-cjs/lib/shapes/shared/HyperlinkButton.js +1 -1
  16. package/dist-cjs/lib/shapes/shared/HyperlinkButton.js.map +2 -2
  17. package/dist-cjs/lib/shapes/shared/useEditablePlainText.js +2 -3
  18. package/dist-cjs/lib/shapes/shared/useEditablePlainText.js.map +2 -2
  19. package/dist-cjs/lib/shapes/text/PlainTextArea.js +2 -1
  20. package/dist-cjs/lib/shapes/text/PlainTextArea.js.map +2 -2
  21. package/dist-cjs/lib/tools/SelectTool/childStates/DraggingHandle.js +3 -1
  22. package/dist-cjs/lib/tools/SelectTool/childStates/DraggingHandle.js.map +2 -2
  23. package/dist-cjs/lib/ui/components/A11y.js +1 -1
  24. package/dist-cjs/lib/ui/components/A11y.js.map +2 -2
  25. package/dist-cjs/lib/ui/components/AccessibilityMenu.js +1 -1
  26. package/dist-cjs/lib/ui/components/AccessibilityMenu.js.map +2 -2
  27. package/dist-cjs/lib/ui/components/InputModeMenu.js +77 -0
  28. package/dist-cjs/lib/ui/components/InputModeMenu.js.map +7 -0
  29. package/dist-cjs/lib/ui/components/LanguageMenu.js +1 -0
  30. package/dist-cjs/lib/ui/components/LanguageMenu.js.map +2 -2
  31. package/dist-cjs/lib/ui/components/MainMenu/DefaultMainMenuContent.js +2 -0
  32. package/dist-cjs/lib/ui/components/MainMenu/DefaultMainMenuContent.js.map +2 -2
  33. package/dist-cjs/lib/ui/components/Minimap/DefaultMinimap.js +2 -1
  34. package/dist-cjs/lib/ui/components/Minimap/DefaultMinimap.js.map +2 -2
  35. package/dist-cjs/lib/ui/components/PageMenu/DefaultPageMenu.js +1 -1
  36. package/dist-cjs/lib/ui/components/PageMenu/DefaultPageMenu.js.map +2 -2
  37. package/dist-cjs/lib/ui/components/StylePanel/DefaultStylePanel.js +4 -2
  38. package/dist-cjs/lib/ui/components/StylePanel/DefaultStylePanel.js.map +2 -2
  39. package/dist-cjs/lib/ui/components/StylePanel/DefaultStylePanelContent.js +2 -2
  40. package/dist-cjs/lib/ui/components/StylePanel/DefaultStylePanelContent.js.map +2 -2
  41. package/dist-cjs/lib/ui/components/StylePanel/StylePanelButtonPicker.js +12 -3
  42. package/dist-cjs/lib/ui/components/StylePanel/StylePanelButtonPicker.js.map +2 -2
  43. package/dist-cjs/lib/ui/components/StylePanel/StylePanelContext.js +4 -2
  44. package/dist-cjs/lib/ui/components/StylePanel/StylePanelContext.js.map +2 -2
  45. package/dist-cjs/lib/ui/components/Toolbar/AltTextEditor.js +3 -2
  46. package/dist-cjs/lib/ui/components/Toolbar/AltTextEditor.js.map +2 -2
  47. package/dist-cjs/lib/ui/components/Toolbar/LinkEditor.js +5 -4
  48. package/dist-cjs/lib/ui/components/Toolbar/LinkEditor.js.map +2 -2
  49. package/dist-cjs/lib/ui/components/Toolbar/OverflowingToolbar.js +1 -1
  50. package/dist-cjs/lib/ui/components/Toolbar/OverflowingToolbar.js.map +2 -2
  51. package/dist-cjs/lib/ui/components/Toolbar/ToggleToolLockedButton.js +6 -2
  52. package/dist-cjs/lib/ui/components/Toolbar/ToggleToolLockedButton.js.map +2 -2
  53. package/dist-cjs/lib/ui/components/menu-items.js +6 -4
  54. package/dist-cjs/lib/ui/components/menu-items.js.map +2 -2
  55. package/dist-cjs/lib/ui/components/primitives/TldrawUiContextualToolbar.js +1 -1
  56. package/dist-cjs/lib/ui/components/primitives/TldrawUiContextualToolbar.js.map +2 -2
  57. package/dist-cjs/lib/ui/components/primitives/TldrawUiInput.js +3 -1
  58. package/dist-cjs/lib/ui/components/primitives/TldrawUiInput.js.map +2 -2
  59. package/dist-cjs/lib/ui/components/primitives/TldrawUiToolbar.js +1 -0
  60. package/dist-cjs/lib/ui/components/primitives/TldrawUiToolbar.js.map +2 -2
  61. package/dist-cjs/lib/ui/components/primitives/TldrawUiTooltip.js +44 -21
  62. package/dist-cjs/lib/ui/components/primitives/TldrawUiTooltip.js.map +2 -2
  63. package/dist-cjs/lib/ui/components/primitives/menus/TldrawUiMenuCheckboxItem.js +3 -0
  64. package/dist-cjs/lib/ui/components/primitives/menus/TldrawUiMenuCheckboxItem.js.map +2 -2
  65. package/dist-cjs/lib/ui/components/primitives/menus/TldrawUiMenuItem.js +3 -3
  66. package/dist-cjs/lib/ui/components/primitives/menus/TldrawUiMenuItem.js.map +2 -2
  67. package/dist-cjs/lib/ui/context/actions.js +11 -25
  68. package/dist-cjs/lib/ui/context/actions.js.map +2 -2
  69. package/dist-cjs/lib/ui/context/events.js.map +2 -2
  70. package/dist-cjs/lib/ui/hooks/useClipboardEvents.js +1 -1
  71. package/dist-cjs/lib/ui/hooks/useClipboardEvents.js.map +2 -2
  72. package/dist-cjs/lib/ui/hooks/useTranslation/TLUiTranslationKey.js.map +1 -1
  73. package/dist-cjs/lib/ui/hooks/useTranslation/defaultTranslation.js +10 -2
  74. package/dist-cjs/lib/ui/hooks/useTranslation/defaultTranslation.js.map +2 -2
  75. package/dist-cjs/lib/ui/version.js +3 -3
  76. package/dist-cjs/lib/ui/version.js.map +1 -1
  77. package/dist-esm/index.d.mts +99 -13
  78. package/dist-esm/index.mjs +11 -3
  79. package/dist-esm/index.mjs.map +2 -2
  80. package/dist-esm/lib/defaultExternalContentHandlers.mjs +10 -0
  81. package/dist-esm/lib/defaultExternalContentHandlers.mjs.map +2 -2
  82. package/dist-esm/lib/shapes/arrow/arrowTargetState.mjs +3 -2
  83. package/dist-esm/lib/shapes/arrow/arrowTargetState.mjs.map +2 -2
  84. package/dist-esm/lib/shapes/arrow/toolStates/Pointing.mjs +1 -1
  85. package/dist-esm/lib/shapes/arrow/toolStates/Pointing.mjs.map +2 -2
  86. package/dist-esm/lib/shapes/bookmark/BookmarkShapeUtil.mjs +1 -2
  87. package/dist-esm/lib/shapes/bookmark/BookmarkShapeUtil.mjs.map +2 -2
  88. package/dist-esm/lib/shapes/frame/components/FrameLabelInput.mjs +9 -3
  89. package/dist-esm/lib/shapes/frame/components/FrameLabelInput.mjs.map +2 -2
  90. package/dist-esm/lib/shapes/shared/HyperlinkButton.mjs +2 -2
  91. package/dist-esm/lib/shapes/shared/HyperlinkButton.mjs.map +2 -2
  92. package/dist-esm/lib/shapes/shared/useEditablePlainText.mjs +2 -4
  93. package/dist-esm/lib/shapes/shared/useEditablePlainText.mjs.map +2 -2
  94. package/dist-esm/lib/shapes/text/PlainTextArea.mjs +3 -2
  95. package/dist-esm/lib/shapes/text/PlainTextArea.mjs.map +2 -2
  96. package/dist-esm/lib/tools/SelectTool/childStates/DraggingHandle.mjs +3 -1
  97. package/dist-esm/lib/tools/SelectTool/childStates/DraggingHandle.mjs.map +2 -2
  98. package/dist-esm/lib/ui/components/A11y.mjs +1 -2
  99. package/dist-esm/lib/ui/components/A11y.mjs.map +2 -2
  100. package/dist-esm/lib/ui/components/AccessibilityMenu.mjs +3 -3
  101. package/dist-esm/lib/ui/components/AccessibilityMenu.mjs.map +2 -2
  102. package/dist-esm/lib/ui/components/InputModeMenu.mjs +57 -0
  103. package/dist-esm/lib/ui/components/InputModeMenu.mjs.map +7 -0
  104. package/dist-esm/lib/ui/components/LanguageMenu.mjs +1 -0
  105. package/dist-esm/lib/ui/components/LanguageMenu.mjs.map +2 -2
  106. package/dist-esm/lib/ui/components/MainMenu/DefaultMainMenuContent.mjs +2 -0
  107. package/dist-esm/lib/ui/components/MainMenu/DefaultMainMenuContent.mjs.map +2 -2
  108. package/dist-esm/lib/ui/components/Minimap/DefaultMinimap.mjs +2 -1
  109. package/dist-esm/lib/ui/components/Minimap/DefaultMinimap.mjs.map +2 -2
  110. package/dist-esm/lib/ui/components/PageMenu/DefaultPageMenu.mjs +1 -2
  111. package/dist-esm/lib/ui/components/PageMenu/DefaultPageMenu.mjs.map +2 -2
  112. package/dist-esm/lib/ui/components/StylePanel/DefaultStylePanel.mjs +4 -2
  113. package/dist-esm/lib/ui/components/StylePanel/DefaultStylePanel.mjs.map +2 -2
  114. package/dist-esm/lib/ui/components/StylePanel/DefaultStylePanelContent.mjs +2 -2
  115. package/dist-esm/lib/ui/components/StylePanel/DefaultStylePanelContent.mjs.map +2 -2
  116. package/dist-esm/lib/ui/components/StylePanel/StylePanelButtonPicker.mjs +12 -3
  117. package/dist-esm/lib/ui/components/StylePanel/StylePanelButtonPicker.mjs.map +2 -2
  118. package/dist-esm/lib/ui/components/StylePanel/StylePanelContext.mjs +4 -2
  119. package/dist-esm/lib/ui/components/StylePanel/StylePanelContext.mjs.map +2 -2
  120. package/dist-esm/lib/ui/components/Toolbar/AltTextEditor.mjs +3 -2
  121. package/dist-esm/lib/ui/components/Toolbar/AltTextEditor.mjs.map +2 -2
  122. package/dist-esm/lib/ui/components/Toolbar/LinkEditor.mjs +5 -4
  123. package/dist-esm/lib/ui/components/Toolbar/LinkEditor.mjs.map +2 -2
  124. package/dist-esm/lib/ui/components/Toolbar/OverflowingToolbar.mjs +1 -1
  125. package/dist-esm/lib/ui/components/Toolbar/OverflowingToolbar.mjs.map +2 -2
  126. package/dist-esm/lib/ui/components/Toolbar/ToggleToolLockedButton.mjs +6 -2
  127. package/dist-esm/lib/ui/components/Toolbar/ToggleToolLockedButton.mjs.map +2 -2
  128. package/dist-esm/lib/ui/components/menu-items.mjs +6 -4
  129. package/dist-esm/lib/ui/components/menu-items.mjs.map +2 -2
  130. package/dist-esm/lib/ui/components/primitives/TldrawUiContextualToolbar.mjs +1 -2
  131. package/dist-esm/lib/ui/components/primitives/TldrawUiContextualToolbar.mjs.map +2 -2
  132. package/dist-esm/lib/ui/components/primitives/TldrawUiInput.mjs +3 -1
  133. package/dist-esm/lib/ui/components/primitives/TldrawUiInput.mjs.map +2 -2
  134. package/dist-esm/lib/ui/components/primitives/TldrawUiToolbar.mjs +1 -0
  135. package/dist-esm/lib/ui/components/primitives/TldrawUiToolbar.mjs.map +2 -2
  136. package/dist-esm/lib/ui/components/primitives/TldrawUiTooltip.mjs +44 -21
  137. package/dist-esm/lib/ui/components/primitives/TldrawUiTooltip.mjs.map +2 -2
  138. package/dist-esm/lib/ui/components/primitives/menus/TldrawUiMenuCheckboxItem.mjs +3 -0
  139. package/dist-esm/lib/ui/components/primitives/menus/TldrawUiMenuCheckboxItem.mjs.map +2 -2
  140. package/dist-esm/lib/ui/components/primitives/menus/TldrawUiMenuItem.mjs +3 -3
  141. package/dist-esm/lib/ui/components/primitives/menus/TldrawUiMenuItem.mjs.map +2 -2
  142. package/dist-esm/lib/ui/context/actions.mjs +11 -25
  143. package/dist-esm/lib/ui/context/actions.mjs.map +2 -2
  144. package/dist-esm/lib/ui/context/events.mjs.map +2 -2
  145. package/dist-esm/lib/ui/hooks/useClipboardEvents.mjs +1 -2
  146. package/dist-esm/lib/ui/hooks/useClipboardEvents.mjs.map +2 -2
  147. package/dist-esm/lib/ui/hooks/useTranslation/defaultTranslation.mjs +10 -2
  148. package/dist-esm/lib/ui/hooks/useTranslation/defaultTranslation.mjs.map +2 -2
  149. package/dist-esm/lib/ui/version.mjs +3 -3
  150. package/dist-esm/lib/ui/version.mjs.map +1 -1
  151. package/package.json +3 -3
  152. package/src/index.ts +8 -1
  153. package/src/lib/defaultExternalContentHandlers.ts +14 -0
  154. package/src/lib/shapes/arrow/ArrowShapeOptions.test.ts +83 -13
  155. package/src/lib/shapes/arrow/ArrowShapeTool.test.ts +97 -3
  156. package/src/lib/shapes/arrow/arrow-types.ts +3 -5
  157. package/src/lib/shapes/arrow/arrowTargetState.ts +34 -3
  158. package/src/lib/shapes/arrow/toolStates/Pointing.tsx +1 -1
  159. package/src/lib/shapes/bookmark/BookmarkShapeUtil.tsx +1 -2
  160. package/src/lib/shapes/frame/components/FrameLabelInput.tsx +10 -3
  161. package/src/lib/shapes/shared/HyperlinkButton.tsx +2 -2
  162. package/src/lib/shapes/shared/useEditablePlainText.ts +2 -5
  163. package/src/lib/shapes/text/PlainTextArea.tsx +3 -2
  164. package/src/lib/tools/SelectTool/childStates/DraggingHandle.tsx +6 -2
  165. package/src/lib/ui/components/A11y.tsx +1 -2
  166. package/src/lib/ui/components/AccessibilityMenu.tsx +2 -2
  167. package/src/lib/ui/components/InputModeMenu.tsx +65 -0
  168. package/src/lib/ui/components/LanguageMenu.tsx +1 -0
  169. package/src/lib/ui/components/MainMenu/DefaultMainMenuContent.tsx +4 -0
  170. package/src/lib/ui/components/Minimap/DefaultMinimap.tsx +2 -1
  171. package/src/lib/ui/components/PageMenu/DefaultPageMenu.tsx +1 -2
  172. package/src/lib/ui/components/StylePanel/DefaultStylePanel.tsx +4 -2
  173. package/src/lib/ui/components/StylePanel/DefaultStylePanelContent.tsx +4 -2
  174. package/src/lib/ui/components/StylePanel/StylePanelButtonPicker.tsx +10 -3
  175. package/src/lib/ui/components/StylePanel/StylePanelContext.tsx +5 -3
  176. package/src/lib/ui/components/Toolbar/AltTextEditor.tsx +4 -3
  177. package/src/lib/ui/components/Toolbar/LinkEditor.tsx +6 -5
  178. package/src/lib/ui/components/Toolbar/OverflowingToolbar.tsx +1 -1
  179. package/src/lib/ui/components/Toolbar/ToggleToolLockedButton.tsx +9 -2
  180. package/src/lib/ui/components/menu-items.tsx +5 -3
  181. package/src/lib/ui/components/primitives/TldrawUiContextualToolbar.tsx +1 -2
  182. package/src/lib/ui/components/primitives/TldrawUiInput.tsx +3 -0
  183. package/src/lib/ui/components/primitives/TldrawUiToolbar.tsx +2 -1
  184. package/src/lib/ui/components/primitives/TldrawUiTooltip.tsx +26 -5
  185. package/src/lib/ui/components/primitives/menus/TldrawUiMenuCheckboxItem.tsx +4 -0
  186. package/src/lib/ui/components/primitives/menus/TldrawUiMenuItem.tsx +3 -3
  187. package/src/lib/ui/context/actions.tsx +18 -27
  188. package/src/lib/ui/context/events.tsx +2 -1
  189. package/src/lib/ui/hooks/useClipboardEvents.ts +1 -2
  190. package/src/lib/ui/hooks/useTranslation/TLUiTranslationKey.ts +10 -2
  191. package/src/lib/ui/hooks/useTranslation/defaultTranslation.ts +10 -2
  192. package/src/lib/ui/version.ts +3 -3
  193. package/src/lib/ui.css +25 -2
  194. package/src/test/TestEditor.ts +8 -2
  195. package/src/test/commands/setCamera.test.ts +13 -0
  196. package/src/test/frames.test.ts +15 -0
  197. package/tldraw.css +25 -2
@@ -47,13 +47,21 @@ describe('ArrowShapeOptions', () => {
47
47
  it('should have correct default shouldBeExact behavior (alt key)', () => {
48
48
  const util = editor.getShapeUtil<ArrowShapeUtil>('arrow')
49
49
 
50
- // Test without alt key
50
+ // Test without alt key, not precise
51
51
  editor.inputs.altKey = false
52
- expect(util.options.shouldBeExact(editor)).toBe(false)
52
+ expect(util.options.shouldBeExact(editor, false)).toBe(false)
53
53
 
54
- // Test with alt key
54
+ // Test without alt key, precise
55
+ editor.inputs.altKey = false
56
+ expect(util.options.shouldBeExact(editor, true)).toBe(false)
57
+
58
+ // Test with alt key, not precise
59
+ editor.inputs.altKey = true
60
+ expect(util.options.shouldBeExact(editor, false)).toBe(true)
61
+
62
+ // Test with alt key, precise
55
63
  editor.inputs.altKey = true
56
- expect(util.options.shouldBeExact(editor)).toBe(true)
64
+ expect(util.options.shouldBeExact(editor, true)).toBe(true)
57
65
  })
58
66
 
59
67
  it('should have correct default shouldIgnoreTargets behavior (ctrl key)', () => {
@@ -186,7 +194,7 @@ describe('ArrowShapeOptions', () => {
186
194
  class CustomArrowShapeUtil extends ArrowShapeUtil {
187
195
  override options = {
188
196
  ...baseUtil.options,
189
- shouldBeExact: (editor: any) => editor.inputs.shiftKey, // Use shift instead of alt
197
+ shouldBeExact: (editor: any, _isPrecise: boolean) => editor.inputs.shiftKey, // Use shift instead of alt
190
198
  }
191
199
  }
192
200
 
@@ -195,12 +203,14 @@ describe('ArrowShapeOptions', () => {
195
203
  // Test with shift key
196
204
  editor.inputs.shiftKey = true
197
205
  editor.inputs.altKey = false
198
- expect(customUtil.options.shouldBeExact(editor)).toBe(true)
206
+ expect(customUtil.options.shouldBeExact(editor, false)).toBe(true)
207
+ expect(customUtil.options.shouldBeExact(editor, true)).toBe(true)
199
208
 
200
209
  // Test without shift key
201
210
  editor.inputs.shiftKey = false
202
211
  editor.inputs.altKey = true // Alt key should not matter for custom implementation
203
- expect(customUtil.options.shouldBeExact(editor)).toBe(false)
212
+ expect(customUtil.options.shouldBeExact(editor, false)).toBe(false)
213
+ expect(customUtil.options.shouldBeExact(editor, true)).toBe(false)
204
214
  })
205
215
 
206
216
  it('should allow customizing shouldIgnoreTargets behavior', () => {
@@ -232,9 +242,9 @@ describe('ArrowShapeOptions', () => {
232
242
  class CustomArrowShapeUtil extends ArrowShapeUtil {
233
243
  override options = {
234
244
  ...baseUtil.options,
235
- shouldBeExact: (editor: any) => {
236
- // Custom logic: exact when both alt and shift are pressed
237
- return editor.inputs.altKey && editor.inputs.shiftKey
245
+ shouldBeExact: (editor: any, isPrecise: boolean) => {
246
+ // Custom logic: exact when both alt and shift are pressed, and only if precise
247
+ return editor.inputs.altKey && editor.inputs.shiftKey && isPrecise
238
248
  },
239
249
  shouldIgnoreTargets: (editor: any) => {
240
250
  // Custom logic: ignore targets when any modifier key is pressed
@@ -245,15 +255,20 @@ describe('ArrowShapeOptions', () => {
245
255
 
246
256
  const customUtil = new CustomArrowShapeUtil(editor)
247
257
 
248
- // Test shouldBeExact with both keys
258
+ // Test shouldBeExact with both keys and precise
249
259
  editor.inputs.altKey = true
250
260
  editor.inputs.shiftKey = true
251
- expect(customUtil.options.shouldBeExact(editor)).toBe(true)
261
+ expect(customUtil.options.shouldBeExact(editor, true)).toBe(true)
262
+
263
+ // Test shouldBeExact with both keys but not precise
264
+ editor.inputs.altKey = true
265
+ editor.inputs.shiftKey = true
266
+ expect(customUtil.options.shouldBeExact(editor, false)).toBe(false)
252
267
 
253
268
  // Test shouldBeExact with only one key
254
269
  editor.inputs.altKey = true
255
270
  editor.inputs.shiftKey = false
256
- expect(customUtil.options.shouldBeExact(editor)).toBe(false)
271
+ expect(customUtil.options.shouldBeExact(editor, true)).toBe(false)
257
272
 
258
273
  // Test shouldIgnoreTargets with any key
259
274
  editor.inputs.altKey = false
@@ -283,6 +298,61 @@ describe('ArrowShapeOptions', () => {
283
298
  expect(editor.getCurrentToolId()).toBe('arrow')
284
299
  })
285
300
 
301
+ it('should allow custom shouldBeExact logic based on isPrecise - example from arrow precise-exact', () => {
302
+ // This replicates the logic from the arrows-precise-exact example
303
+ const baseUtil = editor.getShapeUtil<ArrowShapeUtil>('arrow')
304
+ class ExampleArrowShapeUtil extends ArrowShapeUtil {
305
+ override options = {
306
+ ...baseUtil.options,
307
+ shouldBeExact: (_editor: any, isPrecise: boolean) => isPrecise,
308
+ }
309
+ }
310
+
311
+ // Replace the util temporarily for testing
312
+ const customUtil = new ExampleArrowShapeUtil(editor)
313
+ const originalShouldBeExact = baseUtil.options.shouldBeExact
314
+ baseUtil.options.shouldBeExact = customUtil.options.shouldBeExact
315
+
316
+ try {
317
+ editor.setCurrentTool('arrow')
318
+ editor.inputs.ctrlKey = false // Allow binding
319
+
320
+ // Set up fast pointer velocity to ensure precise remains false
321
+ editor.inputs.pointerVelocity = { x: 2, y: 2, len: () => 2.8 } as any
322
+
323
+ const targetState = updateArrowTargetState({
324
+ editor,
325
+ pointInPageSpace: { x: 150, y: 150 },
326
+ arrow: undefined,
327
+ isPrecise: true, // Input precise
328
+ currentBinding: undefined,
329
+ oppositeBinding: undefined,
330
+ })
331
+
332
+ // With the custom logic, precise arrows should be exact
333
+ expect(targetState?.isExact).toBe(true)
334
+ expect(targetState?.isPrecise).toBe(true)
335
+
336
+ // Test with non-precise movement (and fast velocity to avoid auto-precise)
337
+ const nonPreciseTargetState = updateArrowTargetState({
338
+ editor,
339
+ pointInPageSpace: { x: 150, y: 150 },
340
+ arrow: undefined,
341
+ isPrecise: false, // Not precise
342
+ currentBinding: undefined,
343
+ oppositeBinding: undefined,
344
+ })
345
+
346
+ // Non-precise arrows should not be exact with this custom logic,
347
+ // but they might still become precise due to internal logic
348
+ // The key test is that shouldBeExact gets the final computed precise value
349
+ expect(nonPreciseTargetState).toBeDefined()
350
+ } finally {
351
+ // Restore original function
352
+ baseUtil.options.shouldBeExact = originalShouldBeExact
353
+ }
354
+ })
355
+
286
356
  it('should respect shouldIgnoreTargets when starting arrow creation', () => {
287
357
  editor.setCurrentTool('arrow')
288
358
 
@@ -1,6 +1,8 @@
1
1
  import { IndexKey, TLArrowShape, TLShapeId, Vec, createShapeId } from '@tldraw/editor'
2
2
  import { vi } from 'vitest'
3
3
  import { TestEditor } from '../../../test/TestEditor'
4
+ import { defaultShapeUtils } from '../../defaultShapeUtils'
5
+ import { ArrowShapeUtil } from './ArrowShapeUtil'
4
6
  import { getArrowTargetState } from './arrowTargetState'
5
7
  import { getArrowBindings } from './shared'
6
8
 
@@ -26,8 +28,8 @@ function bindings(id: TLShapeId) {
26
28
  return getArrowBindings(editor, editor.getShape(id) as TLArrowShape)
27
29
  }
28
30
 
29
- beforeEach(() => {
30
- editor = new TestEditor()
31
+ function init(opts?: ConstructorParameters<typeof TestEditor>[0]) {
32
+ editor = new TestEditor(opts)
31
33
  editor
32
34
  .selectAll()
33
35
  .deleteShapes(editor.getSelectedShapeIds())
@@ -36,7 +38,9 @@ beforeEach(() => {
36
38
  { id: ids.box2, type: 'geo', x: 300, y: 300, props: { w: 100, h: 100 } },
37
39
  { id: ids.box3, type: 'geo', x: 350, y: 350, props: { w: 50, h: 50 } }, // overlapping box2, but smaller!
38
40
  ])
39
- })
41
+ }
42
+
43
+ beforeEach(init)
40
44
 
41
45
  it('enters the arrow state', () => {
42
46
  editor.setCurrentTool('arrow')
@@ -578,6 +582,96 @@ describe('reparenting issue', () => {
578
582
  })
579
583
  })
580
584
 
585
+ describe('precision timeout configuration', () => {
586
+ it('uses a timeout when dragging arrow handles', () => {
587
+ // Create an arrow first
588
+
589
+ editor.setCurrentTool('arrow').pointerDown(0, 0)
590
+ // Use high velocity to avoid precise mode immediately
591
+ editor.inputs.pointerVelocity = new Vec(1, 1)
592
+ editor.pointerMove(100, 100)
593
+
594
+ const arrow = editor.getCurrentPageShapes()[
595
+ editor.getCurrentPageShapes().length - 1
596
+ ] as TLArrowShape
597
+
598
+ editor.expectToBeIn('select.dragging_handle')
599
+
600
+ expect(bindings(arrow.id)).toMatchObject({
601
+ end: {
602
+ toId: ids.box1,
603
+ props: {
604
+ isPrecise: false,
605
+ },
606
+ },
607
+ })
608
+
609
+ vi.advanceTimersByTime(1000)
610
+
611
+ expect(bindings(arrow.id)).toMatchObject({
612
+ end: {
613
+ toId: ids.box1,
614
+ props: {
615
+ isPrecise: true,
616
+ },
617
+ },
618
+ })
619
+ })
620
+
621
+ it('allows configuring the pointingPreciseTimeout', () => {
622
+ init({
623
+ shapeUtils: [
624
+ ...defaultShapeUtils.map((s) =>
625
+ s.type === 'arrow' ? ArrowShapeUtil.configure({ pointingPreciseTimeout: 2000 }) : s
626
+ ),
627
+ ],
628
+ })
629
+ // Create an arrow first
630
+
631
+ editor.setCurrentTool('arrow').pointerDown(0, 0)
632
+ // Use high velocity to avoid precise mode immediately
633
+ editor.inputs.pointerVelocity = new Vec(1, 1)
634
+ editor.pointerMove(100, 100)
635
+
636
+ const arrow = editor.getCurrentPageShapes()[
637
+ editor.getCurrentPageShapes().length - 1
638
+ ] as TLArrowShape
639
+
640
+ editor.expectToBeIn('select.dragging_handle')
641
+
642
+ expect(bindings(arrow.id)).toMatchObject({
643
+ end: {
644
+ toId: ids.box1,
645
+ props: {
646
+ isPrecise: false,
647
+ },
648
+ },
649
+ })
650
+
651
+ vi.advanceTimersByTime(1000)
652
+
653
+ expect(bindings(arrow.id)).toMatchObject({
654
+ end: {
655
+ toId: ids.box1,
656
+ props: {
657
+ isPrecise: false,
658
+ },
659
+ },
660
+ })
661
+
662
+ vi.advanceTimersByTime(1000)
663
+
664
+ expect(bindings(arrow.id)).toMatchObject({
665
+ end: {
666
+ toId: ids.box1,
667
+ props: {
668
+ isPrecise: true,
669
+ },
670
+ },
671
+ })
672
+ })
673
+ })
674
+
581
675
  describe('line bug', () => {
582
676
  it('works as expected when binding to a straight line', () => {
583
677
  editor.selectAll().deleteShapes(editor.getSelectedShapeIds())
@@ -81,7 +81,7 @@ export interface ArrowShapeOptions {
81
81
  */
82
82
  readonly hoverPreciseTimeout: number
83
83
  /**
84
- * When pointing at a shape using the arrow tool or draggin an arrow terminal handle, how long
84
+ * When pointing at a shape using the arrow tool or dragging an arrow terminal handle, how long
85
85
  * should we wait before we assume the user is targeting precisely instead of imprecisely.
86
86
  */
87
87
  readonly pointingPreciseTimeout: number
@@ -90,13 +90,11 @@ export interface ArrowShapeOptions {
90
90
  * When creating an arrow, should it stop exactly at the pointer, or should
91
91
  * it stop at the edge of the target shape.
92
92
  */
93
- // eslint-disable-next-line @typescript-eslint/method-signature-style
94
- readonly shouldBeExact: (editor: Editor) => boolean
93
+ shouldBeExact(editor: Editor, isPrecise: boolean): boolean
95
94
  /**
96
95
  * When creating an arrow, should it bind to the target shape.
97
96
  */
98
- // eslint-disable-next-line @typescript-eslint/method-signature-style
99
- readonly shouldIgnoreTargets: (editor: Editor) => boolean
97
+ shouldIgnoreTargets(editor: Editor): boolean
100
98
  }
101
99
 
102
100
  /** @public */
@@ -27,6 +27,11 @@ import {
27
27
  ElbowArrowSideDeltas,
28
28
  } from './elbow/definitions'
29
29
 
30
+ /**
31
+ * Options passed to {@link updateArrowTargetState}.
32
+ *
33
+ * @public
34
+ */
30
35
  export interface UpdateArrowTargetStateOpts {
31
36
  editor: Editor
32
37
  pointInPageSpace: VecLike
@@ -37,6 +42,13 @@ export interface UpdateArrowTargetStateOpts {
37
42
  oppositeBinding: TLArrowBinding | undefined
38
43
  }
39
44
 
45
+ /**
46
+ * State representing what we're pointing to when drawing or updating an arrow. You can get this
47
+ * state using {@link getArrowTargetState}, and update it as part of an arrow interaction with
48
+ * {@link updateArrowTargetState} or {@link clearArrowTargetState}.
49
+ *
50
+ * @public
51
+ */
40
52
  export interface ArrowTargetState {
41
53
  target: TLShape
42
54
  arrowKind: TLArrowShapeKind
@@ -63,14 +75,32 @@ function getArrowTargetAtom(editor: Editor) {
63
75
  return arrowTargetStore.get(editor, () => atom('arrowTarget', null))
64
76
  }
65
77
 
78
+ /**
79
+ * Get the current arrow target state for an editor. See {@link ArrowTargetState} for more
80
+ * information.
81
+ *
82
+ * @public
83
+ */
66
84
  export function getArrowTargetState(editor: Editor) {
67
85
  return getArrowTargetAtom(editor).get()
68
86
  }
69
87
 
88
+ /**
89
+ * Clear the current arrow target state for an editor. See {@link ArrowTargetState} for more
90
+ * information.
91
+ *
92
+ * @public
93
+ */
70
94
  export function clearArrowTargetState(editor: Editor) {
71
95
  getArrowTargetAtom(editor).set(null)
72
96
  }
73
97
 
98
+ /**
99
+ * Update the current arrow target state for an editor. See {@link ArrowTargetState} for more
100
+ * information.
101
+ *
102
+ * @public
103
+ */
74
104
  export function updateArrowTargetState({
75
105
  editor,
76
106
  pointInPageSpace,
@@ -87,8 +117,6 @@ export function updateArrowTargetState({
87
117
  return null
88
118
  }
89
119
 
90
- const isExact = util.options.shouldBeExact(editor)
91
-
92
120
  const arrowKind = arrow ? arrow.props.kind : editor.getStyleForNextShape(ArrowShapeKindStyle)
93
121
 
94
122
  const target = editor.getShapeAtPoint(pointInPageSpace, {
@@ -165,7 +193,7 @@ export function updateArrowTargetState({
165
193
  }
166
194
  }
167
195
 
168
- let precise = isPrecise || isExact
196
+ let precise = isPrecise
169
197
 
170
198
  if (!precise) {
171
199
  // If we're switching to a new bound shape, then precise only if moving slowly
@@ -186,6 +214,9 @@ export function updateArrowTargetState({
186
214
  }
187
215
  }
188
216
 
217
+ const isExact = util.options.shouldBeExact(editor, precise)
218
+ if (isExact) precise = true
219
+
189
220
  const shouldSnapCenter = !isExact && precise && targetGeometryInTargetSpace.isClosed
190
221
  // const shouldSnapEdges = !isExact && (precise || !targetGeometryInTargetSpace.isClosed)
191
222
  const shouldSnapEdges =
@@ -163,7 +163,7 @@ export class Pointing extends StateNode {
163
163
  const endHandle = handles.find((h) => h.id === 'end')!
164
164
  const change = util.onHandleDrag?.(this.editor.getShape(shape)!, {
165
165
  handle: { ...endHandle, x: point.x, y: point.y },
166
- isPrecise: false,
166
+ isPrecise: this.isPrecise,
167
167
  isCreatingShape: true,
168
168
  initial: initial,
169
169
  })
@@ -13,7 +13,6 @@ import {
13
13
  debounce,
14
14
  getHashForString,
15
15
  lerp,
16
- markEventAsHandled,
17
16
  tlenv,
18
17
  toDomPrecision,
19
18
  useEditor,
@@ -134,7 +133,7 @@ function BookmarkShapeComponent({ shape }: { shape: TLBookmarkShape }) {
134
133
 
135
134
  const markAsHandledOnShiftKey = useCallback<PointerEventHandler>(
136
135
  (e) => {
137
- if (!editor.inputs.shiftKey) markEventAsHandled(e)
136
+ if (!editor.inputs.shiftKey) editor.markEventAsHandled(e)
138
137
  },
139
138
  [editor]
140
139
  )
@@ -1,4 +1,4 @@
1
- import { TLFrameShape, TLShapeId, markEventAsHandled, useEditor } from '@tldraw/editor'
1
+ import { TLFrameShape, TLShapeId, useEditor } from '@tldraw/editor'
2
2
  import { forwardRef, useCallback } from 'react'
3
3
  import { defaultEmptyAs } from '../FrameShapeUtil'
4
4
 
@@ -8,12 +8,19 @@ export const FrameLabelInput = forwardRef<
8
8
  >(({ id, name, isEditing }, ref) => {
9
9
  const editor = useEditor()
10
10
 
11
+ const handlePointerDown = useCallback(
12
+ (e: React.PointerEvent) => {
13
+ if (isEditing) editor.markEventAsHandled(e)
14
+ },
15
+ [editor, isEditing]
16
+ )
17
+
11
18
  const handleKeyDown = useCallback(
12
19
  (e: React.KeyboardEvent<HTMLInputElement>) => {
13
20
  if (e.key === 'Enter' && !e.nativeEvent.isComposing) {
14
21
  // need to prevent the enter keydown making it's way up to the Idle state
15
22
  // and sending us back into edit mode
16
- markEventAsHandled(e)
23
+ editor.markEventAsHandled(e)
17
24
  e.currentTarget.blur()
18
25
  editor.setEditingShape(null)
19
26
  }
@@ -74,7 +81,7 @@ export const FrameLabelInput = forwardRef<
74
81
  onKeyDown={handleKeyDown}
75
82
  onBlur={handleBlur}
76
83
  onChange={handleChange}
77
- onPointerDown={isEditing ? markEventAsHandled : undefined}
84
+ onPointerDown={handlePointerDown}
78
85
  draggable={false}
79
86
  />
80
87
  {defaultEmptyAs(name, 'Frame') + String.fromCharCode(8203)}
@@ -1,4 +1,4 @@
1
- import { markEventAsHandled, useEditor, useValue } from '@tldraw/editor'
1
+ import { useEditor, useValue } from '@tldraw/editor'
2
2
  import classNames from 'classnames'
3
3
  import { PointerEventHandler, useCallback } from 'react'
4
4
 
@@ -10,7 +10,7 @@ export function HyperlinkButton({ url }: { url: string }) {
10
10
  const hideButton = useValue('zoomLevel', () => editor.getZoomLevel() < 0.32, [editor])
11
11
  const markAsHandledOnShiftKey = useCallback<PointerEventHandler>(
12
12
  (e) => {
13
- if (!editor.inputs.shiftKey) markEventAsHandled(e)
13
+ if (!editor.inputs.shiftKey) editor.markEventAsHandled(e)
14
14
  },
15
15
  [editor]
16
16
  )
@@ -3,7 +3,6 @@ import {
3
3
  TLShapeId,
4
4
  TLUnknownShape,
5
5
  getPointerInfo,
6
- markEventAsHandled,
7
6
  noop,
8
7
  preventDefault,
9
8
  tlenv,
@@ -129,7 +128,7 @@ export function useEditableTextCommon(shapeId: TLShapeId) {
129
128
  // partially if we didn't dispatch/stop below.
130
129
 
131
130
  editor.dispatch({
132
- ...getPointerInfo(e),
131
+ ...getPointerInfo(editor, e),
133
132
  type: 'pointer',
134
133
  name: 'pointer_down',
135
134
  target: 'shape',
@@ -157,13 +156,11 @@ export function useEditableTextCommon(shapeId: TLShapeId) {
157
156
  [editor, shapeId]
158
157
  )
159
158
 
160
- const handleDoubleClick: (e: React.MouseEvent) => void = markEventAsHandled
161
-
162
159
  return {
163
160
  handleFocus: noop,
164
161
  handleBlur: noop,
165
162
  handleInputPointerDown,
166
- handleDoubleClick,
163
+ handleDoubleClick: editor.markEventAsHandled,
167
164
  handlePaste,
168
165
  isEditing,
169
166
  isReadyForEditing,
@@ -1,4 +1,4 @@
1
- import { markEventAsHandled, preventDefault } from '@tldraw/editor'
1
+ import { preventDefault, useEditor } from '@tldraw/editor'
2
2
  import React from 'react'
3
3
  import { TextAreaProps } from './RichTextArea'
4
4
 
@@ -21,6 +21,7 @@ export const PlainTextArea = React.forwardRef<HTMLTextAreaElement, TextAreaProps
21
21
  },
22
22
  ref
23
23
  ) {
24
+ const editor = useEditor()
24
25
  const onChange = (e: React.ChangeEvent<HTMLTextAreaElement>) => {
25
26
  handleChange({ plaintext: e.target.value })
26
27
  }
@@ -46,7 +47,7 @@ export const PlainTextArea = React.forwardRef<HTMLTextAreaElement, TextAreaProps
46
47
  onChange={onChange}
47
48
  onKeyDown={(e) => handleKeyDown(e.nativeEvent)}
48
49
  onBlur={handleBlur}
49
- onTouchEnd={markEventAsHandled}
50
+ onTouchEnd={editor.markEventAsHandled}
50
51
  onContextMenu={isEditing ? (e) => e.stopPropagation() : undefined}
51
52
  onPointerDown={handleInputPointerDown}
52
53
  onPaste={handlePaste}
@@ -13,6 +13,7 @@ import {
13
13
  sortByIndex,
14
14
  structuredClone,
15
15
  } from '@tldraw/editor'
16
+ import { ArrowShapeUtil } from '../../../shapes/arrow/ArrowShapeUtil'
16
17
  import { clearArrowTargetState } from '../../../shapes/arrow/arrowTargetState'
17
18
  import { getArrowBindings } from '../../../shapes/arrow/shared'
18
19
 
@@ -135,10 +136,13 @@ export class DraggingHandle extends StateNode {
135
136
  }
136
137
 
137
138
  // Only relevant to arrows
138
- private exactTimeout = -1 as any
139
+ private exactTimeout = -1
139
140
 
140
141
  // Only relevant to arrows
141
142
  private resetExactTimeout() {
143
+ const arrowUtil = this.editor.getShapeUtil<ArrowShapeUtil>('arrow')
144
+ const timeoutValue = arrowUtil.options.pointingPreciseTimeout
145
+
142
146
  if (this.exactTimeout !== -1) {
143
147
  this.clearExactTimeout()
144
148
  }
@@ -150,7 +154,7 @@ export class DraggingHandle extends StateNode {
150
154
  this.update()
151
155
  }
152
156
  this.exactTimeout = -1
153
- }, 750)
157
+ }, timeoutValue)
154
158
  }
155
159
 
156
160
  // Only relevant to arrows
@@ -1,7 +1,6 @@
1
1
  import {
2
2
  debugFlags,
3
3
  Editor,
4
- markEventAsHandled,
5
4
  TLGeoShape,
6
5
  TLShapeId,
7
6
  unsafe__withoutCapture,
@@ -23,7 +22,7 @@ export function SkipToMainContent() {
23
22
 
24
23
  const handleNavigateToFirstShape = useCallback(
25
24
  (e: MouseEvent | KeyboardEvent) => {
26
- markEventAsHandled(e)
25
+ editor.markEventAsHandled(e)
27
26
  button.current?.blur()
28
27
  const shapes = editor.getCurrentPageShapesInReadingOrder()
29
28
  if (!shapes.length) return
@@ -1,7 +1,7 @@
1
1
  import {
2
+ ToggleEnhancedA11yModeItem,
2
3
  ToggleKeyboardShortcutsItem,
3
4
  ToggleReduceMotionItem,
4
- ToggleUiLabelsItem,
5
5
  } from './menu-items'
6
6
  import { TldrawUiMenuGroup } from './primitives/menus/TldrawUiMenuGroup'
7
7
  import { TldrawUiMenuSubmenu } from './primitives/menus/TldrawUiMenuSubmenu'
@@ -13,7 +13,7 @@ export function AccessibilityMenu() {
13
13
  <TldrawUiMenuGroup id="accessibility">
14
14
  <ToggleReduceMotionItem />
15
15
  <ToggleKeyboardShortcutsItem />
16
- <ToggleUiLabelsItem />
16
+ <ToggleEnhancedA11yModeItem />
17
17
  </TldrawUiMenuGroup>
18
18
  </TldrawUiMenuSubmenu>
19
19
  )
@@ -0,0 +1,65 @@
1
+ import { useEditor, useValue } from '@tldraw/editor'
2
+ import { useUiEvents } from '../context/events'
3
+ import { TldrawUiMenuCheckboxItem } from './primitives/menus/TldrawUiMenuCheckboxItem'
4
+ import { TldrawUiMenuGroup } from './primitives/menus/TldrawUiMenuGroup'
5
+ import { TldrawUiMenuSubmenu } from './primitives/menus/TldrawUiMenuSubmenu'
6
+
7
+ const MODES = ['auto', 'trackpad', 'mouse'] as const
8
+
9
+ /** @public @react */
10
+ export function InputModeMenu() {
11
+ const editor = useEditor()
12
+ const trackEvent = useUiEvents()
13
+
14
+ const inputMode = useValue('inputMode', () => editor.user.getUserPreferences().inputMode, [
15
+ editor,
16
+ ])
17
+ const wheelBehavior = useValue('wheelBehavior', () => editor.getCameraOptions().wheelBehavior, [
18
+ editor,
19
+ ])
20
+
21
+ const isModeChecked = (mode: string) => {
22
+ if (mode === 'auto') {
23
+ return inputMode === null
24
+ }
25
+ return inputMode === mode
26
+ }
27
+
28
+ const getLabel = (mode: string, wheelBehavior: 'zoom' | 'pan' | 'none') => {
29
+ if (mode === 'auto') {
30
+ return `action.toggle-auto-${wheelBehavior}`
31
+ }
32
+
33
+ return mode === 'trackpad' ? 'action.toggle-trackpad' : 'action.toggle-mouse'
34
+ }
35
+
36
+ return (
37
+ <TldrawUiMenuSubmenu id="help menu input-mode" label="menu.input-mode">
38
+ <TldrawUiMenuGroup id="peripheral-mode">
39
+ {MODES.map((mode) => (
40
+ <TldrawUiMenuCheckboxItem
41
+ id={`peripheral-mode-${mode}`}
42
+ key={mode}
43
+ label={getLabel(mode, wheelBehavior)}
44
+ checked={isModeChecked(mode)}
45
+ readonlyOk
46
+ onSelect={() => {
47
+ trackEvent('input-mode', { source: 'menu', value: mode })
48
+ switch (mode) {
49
+ case 'auto':
50
+ editor.user.updateUserPreferences({ inputMode: null })
51
+ break
52
+ case 'trackpad':
53
+ editor.user.updateUserPreferences({ inputMode: 'trackpad' })
54
+ break
55
+ case 'mouse':
56
+ editor.user.updateUserPreferences({ inputMode: 'mouse' })
57
+ break
58
+ }
59
+ }}
60
+ />
61
+ ))}
62
+ </TldrawUiMenuGroup>
63
+ </TldrawUiMenuSubmenu>
64
+ )
65
+ }
@@ -18,6 +18,7 @@ export function LanguageMenu() {
18
18
  {LANGUAGES.map(({ locale, label }) => (
19
19
  <TldrawUiMenuCheckboxItem
20
20
  id={`language-${locale}`}
21
+ lang={locale}
21
22
  key={locale}
22
23
  title={locale}
23
24
  label={label}
@@ -2,6 +2,7 @@ import { useCanRedo, useCanUndo } from '../../hooks/menu-hooks'
2
2
  import { AccessibilityMenu } from '../AccessibilityMenu'
3
3
  import { ColorSchemeMenu } from '../ColorSchemeMenu'
4
4
  import { KeyboardShortcutsMenuItem } from '../HelpMenu/DefaultHelpMenuContent'
5
+ import { InputModeMenu } from '../InputModeMenu'
5
6
  import { LanguageMenu } from '../LanguageMenu'
6
7
  import {
7
8
  ClipboardMenuGroup,
@@ -164,6 +165,9 @@ export function PreferencesGroup() {
164
165
  <TogglePasteAtCursorItem />
165
166
  <ToggleDebugModeItem />
166
167
  </TldrawUiMenuGroup>
168
+ <TldrawUiMenuGroup id="input-mode">
169
+ <InputModeMenu />
170
+ </TldrawUiMenuGroup>
167
171
  <TldrawUiMenuGroup id="color-scheme">
168
172
  <ColorSchemeMenu />
169
173
  </TldrawUiMenuGroup>