tlc-claude-code 2.4.4 → 2.4.5

package/.claude/commands/tlc/build.md

@@ -936,15 +936,33 @@ Verdict: ❌ CHANGES REQUESTED
 ───────────────────────────────
 ```
 
-**Actions on failure:**
-1. Add missing test files
-2. Fix security issues
-3. Split oversized files (>1000 lines) into focused sub-modules
-4. Replace `any` types with proper interfaces or `unknown`
-5. Add explicit return types to all exported functions
-6. Re-run `/tlc:build {phase}` to retry
-
-**CRITICAL: Phase is NOT complete until review passes.**
+**Review-Fix Loop (automatic — do not ask, just do it):**
+
+When the review finds issues, fix them immediately and re-review. This is a loop, not a hand-off:
+
+```
+Iteration 1: Review → found 3 issues
+  → Fix: add missing tests, remove hardcoded secret, split oversized file
+  → Run tests (must still pass after fixes)
+  → Commit fixes: "fix: review findings - phase {N}"
+
+Iteration 2: Re-review → found 1 issue
+  → Fix: replace `any` type with interface
+  → Run tests
+  → Commit fix
+
+Iteration 3: Re-review → clean
+  → Verdict: ✅ APPROVED
+```
+
+**Loop rules:**
+- Max 5 iterations. If still failing after 5, report remaining issues and stop.
+- Run the full test suite after each fix batch (never break tests to fix review issues).
+- Commit after each fix batch — don't accumulate.
+- Each iteration re-runs ALL checks, not just the ones that failed (fixes can introduce new issues).
+- Security issues are fixed first (highest priority), then coverage, then style.
+
+**CRITICAL: Phase is NOT complete until review passes. The loop runs automatically — do not stop after reporting issues.**
 
 ### Step 11: Push Branch and Create PR (Mandatory)
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "tlc-claude-code",
-  "version": "2.4.4",
+  "version": "2.4.5",
   "description": "TLC - Test Led Coding for Claude Code",
   "bin": {
     "tlc-claude-code": "./bin/install.js",

package/server/lib/task-router-config.js

@@ -19,16 +19,33 @@ const path = require('path');
 const ROUTABLE_COMMANDS = [
   'build', 'plan', 'review', 'test', 'coverage',
   'autofix', 'discuss', 'docs', 'edge-cases', 'quick',
+  'design', 'vision',
 ];
 
 /**
- * Default routing: every routable command maps to claude with single strategy.
+ * Default routing: coding commands → codex, thinking commands → claude.
+ *
+ * Coding: build, quick, autofix (single) + edge-cases, review (parallel)
+ * Thinking: plan, discuss, docs, coverage, test, design, vision (single)
+ *
  * @type {Record<string, {models: string[], strategy: string}>}
  */
-const SHIPPED_DEFAULTS = {};
-for (const cmd of ROUTABLE_COMMANDS) {
-  SHIPPED_DEFAULTS[cmd] = { models: ['claude'], strategy: 'single' };
-}
+const SHIPPED_DEFAULTS = {
+  // Coding — codex
+  'build':      { models: ['codex'], strategy: 'single' },
+  'quick':      { models: ['codex'], strategy: 'single' },
+  'autofix':    { models: ['codex'], strategy: 'single' },
+  'edge-cases': { models: ['codex'], strategy: 'parallel' },
+  'review':     { models: ['codex', 'claude'], strategy: 'parallel' },
+  // Thinking — claude
+  'plan':       { models: ['codex', 'claude'], strategy: 'parallel' },
+  'discuss':    { models: ['claude'], strategy: 'single' },
+  'docs':       { models: ['claude'], strategy: 'single' },
+  'coverage':   { models: ['claude'], strategy: 'single' },
+  'test':       { models: ['claude'], strategy: 'single' },
+  'design':     { models: ['claude'], strategy: 'single' },
+  'vision':     { models: ['claude'], strategy: 'single' },
+};
 
 /**
  * Load personal config from ~/.tlc/config.json

package/server/lib/task-router-config.test.js

@@ -27,12 +27,27 @@ function mockFs(fileMap = {}) {
 describe('task-router-config', () => {
   // ── SHIPPED_DEFAULTS ──────────────────────────────────────────────
   describe('SHIPPED_DEFAULTS', () => {
-    it('maps every routable command to claude/single', () => {
+    it('routes coding commands to codex', () => {
+      expect(SHIPPED_DEFAULTS['build']).toEqual({ models: ['codex'], strategy: 'single' });
+      expect(SHIPPED_DEFAULTS['quick']).toEqual({ models: ['codex'], strategy: 'single' });
+      expect(SHIPPED_DEFAULTS['autofix']).toEqual({ models: ['codex'], strategy: 'single' });
+      expect(SHIPPED_DEFAULTS['edge-cases']).toEqual({ models: ['codex'], strategy: 'parallel' });
+      expect(SHIPPED_DEFAULTS['review']).toEqual({ models: ['codex', 'claude'], strategy: 'parallel' });
+    });
+
+    it('routes thinking commands to claude', () => {
+      expect(SHIPPED_DEFAULTS['plan']).toEqual({ models: ['codex', 'claude'], strategy: 'parallel' });
+      expect(SHIPPED_DEFAULTS['discuss']).toEqual({ models: ['claude'], strategy: 'single' });
+      expect(SHIPPED_DEFAULTS['docs']).toEqual({ models: ['claude'], strategy: 'single' });
+      expect(SHIPPED_DEFAULTS['coverage']).toEqual({ models: ['claude'], strategy: 'single' });
+      expect(SHIPPED_DEFAULTS['test']).toEqual({ models: ['claude'], strategy: 'single' });
+      expect(SHIPPED_DEFAULTS['design']).toEqual({ models: ['claude'], strategy: 'single' });
+      expect(SHIPPED_DEFAULTS['vision']).toEqual({ models: ['claude'], strategy: 'single' });
+    });
+
+    it('has an entry for every routable command', () => {
       for (const cmd of ROUTABLE_COMMANDS) {
-        expect(SHIPPED_DEFAULTS[cmd]).toEqual({
-          models: ['claude'],
-          strategy: 'single',
-        });
+        expect(SHIPPED_DEFAULTS[cmd]).toBeDefined();
       }
     });
   });
@@ -43,6 +58,7 @@ describe('task-router-config', () => {
       const expected = [
         'build', 'plan', 'review', 'test', 'coverage',
         'autofix', 'discuss', 'docs', 'edge-cases', 'quick',
+        'design', 'vision',
       ];
       for (const cmd of expected) {
         expect(ROUTABLE_COMMANDS).toContain(cmd);
@@ -128,7 +144,7 @@ describe('task-router-config', () => {
 
   // ── resolveRouting ────────────────────────────────────────────────
   describe('resolveRouting', () => {
-    it('returns shipped defaults when no config exists', () => {
+    it('returns shipped defaults when no config exists (coding command)', () => {
       const fs = mockFs({});
       const result = resolveRouting({
         command: 'build',
@@ -137,6 +153,23 @@ describe('task-router-config', () => {
         fs,
       });
 
+      expect(result).toEqual({
+        models: ['codex'],
+        strategy: 'single',
+        source: 'shipped-defaults',
+        warnings: [],
+      });
+    });
+
+    it('returns shipped defaults when no config exists (thinking command)', () => {
+      const fs = mockFs({});
+      const result = resolveRouting({
+        command: 'discuss',
+        projectDir: '/project',
+        homeDir: '/home/user',
+        fs,
+      });
+
       expect(result).toEqual({
         models: ['claude'],
         strategy: 'single',
@@ -274,7 +307,7 @@ describe('task-router-config', () => {
         warnings: [],
       });
 
-      // 'build' should still use defaults
+      // 'build' should still use its shipped default (codex/single)
       const buildResult = resolveRouting({
         command: 'build',
         projectDir: '/project',
@@ -282,7 +315,7 @@ describe('task-router-config', () => {
         fs,
       });
       expect(buildResult).toEqual({
-        models: ['claude'],
+        models: ['codex'],
         strategy: 'single',
         source: 'shipped-defaults',
         warnings: [],
@@ -306,9 +339,9 @@ describe('task-router-config', () => {
         fs,
       });
 
-      // Should keep default models but use personal strategy
+      // Should keep default models (codex for build) but use personal strategy
       expect(result.strategy).toBe('parallel');
-      expect(result.models).toEqual(['claude']);
+      expect(result.models).toEqual(['codex']);
       expect(result.source).toBe('personal-config');
       expect(result.warnings).toEqual([]);
     });
@@ -393,7 +426,7 @@ describe('task-router-config', () => {
       });
 
       expect(result).toEqual({
-        models: ['claude'],
+        models: ['codex'],
         strategy: 'single',
         source: 'shipped-defaults',
         warnings: [expect.stringContaining('/home/user/.tlc/config.json')],
@@ -413,7 +446,7 @@ describe('task-router-config', () => {
       });
 
       expect(result).toEqual({
-        models: ['claude'],
+        models: ['codex'],
         strategy: 'single',
         source: 'shipped-defaults',
         warnings: [expect.stringContaining('/project/.tlc.json')],
@@ -433,7 +466,7 @@ describe('task-router-config', () => {
         fs,
       });
 
-      expect(result.models).toEqual(['claude']);
+      expect(result.models).toEqual(['codex']);
       expect(result.strategy).toBe('single');
       expect(result.source).toBe('shipped-defaults');
       expect(result.warnings).toHaveLength(2);