tlc-claude-code 2.4.2 → 2.4.3

package/server/lib/task-router-config.test.js

@@ -66,21 +66,22 @@ describe('task-router-config', () => {
       });
 
       const result = loadPersonalConfig({ homeDir: '/home/user', fs });
-      expect(result).toEqual(personalConfig);
+      expect(result).toEqual({ config: personalConfig, warning: null });
     });
 
     it('returns null when file does not exist', () => {
       const fs = mockFs({});
       const result = loadPersonalConfig({ homeDir: '/home/user', fs });
-      expect(result).toBeNull();
+      expect(result).toEqual({ config: null, warning: null });
     });
 
-    it('returns null for malformed JSON', () => {
+    it('returns warning for malformed JSON', () => {
       const fs = mockFs({
         '/home/user/.tlc/config.json': '{ not valid json',
       });
       const result = loadPersonalConfig({ homeDir: '/home/user', fs });
-      expect(result).toBeNull();
+      expect(result.config).toBeNull();
+      expect(result.warning).toContain('/home/user/.tlc/config.json');
     });
   });
 
@@ -97,7 +98,7 @@ describe('task-router-config', () => {
       });
 
       const result = loadProjectOverride({ projectDir: '/project', fs });
-      expect(result).toEqual(tlcJson.task_routing_override);
+      expect(result).toEqual({ override: tlcJson.task_routing_override, warning: null });
     });
 
     it('returns null when .tlc.json has no task_routing_override', () => {
@@ -106,21 +107,22 @@ describe('task-router-config', () => {
       });
 
       const result = loadProjectOverride({ projectDir: '/project', fs });
-      expect(result).toBeNull();
+      expect(result).toEqual({ override: null, warning: null });
     });
 
     it('returns null when .tlc.json does not exist', () => {
       const fs = mockFs({});
       const result = loadProjectOverride({ projectDir: '/project', fs });
-      expect(result).toBeNull();
+      expect(result).toEqual({ override: null, warning: null });
     });
 
-    it('returns null for malformed JSON', () => {
+    it('returns warning for malformed JSON', () => {
       const fs = mockFs({
         '/project/.tlc.json': 'broken!!!',
       });
       const result = loadProjectOverride({ projectDir: '/project', fs });
-      expect(result).toBeNull();
+      expect(result.override).toBeNull();
+      expect(result.warning).toContain('/project/.tlc.json');
     });
   });
 
@@ -139,6 +141,7 @@ describe('task-router-config', () => {
         models: ['claude'],
         strategy: 'single',
         source: 'shipped-defaults',
+        warnings: [],
       });
     });
 
@@ -163,6 +166,7 @@ describe('task-router-config', () => {
         models: ['codex'],
         strategy: 'single',
         source: 'personal-config',
+        warnings: [],
       });
     });
 
@@ -193,6 +197,7 @@ describe('task-router-config', () => {
         models: ['local'],
         strategy: 'single',
         source: 'project-override',
+        warnings: [],
       });
     });
 
@@ -224,6 +229,7 @@ describe('task-router-config', () => {
         models: ['gemini'],
         strategy: 'single',
         source: 'flag-override',
+        warnings: [],
       });
     });
 
@@ -240,6 +246,7 @@ describe('task-router-config', () => {
         models: ['claude'],
         strategy: 'single',
         source: 'shipped-defaults',
+        warnings: [],
       });
     });
 
@@ -264,6 +271,7 @@ describe('task-router-config', () => {
         models: ['claude', 'codex'],
         strategy: 'parallel',
         source: 'personal-config',
+        warnings: [],
       });
 
       // 'build' should still use defaults
@@ -277,6 +285,7 @@ describe('task-router-config', () => {
         models: ['claude'],
         strategy: 'single',
         source: 'shipped-defaults',
+        warnings: [],
       });
     });
 
@@ -301,6 +310,7 @@ describe('task-router-config', () => {
       expect(result.strategy).toBe('parallel');
       expect(result.models).toEqual(['claude']);
       expect(result.source).toBe('personal-config');
+      expect(result.warnings).toEqual([]);
     });
 
     it('partial personal config merges correctly (only models)', () => {
@@ -323,6 +333,7 @@ describe('task-router-config', () => {
       expect(result.models).toEqual(['codex']);
       expect(result.strategy).toBe('single');
       expect(result.source).toBe('personal-config');
+      expect(result.warnings).toEqual([]);
     });
 
     it('missing personal config file handled gracefully', () => {
@@ -345,10 +356,31 @@ describe('task-router-config', () => {
         models: ['local'],
         strategy: 'single',
         source: 'project-override',
+        warnings: [],
       });
     });
 
-    it('malformed personal JSON handled gracefully', () => {
+    it('valid config returns empty warnings array', () => {
+      const personalConfig = {
+        task_routing: {
+          build: { models: ['codex'], strategy: 'single' },
+        },
+      };
+      const fs = mockFs({
+        '/home/user/.tlc/config.json': JSON.stringify(personalConfig),
+      });
+
+      const result = resolveRouting({
+        command: 'build',
+        projectDir: '/project',
+        homeDir: '/home/user',
+        fs,
+      });
+
+      expect(result.warnings).toEqual([]);
+    });
+
+    it('malformed personal JSON handled gracefully with warning', () => {
       const fs = mockFs({
         '/home/user/.tlc/config.json': '{{{{not json!',
       });
@@ -364,10 +396,11 @@ describe('task-router-config', () => {
         models: ['claude'],
         strategy: 'single',
         source: 'shipped-defaults',
+        warnings: [expect.stringContaining('/home/user/.tlc/config.json')],
       });
     });
 
-    it('malformed project JSON handled gracefully', () => {
+    it('malformed project JSON handled gracefully with warning', () => {
       const fs = mockFs({
         '/project/.tlc.json': 'not json either!',
       });
@@ -383,9 +416,31 @@ describe('task-router-config', () => {
         models: ['claude'],
         strategy: 'single',
         source: 'shipped-defaults',
+        warnings: [expect.stringContaining('/project/.tlc.json')],
       });
     });
 
+    it('collects both warnings when personal and project JSON are malformed', () => {
+      const fs = mockFs({
+        '/home/user/.tlc/config.json': '{{{{not json!',
+        '/project/.tlc.json': 'not json either!',
+      });
+
+      const result = resolveRouting({
+        command: 'build',
+        projectDir: '/project',
+        homeDir: '/home/user',
+        fs,
+      });
+
+      expect(result.models).toEqual(['claude']);
+      expect(result.strategy).toBe('single');
+      expect(result.source).toBe('shipped-defaults');
+      expect(result.warnings).toHaveLength(2);
+      expect(result.warnings[0]).toContain('/home/user/.tlc/config.json');
+      expect(result.warnings[1]).toContain('/project/.tlc.json');
+    });
+
     it('model_providers loaded from personal config', () => {
       const personalConfig = {
         task_routing: {
@@ -410,9 +465,10 @@ describe('task-router-config', () => {
 
       expect(result.models).toEqual(['codex']);
       expect(result.providers).toEqual(personalConfig.model_providers);
+      expect(result.warnings).toEqual([]);
     });
 
-    it('personal config with singular model (string) is normalized to models array', () => {
+    it('personal config with singular model (string) is normalized to models array with deprecation warning', () => {
       const personalConfig = {
         task_routing: {
           build: { model: 'codex', strategy: 'single' },
@@ -432,9 +488,12 @@ describe('task-router-config', () => {
       expect(result.models).toEqual(['codex']);
       expect(result.strategy).toBe('single');
       expect(result.source).toBe('personal-config');
+      expect(result.warnings).toEqual([
+        expect.stringMatching(/models/i),
+      ]);
     });
 
-    it('project override with singular model (string) is normalized to models array', () => {
+    it('project override with singular model (string) is normalized to models array with deprecation warning', () => {
       const tlcJson = {
         task_routing_override: {
           review: { model: 'gemini', strategy: 'single' },
@@ -454,6 +513,9 @@ describe('task-router-config', () => {
       expect(result.models).toEqual(['gemini']);
       expect(result.strategy).toBe('single');
       expect(result.source).toBe('project-override');
+      expect(result.warnings).toEqual([
+        expect.stringMatching(/models/i),
+      ]);
     });
 
     it('models array takes precedence over model string in same config entry', () => {
@@ -475,6 +537,7 @@ describe('task-router-config', () => {
 
       expect(result.models).toEqual(['codex', 'claude']);
       expect(result.strategy).toBe('parallel');
+      expect(result.warnings).toEqual([]);
     });
 
     it('returns no providers when personal config has none', () => {
@@ -488,6 +551,7 @@ describe('task-router-config', () => {
       });
 
       expect(result.providers).toBeUndefined();
+      expect(result.warnings).toEqual([]);
     });
   });
 });