tlc-claude-code 2.1.0 → 2.2.0

package/server/lib/review/review-schemas.test.js

@@ -0,0 +1,152 @@
+import { describe, it, expect } from 'vitest';
+import {
+  codeReviewSchema,
+  planReviewSchema,
+  validateReviewOutput,
+  parseMarkdownReview,
+  exportSchemas,
+  SEVERITY_LEVELS,
+} from './review-schemas.js';
+
+describe('review-schemas', () => {
+  describe('codeReviewSchema', () => {
+    it('validates correct code review output', () => {
+      const output = {
+        verdict: 'APPROVED',
+        score: 85,
+        summary: 'Clean implementation with good test coverage.',
+        issues: [],
+      };
+      const result = validateReviewOutput(output, codeReviewSchema);
+      expect(result.valid).toBe(true);
+      expect(result.errors).toHaveLength(0);
+    });
+
+    it('validates output with issues', () => {
+      const output = {
+        verdict: 'CHANGES_REQUESTED',
+        score: 40,
+        summary: 'Several issues found.',
+        issues: [
+          {
+            file: 'src/auth.js',
+            line: 42,
+            severity: 'high',
+            category: 'security',
+            message: 'Hardcoded password detected',
+            suggestion: 'Use environment variable instead',
+          },
+        ],
+      };
+      const result = validateReviewOutput(output, codeReviewSchema);
+      expect(result.valid).toBe(true);
+    });
+
+    it('rejects output missing verdict', () => {
+      const output = { score: 85, summary: 'Good.', issues: [] };
+      const result = validateReviewOutput(output, codeReviewSchema);
+      expect(result.valid).toBe(false);
+      expect(result.errors.some(e => e.includes('verdict'))).toBe(true);
+    });
+
+    it('rejects issue with invalid severity', () => {
+      const output = {
+        verdict: 'APPROVED',
+        score: 85,
+        summary: 'Good.',
+        issues: [
+          { file: 'a.js', line: 1, severity: 'extreme', category: 'bug', message: 'Bad', suggestion: 'Fix' },
+        ],
+      };
+      const result = validateReviewOutput(output, codeReviewSchema);
+      expect(result.valid).toBe(false);
+      expect(result.errors.some(e => e.includes('severity'))).toBe(true);
+    });
+
+    it('rejects issue without file field', () => {
+      const output = {
+        verdict: 'APPROVED',
+        score: 85,
+        summary: 'Good.',
+        issues: [
+          { line: 1, severity: 'low', category: 'style', message: 'Naming', suggestion: 'Rename' },
+        ],
+      };
+      const result = validateReviewOutput(output, codeReviewSchema);
+      expect(result.valid).toBe(false);
+      expect(result.errors.some(e => e.includes('file'))).toBe(true);
+    });
+  });
+
+  describe('planReviewSchema', () => {
+    it('validates correct plan review output', () => {
+      const output = {
+        verdict: 'APPROVED',
+        structureIssues: [],
+        scopeIssues: [],
+        suggestions: ['Consider adding error handling task'],
+      };
+      const result = validateReviewOutput(output, planReviewSchema);
+      expect(result.valid).toBe(true);
+    });
+
+    it('rejects plan review missing verdict', () => {
+      const output = { structureIssues: [], scopeIssues: [], suggestions: [] };
+      const result = validateReviewOutput(output, planReviewSchema);
+      expect(result.valid).toBe(false);
+    });
+  });
+
+  describe('SEVERITY_LEVELS', () => {
+    it('contains all four levels', () => {
+      expect(SEVERITY_LEVELS).toEqual(['critical', 'high', 'medium', 'low']);
+    });
+  });
+
+  describe('parseMarkdownReview', () => {
+    it('extracts APPROVED verdict', () => {
+      const text = '## Review\n\nLooks good!\n\nVerdict: APPROVED';
+      const result = parseMarkdownReview(text);
+      expect(result.verdict).toBe('APPROVED');
+    });
+
+    it('extracts CHANGES_REQUESTED verdict', () => {
+      const text = 'Issues found.\n\nVerdict: CHANGES_REQUESTED\n\n- Fix X\n- Fix Y';
+      const result = parseMarkdownReview(text);
+      expect(result.verdict).toBe('CHANGES_REQUESTED');
+    });
+
+    it('extracts issues from bullet points', () => {
+      const text = `Verdict: CHANGES_REQUESTED
+
+Issues:
+- src/auth.js:42 [high] Hardcoded password
+- src/db.js:10 [medium] Missing error handling`;
+      const result = parseMarkdownReview(text);
+      expect(result.issues.length).toBeGreaterThanOrEqual(2);
+      expect(result.issues[0].file).toBe('src/auth.js');
+    });
+
+    it('returns UNKNOWN for ambiguous text', () => {
+      const text = 'Some random review text without a clear verdict.';
+      const result = parseMarkdownReview(text);
+      expect(result.verdict).toBe('UNKNOWN');
+    });
+  });
+
+  describe('exportSchemas', () => {
+    it('produces valid JSON Schema for code review', () => {
+      const schemas = exportSchemas();
+      expect(schemas.codeReview).toHaveProperty('$schema');
+      expect(schemas.codeReview).toHaveProperty('type', 'object');
+      expect(schemas.codeReview.required).toContain('verdict');
+    });
+
+    it('produces valid JSON Schema for plan review', () => {
+      const schemas = exportSchemas();
+      expect(schemas.planReview).toHaveProperty('$schema');
+      expect(schemas.planReview).toHaveProperty('type', 'object');
+      expect(schemas.planReview.required).toContain('verdict');
+    });
+  });
+});