tlc-claude-code 2.0.1 → 2.2.0

package/server/lib/workspace-api.test.js

@@ -740,4 +740,478 @@ describe('Workspace API', () => {
       expect(repo.phaseName).toBe('Auth');
     });
   });
+
+  // =========================================================================
+  // Memory API routes (Task 1 - Phase 77)
+  // =========================================================================
+
+  describe('Memory API routes', () => {
+    function createRouterWithMemory(projectPath, memoryApi) {
+      const projectId = Buffer.from(projectPath).toString('base64url');
+      const mockConfig = createMockGlobalConfig([path.dirname(projectPath)]);
+      const mockScanner = createMockProjectScanner([
+        { name: 'mem-project', path: projectPath, hasTlc: true, hasPlanning: true },
+      ]);
+      const router = createWorkspaceRouter({
+        globalConfig: mockConfig,
+        projectScanner: mockScanner,
+        memoryApi,
+      });
+      return { router, projectId };
+    }
+
+    it('GET /projects/:id/memory/decisions returns decisions from file adapter', async () => {
+      const projectPath = path.join(tempDir, 'mem-proj');
+      fs.mkdirSync(projectPath, { recursive: true });
+      const mockMemoryApi = {};
+      const { router, projectId } = createRouterWithMemory(projectPath, mockMemoryApi);
+
+      const handler = getHandler(router, 'GET', '/projects/:projectId/memory/decisions');
+      expect(handler).not.toBeNull();
+
+      const { req, res } = createMockReqRes('GET', `/projects/${projectId}/memory/decisions`, {}, { projectId });
+      await handler(req, res);
+
+      expect(res.statusCode).toBe(200);
+      expect(res._json.decisions).toBeDefined();
+      expect(Array.isArray(res._json.decisions)).toBe(true);
+    });
+
+    it('GET /projects/:id/memory/gotchas returns gotchas from file adapter', async () => {
+      const projectPath = path.join(tempDir, 'mem-proj2');
+      fs.mkdirSync(projectPath, { recursive: true });
+      const mockMemoryApi = {};
+      const { router, projectId } = createRouterWithMemory(projectPath, mockMemoryApi);
+
+      const handler = getHandler(router, 'GET', '/projects/:projectId/memory/gotchas');
+      expect(handler).not.toBeNull();
+
+      const { req, res } = createMockReqRes('GET', `/projects/${projectId}/memory/gotchas`, {}, { projectId });
+      await handler(req, res);
+
+      expect(res.statusCode).toBe(200);
+      expect(res._json.gotchas).toBeDefined();
+      expect(Array.isArray(res._json.gotchas)).toBe(true);
+    });
+
+    it('GET /projects/:id/memory/stats returns per-project stats', async () => {
+      const projectPath = path.join(tempDir, 'mem-proj3');
+      fs.mkdirSync(projectPath, { recursive: true });
+      const mockMemoryApi = {};
+      const { router, projectId } = createRouterWithMemory(projectPath, mockMemoryApi);
+
+      const handler = getHandler(router, 'GET', '/projects/:projectId/memory/stats');
+      expect(handler).not.toBeNull();
+
+      const { req, res } = createMockReqRes('GET', `/projects/${projectId}/memory/stats`, {}, { projectId });
+      await handler(req, res);
+
+      expect(res.statusCode).toBe(200);
+      expect(res._json).toHaveProperty('decisions');
+      expect(res._json).toHaveProperty('gotchas');
+      expect(res._json).toHaveProperty('total');
+    });
+
+    it('memory routes return 404 for unknown project', async () => {
+      const mockMemoryApi = {};
+      const unknownId = Buffer.from('/tmp/nonexistent').toString('base64url');
+      const mockConfig = createMockGlobalConfig([tempDir]);
+      const mockScanner = createMockProjectScanner([]);
+      const router = createWorkspaceRouter({
+        globalConfig: mockConfig,
+        projectScanner: mockScanner,
+        memoryApi: mockMemoryApi,
+      });
+
+      const handler = getHandler(router, 'GET', '/projects/:projectId/memory/decisions');
+      const { req, res } = createMockReqRes('GET', `/projects/${unknownId}/memory/decisions`, {}, { projectId: unknownId });
+      await handler(req, res);
+
+      expect(res.statusCode).toBe(404);
+    });
+  });
+
+  // =========================================================================
+  // Project file endpoint (Task 1 - Phase 77)
+  // =========================================================================
+
+  describe('Project file endpoint', () => {
+    it('GET /projects/:id/files/:filename returns .planning file content', async () => {
+      const projectPath = path.join(tempDir, 'file-proj');
+      fs.mkdirSync(path.join(projectPath, '.planning'), { recursive: true });
+      fs.writeFileSync(path.join(projectPath, '.planning', 'ROADMAP.md'), '# Roadmap\n\nPhase 1');
+
+      const projectId = Buffer.from(projectPath).toString('base64url');
+      const mockConfig = createMockGlobalConfig([tempDir]);
+      const mockScanner = createMockProjectScanner([
+        { name: 'file-proj', path: projectPath, hasTlc: true, hasPlanning: true },
+      ]);
+      const router = createWorkspaceRouter({ globalConfig: mockConfig, projectScanner: mockScanner });
+
+      const handler = getHandler(router, 'GET', '/projects/:projectId/files/:filename');
+      expect(handler).not.toBeNull();
+
+      const { req, res } = createMockReqRes('GET', `/projects/${projectId}/files/ROADMAP.md`, {}, { projectId, filename: 'ROADMAP.md' });
+      await handler(req, res);
+
+      expect(res.statusCode).toBe(200);
+      expect(res._json.content).toBe('# Roadmap\n\nPhase 1');
+      expect(res._json.filename).toBe('ROADMAP.md');
+    });
+
+    it('file endpoint returns 404 for missing file', async () => {
+      const projectPath = path.join(tempDir, 'file-proj2');
+      fs.mkdirSync(path.join(projectPath, '.planning'), { recursive: true });
+
+      const projectId = Buffer.from(projectPath).toString('base64url');
+      const mockConfig = createMockGlobalConfig([tempDir]);
+      const mockScanner = createMockProjectScanner([
+        { name: 'file-proj2', path: projectPath, hasTlc: true, hasPlanning: true },
+      ]);
+      const router = createWorkspaceRouter({ globalConfig: mockConfig, projectScanner: mockScanner });
+
+      const handler = getHandler(router, 'GET', '/projects/:projectId/files/:filename');
+      const { req, res } = createMockReqRes('GET', `/projects/${projectId}/files/NONEXISTENT.md`, {}, { projectId, filename: 'NONEXISTENT.md' });
+      await handler(req, res);
+
+      expect(res.statusCode).toBe(404);
+    });
+
+    it('file endpoint rejects path traversal', async () => {
+      const projectPath = path.join(tempDir, 'file-proj3');
+      fs.mkdirSync(path.join(projectPath, '.planning'), { recursive: true });
+
+      const projectId = Buffer.from(projectPath).toString('base64url');
+      const mockConfig = createMockGlobalConfig([tempDir]);
+      const mockScanner = createMockProjectScanner([
+        { name: 'file-proj3', path: projectPath, hasTlc: true, hasPlanning: true },
+      ]);
+      const router = createWorkspaceRouter({ globalConfig: mockConfig, projectScanner: mockScanner });
+
+      const handler = getHandler(router, 'GET', '/projects/:projectId/files/:filename');
+      const { req, res } = createMockReqRes('GET', `/projects/${projectId}/files/../../../etc/passwd`, {}, { projectId, filename: '../../../etc/passwd' });
+      await handler(req, res);
+
+      expect(res.statusCode).toBe(400);
+    });
+  });
+
+  // =========================================================================
+  // Coverage in project status (Task 9 - Phase 77)
+  // =========================================================================
+
+  describe('readProjectStatus coverage', () => {
+    it('returns coverage from coverage-summary.json when present', async () => {
+      const projectPath = path.join(tempDir, 'cov-project');
+      fs.mkdirSync(projectPath, { recursive: true });
+      fs.mkdirSync(path.join(projectPath, '.planning'), { recursive: true });
+      fs.writeFileSync(path.join(projectPath, '.tlc.json'), '{}');
+      fs.mkdirSync(path.join(projectPath, 'coverage'), { recursive: true });
+      fs.writeFileSync(
+        path.join(projectPath, 'coverage', 'coverage-summary.json'),
+        JSON.stringify({
+          total: {
+            lines: { pct: 85.5 },
+            statements: { pct: 82.3 },
+            functions: { pct: 90.1 },
+            branches: { pct: 70.2 },
+          },
+        })
+      );
+
+      const projectId = Buffer.from(projectPath).toString('base64url');
+      const mockConfig = createMockGlobalConfig([tempDir]);
+      const mockScanner = createMockProjectScanner([
+        { name: 'cov-project', path: projectPath, hasTlc: true, hasPlanning: true },
+      ]);
+      const router = createWorkspaceRouter({ globalConfig: mockConfig, projectScanner: mockScanner });
+
+      const handler = getHandler(router, 'GET', '/projects/:projectId/status');
+      const { req, res } = createMockReqRes('GET', `/projects/${projectId}/status`, {}, { projectId });
+      await handler(req, res);
+
+      expect(res.statusCode).toBe(200);
+      expect(res._json.status.coverage).toBe(85.5);
+    });
+
+    it('returns null coverage when no coverage-summary.json exists', async () => {
+      const projectPath = path.join(tempDir, 'no-cov-project');
+      fs.mkdirSync(projectPath, { recursive: true });
+      fs.mkdirSync(path.join(projectPath, '.planning'), { recursive: true });
+      fs.writeFileSync(path.join(projectPath, '.tlc.json'), '{}');
+
+      const projectId = Buffer.from(projectPath).toString('base64url');
+      const mockConfig = createMockGlobalConfig([tempDir]);
+      const mockScanner = createMockProjectScanner([
+        { name: 'no-cov-project', path: projectPath, hasTlc: true, hasPlanning: true },
+      ]);
+      const router = createWorkspaceRouter({ globalConfig: mockConfig, projectScanner: mockScanner });
+
+      const handler = getHandler(router, 'GET', '/projects/:projectId/status');
+      const { req, res } = createMockReqRes('GET', `/projects/${projectId}/status`, {}, { projectId });
+      await handler(req, res);
+
+      expect(res.statusCode).toBe(200);
+      expect(res._json.status.coverage).toBeNull();
+    });
+
+    it('returns null coverage when coverage-summary.json is malformed', async () => {
+      const projectPath = path.join(tempDir, 'bad-cov-project');
+      fs.mkdirSync(projectPath, { recursive: true });
+      fs.mkdirSync(path.join(projectPath, '.planning'), { recursive: true });
+      fs.writeFileSync(path.join(projectPath, '.tlc.json'), '{}');
+      fs.mkdirSync(path.join(projectPath, 'coverage'), { recursive: true });
+      fs.writeFileSync(
+        path.join(projectPath, 'coverage', 'coverage-summary.json'),
+        'not json'
+      );
+
+      const projectId = Buffer.from(projectPath).toString('base64url');
+      const mockConfig = createMockGlobalConfig([tempDir]);
+      const mockScanner = createMockProjectScanner([
+        { name: 'bad-cov-project', path: projectPath, hasTlc: true, hasPlanning: true },
+      ]);
+      const router = createWorkspaceRouter({ globalConfig: mockConfig, projectScanner: mockScanner });
+
+      const handler = getHandler(router, 'GET', '/projects/:projectId/status');
+      const { req, res } = createMockReqRes('GET', `/projects/${projectId}/status`, {}, { projectId });
+      await handler(req, res);
+
+      expect(res.statusCode).toBe(200);
+      expect(res._json.status.coverage).toBeNull();
+    });
+  });
+
+  // =========================================================================
+  // Phase 79 — Task 5: Memory capture endpoint
+  // =========================================================================
+  describe('POST /projects/:projectId/memory/capture', () => {
+    it('returns 404 for unknown project', async () => {
+      const mockConfig = createMockGlobalConfig([tempDir]);
+      const mockScanner = createMockProjectScanner([]);
+      const mockMemoryApi = {};
+      const router = createWorkspaceRouter({
+        globalConfig: mockConfig,
+        projectScanner: mockScanner,
+        memoryApi: mockMemoryApi,
+        memoryDeps: {},
+      });
+
+      const handler = getHandler(router, 'POST', '/projects/:projectId/memory/capture');
+      expect(handler).not.toBeNull();
+
+      const fakeId = Buffer.from('/nonexistent').toString('base64url');
+      const { req, res } = createMockReqRes('POST', `/projects/${fakeId}/memory/capture`, { exchanges: [{ user: 'hello', assistant: 'hi there' }] }, { projectId: fakeId });
+      await handler(req, res);
+
+      expect(res.statusCode).toBe(404);
+    });
+
+    it('returns 400 for missing exchanges body', async () => {
+      const projectPath = path.join(tempDir, 'capture-project');
+      fs.mkdirSync(projectPath, { recursive: true });
+      fs.writeFileSync(path.join(projectPath, '.tlc.json'), '{}');
+      fs.mkdirSync(path.join(projectPath, '.planning'), { recursive: true });
+
+      const projectId = Buffer.from(projectPath).toString('base64url');
+      const mockConfig = createMockGlobalConfig([tempDir]);
+      const mockScanner = createMockProjectScanner([
+        { name: 'capture-project', path: projectPath, hasTlc: true, hasPlanning: true },
+      ]);
+      const router = createWorkspaceRouter({
+        globalConfig: mockConfig,
+        projectScanner: mockScanner,
+        memoryApi: {},
+        memoryDeps: {},
+      });
+
+      const handler = getHandler(router, 'POST', '/projects/:projectId/memory/capture');
+      const { req, res } = createMockReqRes('POST', `/projects/${projectId}/memory/capture`, {}, { projectId });
+      await handler(req, res);
+
+      expect(res.statusCode).toBe(400);
+    });
+
+    it('accepts exchanges and returns captured count', async () => {
+      const projectPath = path.join(tempDir, 'capture-ok');
+      fs.mkdirSync(projectPath, { recursive: true });
+      fs.writeFileSync(path.join(projectPath, '.tlc.json'), '{}');
+      fs.mkdirSync(path.join(projectPath, '.planning'), { recursive: true });
+
+      const projectId = Buffer.from(projectPath).toString('base64url');
+      const mockConfig = createMockGlobalConfig([tempDir]);
+      const mockScanner = createMockProjectScanner([
+        { name: 'capture-ok', path: projectPath, hasTlc: true, hasPlanning: true },
+      ]);
+
+      const observerCalls = [];
+      const mockMemoryDeps = {
+        observeAndRemember: async (root, exchange) => { observerCalls.push({ root, exchange }); },
+        vectorIndexer: null,
+      };
+      const router = createWorkspaceRouter({
+        globalConfig: mockConfig,
+        projectScanner: mockScanner,
+        memoryApi: {},
+        memoryDeps: mockMemoryDeps,
+      });
+
+      const handler = getHandler(router, 'POST', '/projects/:projectId/memory/capture');
+      const exchanges = [
+        { user: 'what is TLC?', assistant: 'TLC is a test-led coding tool' },
+        { user: 'how do I use it?', assistant: 'Run /tlc to start' },
+      ];
+      const { req, res } = createMockReqRes('POST', `/projects/${projectId}/memory/capture`, { exchanges }, { projectId });
+      await handler(req, res);
+
+      expect(res.statusCode).toBe(200);
+      expect(res._json.captured).toBe(2);
+    });
+  });
+
+  // =========================================================================
+  // Phase 79 — Task 6: Memory search endpoint
+  // =========================================================================
+  describe('GET /projects/:projectId/memory/search', () => {
+    it('returns 404 for unknown project', async () => {
+      const mockConfig = createMockGlobalConfig([tempDir]);
+      const mockScanner = createMockProjectScanner([]);
+      const router = createWorkspaceRouter({
+        globalConfig: mockConfig,
+        projectScanner: mockScanner,
+        memoryApi: {},
+        memoryDeps: {},
+      });
+
+      const handler = getHandler(router, 'GET', '/projects/:projectId/memory/search');
+      expect(handler).not.toBeNull();
+
+      const fakeId = Buffer.from('/nonexistent').toString('base64url');
+      const { req, res } = createMockReqRes('GET', `/projects/${fakeId}/memory/search`, {}, { projectId: fakeId }, { q: 'test' });
+      await handler(req, res);
+
+      expect(res.statusCode).toBe(404);
+    });
+
+    it('returns 400 for missing query parameter', async () => {
+      const projectPath = path.join(tempDir, 'search-project');
+      fs.mkdirSync(projectPath, { recursive: true });
+      fs.writeFileSync(path.join(projectPath, '.tlc.json'), '{}');
+      fs.mkdirSync(path.join(projectPath, '.planning'), { recursive: true });
+
+      const projectId = Buffer.from(projectPath).toString('base64url');
+      const mockConfig = createMockGlobalConfig([tempDir]);
+      const mockScanner = createMockProjectScanner([
+        { name: 'search-project', path: projectPath, hasTlc: true, hasPlanning: true },
+      ]);
+      const router = createWorkspaceRouter({
+        globalConfig: mockConfig,
+        projectScanner: mockScanner,
+        memoryApi: {},
+        memoryDeps: {},
+      });
+
+      const handler = getHandler(router, 'GET', '/projects/:projectId/memory/search');
+      const { req, res } = createMockReqRes('GET', `/projects/${projectId}/memory/search`, {}, { projectId }, {});
+      await handler(req, res);
+
+      expect(res.statusCode).toBe(400);
+    });
+
+    it('returns search results with source indicator using semantic recall', async () => {
+      const projectPath = path.join(tempDir, 'search-ok');
+      fs.mkdirSync(projectPath, { recursive: true });
+      fs.writeFileSync(path.join(projectPath, '.tlc.json'), '{}');
+      fs.mkdirSync(path.join(projectPath, '.planning'), { recursive: true });
+
+      const projectId = Buffer.from(projectPath).toString('base64url');
+      const mockConfig = createMockGlobalConfig([tempDir]);
+      const mockScanner = createMockProjectScanner([
+        { name: 'search-ok', path: projectPath, hasTlc: true, hasPlanning: true },
+      ]);
+
+      const mockMemoryDeps = {
+        semanticRecall: {
+          recall: async (query) => [{ text: 'remembered item', score: 0.92, type: 'decision' }],
+        },
+      };
+      const router = createWorkspaceRouter({
+        globalConfig: mockConfig,
+        projectScanner: mockScanner,
+        memoryApi: {},
+        memoryDeps: mockMemoryDeps,
+      });
+
+      const handler = getHandler(router, 'GET', '/projects/:projectId/memory/search');
+      const { req, res } = createMockReqRes('GET', `/projects/${projectId}/memory/search`, {}, { projectId }, { q: 'remembered' });
+      await handler(req, res);
+
+      expect(res.statusCode).toBe(200);
+      expect(res._json.results).toBeInstanceOf(Array);
+      expect(res._json.source).toBe('vector');
+    });
+
+    it('falls back to file-based search when semantic recall unavailable', async () => {
+      const projectPath = path.join(tempDir, 'search-fallback');
+      fs.mkdirSync(projectPath, { recursive: true });
+      fs.writeFileSync(path.join(projectPath, '.tlc.json'), '{}');
+      fs.mkdirSync(path.join(projectPath, '.planning'), { recursive: true });
+      // Create a memory file for file-based search to find
+      fs.mkdirSync(path.join(projectPath, '.planning', 'memory'), { recursive: true });
+
+      const projectId = Buffer.from(projectPath).toString('base64url');
+      const mockConfig = createMockGlobalConfig([tempDir]);
+      const mockScanner = createMockProjectScanner([
+        { name: 'search-fallback', path: projectPath, hasTlc: true, hasPlanning: true },
+      ]);
+
+      // No semanticRecall provided — should fall back to file-based
+      const router = createWorkspaceRouter({
+        globalConfig: mockConfig,
+        projectScanner: mockScanner,
+        memoryApi: {},
+        memoryDeps: {},
+      });
+
+      const handler = getHandler(router, 'GET', '/projects/:projectId/memory/search');
+      const { req, res } = createMockReqRes('GET', `/projects/${projectId}/memory/search`, {}, { projectId }, { q: 'something' });
+      await handler(req, res);
+
+      expect(res.statusCode).toBe(200);
+      expect(res._json.results).toBeInstanceOf(Array);
+      expect(res._json.source).toBe('file');
+    });
+
+    it('returns empty results when no matches found', async () => {
+      const projectPath = path.join(tempDir, 'search-empty');
+      fs.mkdirSync(projectPath, { recursive: true });
+      fs.writeFileSync(path.join(projectPath, '.tlc.json'), '{}');
+      fs.mkdirSync(path.join(projectPath, '.planning'), { recursive: true });
+
+      const projectId = Buffer.from(projectPath).toString('base64url');
+      const mockConfig = createMockGlobalConfig([tempDir]);
+      const mockScanner = createMockProjectScanner([
+        { name: 'search-empty', path: projectPath, hasTlc: true, hasPlanning: true },
+      ]);
+
+      const mockMemoryDeps = {
+        semanticRecall: {
+          recall: async () => [],
+        },
+      };
+      const router = createWorkspaceRouter({
+        globalConfig: mockConfig,
+        projectScanner: mockScanner,
+        memoryApi: {},
+        memoryDeps: mockMemoryDeps,
+      });
+
+      const handler = getHandler(router, 'GET', '/projects/:projectId/memory/search');
+      const { req, res } = createMockReqRes('GET', `/projects/${projectId}/memory/search`, {}, { projectId }, { q: 'nonexistent' });
+      await handler(req, res);
+
+      expect(res.statusCode).toBe(200);
+      expect(res._json.results).toEqual([]);
+    });
+  });
 });