tjs-lang 0.7.6 → 0.7.8

package/src/lang/emitters/js-tests.ts

@@ -657,6 +657,12 @@ export function runAllTests(
   // Build mock setup
   const mockSetup = mocks.map((m) => m.body).join('\n')
 
+  // Test bodies may reference Is/IsNot/Eq/NotEq/TypeOf — these come from the
+  // == / != / typeof source-level transforms applied to test bodies in js.ts.
+  // The module's own destructuring may not include them (if the module never
+  // uses ==), so each test block re-destructures into its own block scope.
+  const testRuntimeImports = `const { Is, IsNot, Eq, NotEq, TypeOf } = globalThis.__tjs ?? {};`
+
   // Build test execution code that runs all tests in sequence
   const testBodies = tests
     .map((t, i) => {
@@ -668,6 +674,7 @@ export function runAllTests(
       return `
     // Test ${i}: ${t.description}
     try {
+      ${testRuntimeImports}
       ${body}
       __testResults.push({ idx: ${i}, passed: true });
     } catch (e) {
@@ -869,6 +876,13 @@ export function runAllTests(
     // skip tests gracefully rather than marking them as failures
     const isUnresolvedRef = hasUnresolvedImports && e instanceof ReferenceError
 
+    // The error came from module-level code (e.g. an undefined identifier
+    // in `console.log(... x ...)`), NOT from the function/test under test.
+    // Don't attribute a line — otherwise the editor would mark the function
+    // declaration's line as the error site, misleading the user about where
+    // the actual problem is. The test still appears as failed in the test
+    // list with the explanatory message; the user finds the real error
+    // through the runtime console.
     for (const test of tests) {
       results.push({
         description: test.description,
@@ -876,7 +890,6 @@ export function runAllTests(
         error: isUnresolvedRef
           ? undefined
           : `Module execution failed: ${e.message}`,
-        line: test.line,
       })
     }
     for (const info of syncSigTestInfos) {
@@ -890,7 +903,6 @@ export function runAllTests(
           ? undefined
           : `Module execution failed: ${e.message}`,
         isSignatureTest: true,
-        line: info.line,
       })
     }
   }
@@ -942,7 +954,7 @@ function runTestBlocks(
       const tjsStub = `
         const __saved_tjs = globalThis.__tjs;
         class __MonadicError extends Error { constructor(m,p,e,a,c){super(m);this.name='MonadicError';this.path=p;this.expected=e;this.actual=a;this.callStack=c;} }
-        const __stub_tjs = { version: '0.0.0', MonadicError: __MonadicError, pushStack: () => {}, popStack: () => {}, getStack: () => [], typeError: (path, expected, value) => new __MonadicError(\`Type error at \${path}: expected \${expected}\`, path, expected, typeof value), createRuntime: function() { return this; } };
+        const __stub_tjs = { version: '0.0.0', MonadicError: __MonadicError, pushStack: () => {}, popStack: () => {}, getStack: () => [], typeError: (path, expected, value) => new __MonadicError(\`Type error at \${path}: expected \${expected}\`, path, expected, typeof value), toBool: (v) => (v instanceof Boolean || v instanceof Number || v instanceof String) ? Boolean(v.valueOf()) : Boolean(v), createRuntime: function() { return this; } };
         globalThis.__tjs = __stub_tjs;
       `
       const tjsRestore = `globalThis.__tjs = __saved_tjs;`
@@ -1301,7 +1313,7 @@ function runSignatureTest(
     const tjsStub = `
       const __saved_tjs = globalThis.__tjs;
       class __MonadicError extends Error { constructor(m,p,e,a,c){super(m);this.name='MonadicError';this.path=p;this.expected=e;this.actual=a;this.callStack=c;} }
-      const __stub_tjs = { version: '0.0.0', MonadicError: __MonadicError, pushStack: () => {}, popStack: () => {}, getStack: () => [], typeError: (path, expected, value) => new __MonadicError(\`Type error at \${path}: expected \${expected}\`, path, expected, typeof value), createRuntime: function() { return this; } };
+      const __stub_tjs = { version: '0.0.0', MonadicError: __MonadicError, pushStack: () => {}, popStack: () => {}, getStack: () => [], typeError: (path, expected, value) => new __MonadicError(\`Type error at \${path}: expected \${expected}\`, path, expected, typeof value), toBool: (v) => (v instanceof Boolean || v instanceof Number || v instanceof String) ? Boolean(v.valueOf()) : Boolean(v), createRuntime: function() { return this; } };
       globalThis.__tjs = __stub_tjs;
     `
     const tjsRestore = `globalThis.__tjs = __saved_tjs;`

package/src/lang/emitters/js.ts

@@ -53,7 +53,12 @@ import {
   extractTDoc,
   preprocess,
   transformExtensionCalls,
+  stripLineComments,
 } from '../parser'
+import {
+  transformEqualityToStructural,
+  transformIsOperators,
+} from '../parser-transforms'
 import type { TypeDescriptor, ParameterDescriptor } from '../types'
 import { inferTypeFromValue, parseParameter } from '../inference'
 import { extractTests } from '../tests'
@@ -64,6 +69,10 @@ import {
 } from './js-tests'
 export { stripModuleSyntax, stripTjsPreamble } from './js-tests'
 import { generateWasmBootstrap } from './js-wasm'
+import {
+  rewriteBoolCoercion,
+  rewriteBoolCoercionInSource,
+} from '../bool-coercion'
 
 export interface TJSTranspileOptions {
   /** Filename for error messages */
@@ -414,6 +423,19 @@ function generateInlineValidationCode(
   // 2. Type checks with proper error emission
   for (const [paramName, param] of params) {
     const path = `${pathPrefix}${funcName}.${paramName}`
+
+    // For array params: if the array contains a MonadicError, propagate
+    // the first one we find instead of failing the type check with
+    // "expected array, got X". This is the "errors propagate, not
+    // accumulate" rule — a function receiving an array of values where
+    // one is an error should surface that error, not say the array's
+    // shape is wrong.
+    if (param.type.kind === 'array') {
+      lines.push(
+        `if (Array.isArray(${paramName})) { for (const __i of ${paramName}) { if (__i instanceof Error && __i.path !== undefined) return __i } }`
+      )
+    }
+
     const typeCheck = generateTypeCheckExpr(paramName, param.type)
 
     if (typeCheck) {
@@ -431,6 +453,19 @@ function generateInlineValidationCode(
         )
       }
     }
+
+    // If the param is a function with declared shape (e.g. `fn = (x: 0) => 0`),
+    // wrap it so its arguments and return value are validated on every call.
+    // Skipped when shape is unspecified or contains non-simple kinds.
+    if (param.type.kind === 'function') {
+      const shapeCheck = generateFunctionShapeCheck(paramName, param.type, path)
+      if (shapeCheck) {
+        lines.push(shapeCheck)
+        // checkFnShape returns either the function unchanged or a
+        // MonadicError. Re-check Error propagation after the assignment.
+        lines.push(`if (${paramName} instanceof Error) return ${paramName};`)
+      }
+    }
   }
 
   if (lines.length === 0) return null
@@ -576,6 +611,10 @@ export function transpileToJS(
   } = options
   const warnings: string[] = []
 
+  // Strip single-line comments early — apostrophes in comments (e.g. "don't")
+  // confuse brace matching in test extraction and other transforms
+  source = stripLineComments(source)
+
   // Extract source file annotation if present (from TS transpilation)
   const sourceFileAnnotation = extractSourceFileAnnotation(source)
   const effectiveFilename = sourceFileAnnotation || filename
@@ -600,6 +639,29 @@ export function transpileToJS(
   // Preprocess source (handles TJS syntax transformations)
   const preprocessed = preprocess(cleanSource)
 
+  // Apply the same source-level equality transforms to extracted test/mock
+  // bodies so they observe the module's TJS semantics (e.g. structural ==).
+  // Test bodies are extracted as raw text before parse(), so they would
+  // otherwise run with native JS == coercion regardless of TjsEquals mode.
+  for (const t of tests) {
+    t.body = transformIsOperators(t.body)
+    if (preprocessed.tjsModes.tjsEquals) {
+      t.body = transformEqualityToStructural(t.body)
+    }
+    if (preprocessed.tjsModes.tjsStandard) {
+      t.body = rewriteBoolCoercionInSource(t.body)
+    }
+  }
+  for (const m of mocks) {
+    m.body = transformIsOperators(m.body)
+    if (preprocessed.tjsModes.tjsEquals) {
+      m.body = transformEqualityToStructural(m.body)
+    }
+    if (preprocessed.tjsModes.tjsStandard) {
+      m.body = rewriteBoolCoercionInSource(m.body)
+    }
+  }
+
   // Build types map for all functions
   const allTypes: Record<string, TJSTypeInfo> = {}
 
@@ -645,6 +707,41 @@ export function transpileToJS(
     warnings.push(...funcWarnings)
     allTypes[funcName] = types
 
+    // Cross-reference inference: when a parameter default is a bare
+    // identifier referring to a previously-declared TJS function, use that
+    // function's signature as the parameter's type. So
+    //
+    //   function strLength(s: ''): 0 { ... }
+    //   function map(arr: [''], counter = strLength) { ... }
+    //
+    // makes `counter`'s type `(s: string) => integer` (instead of `any`),
+    // which means the checkFnShape pass-time check fires when a wrong-
+    // shape callback is passed at the call site.
+    for (const param of func.params) {
+      if (
+        param.type === 'AssignmentPattern' &&
+        param.left.type === 'Identifier' &&
+        param.right.type === 'Identifier'
+      ) {
+        const localName = param.left.name
+        const refName = (param.right as any).name as string
+        const refInfo = allTypes[refName]
+        if (refInfo && types.params[localName]) {
+          const fnParams = Object.entries(refInfo.params).map(([n, p]) => ({
+            name: n,
+            type: p.type,
+          }))
+          const fnReturns =
+            (refInfo as any).returns ?? ({ kind: 'any' } as TypeDescriptor)
+          types.params[localName].type = {
+            kind: 'function',
+            params: fnParams,
+            returns: fnReturns,
+          }
+        }
+      }
+    }
+
     // Clean up param defaults in the emitted JS.
     // After colon→equals transform, `x: false | undefined` becomes
     // `x = false | undefined` in the parsed source.
@@ -754,6 +851,18 @@ export function transpileToJS(
     }
   }
 
+  // Boolean coercion rewrite (TjsStandard). Rewrites every truthiness
+  // context (`if`, `while`, `for`, `do/while`, `!`, `&&`, `||`, `?:`,
+  // and `Boolean(x)` calls) to call `__tjs.toBool` so boxed primitives
+  // unwrap before coercion. See src/lang/bool-coercion.ts.
+  if (preprocessed.tjsModes.tjsStandard) {
+    const boolPatches = rewriteBoolCoercion(program, preprocessed.source)
+    for (const p of boolPatches) {
+      deletions.push({ start: p.start, end: p.end })
+      insertions.push({ position: p.start, text: p.newText })
+    }
+  }
+
   // Apply deletions first (reverse order to maintain offsets), then insertions.
   // Deletions strip | union suffixes from param defaults in the output JS.
   deletions.sort((a, b) => b.start - a.start)
@@ -795,6 +904,8 @@ export function transpileToJS(
   const needsEnum = /\bEnum\(/.test(code)
   const needsUnion = /\bUnion\(/.test(code)
   const needsBang = code.includes('__tjs.bang(')
+  const needsToBool = code.includes('__tjs.toBool(')
+  const needsCheckFnShape = code.includes('__tjs.checkFnShape(')
   const needsSafeEval = preprocessed.tjsModes.tjsSafeEval
 
   const needsRuntime =
@@ -811,6 +922,8 @@ export function transpileToJS(
     needsEnum ||
     needsUnion ||
     needsBang ||
+    needsToBool ||
+    needsCheckFnShape ||
     needsSafeEval
 
   if (needsRuntime) {
@@ -887,6 +1000,28 @@ export function transpileToJS(
         `function Union(d,...v){const vals=v.flat();return{description:d,check:x=>vals.includes(x),values:vals,__runtimeType:true}}`
       )
     }
+    // toBool — honest truthiness (unwraps boxed primitives)
+    if (needsToBool) {
+      inlineParts.push(
+        `function toBool(v){if(v instanceof Boolean||v instanceof Number||v instanceof String)return Boolean(v.valueOf());return Boolean(v)}`
+      )
+    }
+
+    // checkFnShape — pass-time shape check for function-typed params
+    if (needsCheckFnShape) {
+      // checkFnShape depends on MonadicError; ensure it's inlined
+      if (!needsTypeError) {
+        inlineParts.push(
+          `class MonadicError extends Error{constructor(m,p,e,a,c,r){super(m);this.name='MonadicError';this.path=p;this.expected=e;this.actual=a;this.callStack=c;this.reason=r}}`,
+          `function typeError(p,e,v,r){const a=v===null?'null':typeof v;const m=r?'Expected '+e+" for '"+p+"': "+r:'Expected '+e+" for '"+p+"', got "+a;const err=new MonadicError(m,p,e,a,undefined,r);const c=globalThis.__tjs?.getConfig?.();if(c?.logTypeErrors)console.error('[TJS TypeError] '+err.message);if(c?.throwTypeErrors)throw err;return err}`,
+          `function isMonadicError(v){return v instanceof Error&&v.name==='MonadicError'&&'path' in v}`
+        )
+      }
+      inlineParts.push(
+        `function checkFnShape(fn,expectedParams,expectedReturn,path){if(typeof fn!=='function')return fn;const meta=fn.__tjs;if(!meta||!meta.params)return fn;const entries=Object.entries(meta.params);for(let i=0;i<expectedParams.length;i++){const e=expectedParams[i];if(e==='any')continue;const a=entries[i];if(!a)continue;const ak=a[1]&&a[1].type&&a[1].type.kind;if(!ak||ak==='any')continue;if(ak!==e)return new MonadicError("Expected (...arg"+i+": "+e+", ...) for '"+path+"', but callback declares arg"+i+" as "+ak,path+"(arg"+i+")",e,ak)}if(expectedReturn!=='any'&&meta.returns){const ar=(meta.returns.type&&meta.returns.type.kind)||meta.returns.kind;if(ar&&ar!=='any'&&ar!==expectedReturn)return new MonadicError("Expected callback returning "+expectedReturn+" for '"+path+"', but callback returns "+ar,path+"(return)",expectedReturn,ar)}return fn}`
+      )
+    }
+
     // Bang access (!.) — asserted non-null member access
     if (needsBang) {
       // bang depends on typeError and isMonadicError — ensure they're inlined
@@ -921,6 +1056,11 @@ export function transpileToJS(
     if (needsFunctionPredicate) fallbackEntries.push('FunctionPredicate')
     if (needsEnum) fallbackEntries.push('Enum')
     if (needsUnion) fallbackEntries.push('Union')
+    if (needsToBool) fallbackEntries.push('toBool')
+    if (needsCheckFnShape) {
+      fallbackEntries.push('checkFnShape')
+      if (!needsTypeError) fallbackEntries.push('typeError', 'isMonadicError')
+    }
     if (needsBang) {
       fallbackEntries.push('bang')
       // Ensure typeError/isMonadicError are in fallback even if not otherwise needed
@@ -1263,13 +1403,33 @@ function generateTypeCheckExpr(
       return `${fieldPath} !== null` // nullable doesn't apply to null itself
     case 'undefined':
       return `${fieldPath} !== undefined`
-    case 'array':
-      check = `!Array.isArray(${fieldPath})`
+    case 'array': {
+      // Always require an Array. If item type is known and non-trivial,
+      // also validate every item — `arr: [0]` means "array of integers",
+      // not "any array". Without this, a function returning
+      // `[MonadicError, MonadicError]` would pass the `: [0]` return-
+      // type check (it's an array) and surface a confusing array-of-
+      // errors to the caller.
+      const itemCheck =
+        type.items && type.items.kind !== 'any'
+          ? generateTypeCheckExpr('__a', type.items)
+          : null
+      if (itemCheck) {
+        check = `(!Array.isArray(${fieldPath}) || ${fieldPath}.some(__a => ${itemCheck}))`
+      } else {
+        check = `!Array.isArray(${fieldPath})`
+      }
       break
+    }
     case 'object':
       // For nested objects, just check it's an object (deep validation is separate)
       check = `(typeof ${fieldPath} !== 'object' || ${fieldPath} === null || Array.isArray(${fieldPath}))`
       break
+    case 'function':
+      // Shape isn't validated at call time (we don't introspect arity or
+      // call the function with probes) — just check it IS callable.
+      check = `typeof ${fieldPath} !== 'function'`
+      break
     case 'union': {
       const checks = (type as any).members
         .map((m: TypeDescriptor) => generateTypeCheckExpr(fieldPath, m))
@@ -1295,6 +1455,52 @@ function generateTypeCheckExpr(
 // Alias for backward compatibility with other functions that use this
 const generateTypeCheck = generateTypeCheckExpr
 
+/** Kinds checkType can validate by string name (no RuntimeType needed). */
+const SIMPLE_KINDS = new Set([
+  'string',
+  'number',
+  'integer',
+  'non-negative-integer',
+  'boolean',
+  'function',
+  'any',
+  'undefined',
+  'null',
+  'object', // checkType handles this via typeof
+])
+
+/**
+ * Generate a `__tjs.checkFnShape(...)` call that validates a passed-in
+ * function's declared shape against the expected shape ONCE at pass time.
+ * On mismatch the param is reassigned to a MonadicError; the existing
+ * `if (param instanceof Error) return param` check above handles
+ * propagation. On match the param is unchanged. Untyped functions
+ * (no `__tjs` metadata — anonymous arrows) pass through unchanged.
+ *
+ * Returns null when the expected shape can't be represented as simple
+ * TypeSpec strings, or when there's nothing useful to check (all-`any`).
+ */
+function generateFunctionShapeCheck(
+  paramName: string,
+  type: TypeDescriptor,
+  path: string
+): string | null {
+  const fnParams = (type.params ?? []) as Array<{
+    name: string
+    type: TypeDescriptor
+  }>
+  const fnReturns = type.returns ?? { kind: 'any' as const }
+  const paramKinds = fnParams.map((p) => p.type?.kind)
+  const allSimple =
+    paramKinds.every((k) => k && SIMPLE_KINDS.has(k)) &&
+    SIMPLE_KINDS.has(fnReturns.kind)
+  const hasUsefulCheck =
+    paramKinds.some((k) => k !== 'any') || fnReturns.kind !== 'any'
+  if (!allSimple || !hasUsefulCheck) return null
+  const paramTypesJson = JSON.stringify(paramKinds)
+  return `if (typeof ${paramName} === 'function') ${paramName} = __tjs.checkFnShape(${paramName}, ${paramTypesJson}, '${fnReturns.kind}', '${path}');`
+}
+
 /**
  * Generate the complete function wrapper with inline validation
  *

package/src/lang/features.test.ts

@@ -153,6 +153,28 @@ describe('Inline Tests', () => {
     expect(result.tests[0].body).toContain('assert')
   })
 
+  it('should extract test descriptions containing other quote types', () => {
+    // Regression: previously the regex excluded all quote chars from
+    // descriptions, so `test 'has "quotes"' { }` was silently dropped.
+    const result = extractTests(`
+      test 'typeof null is "null"' {
+        assert(true)
+      }
+      test "single 'apostrophe' inside" {
+        assert(true)
+      }
+      test \`backticks with "double" and 'single'\` {
+        assert(true)
+      }
+    `)
+    expect(result.tests.length).toBe(3)
+    expect(result.tests[0].description).toBe('typeof null is "null"')
+    expect(result.tests[1].description).toBe("single 'apostrophe' inside")
+    expect(result.tests[2].description).toBe(
+      `backticks with "double" and 'single'`
+    )
+  })
+
   it('should remove tests from output code', () => {
     const result = extractTests(`
       function add(a, b) { return a + b }

package/src/lang/inference.ts

@@ -137,6 +137,31 @@ export function inferTypeFromValue(node: Expression): TypeDescriptor {
       return { kind: 'any' }
     }
 
+    case 'ArrowFunctionExpression':
+    case 'FunctionExpression': {
+      // Function example value (e.g. `fn = (x) => x` or `cb = function() {}`).
+      // Capture parameter names + types and (for concise arrow bodies)
+      // infer the return type from the body expression.
+      const fn = node as any
+      const params: Array<{ name: string; type: TypeDescriptor }> =
+        fn.params.map((p: any) => paramShape(p))
+
+      // Concise arrow body: body IS the return expression, so we can
+      // infer its type. Block bodies (function expressions, multi-line
+      // arrows) stay `any` — scanning return statements is a separate
+      // can of worms.
+      let returns: TypeDescriptor = { kind: 'any' }
+      if (
+        fn.type === 'ArrowFunctionExpression' &&
+        fn.body &&
+        fn.body.type !== 'BlockStatement'
+      ) {
+        returns = inferTypeFromValue(fn.body)
+      }
+
+      return { kind: 'function', params, returns }
+    }
+
     case 'UnaryExpression': {
       const op = (node as any).operator
       const arg = (node as any).argument
@@ -168,6 +193,35 @@ export function inferTypeFromValue(node: Expression): TypeDescriptor {
   }
 }
 
+/**
+ * Extract a function-parameter shape from a Pattern AST node. Used when
+ * we encounter a function/arrow EXAMPLE value and want to record what
+ * its declared parameters look like for documentation and .d.ts emit.
+ *
+ * Plain identifier (`x`)              → { name: 'x', type: any }
+ * Default value (`x = 0`)             → { name: 'x', type: integer }
+ * Rest (`...args`)                    → { name: '...args', type: array }
+ * Destructuring (`{a}`, `[x]`)        → name: '?', type: any (we'd need
+ *                                       to mirror parseParameter to do
+ *                                       this properly; not worth the
+ *                                       complexity for example values)
+ */
+function paramShape(p: any): { name: string; type: TypeDescriptor } {
+  if (p.type === 'Identifier') {
+    return { name: p.name, type: { kind: 'any' } }
+  }
+  if (p.type === 'AssignmentPattern' && p.left?.type === 'Identifier') {
+    return { name: p.left.name, type: inferTypeFromValue(p.right) }
+  }
+  if (p.type === 'RestElement' && p.argument?.type === 'Identifier') {
+    return {
+      name: `...${p.argument.name}`,
+      type: { kind: 'array', items: { kind: 'any' } },
+    }
+  }
+  return { name: '?', type: { kind: 'any' } }
+}
+
 /**
  * Parse a parameter and extract its type and default value
  *

package/src/lang/linter.test.ts

@@ -3,7 +3,7 @@
  */
 
 import { describe, it, expect } from 'bun:test'
-import { lint } from './linter'
+import { lint, type LintDiagnostic } from './linter'
 
 describe('TJS Linter', () => {
   describe('no-explicit-new rule', () => {
@@ -145,4 +145,107 @@ describe('TJS Linter', () => {
       expect(result.diagnostics[0].rule).toBe('parse-error')
     })
   })
+
+  describe('safe-assign rule (TjsSafeAssign)', () => {
+    const onlySafeAssign = (result: { diagnostics: LintDiagnostic[] }) =>
+      result.diagnostics.filter((d) => d.rule.startsWith('safe-assign'))
+
+    it('flags `let x` with no initializer or annotation', () => {
+      const result = lint(`function f() { let x; return x }`)
+      const diags = onlySafeAssign(result)
+      expect(diags.length).toBe(1)
+      expect(diags[0].rule).toBe('safe-assign-let-needs-type')
+      expect(diags[0].severity).toBe('warning')
+      expect(diags[0].message).toContain("'let x'")
+    })
+
+    it('flags `let x = undefined` with no annotation', () => {
+      const result = lint(`function f() { let x = undefined; return x }`)
+      const diags = onlySafeAssign(result)
+      expect(diags.length).toBe(1)
+      expect(diags[0].rule).toBe('safe-assign-let-needs-type')
+      expect(diags[0].message).toContain('undefined')
+    })
+
+    it('flags `let x = null` with no annotation', () => {
+      const result = lint(`function f() { let x = null; return x }`)
+      const diags = onlySafeAssign(result)
+      expect(diags.length).toBe(1)
+      expect(diags[0].rule).toBe('safe-assign-let-needs-type')
+    })
+
+    it('flags `let x = void 0` with no annotation', () => {
+      const result = lint(`function f() { let x = void 0; return x }`)
+      const diags = onlySafeAssign(result)
+      expect(diags.length).toBe(1)
+      expect(diags[0].rule).toBe('safe-assign-let-needs-type')
+    })
+
+    it('accepts `let x = 0` (inferable initializer)', () => {
+      const result = lint(`function f() { let x = 0; return x }`)
+      expect(onlySafeAssign(result).length).toBe(0)
+    })
+
+    it("accepts `let x: ''` (annotation, no init)", () => {
+      const result = lint(`function f() { let x: ''; return x }`)
+      expect(onlySafeAssign(result).length).toBe(0)
+    })
+
+    it("accepts `let x: '' = 'hi'` (annotation + init)", () => {
+      const result = lint(`function f() { let x: '' = 'hi'; return x }`)
+      expect(onlySafeAssign(result).length).toBe(0)
+    })
+
+    it('flags `x = undefined` reassignment to a typed let', () => {
+      const result = lint(
+        `function f() { let x = 'hi'; x = undefined; return x }`
+      )
+      const diags = onlySafeAssign(result)
+      expect(diags.length).toBe(1)
+      expect(diags[0].rule).toBe('safe-assign-no-nullish')
+      expect(diags[0].message).toContain("'x'")
+    })
+
+    it('flags `x = null` reassignment to an annotated let', () => {
+      const result = lint(`function f() { let x: 0; x = null; return x }`)
+      const diags = onlySafeAssign(result)
+      expect(diags.length).toBe(1)
+      expect(diags[0].rule).toBe('safe-assign-no-nullish')
+    })
+
+    it('does not flag `x = "hi"` reassignment', () => {
+      const result = lint(`function f() { let x = 'a'; x = 'b'; return x }`)
+      expect(onlySafeAssign(result).length).toBe(0)
+    })
+
+    it('does not run rule under TjsCompat directive', () => {
+      const result = lint(`
+        TjsCompat
+        function f() { let x; return x }
+      `)
+      expect(onlySafeAssign(result).length).toBe(0)
+    })
+
+    it('emits errors (not warnings) under strict option', () => {
+      const result = lint(`function f() { let x; return x }`, {
+        strict: true,
+      })
+      const diags = onlySafeAssign(result)
+      expect(diags.length).toBe(1)
+      expect(diags[0].severity).toBe('error')
+      expect(result.valid).toBe(false)
+    })
+
+    it('safeAssign: false option disables the rule even in native TJS', () => {
+      const result = lint(`function f() { let x; return x }`, {
+        safeAssign: false,
+      })
+      expect(onlySafeAssign(result).length).toBe(0)
+    })
+
+    it('does not flag const declarations', () => {
+      const result = lint(`function f() { const x = 0; return x }`)
+      expect(onlySafeAssign(result).length).toBe(0)
+    })
+  })
 })