titan-agent 6.2.1 → 6.2.2

package/dist/gateway/routes/update.js

@@ -0,0 +1,100 @@
+#!/usr/bin/env node
+import { exec as nodeExec } from "child_process";
+import nodeFs from "fs";
+import { join } from "path";
+import { Router } from "express";
+import logger from "../../utils/logger.js";
+import { getUpdateInfo as defaultGetUpdateInfo } from "../../utils/updater.js";
+const COMPONENT = "update-route";
+const RESTART_DELAY_MS = 1e3;
+const EXPECTED_DOWN_MS = 2500;
+function detectUpdateMode(cwd, existsSyncFn) {
+  if (existsSyncFn(join(cwd, ".git"))) return "dev-git";
+  if (existsSyncFn("/run/systemd/system") || existsSyncFn(join(cwd, ".systemd-service"))) {
+    return "systemd";
+  }
+  return "npm-global";
+}
+function createUpdateRouter(deps = {}) {
+  const router = Router();
+  const killSelf = deps.killSelf ?? (() => process.kill(process.pid, "SIGTERM"));
+  const existsSyncFn = deps.existsSyncFn ?? nodeFs.existsSync;
+  const execFn = deps.execFn ?? nodeExec;
+  const getUpdateInfoFn = deps.getUpdateInfoFn ?? defaultGetUpdateInfo;
+  const cwdFn = deps.cwdFn ?? (() => process.cwd());
+  const envFn = deps.envFn ?? ((key) => process.env[key]);
+  router.get("/update", async (_req, res) => {
+    const info = await getUpdateInfoFn();
+    const mode = detectUpdateMode(cwdFn(), existsSyncFn);
+    res.json({ ...info, mode });
+  });
+  router.post("/update", (req, res) => {
+    const restart = req.body?.restart === true;
+    const mode = detectUpdateMode(cwdFn(), existsSyncFn);
+    const serviceName = envFn("TITAN_SERVICE_NAME") || "titan";
+    let command = null;
+    if (mode === "dev-git") command = "git pull && npm run build";
+    else if (mode === "npm-global") command = "npm update -g titan-agent";
+    logger.info(
+      COMPONENT,
+      `Update requested: mode=${mode} restart=${restart} service=${serviceName} command=${command ?? "(none, restart-only)"}`
+    );
+    const scheduleRestart = () => {
+      setTimeout(() => {
+        logger.info(COMPONENT, `Sending SIGTERM to self (pid=${process.pid}) for restart`);
+        try {
+          killSelf();
+        } catch (err) {
+          logger.error(COMPONENT, `SIGTERM failed: ${err.message}`);
+        }
+      }, RESTART_DELAY_MS);
+    };
+    if (command === null) {
+      const result = {
+        ok: true,
+        mode,
+        willRestart: restart,
+        expectedDownMs: restart ? EXPECTED_DOWN_MS : void 0,
+        message: restart ? `Restarting ${serviceName}. systemd will revive the process on the on-disk files.` : 'No-op: no command to run for systemd mode. Pass {"restart": true} to reload the process.'
+      };
+      res.json(result);
+      if (restart) scheduleRestart();
+      return;
+    }
+    execFn(command, { timeout: 18e4 }, (error, stdout) => {
+      if (error) {
+        logger.error(COMPONENT, `Update command failed (${mode}): ${error.message}`);
+        if (!res.headersSent) {
+          const result = {
+            ok: false,
+            mode,
+            willRestart: false,
+            error: error.message,
+            output: stdout?.slice(-500)
+          };
+          res.json(result);
+        }
+        return;
+      }
+      logger.info(COMPONENT, `Update command succeeded (${mode})`);
+      if (!res.headersSent) {
+        const result = {
+          ok: true,
+          mode,
+          willRestart: restart,
+          expectedDownMs: restart ? EXPECTED_DOWN_MS : void 0,
+          message: restart ? "Update complete. Restarting." : "Update complete.",
+          output: stdout?.slice(-500)
+        };
+        res.json(result);
+      }
+      if (restart) scheduleRestart();
+    });
+  });
+  return router;
+}
+export {
+  createUpdateRouter,
+  detectUpdateMode
+};
+//# sourceMappingURL=update.js.map

package/dist/gateway/routes/update.js.map

@@ -0,0 +1 @@
+{"version":3,"sources":["../../../src/gateway/routes/update.ts"],"sourcesContent":["/**\n * Tests live in tests/gateway/updateRoute.test.ts. Keep DI seams intact so\n * those tests can mock killSelf/existsSyncFn/execFn/getUpdateInfoFn without\n * touching real disk, real npm, or real process signals.\n *\n * /api/update route — extracted from server.ts during the update-button fix.\n *\n * Why this exists as its own module:\n *   The inline POST /api/update handler in server.ts had four shipping bugs\n *   that broke the in-app \"Update to vX.Y.Z\" button for systemd installs\n *   (which is how Tony's box and the docs both deploy TITAN):\n *\n *     1. Hard-coded `sudo systemctl restart titan-gateway` — the real\n *        service name is `titan` everywhere we ship.\n *     2. Required passwordless sudo from the service user (`dj`), which\n *        is not configured by default → the detached restart script hung\n *        on the password prompt forever and the service stayed dead.\n *     3. Assumed `/opt/TITAN` is a git working tree and ran `git pull` in\n *        it. `/opt/TITAN` is an rsync target per the deploy procedure, not\n *        a git checkout, so this either errored or no-op'd silently.\n *     4. Returned `{ok: true}` to the UI before the restart actually ran,\n *        so users saw \"Update completed\" while the service was dying.\n *\n * The fix:\n *   - For systemd installs: send SIGTERM to ourselves and let\n *     `Restart=always` revive the process on whatever files are on disk.\n *     This is exactly the manual recovery path we already use; the button\n *     just automates it. No sudo, no service-name guessing, no fragile\n *     detached scripts.\n *   - For git-checkout dev installs: still run `git pull && npm run build`\n *     first, then SIGTERM-to-self (if Restart=always is wired) or spawn\n *     a fresh node child (if not).\n *   - For global-npm installs (no systemd, no .git): keep the existing\n *     `npm update -g titan-agent` path — works for users on nvm/volta/fnm.\n *     Users who installed with `sudo npm i -g` will still need to update\n *     from a terminal; that's outside the scope of an in-app button.\n *   - Always return an honest `{ok, willRestart, expectedDownMs, mode}`\n *     shape so the UI can show a real \"Reconnecting…\" state instead of\n *     a fake \"Update completed\" toast.\n */\nimport { exec as nodeExec, type ExecException } from 'child_process';\nimport nodeFs from 'fs';\nimport { join } from 'path';\nimport { Router } from 'express';\nimport logger from '../../utils/logger.js';\nimport { getUpdateInfo as defaultGetUpdateInfo } from '../../utils/updater.js';\n\nconst COMPONENT = 'update-route';\n\nexport type UpdateMode = 'dev-git' | 'systemd' | 'npm-global';\n\n/**\n * Returned from POST /api/update. Older clients that only check `ok` keep\n * working; newer clients (StatusBar, TitanCanvas) can read `willRestart`\n * and `expectedDownMs` to drive a reconnect UX.\n */\nexport interface UpdateActionResult {\n    ok: boolean;\n    mode: UpdateMode;\n    willRestart: boolean;\n    expectedDownMs?: number;\n    message?: string;\n    output?: string;\n    error?: string;\n}\n\nexport interface UpdateRouterDeps {\n    /** Override SIGTERM target for tests. Default: send SIGTERM to current pid. */\n    killSelf?: () => void;\n    /** fs.existsSync override for tests. */\n    existsSyncFn?: (path: string) => boolean;\n    /** child_process.exec override for tests. */\n    execFn?: typeof nodeExec;\n    /** getUpdateInfo override for tests. */\n    getUpdateInfoFn?: typeof defaultGetUpdateInfo;\n    /** Override process.cwd() for tests. */\n    cwdFn?: () => string;\n    /** Override env lookup for tests. */\n    envFn?: (key: string) => string | undefined;\n}\n\nconst RESTART_DELAY_MS = 1000;\nconst EXPECTED_DOWN_MS = 2500; // Conservative: systemd Restart=always usually revives within ~1s.\n\n/**\n * Decide which update path applies based on what's on disk.\n *\n * Order matters:\n *   1. `.git/` at cwd → developer checkout, do the full git-pull+build path.\n *      We check this first because a dev who happens to be on a systemd box\n *      (rare but real) should still get build behavior, not a blind restart.\n *   2. `/run/systemd/system` exists or `.systemd-service` marker at cwd →\n *      production systemd install. Restart-only path; operator handles\n *      file deployment via rsync/ansible/docker.\n *   3. Otherwise → global npm install. `npm update -g`.\n */\nexport function detectUpdateMode(\n    cwd: string,\n    existsSyncFn: (p: string) => boolean,\n): UpdateMode {\n    if (existsSyncFn(join(cwd, '.git'))) return 'dev-git';\n    if (existsSyncFn('/run/systemd/system') || existsSyncFn(join(cwd, '.systemd-service'))) {\n        return 'systemd';\n    }\n    return 'npm-global';\n}\n\nexport function createUpdateRouter(deps: UpdateRouterDeps = {}): Router {\n    const router = Router();\n    const killSelf = deps.killSelf ?? (() => process.kill(process.pid, 'SIGTERM'));\n    const existsSyncFn = deps.existsSyncFn ?? nodeFs.existsSync;\n    const execFn = deps.execFn ?? nodeExec;\n    const getUpdateInfoFn = deps.getUpdateInfoFn ?? defaultGetUpdateInfo;\n    const cwdFn = deps.cwdFn ?? (() => process.cwd());\n    const envFn = deps.envFn ?? ((key: string) => process.env[key]);\n\n    router.get('/update', async (_req, res) => {\n        const info = await getUpdateInfoFn();\n        const mode = detectUpdateMode(cwdFn(), existsSyncFn);\n        res.json({ ...info, mode });\n    });\n\n    router.post('/update', (req, res) => {\n        const restart = req.body?.restart === true;\n        const mode = detectUpdateMode(cwdFn(), existsSyncFn);\n        const serviceName = envFn('TITAN_SERVICE_NAME') || 'titan';\n\n        // Commands per mode.\n        // Systemd: nothing to fetch — files are deployed externally (rsync/ansible/docker).\n        //          The button's only job is to reload the running process into them.\n        // Dev-git: pull + build, then restart so the new dist/ is loaded.\n        // npm-global: shell out to npm; if the user is on nvm/volta/fnm this works\n        //          without sudo. If they did `sudo npm i -g`, npm will EACCES and we\n        //          surface the error honestly instead of pretending.\n        let command: string | null = null;\n        if (mode === 'dev-git') command = 'git pull && npm run build';\n        else if (mode === 'npm-global') command = 'npm update -g titan-agent';\n        // mode === 'systemd' → command stays null, we skip exec entirely\n\n        logger.info(\n            COMPONENT,\n            `Update requested: mode=${mode} restart=${restart} service=${serviceName} command=${command ?? '(none, restart-only)'}`,\n        );\n\n        const scheduleRestart = (): void => {\n            // setTimeout-then-SIGTERM. With systemd Restart=always (verified on Titan PC)\n            // this gives the HTTP response time to flush before we tear the process down.\n            setTimeout(() => {\n                logger.info(COMPONENT, `Sending SIGTERM to self (pid=${process.pid}) for restart`);\n                try {\n                    killSelf();\n                } catch (err) {\n                    logger.error(COMPONENT, `SIGTERM failed: ${(err as Error).message}`);\n                }\n            }, RESTART_DELAY_MS);\n        };\n\n        if (command === null) {\n            // Pure-restart path. systemd will revive us.\n            const result: UpdateActionResult = {\n                ok: true,\n                mode,\n                willRestart: restart,\n                expectedDownMs: restart ? EXPECTED_DOWN_MS : undefined,\n                message: restart\n                    ? `Restarting ${serviceName}. systemd will revive the process on the on-disk files.`\n                    : 'No-op: no command to run for systemd mode. Pass {\"restart\": true} to reload the process.',\n            };\n            res.json(result);\n            if (restart) scheduleRestart();\n            return;\n        }\n\n        // dev-git or npm-global path: run command, then optionally restart.\n        execFn(command, { timeout: 180_000 }, (error: ExecException | null, stdout: string) => {\n            if (error) {\n                logger.error(COMPONENT, `Update command failed (${mode}): ${error.message}`);\n                if (!res.headersSent) {\n                    const result: UpdateActionResult = {\n                        ok: false,\n                        mode,\n                        willRestart: false,\n                        error: error.message,\n                        output: stdout?.slice(-500),\n                    };\n                    res.json(result);\n                }\n                return;\n            }\n            logger.info(COMPONENT, `Update command succeeded (${mode})`);\n            if (!res.headersSent) {\n                const result: UpdateActionResult = {\n                    ok: true,\n                    mode,\n                    willRestart: restart,\n                    expectedDownMs: restart ? EXPECTED_DOWN_MS : undefined,\n                    message: restart ? 'Update complete. Restarting.' : 'Update complete.',\n                    output: stdout?.slice(-500),\n                };\n                res.json(result);\n            }\n            if (restart) scheduleRestart();\n        });\n    });\n\n    return router;\n}\n"],"mappings":";AAwCA,SAAS,QAAQ,gBAAoC;AACrD,OAAO,YAAY;AACnB,SAAS,YAAY;AACrB,SAAS,cAAc;AACvB,OAAO,YAAY;AACnB,SAAS,iBAAiB,4BAA4B;AAEtD,MAAM,YAAY;AAkClB,MAAM,mBAAmB;AACzB,MAAM,mBAAmB;AAclB,SAAS,iBACZ,KACA,cACU;AACV,MAAI,aAAa,KAAK,KAAK,MAAM,CAAC,EAAG,QAAO;AAC5C,MAAI,aAAa,qBAAqB,KAAK,aAAa,KAAK,KAAK,kBAAkB,CAAC,GAAG;AACpF,WAAO;AAAA,EACX;AACA,SAAO;AACX;AAEO,SAAS,mBAAmB,OAAyB,CAAC,GAAW;AACpE,QAAM,SAAS,OAAO;AACtB,QAAM,WAAW,KAAK,aAAa,MAAM,QAAQ,KAAK,QAAQ,KAAK,SAAS;AAC5E,QAAM,eAAe,KAAK,gBAAgB,OAAO;AACjD,QAAM,SAAS,KAAK,UAAU;AAC9B,QAAM,kBAAkB,KAAK,mBAAmB;AAChD,QAAM,QAAQ,KAAK,UAAU,MAAM,QAAQ,IAAI;AAC/C,QAAM,QAAQ,KAAK,UAAU,CAAC,QAAgB,QAAQ,IAAI,GAAG;AAE7D,SAAO,IAAI,WAAW,OAAO,MAAM,QAAQ;AACvC,UAAM,OAAO,MAAM,gBAAgB;AACnC,UAAM,OAAO,iBAAiB,MAAM,GAAG,YAAY;AACnD,QAAI,KAAK,EAAE,GAAG,MAAM,KAAK,CAAC;AAAA,EAC9B,CAAC;AAED,SAAO,KAAK,WAAW,CAAC,KAAK,QAAQ;AACjC,UAAM,UAAU,IAAI,MAAM,YAAY;AACtC,UAAM,OAAO,iBAAiB,MAAM,GAAG,YAAY;AACnD,UAAM,cAAc,MAAM,oBAAoB,KAAK;AASnD,QAAI,UAAyB;AAC7B,QAAI,SAAS,UAAW,WAAU;AAAA,aACzB,SAAS,aAAc,WAAU;AAG1C,WAAO;AAAA,MACH;AAAA,MACA,0BAA0B,IAAI,YAAY,OAAO,YAAY,WAAW,YAAY,WAAW,sBAAsB;AAAA,IACzH;AAEA,UAAM,kBAAkB,MAAY;AAGhC,iBAAW,MAAM;AACb,eAAO,KAAK,WAAW,gCAAgC,QAAQ,GAAG,eAAe;AACjF,YAAI;AACA,mBAAS;AAAA,QACb,SAAS,KAAK;AACV,iBAAO,MAAM,WAAW,mBAAoB,IAAc,OAAO,EAAE;AAAA,QACvE;AAAA,MACJ,GAAG,gBAAgB;AAAA,IACvB;AAEA,QAAI,YAAY,MAAM;AAElB,YAAM,SAA6B;AAAA,QAC/B,IAAI;AAAA,QACJ;AAAA,QACA,aAAa;AAAA,QACb,gBAAgB,UAAU,mBAAmB;AAAA,QAC7C,SAAS,UACH,cAAc,WAAW,4DACzB;AAAA,MACV;AACA,UAAI,KAAK,MAAM;AACf,UAAI,QAAS,iBAAgB;AAC7B;AAAA,IACJ;AAGA,WAAO,SAAS,EAAE,SAAS,KAAQ,GAAG,CAAC,OAA6B,WAAmB;AACnF,UAAI,OAAO;AACP,eAAO,MAAM,WAAW,0BAA0B,IAAI,MAAM,MAAM,OAAO,EAAE;AAC3E,YAAI,CAAC,IAAI,aAAa;AAClB,gBAAM,SAA6B;AAAA,YAC/B,IAAI;AAAA,YACJ;AAAA,YACA,aAAa;AAAA,YACb,OAAO,MAAM;AAAA,YACb,QAAQ,QAAQ,MAAM,IAAI;AAAA,UAC9B;AACA,cAAI,KAAK,MAAM;AAAA,QACnB;AACA;AAAA,MACJ;AACA,aAAO,KAAK,WAAW,6BAA6B,IAAI,GAAG;AAC3D,UAAI,CAAC,IAAI,aAAa;AAClB,cAAM,SAA6B;AAAA,UAC/B,IAAI;AAAA,UACJ;AAAA,UACA,aAAa;AAAA,UACb,gBAAgB,UAAU,mBAAmB;AAAA,UAC7C,SAAS,UAAU,iCAAiC;AAAA,UACpD,QAAQ,QAAQ,MAAM,IAAI;AAAA,QAC9B;AACA,YAAI,KAAK,MAAM;AAAA,MACnB;AACA,UAAI,QAAS,iBAAgB;AAAA,IACjC,CAAC;AAAA,EACL,CAAC;AAED,SAAO;AACX;","names":[]}

package/dist/gateway/server.js

@@ -9,7 +9,6 @@ import { fileURLToPath } from "url";
 import { homedir, hostname as osHostname, cpus, loadavg, totalmem, freemem } from "os";
 import { statfs } from "fs/promises";
 import { randomBytes, timingSafeEqual } from "crypto";
-import { exec, spawn } from "child_process";
 import fs from "fs";
 import { loadConfig, updateConfig } from "../config/config.js";
 import { loadProfile, saveProfile } from "../memory/relationship.js";
@@ -42,7 +41,6 @@ import logger, { initFileLogger } from "../utils/logger.js";
 import { TITAN_VERSION, TITAN_NAME, TITAN_LOGS_DIR, TITAN_HOME } from "../utils/constants.js";
 import { getRestartStats as getRestartStatsSync } from "../utils/restartTracker.js";
 import { recordStartupAnalytics, startHeartbeatAnalytics } from "../analytics/collector.js";
-import { getUpdateInfo } from "../utils/updater.js";
 import { getMissionControlHTML } from "./dashboard.js";
 import { serializePrometheus, titanRequestsTotal, titanRequestDuration, titanErrorsTotal, titanActiveSessions, titanToolCallsTotal, titanTokensTotal, titanModelRequestsTotal } from "./metrics.js";
 import { createHardwareRouter } from "./routes/hardwareRouter.js";
@@ -88,6 +86,7 @@ import { createTestsRouter } from "./routes/tests.js";
 import { createSystemRouter } from "./routes/systemRouter.js";
 import { createVoiceRouter } from "./routes/voiceRouter.js";
 import { createTelephonyRouter } from "./routes/telephony.js";
+import { createUpdateRouter } from "./routes/update.js";
 import { createSocialRouter } from "./routes/socialRouter.js";
 import { createWatchRouter } from "./routes/watchRouter.js";
 import { setupSSEFlush } from "../utils/sseFlush.js";
@@ -2567,69 +2566,7 @@ data: ${JSON.stringify(structured)}
       // Last 20 for detail view
     });
   });
-  app.get("/api/update", async (_req, res) => {
-    const info = await getUpdateInfo();
-    res.json(info);
-  });
-  app.post("/api/update", (req, res) => {
-    const isLocalDev = fs.existsSync(join(process.cwd(), ".git"));
-    const isSystemd = fs.existsSync("/run/systemd/system") || fs.existsSync(join(process.cwd(), ".systemd-service"));
-    const restart = req.body?.restart === true;
-    let command;
-    let postCommand = null;
-    if (isLocalDev) {
-      command = "git pull && npm run build";
-      if (restart) {
-        postCommand = "restart";
-      }
-    } else if (isSystemd) {
-      command = "git pull && npm run build";
-      if (restart) {
-        postCommand = "systemctl";
-      }
-    } else {
-      command = "npm update -g titan-agent";
-    }
-    logger.info(COMPONENT, `Triggering update: ${command} (isDev=${isLocalDev}, isSystemd=${isSystemd}, restart=${restart})`);
-    exec(command, { timeout: 18e4 }, (error, stdout, _stderr) => {
-      if (error) {
-        logger.error(COMPONENT, `Update failed: ${error.message}`);
-        if (!res.headersSent) res.json({ ok: false, error: error.message });
-        return;
-      }
-      logger.info(COMPONENT, `Update completed successfully.\\n${stdout}`);
-      if (!res.headersSent) {
-        res.json({ ok: true, message: "Update completed", restarting: restart, output: stdout.slice(-500) });
-      }
-      if (restart) {
-        logger.info(COMPONENT, "Scheduling restart in 2 seconds...");
-        const cwd = process.cwd();
-        if (postCommand === "systemctl") {
-          const scriptPath = "/tmp/titan-restart.sh";
-          fs.writeFileSync(scriptPath, [
-            "#!/bin/bash",
-            "sleep 2",
-            `cd "${cwd}"`,
-            "sudo systemctl restart titan-gateway"
-          ].join("\n"), { mode: 493 });
-          spawn("bash", [scriptPath], { detached: true, stdio: "ignore" }).unref();
-        } else {
-          const scriptPath = "/tmp/titan-restart.sh";
-          fs.writeFileSync(scriptPath, [
-            "#!/bin/bash",
-            "sleep 2",
-            `cd "${cwd}"`,
-            "nohup node dist/cli/index.js gateway >> /tmp/titan-gateway.log 2>&1 &"
-          ].join("\n"), { mode: 493 });
-          spawn("bash", [scriptPath], { detached: true, stdio: "ignore" }).unref();
-        }
-        setTimeout(() => {
-          logger.info(COMPONENT, "Exiting for restart...");
-          process.exit(0);
-        }, 1e3);
-      }
-    });
-  });
+  app.use("/api", createUpdateRouter());
   app.get("/api/config", (_req, res) => {
     const cfg = loadConfig();
     res.json({