tina4-nodejs 3.13.94 → 3.13.96

package/packages/cli/src/commands/metrics.ts

@@ -15,7 +15,7 @@
  * Returns the intended process exit code (the caller exits). Splitting "compute
  * exit code" from "exit the process" keeps the handler unit-testable.
  */
-import { offenders } from "../../../core/src/metrics.js";
+import { offenders, MetricsEngineError } from "../../../core/src/metrics.js";
 
 type Flags = {
   top: number;
@@ -77,18 +77,24 @@ export function runMetrics(args: string[] = []): number {
   }
   const { top, json, path, failOn } = parsed;
 
-  const result = offenders(path, top);
-  const summary = result.summary;
-  const found = result.offenders;
-
-  if (summary.error) {
-    console.log(`  metrics error: ${summary.error}`);
-    return 2;
+  // ONE engine run. Ask for every offender and slice for display: the gate must
+  // read the FULL set, not the printed top-N, and the old second call re-ran the
+  // whole analysis (its "mtime-cached" comment stopped being true when the
+  // in-process analyzer and its cache were deleted -- ADR-0002).
+  let result;
+  try {
+    result = offenders(path, Number.MAX_SAFE_INTEGER);
+  } catch (e) {
+    if (e instanceof MetricsEngineError) {
+      console.error(`  metrics error: ${e.message}`);
+      return 2;
+    }
+    throw e;
   }
+  const summary = result.summary;
+  const allOffenders = result.offenders;
+  const found = allOffenders.slice(0, top);
 
-  // Decide exit code from the FULL offender set, not just the printed top-N.
-  // offenders()/fullAnalysis() is mtime-cached, so this reuses the same analysis.
-  const allOffenders = offenders(path, summary.total_offenders || 1).offenders;
   const severities = new Set(allOffenders.map((o) => o.severity));
   let exitCode = 0;
   if (failOn === "warn" && (severities.has("warn") || severities.has("error"))) {

package/packages/cli/src/commands/serve.ts

@@ -40,13 +40,14 @@ export async function serveProject(options: ServeOptions): Promise<void> {
   // only needs POST /__dev/api/reload to update the mtime counter for browser polling.
   // No internal file watcher.
 
-  // Graceful shutdown
-  const shutdown = () => {
-    console.log("\n  Shutting down...");
-    server.close();
-    process.exit(0);
-  };
-
-  process.on("SIGINT", shutdown);
-  process.on("SIGTERM", shutdown);
+  // Graceful shutdown is owned by startServer() (packages/core/src/server.ts),
+  // which traps SIGTERM/SIGINT, stops accepting, DRAINS in-flight requests
+  // within TINA4_SHUTDOWN_TIMEOUT, closes the database and exits 0.
+  //
+  // This function used to install its own `server.close(); process.exit(0)`.
+  // Node's docs are explicit that close() is asynchronous and "keeps existing
+  // connections", so exiting on the very next line killed every request the
+  // close was waiting to drain - measured, a request 0.6s into a 2s handler
+  // came back as "connection closed without response".
+  void server;
 }