tina4-nodejs 3.13.89 → 3.13.91

package/CLAUDE.md

@@ -1,10 +1,10 @@
-# CLAUDE.md - AI Developer Guide for tina4-nodejs (v3.13.89)
+# CLAUDE.md - AI Developer Guide for tina4-nodejs (v3.13.91)
 
 > This file helps AI assistants (Claude, Copilot, Cursor, etc.) understand and work on this codebase effectively.
 
 ## What This Project Is
 
-Tina4 for Node.js/TypeScript v3.13.89 - The Intelligent Native Application 4ramework. A convention-over-configuration structural paradigm. The developer writes TypeScript; Tina4 is invisible infrastructure.
+Tina4 for Node.js/TypeScript v3.13.91 - The Intelligent Native Application 4ramework. A convention-over-configuration structural paradigm. The developer writes TypeScript; Tina4 is invisible infrastructure.
 
 The philosophy: zero ceremony, batteries included, file system as source of truth.
 
@@ -1244,7 +1244,7 @@ When adding new features, add a corresponding `test/<feature>.test.ts` file.
 ## v3 Features Summary
 
 - **98 built-in features**, zero third-party dependencies
-- **5,916 tests** passing across 189 files (build + typecheck green)
+- **5,932 tests** passing across 190 files (build + typecheck green)
 - **Race-safe `getNextId()`** with atomic sequence table (`tina4_sequences`) for SQLite/MySQL/MSSQL; PostgreSQL auto-creates sequences
 - **Frond template engine optimizations**: pre-compiled regexes, lazy loop context (copy-on-write), filter chain caching, path split caching, inline common filters (11-15% speedup)
 - **Production server auto-detect**: `npx tina4nodejs serve --production` auto-uses cluster mode

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "tina4-nodejs",
-  "version": "3.13.89",
+  "version": "3.13.91",
   "type": "module",
   "description": "Tina4 for Node.js/TypeScript - 54 built-in features, zero dependencies",
   "keywords": [

package/packages/cli/dist/bin.js

@@ -17938,7 +17938,7 @@ function extractFunctions(source, filePath, root = ".") {
     if (funcName !== null && !NON_FUNCTION_WORDS.has(funcName)) {
       const displayName = funcName === "constructor" && currentClass ? `${currentClass}.constructor` : currentClass !== null && !isTopLevelDecl ? `${currentClass}.${funcName}` : funcName;
       const funcBody = extractFunctionBody(lines, i);
-      const funcLoc = funcBody.split("\n").length;
+      const funcLoc = Math.max(1, countLines(funcBody).loc);
       const complexity = cycloMaticComplexity(funcBody);
       const args = argsStr.split(",").map((a) => a.trim().split(":")[0].split("=")[0].replace("?", "").trim()).filter((a) => a && a !== "this");
       functions.push({
@@ -17954,6 +17954,24 @@ function extractFunctions(source, filePath, root = ".") {
       currentClass = null;
     }
   }
+  return chargeNestedComplexityToTheNestedFunction(functions);
+}
+function chargeNestedComplexityToTheNestedFunction(functions) {
+  if (functions.length < 2) return functions;
+  const lastLine = (f) => f.line + Math.max(1, f.loc) - 1;
+  const contains = (outer, inner) => inner.line > outer.line && lastLine(inner) <= lastLine(outer);
+  const raw = functions.map((f) => f.complexity);
+  functions.forEach((outer, i) => {
+    let subtract = 0;
+    functions.forEach((inner, j) => {
+      if (i === j || !contains(outer, inner)) return;
+      const nestedDeeper = functions.some(
+        (mid, k) => k !== i && k !== j && contains(outer, mid) && contains(mid, inner)
+      );
+      if (!nestedDeeper) subtract += raw[j] - 1;
+    });
+    outer.complexity = Math.max(1, raw[i] - subtract);
+  });
   return functions;
 }
 function extractFunctionBody(lines, startLine) {
@@ -38761,6 +38779,11 @@ function parseFields(fieldsStr) {
   }
   return result;
 }
+var DEFAULT_FIELDS = [["name", "string"]];
+function fieldsOrDefault(fieldsStr) {
+  const parsed = parseFields(fieldsStr);
+  return parsed.length > 0 ? parsed : DEFAULT_FIELDS.map(([f, t]) => [f, t]);
+}
 function parseCliArgs(args) {
   const booleanFlags = /* @__PURE__ */ new Set([
     "no-browser",
@@ -38876,7 +38899,7 @@ async function generate2(what, name, extraArgs = []) {
   }
 }
 function generateModel(name, flags, emitTest = true) {
-  const fields = parseFields(flags.fields || "");
+  const fields = fieldsOrDefault(flags.fields || "");
   const table2 = toTableName(name);
   const dir = resolve29("src/models");
   ensureDir(dir);
@@ -38884,13 +38907,9 @@ function generateModel(name, flags, emitTest = true) {
   const fieldLines = [
     `    id: { type: "integer" as const, primaryKey: true, autoIncrement: true },`
   ];
-  if (fields.length > 0) {
-    for (const [fname, ftype] of fields) {
-      const info = FIELD_TYPE_MAP[ftype] || FIELD_TYPE_MAP.string;
-      fieldLines.push(`    ${fname}: { type: ${info.orm} as const },`);
-    }
-  } else {
-    fieldLines.push(`    name: { type: "string" as const },`);
+  for (const [fname, ftype] of fields) {
+    const info = FIELD_TYPE_MAP[ftype] || FIELD_TYPE_MAP.string;
+    fieldLines.push(`    ${fname}: { type: ${info.orm} as const },`);
   }
   fieldLines.push(`    created_at: { type: "datetime" as const },`);
   const content = `import { BaseModel } from "tina4-nodejs/orm";
@@ -38904,7 +38923,7 @@ ${fieldLines.join("\n")}
 `;
   writeFileSafe(path8, content);
   if (!flags["no-migration"]) {
-    generateMigration(`create_${table2}`, flags, fields.length > 0 ? fields : void 0, table2, false);
+    generateMigration(`create_${table2}`, flags, fields, table2, false);
   }
   if (emitTest) emitModelTest(name, table2, fields);
 }
@@ -38975,7 +38994,12 @@ ${extend(
         "validate / business rules before persist",
         `e.g. reject invalid input; ground: tina4_context("validate before create", "nodejs")`
       )}  const item = new ${model}(req.body as Record<string, unknown>);
-  await item.save();
+  // save() returns false on failure rather than throwing - check it, or a failed
+  // write is reported to the client as a 201 carrying unsaved data.
+  if ((await item.save()) === false) {
+    res.json({ error: "Could not create ${singular}" }, 400);
+    return;
+  }
   res.json({ data: item.toObject() }, 201);
 }
 `
@@ -39055,7 +39079,12 @@ ${extend(
         "guard which fields / who may update",
         `e.g. enforce ownership; ground: tina4_context("authorize update", "nodejs")`
       )}  Object.assign(item, req.body as Record<string, unknown>);
-  await item.save();
+  // save() returns false on failure rather than throwing - check it, or a failed
+  // write is reported to the client as a 200 carrying unsaved data.
+  if ((await item.save()) === false) {
+    res.json({ error: "Could not update ${singular}" }, 400);
+    return;
+  }
   res.json({ data: item.toObject() });
 }
 `
@@ -39362,7 +39391,7 @@ void test${titleName};
   writeFileSafe(path8, content);
 }
 function generateForm(name, flags) {
-  const fields = parseFields(flags.fields || "");
+  const fields = fieldsOrDefault(flags.fields || "");
   const table2 = toTableName(name);
   const routeName = toPlural(table2);
   const inputTypes = {
@@ -39382,9 +39411,8 @@ function generateForm(name, flags) {
   const dir = resolve29("src/templates/forms");
   ensureDir(dir);
   const path8 = join33(dir, `${table2}.twig`);
-  const fieldEntries = fields.length > 0 ? fields : [["name", "string"]];
   let fieldHtml = "";
-  for (const [fname, ftype] of fieldEntries) {
+  for (const [fname, ftype] of fields) {
     const itype = inputTypes[ftype] || "text";
     const label = fname.replace(/_/g, " ").replace(/\b\w/g, (c) => c.toUpperCase());
     const step = ["float", "numeric", "decimal"].includes(ftype) ? ' step="0.01"' : "";
@@ -39428,10 +39456,10 @@ function generateForm(name, flags) {
   writeFileSafe(path8, content);
 }
 function generateView(name, flags) {
-  const fields = parseFields(flags.fields || "");
+  const fields = fieldsOrDefault(flags.fields || "");
   const table2 = toTableName(name);
   const routeName = toPlural(table2);
-  const cols = fields.length > 0 ? fields.map(([f]) => f) : ["name"];
+  const cols = fields.map(([f]) => f);
   const dir = resolve29("src/templates/pages");
   ensureDir(dir);
   const listPath = join33(dir, `${routeName}.twig`);
@@ -39946,7 +39974,7 @@ function sampleLiteral(fieldType) {
   }
 }
 function emitModelTest(model, table2, fields) {
-  const flds = fields.length > 0 ? fields : [["name", "string"]];
+  const flds = fields.length > 0 ? fields : DEFAULT_FIELDS.map(([f, t]) => [f, t]);
   const payload = flds.map(([f, t]) => `${f}: ${sampleLiteral(t)}`).join(", ");
   const stringField = flds.find(([, t]) => ["string", "str", "text"].includes((t || "string").toLowerCase()))?.[0];
   const valueAssert = stringField ? `

package/packages/cli/src/commands/generate.ts

@@ -115,6 +115,21 @@ export function parseFields(fieldsStr: string): Array<[string, string]> {
   return result;
 }
 
+// Called without --fields, the generators fall back to a single `name` string
+// column. That default MUST be materialised here, in one place, and then flow
+// into the model, the migration, the form, the view and the test alike. It used
+// to live only inside the model template, so `generate model X` / `generate
+// crud X` wrote a model declaring `name` while the migration - built from the
+// parsed field list, which was empty - created only id + created_at. The first
+// write then failed with "table x has no column named name".
+export const DEFAULT_FIELDS: ReadonlyArray<[string, string]> = [["name", "string"]];
+
+/** Parsed --fields, or the default single `name` column when none given. */
+export function fieldsOrDefault(fieldsStr: string): Array<[string, string]> {
+  const parsed = parseFields(fieldsStr);
+  return parsed.length > 0 ? parsed : DEFAULT_FIELDS.map(([f, t]) => [f, t] as [string, string]);
+}
+
 export function parseCliArgs(args: string[]): { flags: Record<string, string | boolean>; positional: string[] } {
   // Boolean-only flags that never take a value argument.
   const booleanFlags = new Set([
@@ -290,7 +305,7 @@ export async function generate(what: string, name: string, extraArgs: string[] =
 // ── Model ───────────────────────────────────────────────────────────
 
 function generateModel(name: string, flags: Record<string, string | boolean>, emitTest = true): void {
-  const fields = parseFields((flags.fields as string) || "");
+  const fields = fieldsOrDefault((flags.fields as string) || "");
   const table = toTableName(name);
   const dir = resolve("src/models");
   ensureDir(dir);
@@ -300,13 +315,9 @@ function generateModel(name: string, flags: Record<string, string | boolean>, em
   const fieldLines: string[] = [
     `    id: { type: "integer" as const, primaryKey: true, autoIncrement: true },`,
   ];
-  if (fields.length > 0) {
-    for (const [fname, ftype] of fields) {
-      const info = FIELD_TYPE_MAP[ftype] || FIELD_TYPE_MAP.string;
-      fieldLines.push(`    ${fname}: { type: ${info.orm} as const },`);
-    }
-  } else {
-    fieldLines.push(`    name: { type: "string" as const },`);
+  for (const [fname, ftype] of fields) {
+    const info = FIELD_TYPE_MAP[ftype] || FIELD_TYPE_MAP.string;
+    fieldLines.push(`    ${fname}: { type: ${info.orm} as const },`);
   }
   fieldLines.push(`    created_at: { type: "datetime" as const },`);
 
@@ -328,7 +339,11 @@ ${fieldLines.join("\n")}
   // (below) proves the schema through the real ORM, so the migration sub-call
   // does NOT also co-emit a migration test (emitTest=false).
   if (!flags["no-migration"]) {
-    generateMigration(`create_${table}`, flags, fields.length > 0 ? fields : undefined, table, false);
+    // Always hand over the RESOLVED field list. Passing `undefined` when the
+    // parsed list was empty made the migration fall back to its own
+    // parseFields() - also empty - so the table got only id + created_at while
+    // the model above declared `name`, and the first write 500'd.
+    generateMigration(`create_${table}`, flags, fields, table, false);
   }
 
   // Co-emit a real SQLite roundtrip test next to the model. Composite
@@ -417,7 +432,12 @@ ${modelImportBase}${secureOptOut(isPublic)}export const meta = { summary: "Creat
 export default async function (req: Tina4Request, res: Tina4Response) {
 ${extend("validate / business rules before persist",
   `e.g. reject invalid input; ground: tina4_context("validate before create", "nodejs")`)}  const item = new ${model}(req.body as Record<string, unknown>);
-  await item.save();
+  // save() returns false on failure rather than throwing - check it, or a failed
+  // write is reported to the client as a 201 carrying unsaved data.
+  if ((await item.save()) === false) {
+    res.json({ error: "Could not create ${singular}" }, 400);
+    return;
+  }
   res.json({ data: item.toObject() }, 201);
 }
 `,
@@ -499,7 +519,12 @@ export default async function (req: Tina4Request, res: Tina4Response) {
   }
 ${extend("guard which fields / who may update",
   `e.g. enforce ownership; ground: tina4_context("authorize update", "nodejs")`)}  Object.assign(item, req.body as Record<string, unknown>);
-  await item.save();
+  // save() returns false on failure rather than throwing - check it, or a failed
+  // write is reported to the client as a 200 carrying unsaved data.
+  if ((await item.save()) === false) {
+    res.json({ error: "Could not update ${singular}" }, 400);
+    return;
+  }
   res.json({ data: item.toObject() });
 }
 `,
@@ -873,7 +898,7 @@ void test${titleName};
 // ── Form ────────────────────────────────────────────────────────────
 
 function generateForm(name: string, flags: Record<string, string | boolean>): void {
-  const fields = parseFields((flags.fields as string) || "");
+  const fields = fieldsOrDefault((flags.fields as string) || "");
   const table = toTableName(name);
   const routeName = toPlural(table);
 
@@ -890,9 +915,8 @@ function generateForm(name: string, flags: Record<string, string | boolean>): vo
   const path = join(dir, `${table}.twig`);
 
   // Build form fields
-  const fieldEntries = fields.length > 0 ? fields : [["name", "string"] as [string, string]];
   let fieldHtml = "";
-  for (const [fname, ftype] of fieldEntries) {
+  for (const [fname, ftype] of fields) {
     const itype = inputTypes[ftype] || "text";
     const label = fname.replace(/_/g, " ").replace(/\b\w/g, (c) => c.toUpperCase());
     const step = ["float", "numeric", "decimal"].includes(ftype) ? ' step="0.01"' : "";
@@ -946,11 +970,11 @@ function generateForm(name: string, flags: Record<string, string | boolean>): vo
 // ── View ────────────────────────────────────────────────────────────
 
 function generateView(name: string, flags: Record<string, string | boolean>): void {
-  const fields = parseFields((flags.fields as string) || "");
+  const fields = fieldsOrDefault((flags.fields as string) || "");
   const table = toTableName(name);
   const routeName = toPlural(table);
 
-  const cols = fields.length > 0 ? fields.map(([f]) => f) : ["name"];
+  const cols = fields.map(([f]) => f);
 
   const dir = resolve("src/templates/pages");
   ensureDir(dir);
@@ -1591,7 +1615,9 @@ function sampleLiteral(fieldType: string): string {
 
 /** model → real SQLite roundtrip (create / read back / missing → null). */
 function emitModelTest(model: string, table: string, fields: Array<[string, string]>): void {
-  const flds = fields.length > 0 ? fields : [["name", "string"] as [string, string]];
+  // Reuse the single DEFAULT_FIELDS constant rather than re-stating the literal,
+  // so the co-emitted test can never describe a shape the model does not have.
+  const flds = fields.length > 0 ? fields : DEFAULT_FIELDS.map(([f, t]) => [f, t] as [string, string]);
   const payload = flds.map(([f, t]) => `${f}: ${sampleLiteral(t)}`).join(", ");
   const stringField = flds.find(([, t]) => ["string", "str", "text"].includes((t || "string").toLowerCase()))?.[0];
   const valueAssert = stringField

package/packages/core/dist/index.js

@@ -17937,7 +17937,7 @@ function extractFunctions(source, filePath, root = ".") {
     if (funcName !== null && !NON_FUNCTION_WORDS.has(funcName)) {
       const displayName = funcName === "constructor" && currentClass ? `${currentClass}.constructor` : currentClass !== null && !isTopLevelDecl ? `${currentClass}.${funcName}` : funcName;
       const funcBody = extractFunctionBody(lines, i);
-      const funcLoc = funcBody.split("\n").length;
+      const funcLoc = Math.max(1, countLines(funcBody).loc);
       const complexity = cycloMaticComplexity(funcBody);
       const args = argsStr.split(",").map((a) => a.trim().split(":")[0].split("=")[0].replace("?", "").trim()).filter((a) => a && a !== "this");
       functions.push({
@@ -17953,6 +17953,24 @@ function extractFunctions(source, filePath, root = ".") {
       currentClass = null;
     }
   }
+  return chargeNestedComplexityToTheNestedFunction(functions);
+}
+function chargeNestedComplexityToTheNestedFunction(functions) {
+  if (functions.length < 2) return functions;
+  const lastLine = (f) => f.line + Math.max(1, f.loc) - 1;
+  const contains = (outer, inner) => inner.line > outer.line && lastLine(inner) <= lastLine(outer);
+  const raw = functions.map((f) => f.complexity);
+  functions.forEach((outer, i) => {
+    let subtract = 0;
+    functions.forEach((inner, j) => {
+      if (i === j || !contains(outer, inner)) return;
+      const nestedDeeper = functions.some(
+        (mid, k) => k !== i && k !== j && contains(outer, mid) && contains(mid, inner)
+      );
+      if (!nestedDeeper) subtract += raw[j] - 1;
+    });
+    outer.complexity = Math.max(1, raw[i] - subtract);
+  });
   return functions;
 }
 function extractFunctionBody(lines, startLine) {