tina4-nodejs 3.13.86 → 3.13.87

package/packages/frond/dist/index.js

@@ -101,6 +101,15 @@ function liveAttr(value) {
 }
 var filterChainCache = /* @__PURE__ */ new Map();
 var pathParseCache = /* @__PURE__ */ new Map();
+var TEMPLATE_CACHE_MAX = 256;
+function capCache(cache, maxEntries) {
+  if (cache.size < maxEntries) return;
+  let drop = Math.floor(maxEntries / 2);
+  for (const key of cache.keys()) {
+    cache.delete(key);
+    if (--drop <= 0) break;
+  }
+}
 var TOKEN_RE = /(\{%-?\s*[\s\S]*?\s*-?%\})|(\{\{-?\s*[\s\S]*?\s*-?\}\})|(\{#[\s\S]*?#\})/g;
 var RAW_BLOCK_RE = /\{%-?\s*raw\s*-?%\}([\s\S]*?)\{%-?\s*endraw\s*-?%\}/g;
 function tokenize(source) {
@@ -454,6 +463,9 @@ function evalExpr(expr, context) {
       }).join("");
     }
   }
+  if (expr.startsWith("not ")) {
+    return evalComparison(expr, context);
+  }
   for (const op of [" not in ", " in ", " is not ", " is ", "!=", "==", ">=", "<=", ">", "<", " and ", " or ", " not "]) {
     if (findOutsideQuotes(expr, op) >= 0) {
       return evalComparison(expr, context);
@@ -1409,6 +1421,7 @@ var Frond = class _Frond {
     const source = readFileSync(filePath, "utf-8");
     const mtime = statSync(filePath).mtimeMs;
     const tokens = tokenize(source);
+    capCache(this.compiled, TEMPLATE_CACHE_MAX);
     this.compiled.set(template, { tokens, mtime, cachedAt: Date.now() });
     return this.executeWithSource(source, tokens, context);
   }
@@ -1423,6 +1436,7 @@ var Frond = class _Frond {
       }
     }
     const tokens = tokenize(source);
+    capCache(this.compiledStrings, TEMPLATE_CACHE_MAX);
     this.compiledStrings.set(key, { tokens, cachedAt: Date.now() });
     return this.executeCached(tokens, context);
   }
@@ -1638,6 +1652,9 @@ var Frond = class _Frond {
         } else if (tag === "macro") {
           const skip = this.handleMacro(tokens, i, context);
           i = skip;
+        } else if (tag === "import") {
+          this.handleImportAs(content, context);
+          i++;
         } else if (tag === "from") {
           this.handleFromImport(content, context);
           i++;
@@ -2204,7 +2221,7 @@ var Frond = class _Frond {
       return i2;
     }
     const macroName = m[1];
-    const paramNames = m[2].split(",").map((p) => p.trim()).filter(Boolean);
+    const params = _Frond.parseMacroParams(m[2]);
     const bodyTokens = [];
     let i = start + 1;
     while (i < tokens.length) {
@@ -2219,13 +2236,94 @@ var Frond = class _Frond {
     const capturedContext = { ...context };
     context[macroName] = (...args) => {
       const macroCtx = { ...capturedContext };
-      for (let pi = 0; pi < paramNames.length; pi++) {
-        macroCtx[paramNames[pi]] = pi < args.length ? args[pi] : null;
+      for (let pi = 0; pi < params.length; pi++) {
+        const [pname, pdefault] = params[pi];
+        macroCtx[pname] = pi < args.length ? args[pi] : pdefault;
       }
       return new SafeString(engine.renderTokens([...bodyTokens], macroCtx));
     };
     return i;
   }
+  /**
+   * Parse a macro parameter list into [name, default] pairs.
+   *
+   * Handles: name, name="default", name='default'. Splitting on "," alone left a
+   * defaulted parameter literally NAMED `greeting='Hello'`, so the body's
+   * {{ greeting }} matched nothing (rendered empty) AND the caller's positional
+   * argument was stored under that junk key and lost. Mirrors the Python master's
+   * _parse_macro_params. The default is null when none is declared.
+   */
+  static parseMacroParams(rawParams) {
+    return rawParams.split(",").map((p) => p.trim()).filter(Boolean).map((p) => {
+      const eq = p.indexOf("=");
+      if (eq === -1) return [p, null];
+      const name = p.slice(0, eq).trim();
+      let dflt = p.slice(eq + 1).trim();
+      if (dflt.length >= 2 && (dflt.startsWith('"') && dflt.endsWith('"') || dflt.startsWith("'") && dflt.endsWith("'"))) {
+        dflt = dflt.slice(1, -1);
+      }
+      return [name, dflt];
+    });
+  }
+  /**
+   * {% import "file" as alias %} -- load EVERY macro in a file under one namespace.
+   *
+   * The alias is bound as a plain object of macro functions, so {{ alias.greet(x) }}
+   * resolves through the engine's existing dotted-call path and each macro keeps the
+   * same argument binding, default handling and SafeString output as any other macro.
+   * A namespace object (not a class) is deliberate: a function stored as a class
+   * attribute binds as a method and would inject the namespace as the first argument,
+   * which is exactly the argument-shift bug the Python master carried (fixed there
+   * with types.SimpleNamespace). Both import forms must render identically.
+   */
+  handleImportAs(content, context) {
+    const m = content.match(/^import\s+["'](.+?)["']\s+as\s+(\w+)/);
+    if (!m) return;
+    const filename = m[1];
+    const alias = m[2];
+    const namespace = {};
+    const source = this.load(filename);
+    const tokens = tokenize(source);
+    let i = 0;
+    while (i < tokens.length) {
+      const [ttype, raw] = tokens[i];
+      if (ttype === "BLOCK") {
+        const [tagContent] = stripTag(raw);
+        if ((tagContent.split(/\s+/)[0] || "") === "macro") {
+          const macroM = tagContent.match(/^macro\s+(\w+)\s*\(([^)]*)\)/);
+          if (macroM) {
+            const macroName = macroM[1];
+            const params = _Frond.parseMacroParams(macroM[2]);
+            const bodyTokens = [];
+            i++;
+            while (i < tokens.length) {
+              if (tokens[i][0] === "BLOCK" && tokens[i][1].includes("endmacro")) {
+                i++;
+                break;
+              }
+              bodyTokens.push(tokens[i]);
+              i++;
+            }
+            const capturedBody = [...bodyTokens];
+            const capturedParams = [...params];
+            const capturedCtx = { ...context };
+            const engine = this;
+            namespace[macroName] = (...args) => {
+              const macroCtx = { ...capturedCtx };
+              for (let pi = 0; pi < capturedParams.length; pi++) {
+                const [pname, pdefault] = capturedParams[pi];
+                macroCtx[pname] = pi < args.length ? args[pi] : pdefault;
+              }
+              return new SafeString(engine.renderTokens([...capturedBody], macroCtx));
+            };
+            continue;
+          }
+        }
+      }
+      i++;
+    }
+    context[alias] = namespace;
+  }
   handleFromImport(content, context) {
     const m = content.match(/^from\s+["'](.+?)["']\s+import\s+(.+)/);
     if (!m) return;
@@ -2243,7 +2341,7 @@ var Frond = class _Frond {
           const macroM = tagContent.match(/^macro\s+(\w+)\s*\(([^)]*)\)/);
           if (macroM && names.includes(macroM[1])) {
             const macroName = macroM[1];
-            const paramNames = macroM[2].split(",").map((p) => p.trim()).filter(Boolean);
+            const paramNames = _Frond.parseMacroParams(macroM[2]);
             const bodyTokens = [];
             i++;
             while (i < tokens.length) {
@@ -2261,7 +2359,8 @@ var Frond = class _Frond {
             context[macroName] = (...args) => {
               const macroCtx = { ...capturedCtx };
               for (let pi = 0; pi < capturedParams.length; pi++) {
-                macroCtx[capturedParams[pi]] = pi < args.length ? args[pi] : null;
+                const [pname, pdefault] = capturedParams[pi];
+                macroCtx[pname] = pi < args.length ? args[pi] : pdefault;
               }
               return new SafeString(engine.renderTokens([...capturedBody], macroCtx));
             };

package/packages/frond/src/engine.ts

@@ -202,6 +202,40 @@ const filterChainCache = new Map<string, [string, [string, unknown[]][]]>();
 /** Cache for parsed dotted/bracket paths: expr string -> [parts, fromBracket] */
 const pathParseCache = new Map<string, [string[], boolean[]]>();
 
+/**
+ * Hard cap on the template caches — `compiled` and `compiledStrings`
+ * (ADR-0004, parity with PHP/Python/Ruby TEMPLATE_CACHE_MAX).
+ *
+ * An entry here is a whole token list, so the cap sits well below what a
+ * per-expression memo would justify. 256 is far above any real application's
+ * template count, so a normal app never evicts. The cap exists for the
+ * workload that genuinely grows without limit for the life of a worker:
+ * `renderString` keys on md5(source), so an app that builds template strings
+ * dynamically adds an entry per distinct string.
+ */
+export const TEMPLATE_CACHE_MAX = 256;
+
+/**
+ * Keep a memo cache bounded. Call immediately before inserting a new entry.
+ *
+ * Eviction is insertion-ordered (oldest first), not true LRU: a `Map`
+ * preserves insertion order, so dropping from the front is cheap, whereas
+ * refreshing recency on every cache HIT would add writes to the hottest path
+ * in a render and cost more than it saves. Half the cache is dropped at once
+ * so the sweep amortises to O(1) per insert.
+ *
+ * Evicting can never change what a render produces: every read site treats a
+ * miss as "recompute", so a swept entry is rebuilt on next use.
+ */
+function capCache(cache: Map<string, unknown>, maxEntries: number): void {
+  if (cache.size < maxEntries) return;
+  let drop = Math.floor(maxEntries / 2);
+  for (const key of cache.keys()) {
+    cache.delete(key);
+    if (--drop <= 0) break;
+  }
+}
+
 // ── Lexer ──────────────────────────────────────────────────────
 
 const TOKEN_RE = /(\{%-?\s*[\s\S]*?\s*-?%\})|(\{\{-?\s*[\s\S]*?\s*-?\}\})|(\{#[\s\S]*?#\})/g;
@@ -609,7 +643,21 @@ function evalExpr(expr: string, context: Record<string, unknown>): unknown {
     }
   }
 
-  // Check for comparison/logical operators
+  // Comparison/logical operators -> evalComparison, the SAME evaluator {% if %}
+  // uses, so a condition means the same thing in a condition and in an output
+  // expression.
+  //
+  // The LEADING unary `not` needs its own check: every operator below is matched
+  // WITH surrounding spaces, so `not x` (nothing to its left) matched none of
+  // them, fell through to the variable-resolution tail, and was looked up as a
+  // variable literally named "not x" -- found nothing, rendered EMPTY.
+  // `{% if not x %}` and `x and not y` always worked; only the standalone
+  // `{{ not x }}` was dropped, and before booleans rendered lowercase a dropped
+  // expression and `false -> ''` looked identical, which is why it survived.
+  // Fixed in 3.13.87 alongside the boolean contract.
+  if (expr.startsWith("not ")) {
+    return evalComparison(expr, context);
+  }
   for (const op of [" not in ", " in ", " is not ", " is ", "!=", "==", ">=", "<=", ">", "<", " and ", " or ", " not "]) {
     if (findOutsideQuotes(expr, op) >= 0) {
       return evalComparison(expr, context);
@@ -1685,6 +1733,7 @@ export class Frond {
     const source = readFileSync(filePath, "utf-8");
     const mtime = statSync(filePath).mtimeMs;
     const tokens = tokenize(source);
+    capCache(this.compiled as Map<string, unknown>, TEMPLATE_CACHE_MAX);
     this.compiled.set(template, { tokens, mtime, cachedAt: Date.now() });
     return this.executeWithSource(source, tokens, context);
   }
@@ -1702,6 +1751,7 @@ export class Frond {
     }
 
     const tokens = tokenize(source);
+    capCache(this.compiledStrings as Map<string, unknown>, TEMPLATE_CACHE_MAX);
     this.compiledStrings.set(key, { tokens, cachedAt: Date.now() });
     return this.executeCached(tokens, context);
   }
@@ -1977,6 +2027,9 @@ export class Frond {
         } else if (tag === "macro") {
           const skip = this.handleMacro(tokens, i, context);
           i = skip;
+        } else if (tag === "import") {
+          this.handleImportAs(content, context);
+          i++;
         } else if (tag === "from") {
           this.handleFromImport(content, context);
           i++;
@@ -2587,7 +2640,7 @@ export class Frond {
     }
 
     const macroName = m[1];
-    const paramNames = m[2].split(",").map(p => p.trim()).filter(Boolean);
+    const params = Frond.parseMacroParams(m[2]);
 
     // Collect body tokens
     const bodyTokens: Token[] = [];
@@ -2606,8 +2659,9 @@ export class Frond {
     const capturedContext = { ...context };
     context[macroName] = (...args: unknown[]) => {
       const macroCtx: Record<string, unknown> = { ...capturedContext };
-      for (let pi = 0; pi < paramNames.length; pi++) {
-        macroCtx[paramNames[pi]] = pi < args.length ? args[pi] : null;
+      for (let pi = 0; pi < params.length; pi++) {
+        const [pname, pdefault] = params[pi];
+        macroCtx[pname] = pi < args.length ? args[pi] : pdefault;
       }
       return new SafeString(engine.renderTokens([...bodyTokens], macroCtx));
     };
@@ -2615,6 +2669,104 @@ export class Frond {
     return i;
   }
 
+  /**
+   * Parse a macro parameter list into [name, default] pairs.
+   *
+   * Handles: name, name="default", name='default'. Splitting on "," alone left a
+   * defaulted parameter literally NAMED `greeting='Hello'`, so the body's
+   * {{ greeting }} matched nothing (rendered empty) AND the caller's positional
+   * argument was stored under that junk key and lost. Mirrors the Python master's
+   * _parse_macro_params. The default is null when none is declared.
+   */
+  static parseMacroParams(rawParams: string): Array<[string, string | null]> {
+    return rawParams
+      .split(",")
+      .map(p => p.trim())
+      .filter(Boolean)
+      .map(p => {
+        const eq = p.indexOf("=");
+        if (eq === -1) return [p, null] as [string, string | null];
+        const name = p.slice(0, eq).trim();
+        let dflt = p.slice(eq + 1).trim();
+        if (
+          dflt.length >= 2 &&
+          ((dflt.startsWith('"') && dflt.endsWith('"')) ||
+            (dflt.startsWith("'") && dflt.endsWith("'")))
+        ) {
+          dflt = dflt.slice(1, -1);
+        }
+        return [name, dflt] as [string, string | null];
+      });
+  }
+
+  /**
+   * {% import "file" as alias %} -- load EVERY macro in a file under one namespace.
+   *
+   * The alias is bound as a plain object of macro functions, so {{ alias.greet(x) }}
+   * resolves through the engine's existing dotted-call path and each macro keeps the
+   * same argument binding, default handling and SafeString output as any other macro.
+   * A namespace object (not a class) is deliberate: a function stored as a class
+   * attribute binds as a method and would inject the namespace as the first argument,
+   * which is exactly the argument-shift bug the Python master carried (fixed there
+   * with types.SimpleNamespace). Both import forms must render identically.
+   */
+  private handleImportAs(content: string, context: Record<string, unknown>): void {
+    const m = content.match(/^import\s+["'](.+?)["']\s+as\s+(\w+)/);
+    if (!m) return;
+
+    const filename = m[1];
+    const alias = m[2];
+    const namespace: Record<string, unknown> = {};
+
+    const source = this.load(filename);
+    const tokens = tokenize(source);
+
+    let i = 0;
+    while (i < tokens.length) {
+      const [ttype, raw] = tokens[i];
+      if (ttype === "BLOCK") {
+        const [tagContent] = stripTag(raw);
+        if ((tagContent.split(/\s+/)[0] || "") === "macro") {
+          const macroM = tagContent.match(/^macro\s+(\w+)\s*\(([^)]*)\)/);
+          if (macroM) {
+            const macroName = macroM[1];
+            const params = Frond.parseMacroParams(macroM[2]);
+
+            const bodyTokens: Token[] = [];
+            i++;
+            while (i < tokens.length) {
+              if (tokens[i][0] === "BLOCK" && tokens[i][1].includes("endmacro")) {
+                i++;
+                break;
+              }
+              bodyTokens.push(tokens[i]);
+              i++;
+            }
+
+            // Own copies per macro — avoids closure-over-loop-variable sharing.
+            const capturedBody = [...bodyTokens];
+            const capturedParams = [...params];
+            const capturedCtx = { ...context };
+            const engine = this;
+
+            namespace[macroName] = (...args: unknown[]) => {
+              const macroCtx: Record<string, unknown> = { ...capturedCtx };
+              for (let pi = 0; pi < capturedParams.length; pi++) {
+                const [pname, pdefault] = capturedParams[pi];
+                macroCtx[pname] = pi < args.length ? args[pi] : pdefault;
+              }
+              return new SafeString(engine.renderTokens([...capturedBody], macroCtx));
+            };
+            continue;
+          }
+        }
+      }
+      i++;
+    }
+
+    context[alias] = namespace;
+  }
+
   private handleFromImport(content: string, context: Record<string, unknown>): void {
     const m = content.match(/^from\s+["'](.+?)["']\s+import\s+(.+)/);
     if (!m) return;
@@ -2635,7 +2787,7 @@ export class Frond {
           const macroM = tagContent.match(/^macro\s+(\w+)\s*\(([^)]*)\)/);
           if (macroM && names.includes(macroM[1])) {
             const macroName = macroM[1];
-            const paramNames = macroM[2].split(",").map(p => p.trim()).filter(Boolean);
+            const paramNames = Frond.parseMacroParams(macroM[2]);
 
             const bodyTokens: Token[] = [];
             i++;
@@ -2657,7 +2809,8 @@ export class Frond {
             context[macroName] = (...args: unknown[]) => {
               const macroCtx: Record<string, unknown> = { ...capturedCtx };
               for (let pi = 0; pi < capturedParams.length; pi++) {
-                macroCtx[capturedParams[pi]] = pi < args.length ? args[pi] : null;
+                const [pname, pdefault] = capturedParams[pi];
+                macroCtx[pname] = pi < args.length ? args[pi] : pdefault;
               }
               return new SafeString(engine.renderTokens([...capturedBody], macroCtx));
             };