tina4-nodejs 3.13.74 → 3.13.76

package/CLAUDE.md

@@ -1,10 +1,10 @@
-# CLAUDE.md - AI Developer Guide for tina4-nodejs (v3.13.74)
+# CLAUDE.md - AI Developer Guide for tina4-nodejs (v3.13.76)
 
 > This file helps AI assistants (Claude, Copilot, Cursor, etc.) understand and work on this codebase effectively.
 
 ## What This Project Is
 
-Tina4 for Node.js/TypeScript v3.13.74 - The Intelligent Native Application 4ramework. A convention-over-configuration structural paradigm. The developer writes TypeScript; Tina4 is invisible infrastructure.
+Tina4 for Node.js/TypeScript v3.13.76 - The Intelligent Native Application 4ramework. A convention-over-configuration structural paradigm. The developer writes TypeScript; Tina4 is invisible infrastructure.
 
 The philosophy: zero ceremony, batteries included, file system as source of truth.
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "tina4-nodejs",
-  "version": "3.13.74",
+  "version": "3.13.76",
   "type": "module",
   "description": "Tina4 for Node.js/TypeScript - 54 built-in features, zero dependencies",
   "keywords": [

package/packages/core/src/static.ts

@@ -1,4 +1,4 @@
-import { existsSync, readFileSync, statSync } from "node:fs";
+import { existsSync, readFileSync, statSync, type Stats } from "node:fs";
 import { join, extname } from "node:path";
 import type { Tina4Request, Tina4Response } from "./types.js";
 
@@ -55,6 +55,29 @@ export function tryServeStatic(
     const ext = extname(filePath);
     const contentType = MIME_TYPES[ext] ?? "application/octet-stream";
 
+    // Cheap validators from the file's size + mtime — no hashing needed. A weak
+    // ETag (W/) is correct here: two representations with the same size+mtime
+    // are treated as equivalent for caching. Last-Modified is second-resolution
+    // per HTTP.
+    const etag = `W/"${stat.size}-${stat.mtimeMs}"`;
+    const lastModified = stat.mtime.toUTCString();
+
+    // A static asset MAY be cached but MUST be revalidated before use, so a
+    // redeployed file reaches the browser on the next load without a manual hard
+    // refresh; an unchanged asset costs a cheap 304, not a re-download. These
+    // ride on both the 200 and the 304 so the client always has fresh
+    // validators. Parity with the Python master static handler.
+    res.raw.setHeader("Cache-Control", "no-cache, must-revalidate");
+    res.raw.setHeader("ETag", etag);
+    res.raw.setHeader("Last-Modified", lastModified);
+
+    // Conditional request → 304 Not Modified with no body.
+    if (isNotModified(req, etag, stat)) {
+      res.raw.statusCode = 304;
+      res.raw.end();
+      return true;
+    }
+
     res.raw.setHeader("Content-Type", contentType);
     res.raw.setHeader("Content-Length", stat.size);
     res.raw.end(readFileSync(filePath));
@@ -63,3 +86,53 @@ export function tryServeStatic(
 
   return false;
 }
+
+/**
+ * Read a conditional-request header off the incoming request. Works with the
+ * real `IncomingMessage` (`req.headers`, already lower-cased by Node) AND with
+ * the hand-rolled request objects used in unit tests. Header names must be
+ * lower-case. Returns "" when absent.
+ */
+function conditionalHeader(req: Tina4Request, name: string): string {
+  const headers = (req as { headers?: Record<string, string | string[] | undefined> }).headers;
+  const value = headers?.[name];
+  if (Array.isArray(value)) return value[0] ?? "";
+  return value ?? "";
+}
+
+/**
+ * Answer whether the cached representation the client already holds is still
+ * current. `If-None-Match` wins over `If-Modified-Since` (RFC 7232 §3.3): when
+ * the client sends an entity tag we compare against that alone.
+ */
+function isNotModified(req: Tina4Request, etag: string, stat: Stats): boolean {
+  const ifNoneMatch = conditionalHeader(req, "if-none-match");
+  if (ifNoneMatch) {
+    return etagMatches(ifNoneMatch, etag);
+  }
+  const ifModifiedSince = conditionalHeader(req, "if-modified-since");
+  if (ifModifiedSince) {
+    const since = Date.parse(ifModifiedSince);
+    if (!Number.isNaN(since)) {
+      // Last-Modified is second-resolution; floor the mtime so sub-second
+      // precision never reports a spurious "modified".
+      const modified = Math.floor(stat.mtimeMs / 1000) * 1000;
+      return modified <= since;
+    }
+  }
+  return false;
+}
+
+/**
+ * Weak comparison of an `If-None-Match` value against our ETag. The header may
+ * be `*`, a single tag, or a comma-separated list; the `W/` weak prefix is
+ * stripped on both sides before comparing (RFC 7232 §2.3.2 weak comparison).
+ */
+function etagMatches(ifNoneMatch: string, etag: string): boolean {
+  const strip = (tag: string) => tag.trim().replace(/^W\//, "");
+  const target = strip(etag);
+  return ifNoneMatch.split(",").some((candidate) => {
+    const trimmed = candidate.trim();
+    return trimmed === "*" || strip(trimmed) === target;
+  });
+}

package/packages/orm/src/migration.ts

@@ -470,21 +470,52 @@ async function recordApplied(
     `DELETE FROM "${MIGRATION_TABLE}" WHERE migration_name = ?`,
     [name],
   );
+  // Build the column list from the columns that ACTUALLY exist on the table, so
+  // a legacy column left behind by an in-place upgrade is populated rather than
+  // defaulted to NULL. Node never created a `migration_id` column, but a Node app
+  // can be pointed at a database whose tina4_migration table was created by
+  // tina4-python v3 <= 3.13.54 - there `migration_id` is NOT NULL, and an insert
+  // that omits it fails, wedging every migration on that database
+  // (tina4-python#93). Mirrors the PHP + Python masters.
+  const cols = await trackingColumns(db);
+  const insertCols = ["migration_name", "description", "batch", "executed_at", "passed"];
+  const values: unknown[] = [name, description, batch, now, passed];
+
+  if (cols.has("migration_id")) {
+    insertCols.push("migration_id");
+    values.push(name);
+  }
+
   if (isFirebirdAdapter(db)) {
     // Firebird: generate the id from the sequence.
     const rows = await adapterQuery<{ NEXT_ID: number }>(db,
       "SELECT GEN_ID(GEN_TINA4_MIGRATION_ID, 1) AS NEXT_ID FROM RDB$DATABASE",
     );
-    const nextId = rows[0]?.NEXT_ID ?? 1;
-    await adapterExecute(db,
-      `INSERT INTO "${MIGRATION_TABLE}" (id, migration_name, description, batch, executed_at, passed) VALUES (?, ?, ?, ?, ?, ?)`,
-      [nextId, name, description, batch, now, passed],
-    );
-  } else {
-    await adapterExecute(db,
-      `INSERT INTO "${MIGRATION_TABLE}" (migration_name, description, batch, executed_at, passed) VALUES (?, ?, ?, ?, ?)`,
-      [name, description, batch, now, passed],
+    insertCols.unshift("id");
+    values.unshift(rows[0]?.NEXT_ID ?? 1);
+  }
+
+  const placeholders = insertCols.map(() => "?").join(", ");
+  await adapterExecute(db,
+    `INSERT INTO "${MIGRATION_TABLE}" (${insertCols.join(", ")}) VALUES (${placeholders})`,
+    values,
+  );
+}
+
+/**
+ * Lowercased column names on the tracking table. Returns an empty set on any
+ * failure so a missing/unreadable table falls back to the canonical columns.
+ */
+async function trackingColumns(db: DatabaseAdapter): Promise<Set<string>> {
+  try {
+    // The DatabaseAdapter contract exposes columns(), not getColumns().
+    const cols = await (db as any).columns?.(MIGRATION_TABLE);
+    if (!Array.isArray(cols)) return new Set();
+    return new Set(
+      cols.map((c: any) => String(c?.name ?? c ?? "").toLowerCase()).filter(Boolean),
     );
+  } catch {
+    return new Set();
   }
 }