tina4-nodejs 3.13.119 → 3.13.121

package/packages/cli/src/commands/migrateCreate.ts

@@ -8,53 +8,48 @@
  * Creates both:
  *   migrations/YYYYMMDDHHMMSS_description.sql       (up migration)
  *   migrations/YYYYMMDDHHMMSS_description.down.sql   (rollback)
+ *
+ * 3.13.121 (ADR-0063): this is a thin delegation to `generate migration` so a
+ * scaffolded migration has ONE shape and ONE envelope regardless of whether
+ * the developer typed `tina4 migrate:create` or `tina4 generate migration`.
+ * The two file paths emitted here (`_desc.sql` + `_desc.down.sql`) and the
+ * schema-awareness on `create_X` names are unchanged; the delegation adds the
+ * ADR-0063 `generate_v1_1` envelope, `--json` / `--dry-run` support, and the
+ * `edit_hints[]` / `next[]` machinery for free. `--no-test` preserves the
+ * pre-3.13.121 UX (just a migration, no co-emitted test).
  */
-import { existsSync, mkdirSync, readdirSync, writeFileSync } from "node:fs";
-import { join, resolve } from "node:path";
+import { generate } from "./generate.js";
+
+export async function createMigration(args: string[] = []): Promise<void> {
+  // Split flags from the description so `tina4 migrate:create "add users"
+  // --json --dry-run` reaches the same envelope machinery as its
+  // `tina4 generate migration` twin (see test/migrateCreateEnvelopeParity.test.ts).
+  const positionals: string[] = [];
+  const flags: string[] = [];
+  for (const arg of args) {
+    if (arg.startsWith("--")) flags.push(arg);
+    else positionals.push(arg);
+  }
+  const description = positionals.join(" ").trim();
 
-export async function createMigration(description?: string): Promise<void> {
   if (!description) {
     console.error("  Usage: tina4 migrate:create <description>");
     console.error('  Example: tina4 migrate:create "create users table"');
     process.exit(1);
   }
 
-  const dir = resolve("migrations");
-
-  // Ensure migrations/ exists
-  if (!existsSync(dir)) {
-    mkdirSync(dir, { recursive: true });
-  }
-
-  // Sanitise description for filename
-  const safeName = description
+  // Sanitise the description into a filename-safe slug BEFORE delegation.
+  // Preserves migrate:create's pre-3.13.121 UX: `migrate:create "add users"`
+  // still yields `${ts}_add_users.sql` (space -> underscore, lowercased),
+  // never a filename with a bare space. `generate migration` takes its name
+  // verbatim by design; migrate:create is the human-friendly front door.
+  const safeDescription = description
     .toLowerCase()
     .replace(/[^a-z0-9]+/g, "_")
     .replace(/^_|_$/g, "");
 
-  // Use YYYYMMDDHHMMSS timestamp prefix
-  const now = new Date();
-  const timestamp = [
-    now.getFullYear(),
-    String(now.getMonth() + 1).padStart(2, "0"),
-    String(now.getDate()).padStart(2, "0"),
-    String(now.getHours()).padStart(2, "0"),
-    String(now.getMinutes()).padStart(2, "0"),
-    String(now.getSeconds()).padStart(2, "0"),
-  ].join("");
-
-  const upFileName = `${timestamp}_${safeName}.sql`;
-  const downFileName = `${timestamp}_${safeName}.down.sql`;
-  const upPath = join(dir, upFileName);
-  const downPath = join(dir, downFileName);
-
-  const upTemplate = `-- Migration: ${description}\n-- Created: ${now.toISOString()}\n\n`;
-  const downTemplate = `-- Rollback: ${description}\n-- Created: ${now.toISOString()}\n\n`;
-
-  writeFileSync(upPath, upTemplate, "utf-8");
-  writeFileSync(downPath, downTemplate, "utf-8");
-
-  console.log(`  Created migration:  ${upFileName}`);
-  console.log(`  Created rollback:   ${downFileName}`);
-  console.log(`  Path: ${dir}`);
+  // Delegate to `generate migration` with --no-test so migrate:create stays
+  // "just a migration, no test" — its pre-3.13.121 semantics — while getting
+  // the ADR-0063 envelope, edit_hints[], next[] and --json/--dry-run for free.
+  await generate("migration", safeDescription, ["--no-test", ...flags]);
 }