tileserver-gl-light 3.1.1 → 4.1.0

package/src/serve_rendered.js

@@ -1,37 +1,33 @@
 'use strict';
 
-const advancedPool = require('advanced-pool');
-const fs = require('fs');
-const path = require('path');
-const url = require('url');
-const util = require('util');
-const zlib = require('zlib');
-
-// sharp has to be required before node-canvas
-// see https://github.com/lovell/sharp/issues/371
-const sharp = require('sharp');
-
-const { createCanvas } = require('canvas');
-
-const clone = require('clone');
-const Color = require('color');
-const express = require('express');
-const mercator = new (require('@mapbox/sphericalmercator'))();
-const mbgl = require('@mapbox/mapbox-gl-native');
-const MBTiles = require('@mapbox/mbtiles');
-const proj4 = require('proj4');
-const request = require('request');
-
-const utils = require('./utils');
+import advancedPool from 'advanced-pool';
+import fs from 'node:fs';
+import path from 'path';
+import url from 'url';
+import util from 'util';
+import zlib from 'zlib';
+import sharp from 'sharp'; // sharp has to be required before node-canvas. see https://github.com/lovell/sharp/issues/371
+import pkg from 'canvas';
+import clone from 'clone';
+import Color from 'color';
+import express from 'express';
+import SphericalMercator from '@mapbox/sphericalmercator';
+import mlgl from '@maplibre/maplibre-gl-native';
+import MBTiles from '@mapbox/mbtiles';
+import proj4 from 'proj4';
+import request from 'request';
+import {getFontsPbf, getTileUrls, fixTileJSONCenter} from './utils.js';
 
 const FLOAT_PATTERN = '[+-]?(?:\\d+|\\d+\.?\\d+)';
 const httpTester = /^(http(s)?:)?\/\//;
 
-const getScale = scale => (scale || '@1x').slice(1, 2) | 0;
+const {createCanvas} = pkg;
+const mercator = new SphericalMercator();
+const getScale = (scale) => (scale || '@1x').slice(1, 2) | 0;
 
-mbgl.on('message', e => {
+mlgl.on('message', (e) => {
   if (e.severity === 'WARNING' || e.severity === 'ERROR') {
-    console.log('mbgl:', e);
+    console.log('mlgl:', e);
   }
 });
 
@@ -54,14 +50,14 @@ const cachedEmptyResponses = {
 };
 
 /**
- * Create an appropriate mbgl response for http errors.
+ * Create an appropriate mlgl response for http errors.
  * @param {string} format The format (a sharp format or 'pbf').
  * @param {string} color The background color (or empty string for transparent).
- * @param {Function} callback The mbgl callback.
+ * @param {Function} callback The mlgl callback.
  */
 function createEmptyResponse(format, color, callback) {
   if (!format || format === 'pbf') {
-    callback(null, { data: cachedEmptyResponses[''] });
+    callback(null, {data: cachedEmptyResponses['']});
     return;
   }
 
@@ -75,7 +71,7 @@ function createEmptyResponse(format, color, callback) {
   const cacheKey = `${format},${color}`;
   const data = cachedEmptyResponses[cacheKey];
   if (data) {
-    callback(null, { data: data });
+    callback(null, {data: data});
     return;
   }
 
@@ -93,7 +89,7 @@ function createEmptyResponse(format, color, callback) {
     if (!err) {
       cachedEmptyResponses[cacheKey] = buffer;
     }
-    callback(null, { data: buffer });
+    callback(null, {data: buffer});
   });
 }
 
@@ -119,7 +115,7 @@ const extractPathFromQuery = (query, transformer) => {
 };
 
 const renderOverlay = (z, x, y, bearing, pitch, w, h, scale,
-  path, query) => {
+    path, query) => {
   if (!path || path.length < 2) {
     return null;
   }
@@ -179,14 +175,14 @@ const calcZForBBox = (bbox, w, h, query) => {
   const padding = query.padding !== undefined ?
     parseFloat(query.padding) : 0.1;
 
-  const minCorner = mercator.px([bbox[0], bbox[3]], z),
-    maxCorner = mercator.px([bbox[2], bbox[1]], z);
+  const minCorner = mercator.px([bbox[0], bbox[3]], z);
+  const maxCorner = mercator.px([bbox[2], bbox[1]], z);
   const w_ = w / (1 + 2 * padding);
   const h_ = h / (1 + 2 * padding);
 
   z -= Math.max(
-    Math.log((maxCorner[0] - minCorner[0]) / w_),
-    Math.log((maxCorner[1] - minCorner[1]) / h_)
+      Math.log((maxCorner[0] - minCorner[0]) / w_),
+      Math.log((maxCorner[1] - minCorner[1]) / h_)
   ) / Math.LN2;
 
   z = Math.max(Math.log(Math.max(w, h) / 256) / Math.LN2, Math.min(25, z));
@@ -197,7 +193,7 @@ const calcZForBBox = (bbox, w, h, query) => {
 const existingFonts = {};
 let maxScaleFactor = 2;
 
-module.exports = {
+export const serve_rendered = {
   init: (options, repo) => {
     const fontListingPromise = new Promise((resolve, reject) => {
       fs.readdir(options.paths.fonts, (err, files) => {
@@ -229,9 +225,7 @@ module.exports = {
 
     const app = express().disable('x-powered-by');
 
-    const respondImage = (item, z, lon, lat, bearing, pitch,
-      width, height, scale, format, res, next,
-      opt_overlay) => {
+    const respondImage = (item, z, lon, lat, bearing, pitch, width, height, scale, format, res, next, opt_overlay, opt_mode='tile') => {
       if (Math.abs(lon) > 180 || Math.abs(lat) > 85.06 ||
         lon !== lon || lat !== lat) {
         return res.status(400).send('Invalid center');
@@ -248,11 +242,16 @@ module.exports = {
         return res.status(400).send('Invalid format');
       }
 
-      const pool = item.map.renderers[scale];
+      let pool;
+      if (opt_mode === 'tile') {
+        pool = item.map.renderers[scale];
+      } else {
+        pool = item.map.renderers_static[scale];
+      }
       pool.acquire((err, renderer) => {
-        const mbglZ = Math.max(0, z - 1);
+        const mlglZ = Math.max(0, z - 1);
         const params = {
-          zoom: mbglZ,
+          zoom: mlglZ,
           center: [lon, lat],
           bearing: bearing,
           pitch: pitch,
@@ -279,9 +278,9 @@ module.exports = {
 
           // Fix semi-transparent outlines on raw, premultiplied input
           // https://github.com/maptiler/tileserver-gl/issues/350#issuecomment-477857040
-          for (var i = 0; i < data.length; i += 4) {
-            var alpha = data[i + 3];
-            var norm = alpha / 255;
+          for (let i = 0; i < data.length; i += 4) {
+            const alpha = data[i + 3];
+            const norm = alpha / 255;
             if (alpha === 0) {
               data[i] = 0;
               data[i + 1] = 0;
@@ -302,9 +301,11 @@ module.exports = {
           });
 
           if (z > 2 && tileMargin > 0) {
+            const [_, y] = mercator.px(params.center, z);
+            let yoffset = Math.max(Math.min(0, y - 128 - tileMargin), y + 128 + tileMargin - Math.pow(2, z + 8));
             image.extract({
               left: tileMargin * scale,
-              top: tileMargin * scale,
+              top: (tileMargin + yoffset) * scale,
               width: width * scale,
               height: height * scale
             });
@@ -316,7 +317,7 @@ module.exports = {
           }
 
           if (opt_overlay) {
-            image.composite([{ input: opt_overlay }]);
+            image.composite([{input: opt_overlay}]);
           }
           if (item.watermark) {
             const canvas = createCanvas(scale * width, scale * height);
@@ -329,17 +330,17 @@ module.exports = {
             ctx.fillStyle = 'rgba(0,0,0,.4)';
             ctx.fillText(item.watermark, 5, height - 5);
 
-            image.composite([{ input: canvas.toBuffer() }]);
+            image.composite([{input: canvas.toBuffer()}]);
           }
 
           const formatQuality = (options.formatQuality || {})[format];
 
           if (format === 'png') {
-            image.png({ adaptiveFiltering: false });
+            image.png({adaptiveFiltering: false});
           } else if (format === 'jpeg') {
-            image.jpeg({ quality: formatQuality || 80 });
+            image.jpeg({quality: formatQuality || 80});
           } else if (format === 'webp') {
-            image.webp({ quality: formatQuality || 90 });
+            image.webp({quality: formatQuality || 90});
           }
           image.toBuffer((err, buffer, info) => {
             if (!buffer) {
@@ -362,18 +363,18 @@ module.exports = {
         return res.sendStatus(404);
       }
 
-      const modifiedSince = req.get('if-modified-since'), cc = req.get('cache-control');
+      const modifiedSince = req.get('if-modified-since'); const cc = req.get('cache-control');
       if (modifiedSince && (!cc || cc.indexOf('no-cache') === -1)) {
         if (new Date(item.lastModified) <= new Date(modifiedSince)) {
           return res.sendStatus(304);
         }
       }
 
-      const z = req.params.z | 0,
-        x = req.params.x | 0,
-        y = req.params.y | 0,
-        scale = getScale(req.params.scale),
-        format = req.params.format;
+      const z = req.params.z | 0;
+      const x = req.params.x | 0;
+      const y = req.params.y | 0;
+      const scale = getScale(req.params.scale);
+      const format = req.params.format;
       if (z < 0 || x < 0 || y < 0 ||
         z > 22 || x >= Math.pow(2, z) || y >= Math.pow(2, z)) {
         return res.status(404).send('Out of bounds');
@@ -383,8 +384,7 @@ module.exports = {
         ((x + 0.5) / (1 << z)) * (256 << z),
         ((y + 0.5) / (1 << z)) * (256 << z)
       ], z);
-      return respondImage(item, z, tileCenter[0], tileCenter[1], 0, 0,
-        tileSize, tileSize, scale, format, res, next);
+      return respondImage(item, z, tileCenter[0], tileCenter[1], 0, 0, tileSize, tileSize, scale, format, res, next);
     });
 
     if (options.serveStaticMaps !== false) {
@@ -393,8 +393,8 @@ module.exports = {
 
       const centerPattern =
         util.format(':x(%s),:y(%s),:z(%s)(@:bearing(%s)(,:pitch(%s))?)?',
-          FLOAT_PATTERN, FLOAT_PATTERN, FLOAT_PATTERN,
-          FLOAT_PATTERN, FLOAT_PATTERN);
+            FLOAT_PATTERN, FLOAT_PATTERN, FLOAT_PATTERN,
+            FLOAT_PATTERN, FLOAT_PATTERN);
 
       app.get(util.format(staticPattern, centerPattern), (req, res, next) => {
         const item = repo[req.params.id];
@@ -402,15 +402,15 @@ module.exports = {
           return res.sendStatus(404);
         }
         const raw = req.params.raw;
-        let z = +req.params.z,
-          x = +req.params.x,
-          y = +req.params.y,
-          bearing = +(req.params.bearing || '0'),
-          pitch = +(req.params.pitch || '0'),
-          w = req.params.width | 0,
-          h = req.params.height | 0,
-          scale = getScale(req.params.scale),
-          format = req.params.format;
+        const z = +req.params.z;
+        let x = +req.params.x;
+        let y = +req.params.y;
+        const bearing = +(req.params.bearing || '0');
+        const pitch = +(req.params.pitch || '0');
+        const w = req.params.width | 0;
+        const h = req.params.height | 0;
+        const scale = getScale(req.params.scale);
+        const format = req.params.format;
 
         if (z < 0) {
           return res.status(404).send('Invalid zoom');
@@ -426,11 +426,9 @@ module.exports = {
         }
 
         const path = extractPathFromQuery(req.query, transformer);
-        const overlay = renderOverlay(z, x, y, bearing, pitch, w, h, scale,
-          path, req.query);
+        const overlay = renderOverlay(z, x, y, bearing, pitch, w, h, scale, path, req.query);
 
-        return respondImage(item, z, x, y, bearing, pitch, w, h, scale, format,
-          res, next, overlay);
+        return respondImage(item, z, x, y, bearing, pitch, w, h, scale, format, res, next, overlay, 'static');
       });
 
       const serveBounds = (req, res, next) => {
@@ -439,8 +437,7 @@ module.exports = {
           return res.sendStatus(404);
         }
         const raw = req.params.raw;
-        const bbox = [+req.params.minx, +req.params.miny,
-        +req.params.maxx, +req.params.maxy];
+        const bbox = [+req.params.minx, +req.params.miny, +req.params.maxx, +req.params.maxy];
         let center = [(bbox[0] + bbox[2]) / 2, (bbox[1] + bbox[3]) / 2];
 
         const transformer = raw ?
@@ -456,32 +453,31 @@ module.exports = {
           center = transformer(center);
         }
 
-        const w = req.params.width | 0,
-          h = req.params.height | 0,
-          scale = getScale(req.params.scale),
-          format = req.params.format;
+        const w = req.params.width | 0;
+        const h = req.params.height | 0;
+        const scale = getScale(req.params.scale);
+        const format = req.params.format;
 
-        const z = calcZForBBox(bbox, w, h, req.query),
-          x = center[0],
-          y = center[1],
-          bearing = 0,
-          pitch = 0;
+        const z = calcZForBBox(bbox, w, h, req.query);
+        const x = center[0];
+        const y = center[1];
+        const bearing = 0;
+        const pitch = 0;
 
         const path = extractPathFromQuery(req.query, transformer);
-        const overlay = renderOverlay(z, x, y, bearing, pitch, w, h, scale,
-          path, req.query);
-        return respondImage(item, z, x, y, bearing, pitch, w, h, scale, format,
-          res, next, overlay);
+        const overlay = renderOverlay(z, x, y, bearing, pitch, w, h, scale, path, req.query);
+
+        return respondImage(item, z, x, y, bearing, pitch, w, h, scale, format, res, next, overlay, 'static');
       };
 
       const boundsPattern =
         util.format(':minx(%s),:miny(%s),:maxx(%s),:maxy(%s)',
-          FLOAT_PATTERN, FLOAT_PATTERN, FLOAT_PATTERN, FLOAT_PATTERN);
+            FLOAT_PATTERN, FLOAT_PATTERN, FLOAT_PATTERN, FLOAT_PATTERN);
 
       app.get(util.format(staticPattern, boundsPattern), serveBounds);
 
       app.get('/:id/static/', (req, res, next) => {
-        for (let key in req.query) {
+        for (const key in req.query) {
           req.query[key.toLowerCase()] = req.query[key];
         }
         req.params.raw = true;
@@ -510,12 +506,12 @@ module.exports = {
           return res.sendStatus(404);
         }
         const raw = req.params.raw;
-        const w = req.params.width | 0,
-          h = req.params.height | 0,
-          bearing = 0,
-          pitch = 0,
-          scale = getScale(req.params.scale),
-          format = req.params.format;
+        const w = req.params.width | 0;
+        const h = req.params.height | 0;
+        const bearing = 0;
+        const pitch = 0;
+        const scale = getScale(req.params.scale);
+        const format = req.params.format;
 
         const transformer = raw ?
           mercator.inverse.bind(mercator) : item.dataProjWGStoInternalWGS;
@@ -535,18 +531,16 @@ module.exports = {
 
         const bbox_ = mercator.convert(bbox, '900913');
         const center = mercator.inverse(
-          [(bbox_[0] + bbox_[2]) / 2, (bbox_[1] + bbox_[3]) / 2]
+            [(bbox_[0] + bbox_[2]) / 2, (bbox_[1] + bbox_[3]) / 2]
         );
 
-        const z = calcZForBBox(bbox, w, h, req.query),
-          x = center[0],
-          y = center[1];
+        const z = calcZForBBox(bbox, w, h, req.query);
+        const x = center[0];
+        const y = center[1];
 
-        const overlay = renderOverlay(z, x, y, bearing, pitch, w, h, scale,
-          path, req.query);
+        const overlay = renderOverlay(z, x, y, bearing, pitch, w, h, scale, path, req.query);
 
-        return respondImage(item, z, x, y, bearing, pitch, w, h, scale, format,
-          res, next, overlay);
+        return respondImage(item, z, x, y, bearing, pitch, w, h, scale, format, res, next, overlay, 'static');
       });
     }
 
@@ -556,8 +550,8 @@ module.exports = {
         return res.sendStatus(404);
       }
       const info = clone(item.tileJSON);
-      info.tiles = utils.getTileUrls(req, info.tiles,
-        `styles/${req.params.id}`, info.format, item.publicUrl);
+      info.tiles = getTileUrls(req, info.tiles,
+          `styles/${req.params.id}`, info.format, item.publicUrl);
       return res.send(info);
     });
 
@@ -566,44 +560,45 @@ module.exports = {
   add: (options, repo, params, id, publicUrl, dataResolver) => {
     const map = {
       renderers: [],
+      renderers_static: [],
       sources: {}
     };
 
     let styleJSON;
-    const createPool = (ratio, min, max) => {
+    const createPool = (ratio, mode, min, max) => {
       const createRenderer = (ratio, createCallback) => {
-        const renderer = new mbgl.Map({
-          mode: "tile",
+        const renderer = new mlgl.Map({
+          mode: mode,
           ratio: ratio,
           request: (req, callback) => {
             const protocol = req.url.split(':')[0];
-            //console.log('Handling request:', req);
+            // console.log('Handling request:', req);
             if (protocol === 'sprites') {
               const dir = options.paths[protocol];
               const file = unescape(req.url).substring(protocol.length + 3);
               fs.readFile(path.join(dir, file), (err, data) => {
-                callback(err, { data: data });
+                callback(err, {data: data});
               });
             } else if (protocol === 'fonts') {
               const parts = req.url.split('/');
               const fontstack = unescape(parts[2]);
               const range = parts[3].split('.')[0];
-              utils.getFontsPbf(
-                null, options.paths[protocol], fontstack, range, existingFonts
-              ).then(concated => {
-                callback(null, { data: concated });
-              }, err => {
-                callback(err, { data: null });
+              getFontsPbf(
+                  null, options.paths[protocol], fontstack, range, existingFonts
+              ).then((concated) => {
+                callback(null, {data: concated});
+              }, (err) => {
+                callback(err, {data: null});
               });
             } else if (protocol === 'mbtiles') {
               const parts = req.url.split('/');
               const sourceId = parts[2];
               const source = map.sources[sourceId];
               const sourceInfo = styleJSON.sources[sourceId];
-              const z = parts[3] | 0,
-                x = parts[4] | 0,
-                y = parts[5].split('.')[0] | 0,
-                format = parts[5].split('.')[1];
+              const z = parts[3] | 0;
+              const x = parts[4] | 0;
+              const y = parts[5].split('.')[0] | 0;
+              const format = parts[5].split('.')[1];
               source.getTile(z, x, y, (err, data, headers) => {
                 if (err) {
                   if (options.verbose) console.log('MBTiles error, serving empty', err);
@@ -620,11 +615,11 @@ module.exports = {
                   try {
                     response.data = zlib.unzipSync(data);
                   } catch (err) {
-                    console.log("Skipping incorrect header for tile mbtiles://%s/%s/%s/%s.pbf", id, z, x, y);
+                    console.log('Skipping incorrect header for tile mbtiles://%s/%s/%s/%s.pbf', id, z, x, y);
                   }
                   if (options.dataDecoratorFunc) {
                     response.data = options.dataDecoratorFunc(
-                      sourceId, 'data', response.data, z, x, y);
+                        sourceId, 'data', response.data, z, x, y);
                   }
                 } else {
                   response.data = data;
@@ -671,7 +666,7 @@ module.exports = {
         min: min,
         max: max,
         create: createRenderer.bind(null, ratio),
-        destroy: renderer => {
+        destroy: (renderer) => {
           renderer.release();
         }
       });
@@ -689,8 +684,8 @@ module.exports = {
     if (styleJSON.sprite && !httpTester.test(styleJSON.sprite)) {
       styleJSON.sprite = 'sprites://' +
         styleJSON.sprite
-          .replace('{style}', path.basename(styleFile, '.json'))
-          .replace('{styleJsonFolder}', path.relative(options.paths.sprites, path.dirname(styleJSONPath)));
+            .replace('{style}', path.basename(styleFile, '.json'))
+            .replace('{styleJsonFolder}', path.relative(options.paths.sprites, path.dirname(styleJSONPath)));
     }
     if (styleJSON.glyphs && !httpTester.test(styleJSON.glyphs)) {
       styleJSON.glyphs = `fonts://${styleJSON.glyphs}`;
@@ -721,9 +716,9 @@ module.exports = {
     const attributionOverride = params.tilejson && params.tilejson.attribution;
     Object.assign(tileJSON, params.tilejson || {});
     tileJSON.tiles = params.domains || options.domains;
-    utils.fixTileJSONCenter(tileJSON);
+    fixTileJSONCenter(tileJSON);
 
-    repo[id] = {
+    const repoobj = {
       tileJSON,
       publicUrl,
       map,
@@ -731,6 +726,7 @@ module.exports = {
       lastModified: new Date().toUTCString(),
       watermark: params.watermark || options.watermark
     };
+    repo[id] = repoobj;
 
     const queue = [];
     for (const name of Object.keys(styleJSON.sources)) {
@@ -764,18 +760,18 @@ module.exports = {
           if (!mbtilesFileStats.isFile() || mbtilesFileStats.size === 0) {
             throw Error(`Not valid MBTiles file: ${mbtilesFile}`);
           }
-          map.sources[name] = new MBTiles(mbtilesFile, err => {
+          map.sources[name] = new MBTiles(mbtilesFile + '?mode=ro', err => {
             map.sources[name].getInfo((err, info) => {
               if (err) {
                 console.error(err);
                 return;
               }
 
-              if (!repo[id].dataProjWGStoInternalWGS && info.proj4) {
+              if (!repoobj.dataProjWGStoInternalWGS && info.proj4) {
                 // how to do this for multiple sources with different proj4 defs?
                 const to3857 = proj4('EPSG:3857');
                 const toDataProj = proj4(info.proj4);
-                repo[id].dataProjWGStoInternalWGS = xy => to3857.inverse(toDataProj.forward(xy));
+                repoobj.dataProjWGStoInternalWGS = (xy) => to3857.inverse(toDataProj.forward(xy));
               }
 
               const type = source.type;
@@ -793,10 +789,12 @@ module.exports = {
 
               if (!attributionOverride &&
                 source.attribution && source.attribution.length > 0) {
-                if (tileJSON.attribution.length > 0) {
-                  tileJSON.attribution += '; ';
+                if (!tileJSON.attribution.includes(source.attribution)) {
+                  if (tileJSON.attribution.length > 0) {
+                    tileJSON.attribution += ' | ';
+                  }
+                  tileJSON.attribution += source.attribution;
                 }
-                tileJSON.attribution += source.attribution;
               }
               resolve();
             });
@@ -814,19 +812,23 @@ module.exports = {
         const j = Math.min(maxPoolSizes.length - 1, s - 1);
         const minPoolSize = minPoolSizes[i];
         const maxPoolSize = Math.max(minPoolSize, maxPoolSizes[j]);
-        map.renderers[s] = createPool(s, minPoolSize, maxPoolSize);
+        map.renderers[s] = createPool(s, 'tile', minPoolSize, maxPoolSize);
+        map.renderers_static[s] = createPool(s, 'static', minPoolSize, maxPoolSize);
       }
     });
 
     return Promise.all([renderersReadyPromise]);
   },
   remove: (repo, id) => {
-    let item = repo[id];
+    const item = repo[id];
     if (item) {
-      item.map.renderers.forEach(pool => {
+      item.map.renderers.forEach((pool) => {
+        pool.close();
+      });
+      item.map.renderers_static.forEach((pool) => {
         pool.close();
       });
     }
     delete repo[id];
-  },
+  }
 };

package/src/serve_style.js

@@ -1,13 +1,13 @@
 'use strict';
 
-const path = require('path');
-const fs = require('fs');
+import path from 'path';
+import fs from 'node:fs';
 
-const clone = require('clone');
-const express = require('express');
-import {validate} from '@mapbox/mapbox-gl-style-spec';
+import clone from 'clone';
+import express from 'express';
+import {validate} from '@maplibre/maplibre-gl-style-spec';
 
-const utils = require('./utils');
+import {getPublicUrl} from './utils.js';
 
 const httpTester = /^(http(s)?:)?\/\//;
 
@@ -24,10 +24,10 @@ const fixUrl = (req, url, publicUrl, opt_nokey) => {
     query = `?${queryParams.join('&')}`;
   }
   return url.replace(
-    'local://', utils.getPublicUrl(publicUrl, req)) + query;
+      'local://', getPublicUrl(publicUrl, req)) + query;
 };
 
-module.exports = {
+export const serve_style = {
   init: (options, repo) => {
     const app = express().disable('x-powered-by');
 
@@ -56,8 +56,8 @@ module.exports = {
       if (!item || !item.spritePath) {
         return res.sendStatus(404);
       }
-      const scale = req.params.scale,
-        format = req.params.format;
+      const scale = req.params.scale;
+      const format = req.params.format;
       const filename = `${item.spritePath + (scale || '')}.${format}`;
       return fs.readFile(filename, (err, data) => {
         if (err) {
@@ -87,7 +87,7 @@ module.exports = {
       return false;
     }
 
-    let validationErrors = validate(styleFileData);
+    const validationErrors = validate(styleFileData);
     if (validationErrors.length > 0) {
       console.log(`The file "${params.style}" is not valid a valid style file:`);
       for (const err of validationErrors) {
@@ -95,7 +95,7 @@ module.exports = {
       }
       return false;
     }
-    let styleJSON = JSON.parse(styleFileData);
+    const styleJSON = JSON.parse(styleFileData);
 
     for (const name of Object.keys(styleJSON.sources)) {
       const source = styleJSON.sources[name];
@@ -120,7 +120,7 @@ module.exports = {
       }
     }
 
-    for (let obj of styleJSON.layers) {
+    for (const obj of styleJSON.layers) {
       if (obj['type'] === 'symbol') {
         const fonts = (obj['layout'] || {})['text-font'];
         if (fonts && fonts.length) {
@@ -136,9 +136,9 @@ module.exports = {
 
     if (styleJSON.sprite && !httpTester.test(styleJSON.sprite)) {
       spritePath = path.join(options.paths.sprites,
-        styleJSON.sprite
-          .replace('{style}', path.basename(styleFile, '.json'))
-          .replace('{styleJsonFolder}', path.relative(options.paths.sprites, path.dirname(styleFile)))
+          styleJSON.sprite
+              .replace('{style}', path.basename(styleFile, '.json'))
+              .replace('{styleJsonFolder}', path.relative(options.paths.sprites, path.dirname(styleFile)))
       );
       styleJSON.sprite = `local://styles/${id}/sprite`;
     }