tigerbeetle-node 0.11.7 → 0.11.8

package/dist/.client.node.sha256

@@ -1 +1 @@
-47b1ff2fdba97cebd987a6012cd302a640a6f0710645f4e3dfd0d3570c2686f9  dist/client.node
+c82197101574fc1267be050abfa7d31ca355036eec3f7d3da9a43a6c83bf6b0c  dist/client.node

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "tigerbeetle-node",
-  "version": "0.11.7",
+  "version": "0.11.8",
   "description": "TigerBeetle Node.js client",
   "main": "dist/index.js",
   "typings": "dist/index.d.ts",

package/src/tigerbeetle/src/vsr/client.zig

@@ -29,7 +29,8 @@ pub fn Client(comptime StateMachine_: type, comptime MessageBus: type) type {
                 results: Error![]const u8,
             ) void;
             user_data: u128,
-            callback: Callback,
+            // Null iff operation=register.
+            callback: ?Callback,
             message: *Message,
         };
 
@@ -194,6 +195,7 @@ pub fn Client(comptime StateMachine_: type, comptime MessageBus: type) type {
             message_body_size: usize,
         ) void {
             self.register();
+            assert(self.request_number > 0);
 
             // We will set parent, context, view and checksums only when sending for the first time:
             message.header.* = .{
@@ -205,9 +207,6 @@ pub fn Client(comptime StateMachine_: type, comptime MessageBus: type) type {
                 .size = @intCast(u32, @sizeOf(Header) + message_body_size),
             };
 
-            assert(self.request_number > 0);
-            self.request_number += 1;
-
             log.debug("{}: request: user_data={} request={} size={} {s}", .{
                 self.id,
                 user_data,
@@ -223,6 +222,7 @@ pub fn Client(comptime StateMachine_: type, comptime MessageBus: type) type {
 
             const was_empty = self.request_queue.empty();
 
+            self.request_number += 1;
             self.request_queue.push_assume_capacity(.{
                 .user_data = user_data,
                 .callback = callback,
@@ -370,12 +370,16 @@ pub fn Client(comptime StateMachine_: type, comptime MessageBus: type) type {
                 on_reply_callback(self.on_reply_context, self, inflight.message, reply);
             }
 
-            if (inflight.message.header.operation != .register) {
-                inflight.callback(
+            if (inflight.callback) |callback| {
+                assert(inflight.message.header.operation != .register);
+
+                callback(
                     inflight.user_data,
                     inflight.message.header.operation.cast(StateMachine),
                     reply.body(),
                 );
+            } else {
+                assert(inflight.message.header.operation == .register);
             }
         }
 
@@ -455,7 +459,7 @@ pub fn Client(comptime StateMachine_: type, comptime MessageBus: type) type {
 
             self.request_queue.push_assume_capacity(.{
                 .user_data = 0,
-                .callback = undefined,
+                .callback = null,
                 .message = message.ref(),
             });