tickmarkr 2.5.5 → 2.5.6

package/dist/tui/ink/fleet-app.js

@@ -25,7 +25,7 @@ function splitSeat(seat) {
     const at = seat.indexOf(":");
     return { adapter: seat.slice(0, at), model: seat.slice(at + 1) };
 }
-export function FleetApp({ ageMs, agents, initialDenyAdapters, initialDenyModels, initialDenyWorkersAdapters = [], initialDenyWorkersModels = [], modelGroups, initialMode, modeOptions, initialMap, modePreview, shapeRows, candidatesForShape, preferOptionsForShape, initialSteering, steeringOptionsFor, reviewOverlay, reloadGuard, stagedRouting, entry = "probe", initialJudge = "", judgeSeats = [], viewRows = Number.POSITIVE_INFINITY, frameColumns = 100, frameRows, }) {
+export function FleetApp({ ageMs, agents, initialDenyAdapters, initialDenyModels, initialAllowOut = [], initialDenyWorkersAdapters = [], initialDenyWorkersModels = [], modelGroups, initialMode, modeOptions, initialMap, modePreview, shapeRows, candidatesForShape, preferOptionsForShape, initialSteering, steeringOptionsFor, reviewOverlay, reloadGuard, stagedRouting, entry = "probe", initialJudge = "", judgeSeats = [], viewRows = Number.POSITIVE_INFINITY, frameColumns = 100, frameRows, }) {
     const { exit } = useApp();
     const [, setRevision] = useState(0);
     const uiRef = useRef(null);
@@ -45,6 +45,7 @@ export function FleetApp({ ageMs, agents, initialDenyAdapters, initialDenyModels
         lastEdit: null,
         deny: new Set(initialDenyAdapters),
         denyModels: new Set(initialDenyModels),
+        allowOut: new Set(initialAllowOut),
         denyWorkersAdapters: new Set(initialDenyWorkersAdapters),
         denyWorkersModels: new Set(initialDenyWorkersModels),
         classifications: [],
@@ -64,6 +65,7 @@ export function FleetApp({ ageMs, agents, initialDenyAdapters, initialDenyModels
     // chip, and the empty-`w` notice all read it. Counts staged EDITS, not diff hunks.
     const initialDenySet = new Set(initialDenyAdapters);
     const initialDenyModelSet = new Set(initialDenyModels);
+    const initialAllowOutSet = new Set(initialAllowOut);
     const initialDenyWorkersAdapterSet = new Set(initialDenyWorkersAdapters);
     const initialDenyWorkersModelSet = new Set(initialDenyWorkersModels);
     const stagedCount = () => {
@@ -82,6 +84,9 @@ export function FleetApp({ ageMs, agents, initialDenyAdapters, initialDenyModels
         for (const model of initialDenyModelSet)
             if (!ui.denyModels.has(model))
                 n += 1;
+        for (const key of initialAllowOutSet)
+            if (!ui.allowOut.has(key))
+                n += 1;
         for (const adapter of ui.denyWorkersAdapters)
             if (!initialDenyWorkersAdapterSet.has(adapter))
                 n += 1;
@@ -218,6 +223,7 @@ export function FleetApp({ ageMs, agents, initialDenyAdapters, initialDenyModels
         models: [...ui.denyModels].sort(),
         workersAdapters: [...ui.denyWorkersAdapters].sort(),
         workersModels: [...ui.denyWorkersModels].sort(),
+        allowOut: [...ui.allowOut].sort(),
     });
     const shapeList = () => shapeRows(ui.selectedMode, ui.map, stagedDeny());
     const steeringList = () => [
@@ -245,6 +251,7 @@ export function FleetApp({ ageMs, agents, initialDenyAdapters, initialDenyModels
     const editorState = () => ({
         denyAdapters: [...ui.deny].sort(),
         denyModels: [...ui.denyModels].sort(),
+        allowOut: [...ui.allowOut].sort(),
         denyWorkersAdapters: [...ui.denyWorkersAdapters].sort(),
         denyWorkersModels: [...ui.denyWorkersModels].sort(),
         classifications: ui.classifications.map((classification) => classification.vendor && classification.channel
@@ -940,12 +947,18 @@ export function FleetApp({ ageMs, agents, initialDenyAdapters, initialDenyModels
                 if (agents.find((agent) => agent.id === id)?.authed === false) {
                     ui.notice = `${id} is not authed — Space only toggles fleet membership; re-auth the ${id} CLI, then run tickmarkr doctor`;
                 }
-                const next = new Set(ui.deny);
-                if (next.has(id))
-                    next.delete(id);
-                else
-                    next.add(id);
-                ui.deny = next;
+                // OBS-1046: an adapter routing.allow leaves out comes back in by clearing THAT reason
+                if (ui.allowOut.has(id)) {
+                    ui.allowOut = new Set([...ui.allowOut].filter((key) => key !== id));
+                }
+                else {
+                    const next = new Set(ui.deny);
+                    if (next.has(id))
+                        next.delete(id);
+                    else
+                        next.add(id);
+                    ui.deny = next;
+                }
                 clampList();
                 bump();
                 return;
@@ -1048,12 +1061,14 @@ export function FleetApp({ ageMs, agents, initialDenyAdapters, initialDenyModels
                     ui.lastEdit = { id, text: `space: moved ${entry} to routing.deny.models` };
                 }
                 else {
-                    // round 2 finding 2: either flat list may carry this channel's own reason
+                    // round 2 finding 2: either flat list may carry this channel's own reason; OBS-1046: an
+                    // allow exclusion is the LAST reason cleared, and never together with an authored deny
                     const fromModels = select(ui.denyModels, true);
                     const fromAdapters = fromModels === undefined ? select(ui.deny, true) : undefined;
-                    const entry = fromModels ?? fromAdapters;
+                    const fromAllow = fromModels === undefined && fromAdapters === undefined ? select(ui.allowOut, true) : undefined;
+                    const entry = fromModels ?? fromAdapters ?? fromAllow;
                     if (entry === undefined) {
-                        const shared = ui.deny.has(row.adapter)
+                        const shared = ui.deny.has(row.adapter) || ui.allowOut.has(row.adapter)
                             ? `every ${row.adapter} channel is out together — take the adapter back in on the rail`
                             : "a shared entry covers other channels too";
                         ui.notice = `${id} stays out — ${row.reasons.join("; ")} — Space edits only this channel's own entries; ${shared}`;
@@ -1062,9 +1077,12 @@ export function FleetApp({ ageMs, agents, initialDenyAdapters, initialDenyModels
                     }
                     if (fromModels !== undefined)
                         ui.denyModels = new Set([...ui.denyModels].filter((staged) => staged !== entry));
-                    else
+                    else if (fromAdapters !== undefined)
                         ui.deny = new Set([...ui.deny].filter((staged) => staged !== entry));
-                    ui.lastEdit = { id, text: `space: cleared ${entry} from routing.deny.${fromModels !== undefined ? "models" : "adapters"}` };
+                    else
+                        ui.allowOut = new Set([...ui.allowOut].filter((staged) => staged !== entry));
+                    const scope = fromModels !== undefined ? "routing.deny.models" : fromAdapters !== undefined ? "routing.deny.adapters" : "routing.allow";
+                    ui.lastEdit = { id, text: `space: cleared ${entry} from ${scope}` };
                 }
                 bump();
                 return;
@@ -1333,7 +1351,7 @@ export function FleetApp({ ageMs, agents, initialDenyAdapters, initialDenyModels
     const railAdapter = (index, railIndex) => {
         const group = modelGroups[index];
         const agent = agents.find((candidate) => candidate.id === group.adapter);
-        const denied = ui.deny.has(group.adapter);
+        const denied = ui.deny.has(group.adapter) || ui.allowOut.has(group.adapter);
         const active = ui.view === "models" && ui.adapterAt === index;
         const selected = ui.focus === "rail" && ui.railAt === railIndex;
         return (_jsxs(Text, { children: [selected ? _jsx(Text, { color: INK.brand, children: "❯ " }) : _jsx(Text, { children: "  " }), denied ? _jsx(Glyph, { kind: "off" }) : agent?.authed === false ? _jsx(Glyph, { kind: "fail" }) : _jsx(Glyph, { kind: "on" }), _jsx(Text, { children: " " }), _jsx(Text, { bold: active, color: active ? INK.brand : undefined, dimColor: denied, children: padCell(group.adapter, 12) }), _jsx(Text, { dimColor: true, children: padCellStart(String(visibleCount(index)), 4) })] }, group.adapter));
@@ -1578,7 +1596,7 @@ export function FleetApp({ ageMs, agents, initialDenyAdapters, initialDenyModels
                 ? _jsx(Text, { color: INK.warn, children: ` ! ${clip(ui.notice, width - 4)}` })
                 : details.map((line) => _jsx(Text, { dimColor: true, children: ` ${clip(line, width - 2)}` }, line)), _jsx(KeyBar, { binds: keyBinds() })] }));
 }
-export async function runFleetInkEditor({ ageMs, adapters, health, initialDenyAdapters, initialDenyModels, initialDenyWorkersAdapters = [], initialDenyWorkersModels = [], modelGroups, initialMode, modeOptions, initialMap, modePreview, shapeRows, candidatesForShape, preferOptionsForShape, initialSteering, steeringOptionsFor, reviewOverlay, reloadGuard, stagedRouting, entry = "probe", initialJudge = "", judgeSeats = [], initialInput = [], input, output, debug = false, }) {
+export async function runFleetInkEditor({ ageMs, adapters, health, initialDenyAdapters, initialDenyModels, initialAllowOut = [], initialDenyWorkersAdapters = [], initialDenyWorkersModels = [], modelGroups, initialMode, modeOptions, initialMap, modePreview, shapeRows, candidatesForShape, preferOptionsForShape, initialSteering, steeringOptionsFor, reviewOverlay, reloadGuard, stagedRouting, entry = "probe", initialJudge = "", judgeSeats = [], initialInput = [], input, output, debug = false, }) {
     const agents = adapters.flatMap((adapter) => {
         const state = health[adapter.id];
         if (!state?.installed)
@@ -1602,7 +1620,7 @@ export async function runFleetInkEditor({ ageMs, adapters, health, initialDenyAd
     // rebuilt from output.columns/rows so a pane resize re-renders at the new size. Same root
     // element type on every rerender ⇒ React keeps the component instance, so staged edits,
     // cursor, and overlays all survive the resize.
-    const editorElement = () => (_jsx(FleetApp, { ageMs: ageMs, agents: agents, initialDenyAdapters: initialDenyAdapters, initialDenyModels: initialDenyModels, initialDenyWorkersAdapters: initialDenyWorkersAdapters, initialDenyWorkersModels: initialDenyWorkersModels, modelGroups: declaredModelGroups, initialMode: initialMode, modeOptions: modeOptions, initialMap: initialMap, modePreview: modePreview, shapeRows: shapeRows, candidatesForShape: candidatesForShape, preferOptionsForShape: preferOptionsForShape, initialSteering: initialSteering, steeringOptionsFor: steeringOptionsFor, reviewOverlay: reviewOverlay, reloadGuard: reloadGuard, stagedRouting: stagedRouting, entry: entry, initialJudge: initialJudge, judgeSeats: judgeSeats, 
+    const editorElement = () => (_jsx(FleetApp, { ageMs: ageMs, agents: agents, initialDenyAdapters: initialDenyAdapters, initialDenyModels: initialDenyModels, initialAllowOut: initialAllowOut, initialDenyWorkersAdapters: initialDenyWorkersAdapters, initialDenyWorkersModels: initialDenyWorkersModels, modelGroups: declaredModelGroups, initialMode: initialMode, modeOptions: modeOptions, initialMap: initialMap, modePreview: modePreview, shapeRows: shapeRows, candidatesForShape: candidatesForShape, preferOptionsForShape: preferOptionsForShape, initialSteering: initialSteering, steeringOptionsFor: steeringOptionsFor, reviewOverlay: reviewOverlay, reloadGuard: reloadGuard, stagedRouting: stagedRouting, entry: entry, initialJudge: initialJudge, judgeSeats: judgeSeats, 
         // v1.90.9: cap every list to the terminal minus chrome so the cursor and header can
         // never scroll off-screen (omp's 218-model list did exactly that pre-cap).
         // OBS-523: chrome is ≤12 rows worst case (header, borders, padding, scope+search,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "tickmarkr",
-  "version": "2.5.5",
+  "version": "2.5.6",
   "description": "Spec in, verified work out.",
   "type": "module",
   "license": "MIT",
@@ -17,7 +17,7 @@
   },
   "homepage": "https://github.com/alzahrani-khalid/tickmarkr",
   "engines": {
-    "node": ">=20"
+    "node": ">=20.3"
   },
   "bin": {
     "tickmarkr": "dist/cli/index.js",

package/skills/tickmarkr-overseer/scripts/grade-ci.sh

@@ -50,14 +50,41 @@ while IFS=$'\t' read -r id name status conclusion; do
   skipped=$(printf '%s\n' "$files" | grep -oE '[0-9]+ skipped' | awk '{s+=$1} END{print s+0}')
   failed=$(printf '%s\n' "$files" | grep -oE '[0-9]+ failed' | awk '{s+=$1} END{print s+0}')
   timedout=$(grep -cE 'Test timed out|Error: Hook timed out' "$log" || true)
+  # Vitest reports errors thrown outside any test (unhandled rejections, worker crashes) in an
+  # "Unhandled Errors" block that leaves the file summary green and the count oracle satisfied;
+  # its own tally line names how many. Any unhandled error is RED, never a green suite.
+  unhandled=$(grep -oE 'Vitest caught [0-9]+ unhandled error' "$log" | grep -oE '[0-9]+' | awk '{s+=$1} END{print s+0}')
+  if [ "$unhandled" -eq 0 ]; then
+    unhandled=$(grep -cE 'Unhandled Errors' "$log" || true)
+  fi
+  # OBS-1058 (RULING-231-17 precedent, v2.5.5 close R115 add.7): a vitest-worker RPC timeout
+  # ("Timeout calling \"onTaskUpdate\"") is the starved runner talking, not a test — every green
+  # release run has carried one. Only a timeout that is ITSELF an unhandled entry counts: the first
+  # payload line under a per-error header, nothing later. The header is Vitest's own structural line —
+  # a run of ⎯ on each side of "Unhandled Error", ANSI stripped (both the raw ESC byte and gh's `^[` rendering of it), nothing else on the line — so prose that
+  # merely contains the words never opens a window — and the payload must be Vitest's whole line
+  # (`Error: [vitest-worker]: Timeout calling "<method>"`), so an assertion quoting it stays RED. Per-error headers are honoured only inside Vitest's own block —
+  # after its structural "Unhandled Errors" line and "Vitest caught N" tally, until the file summary — and
+  # the count never exceeds N, so a test that prints a header and a timeout to stdout forges nothing. A stray diagnostic elsewhere in the log never
+  # offsets a real unhandled error; anything else under a header stays RED.
+  esc=$(printf '\033')
+  rpc=$(awk -v esc="$esc" '{ line = $0; gsub(/\^\[\[[0-9;]*m/, "", line); gsub(esc "\\[[0-9;]*m", "", line); sub(/^[^\t]*\t[^\t]*\t[0-9T:.-]+Z[ ]?/, "", line) }
+             line ~ /^(⎯)+ Unhandled Errors (⎯)+[ \t]*$/ { opening = 1; next }
+             opening && line !~ /[^ \t]/ { next }
+             opening { opening = 0; if (line ~ /^Vitest caught [0-9]+ unhandled error/) { armed = 1; cap = line; sub(/^Vitest caught /, "", cap); sub(/ .*$/, "", cap) } }
+             armed && line ~ /^[ \t]*Test Files / { armed = 0 }
+             armed && line ~ /^(⎯)+ Unhandled Error (⎯)+[ \t]*$/ { pending = 1; next }
+             pending && line ~ /[^ \t]/ { pending = 0; if (line ~ /^Error: \[vitest-worker\]: Timeout calling "[A-Za-z]+"[ \t]*$/) n++ }
+             END { if (n > cap + 0) n = cap + 0; print n + 0 }' "$log")
+  if [ "$rpc" -gt 0 ] && [ "$unhandled" -ge "$rpc" ]; then unhandled=$((unhandled - rpc)); fi
   errors=$(grep -oE '##\[error\].*' "$log" | sort | uniq -c | sed 's/^ *//' | tr '\n' ';')
 
-  echo "$name: oracle=[${oracle:-MISSING}] files=[$(printf '%s' "$files" | tr '\n' '|')] passed=$passed skipped=$skipped failed=$failed timedout=$timedout errors=[$errors]"
+  echo "$name: oracle=[${oracle:-MISSING}] files=[$(printf '%s' "$files" | tr '\n' '|')] passed=$passed skipped=$skipped failed=$failed timedout=$timedout unhandled=$unhandled runner_rpc_timeouts=${rpc:-0} errors=[$errors]"
   if [ -z "$oracle" ] || [ -z "$files" ]; then
     echo "$name: UNREADABLE"
     mark_unreadable
   elif [ "$oracle" = "COUNT_ORACLE GREEN expected=$expected actual=$expected" ] \
-       && [ "$failed" -eq 0 ] && [ "$timedout" -eq 0 ] \
+       && [ "$failed" -eq 0 ] && [ "$timedout" -eq 0 ] && [ "$unhandled" -eq 0 ] \
        && [ $((passed + skipped)) -eq "$expected" ]; then
     echo "$name: GREEN"
   else