ticketlens 0.9.13 → 0.9.14

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ticketlens",
-  "version": "0.9.13",
+  "version": "0.9.14",
   "description": "Jira CLI for developers — fetch ticket context, triage your queue, and stop tab-switching. Zero dependencies, all local.",
   "type": "module",
   "bin": {

package/skills/jtb/scripts/lib/attachment-downloader.mjs

@@ -11,6 +11,21 @@ import { DEFAULT_CONFIG_DIR } from './config.mjs';
 const MAX_ATTACHMENTS = 20;
 const MAX_FILE_BYTES = 10 * 1024 * 1024; // 10 MB
 
+// Blocks redirect targets to private/internal addresses (SSRF via redirect).
+// Mirrors BLOCKED_PATTERNS in jira-client.mjs; kept local to avoid coupling.
+const BLOCKED_REDIRECT_PATTERNS = [
+  /^127\./, /^10\./, /^172\.(1[6-9]|2\d|3[01])\./, /^192\.168\./,
+  /^169\.254\./, /^0\.0\.0\.0$/, /^::1$/, /^::ffff:/i, /^fc00:/i, /^fe80:/i, /^localhost$/i,
+];
+
+function isSafeRedirectUrl(url) {
+  let parsed;
+  try { parsed = new URL(url); } catch { return false; }
+  if (parsed.protocol !== 'https:') return false;
+  const hostname = parsed.hostname.replace(/^\[|\]$/g, '');
+  return !BLOCKED_REDIRECT_PATTERNS.some(re => re.test(hostname));
+}
+
 /**
  * @param {object} ticket         Normalized ticket (from normalizeTicket)
  * @param {object} opts
@@ -83,10 +98,23 @@ export async function downloadAttachments(ticket, opts = {}) {
       onProgress?.(`  download  ${a.filename}`);
       try {
         const headers = buildAuthHeader(env);
-        // Default redirect:'follow' — Jira Cloud attachment URLs may redirect to CDN/S3
-        // presigned URLs. The SSRF guard above already validates the initial URL is on
-        // the configured Jira origin, which is the relevant security boundary here.
-        const response = await fetcher(a.content, { headers });
+        // Probe with redirect:'manual' to intercept any redirect before following it.
+        // Validates the redirect target against BLOCKED_REDIRECT_PATTERNS so a
+        // Jira-origin URL that redirects to a private IP (e.g. 169.254.x.x) is rejected.
+        const probe = await fetcher(a.content, { headers, redirect: 'manual' });
+        let response;
+        if (probe.status >= 300 && probe.status < 400) {
+          const location = probe.headers?.get?.('location');
+          if (!location) throw new Error('Redirect without Location header');
+          const redirectUrl = new URL(location, a.content).href;
+          if (!isSafeRedirectUrl(redirectUrl)) {
+            throw new Error(`Redirect to blocked host (${new URL(redirectUrl).hostname}) rejected`);
+          }
+          // Safe CDN/S3 redirect — follow without auth (presigned URLs are self-authorizing)
+          response = await fetcher(redirectUrl, { redirect: 'follow' });
+        } else {
+          response = probe;
+        }
         if (!response.ok) throw new Error(`HTTP ${response.status} (${response.statusText})`);
         const buffer = await response.arrayBuffer();
         fs.writeFileSync(localPath, Buffer.from(buffer));