ticketlens 0.42.2 → 0.42.4

package/README.md

@@ -1121,6 +1121,7 @@ npm test
 See [ROADMAP.md](ROADMAP.md) for the full plan.
 
 Recently shipped:
+- **`review`/`compliance` fixes** — branch diff now uses merge-base semantics, no longer picks up unrelated unmerged-main files; AC parser now recognizes Jira wiki `Requirements`/`How to test` headers, not just literal "Acceptance Criteria"
 - **`ticketlens update --priority`** — a bad priority name now tells you the project's real, current valid options instead of a bare tracker error
 - **`ticketlens assign --to="name or email"`** — assign a ticket to another developer, not just yourself. Jira (Cloud + Server/DC); searches real assignable users first, lists matches, executes only on one confirmed match. Pro tier
 - **Console: Recall "select all N matching" bulk delete** — Gmail-style banner deletes every note matching your search/filters across all pages, not just the current one

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ticketlens",
-  "version": "0.42.2",
+  "version": "0.42.4",
   "description": "Jira CLI for developers — fetch ticket context, triage your queue, and stop tab-switching. Zero dependencies, all local.",
   "type": "module",
   "bin": {

package/skills/jtb/hooks/recall-auto-capture.mjs

@@ -29,7 +29,7 @@ import { appendFileSync } from 'node:fs';
 import { join } from 'node:path';
 import { isLicensed } from '../scripts/lib/license.mjs';
 import { readCliToken } from '../scripts/lib/cli-auth.mjs';
-import { buildCaptureExcerpt, privateTmpDir } from './recall-nudge-lib.mjs';
+import { buildCaptureExcerpt, privateTmpDir, writeLastCaptureAt } from './recall-nudge-lib.mjs';
 import { autoCapture } from '../scripts/lib/summarizer.mjs';
 import { runNoteAdd } from '../scripts/lib/note-command.mjs';
 import { DEFAULT_CONFIG_DIR } from '../scripts/lib/config.mjs';
@@ -56,17 +56,20 @@ function logLine(message) {
  * @param {string} opts.transcriptPath
  * @param {string} [opts.ticketKey]
  * @param {string} [opts.configDir]
+ * @param {string} [opts.cwd] - directory whose shared capture marker gets updated on a real capture (backlog #44: makes a successful background capture visible to a later sync Stop check, which otherwise has no way to know this ran)
  * @returns {Promise<{outcome: 'skipped'|'captured'|'not-written'|'error', reason?: string, title?: string, error?: string}>}
  */
 export async function runAutoCapture({
   transcriptPath,
   ticketKey,
   configDir = DEFAULT_CONFIG_DIR,
+  cwd = process.cwd(),
   isLicensedFn = isLicensed,
   readCliTokenFn = readCliToken,
   buildCaptureExcerptFn = buildCaptureExcerpt,
   autoCaptureFn = autoCapture,
   runNoteAddFn = runNoteAdd,
+  writeLastCaptureAtFn = writeLastCaptureAt,
 } = {}) {
   if (!isLicensedFn('pro', configDir)) {
     logLine('skipped: not licensed');
@@ -112,10 +115,16 @@ export async function runAutoCapture({
   });
 
   logLine(written ? `captured: ${result.title}` : `not-written: ${result.title}`);
+  if (written) writeLastCaptureAtFn(cwd, Date.now());
   return written ? { outcome: 'captured', title: result.title } : { outcome: 'not-written', title: result.title };
 }
 
 if (import.meta.url === `file://${process.argv[1]}`) {
-  const [, , transcriptPath, ticketKeyArg] = process.argv;
-  runAutoCapture({ transcriptPath, ticketKey: ticketKeyArg || undefined }).catch(() => { /* never escape — nothing is watching this process */ });
+  // cwdArg (backlog #44 code review): passed explicitly by the spawning Stop
+  // hook rather than relying on this child's own process.cwd() — Node
+  // resolves process.cwd() through symlinks, so a cwd with a symlinked
+  // component would otherwise hash to a different marker file than the one
+  // a later Stop's hasRecentCapture(cwd) reads, silently breaking the bridge.
+  const [, , transcriptPath, ticketKeyArg, cwdArg] = process.argv;
+  runAutoCapture({ transcriptPath, ticketKey: ticketKeyArg || undefined, cwd: cwdArg || undefined }).catch(() => { /* never escape — nothing is watching this process */ });
 }

package/skills/jtb/hooks/recall-nudge-stop.mjs

@@ -89,11 +89,31 @@ if (!sessionId || !transcriptPath) process.exit(0);
 
 const { sawFetch, sawMutatingAction, sawRecallFlag, sawNoteAdd, ticketKey } = scanTranscript(transcriptPath);
 const cliToken = readCliToken();
+// Backlog #44 (9th/10th reports): entitled accounts already run the async
+// auto-capture judge below — throttled to at most once per CAPTURE_FRESHNESS_MS
+// per cwd (hasRecentAutoCaptureAttempt below), not on every single Stop. Once
+// it succeeds, its outcome is now visible via writeLastCaptureAt
+// (recall-auto-capture.mjs) to a LATER Stop's hasRecentCapture() check — but
+// THIS Stop's own decision below still can't see an attempt spawned moments
+// ago (detached, still running), nor is a fresh one spawned if the window's
+// one attempt already ran and moved on. For that residual window, a hard
+// block duplicates a safety net that's already in flight or already spent:
+// exit 0 instead of 2 so this never blocks the turn for these accounts. Free
+// tier has no such net, so it keeps the hard block unchanged — this is its
+// only enforcement.
+const hasSafetyNet = isLicensed('pro') && Boolean(cliToken);
 
-if (isLicensed('pro') && cliToken && !hasRecentAutoCaptureAttempt(cwd)) {
+if (hasSafetyNet && !hasRecentAutoCaptureAttempt(cwd)) {
   try {
     writeLastAutoCaptureAttemptAt(cwd, Date.now());
-    const child = spawn(process.execPath, [AUTO_CAPTURE_SCRIPT, transcriptPath, ticketKey ?? ''], {
+    // cwd is passed explicitly as argv (not left to the child's own
+    // process.cwd()) — code review finding: Node resolves process.cwd()
+    // through symlinks, so a cwd with any symlink component (macOS os.tmpdir()
+    // itself, an iCloud-synced Desktop, a Docker bind mount) would make the
+    // child's own process.cwd() differ from the string used here, hashing to
+    // a different marker file and silently breaking the bridge this fix exists
+    // to build.
+    const child = spawn(process.execPath, [AUTO_CAPTURE_SCRIPT, transcriptPath, ticketKey ?? '', cwd], {
       cwd,
       detached: true,
       stdio: 'ignore',
@@ -156,4 +176,7 @@ if (sawRecallFlag) {
     '`ticketlens note add`. If genuinely nothing qualified, just say so — then finish.\n',
   );
 }
-process.exit(2);
+// hasSafetyNet: the message above is still written (a diagnostic trail if
+// the async job silently fails) but exit 0 means Claude Code never surfaces
+// it or blocks the turn — only exit 2 feeds stderr back (backlog #44).
+process.exit(hasSafetyNet ? 0 : 2);

package/skills/jtb/scripts/fetch-ticket.mjs

@@ -800,7 +800,7 @@ export async function run(args, envOrOpts = process.env, fetcher = globalThis.fe
     const logResult = execFn('git', ['log', '--oneline', `${baseBranch}..HEAD`], { encoding: 'utf8', cwd, timeout: 10_000 });
     const commitMessages = logResult.status === 0 ? (logResult.stdout ?? '') : '';
 
-    const diffResult = execFn('git', ['diff', `${baseBranch}..HEAD`], { encoding: 'utf8', cwd, timeout: 30_000 });
+    const diffResult = execFn('git', ['diff', `${baseBranch}...HEAD`], { encoding: 'utf8', cwd, timeout: 30_000 });
     const diff = diffResult.status === 0 ? (diffResult.stdout || null) : null;
 
     const allText = [headBranch ?? '', commitMessages].join('\n');

package/skills/jtb/scripts/lib/branch-scanner.mjs

@@ -43,7 +43,7 @@ export function scanCurrentBranch({ cwd = process.cwd(), execFn = spawnSync, fsC
 
   let files = [];
   if (base) {
-    const diffOut = run(execFn, ['diff', '--name-only', `${base}..HEAD`], cwd);
+    const diffOut = run(execFn, ['diff', '--name-only', `${base}...HEAD`], cwd);
     if (diffOut) {
       files = diffOut.trim().split('\n').filter(Boolean).slice(0, MAX_FILES);
     }

package/skills/jtb/scripts/lib/requirement-extractor.mjs

@@ -9,8 +9,17 @@
 const RE_GWT           = /^\s*(given|when|then)\s+(.+)/i;
 const RE_MUST_ITEM     = /^\s*[-*•]\s+((?:must|should|shall|ensure|verify)\b.+|.+(?:must|should|shall|ensure|verify).+)/i;
 const RE_NUM_MUST      = /^\s*\d+[.)]\s+((?:must|should|shall|ensure|verify)\b.+|.+(?:must|should|shall|ensure|verify).+)/i;
-const RE_AC_HEADER     = /^\s*(?:#+\s*|h[1-6]\.\s*)?acceptance criteria\s*:?\s*$/i;
-const RE_HEADING       = /^\s*(?:#+|h[1-6]\.)\s+/i;
+// Matches "Acceptance Criteria" plus the two real-world Jira Server/DC section headers
+// (backlog #43) that carry the same content without that literal phrase: "Requirements"
+// and "How to test". A nested subheading (e.g. "h3. Validation range") does NOT match
+// this and still exits the section — known limitation, filed as a follow-up.
+const RE_AC_HEADER     = /^\s*(?:#+\s*|h[1-6]\.\s*)?(?:acceptance criteria|requirements|how to test)\s*:?\s*$/i;
+// Wiki-only (h1.-h6.) for section-exit detection — backlog #43: a leading markdown "#"
+// is indistinguishable from Jira Server/DC's "#" numbered-list marker (e.g. "# Run the
+// test suite."), so including it here closed real AC/how-to-test sections on their own
+// first list item. Entry detection (RE_AC_HEADER/RE_NON_AC_HEADER) is unaffected — those
+// still accept a markdown "#" prefix on the header line itself.
+const RE_HEADING       = /^\s*h[1-6]\.\s+/i;
 const RE_BULLET        = /^\s*[-*•]\s+(.+)/;
 const RE_NUM_ITEM      = /^\s*\d+[.)]\s+(.+)/;
 const RE_NUM_MARKER    = /^\s*(\d+)[.)]/;
@@ -101,7 +110,7 @@ export function extractRequirements(text) {
 
     if (RE_AC_HEADER.test(line)) { inAcSection = true; continue; }
 
-    // Exit on any explicit heading (markdown ## or wiki h2.) that is not the AC header
+    // Exit on any explicit heading (wiki h1.-h6. only, see RE_HEADING) that is not the AC header
     if (inAcSection && RE_HEADING.test(line) && !RE_AC_HEADER.test(line)) {
       inAcSection = false;
     }