ticketlens 0.1.15 → 0.1.17

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ticketlens",
-  "version": "0.1.15",
+  "version": "0.1.17",
   "description": "Jira CLI for developers — fetch ticket context, triage your queue, and stop tab-switching. Zero dependencies, all local.",
   "type": "module",
   "bin": {

package/skills/jtb/scripts/fetch-ticket.mjs

@@ -145,6 +145,135 @@ async function applySummarize(brief, args, opts, configDir, conn, licensedFn, up
   }
 }
 
+function makeSpinner(s) {
+  // setInterval won't fire while spawnSync blocks the event loop, so we draw
+  // synchronously on update() and only use setInterval during async fetch phases.
+  if (!process.stderr.isTTY) return { update: () => {}, startAnim: () => {}, done: () => {} };
+  const frames = ['⠋','⠙','⠹','⠸','⠼','⠴','⠦','⠧','⠇','⠏'];
+  let fi = 0, msg = '', lastW = 0, timerId = null, finished = false;
+
+  const draw = () => {
+    const raw = `  ${s.brand(frames[fi % frames.length])} ${s.dim(msg)}`;
+    const vis = raw.replace(/\x1b\[[0-9;]*m/g, '');
+    process.stderr.write(`\r${raw}${' '.repeat(Math.max(0, lastW - vis.length))}`);
+    lastW = vis.length;
+  };
+
+  return {
+    update(m) { if (!finished) { fi++; msg = m; draw(); } },
+    startAnim() {
+      if (finished || timerId) return;
+      timerId = setInterval(() => { if (!finished) { fi++; draw(); } }, 80);
+    },
+    done() {
+      if (finished) return;
+      finished = true;
+      if (timerId) { clearInterval(timerId); timerId = null; }
+      process.stderr.write('\r\x1b[2K');
+    },
+  };
+}
+
+function styleReviewMd(md, s) {
+  if (!s.enabled) return md;
+  const lines = md.split('\n');
+  const out = [];
+  let section = '';
+
+  for (const line of lines) {
+    if (line === '## PR Review Context') {
+      out.push('');
+      out.push(`  ${s.brand(s.bold('◆  PR Review Context'))}`);
+      out.push(`  ${s.dim('─'.repeat(50))}`);
+      section = 'header';
+      continue;
+    }
+
+    if (line.startsWith('### ')) {
+      const title = line.slice(4);
+      const fm = title.match(/^Changed files \((\d+)\)$/);
+      if (fm) {
+        out.push('');
+        out.push(`  ${s.bold('Changed files')} ${s.dim('(')}${s.yellow(fm[1])}${s.dim(')')}`);
+        section = 'changed-files';
+        continue;
+      }
+      const icons = { Branch: '⎇  ', 'Ticket context': '◉  ', 'Requirements coverage': '✦  ', 'Review focus': '▲  ' };
+      const icon = icons[title] ?? '';
+      out.push('');
+      out.push(`  ${s.bold(icon + title)}`);
+      section = title.toLowerCase().replace(/\s+/g, '-');
+      continue;
+    }
+
+    if (line.startsWith('#### ')) {
+      const inner = line.slice(5);
+      const covM = inner.match(/^([A-Z][A-Z0-9]+-\d+) \((\d+)%\)$/);
+      if (covM) {
+        const pct = parseInt(covM[2], 10);
+        const pctFmt = pct >= 75 ? s.green(`${pct}%`) : pct >= 50 ? s.yellow(`${pct}%`) : s.red(`${pct}%`);
+        out.push(`  ${s.cyan(s.bold(covM[1]))}  ${s.dim('coverage:')} ${pctFmt}`);
+        continue;
+      }
+      const tkM = inner.match(/^([A-Z][A-Z0-9]+-\d+)[: —–-]+(.*)$/);
+      if (tkM) {
+        out.push('');
+        out.push(`  ${s.cyan(s.bold(tkM[1]))}  ${s.dim(tkM[2].trim())}`);
+        continue;
+      }
+      out.push(line);
+      continue;
+    }
+
+    if (line.match(/^`[^`]+` → `[^`]+`$/)) {
+      const [h, b] = line.split(' → ');
+      out.push(`  ${s.cyan(h.replace(/`/g, ''))}  ${s.dim('→')}  ${s.dim(b.replace(/`/g, ''))}`);
+      continue;
+    }
+    if (line.match(/^→ `[^`]+`$/)) {
+      out.push(`  ${s.dim('(detached HEAD)')}  ${s.dim('→')}  ${s.dim(line.slice(4).replace(/`/g, ''))}`);
+      continue;
+    }
+
+    if (line.startsWith('- ✔ ')) {
+      const text = line.slice(4);
+      const di = text.lastIndexOf(' — ');
+      if (di > 0) out.push(`  ${s.green('✔')} ${text.slice(0, di)}${s.dim(' — ' + text.slice(di + 3))}`);
+      else out.push(`  ${s.green('✔')} ${text}`);
+      continue;
+    }
+    if (line.startsWith('- ✖ ')) { out.push(`  ${s.red('✖')} ${line.slice(4)}`); continue; }
+    if (line.startsWith('- ~ '))  { out.push(`  ${s.yellow('~')} ${s.dim(line.slice(4))}`); continue; }
+
+    if (line.startsWith('- ')) {
+      out.push(section === 'changed-files'
+        ? `  ${s.dim('·')} ${s.dim(line.slice(2))}`
+        : `  ${s.dim('·')} ${line.slice(2)}`);
+      continue;
+    }
+
+    if (line.startsWith('_') && line.endsWith('_') && line.length > 2) {
+      const inner = line.slice(1, -1);
+      if (inner.includes('No linked tickets found')) {
+        out.push(`  ${s.yellow('○')}  ${s.dim(inner)}`);
+      } else if (inner.includes('Requirements coverage analysis requires')) {
+        out.push(`  ${s.yellow('⚡')} ${s.dim(inner)}`);
+      } else if (inner.includes('Generated by TicketLens')) {
+        out.push(s.dim(inner));
+      } else {
+        out.push(`  ${s.dim(inner)}`);
+      }
+      continue;
+    }
+
+    if (line === '---') { out.push(`  ${s.dim('─'.repeat(50))}`); continue; }
+
+    out.push(line);
+  }
+
+  return out.join('\n');
+}
+
 const RETRY_OPTIONS = [
   { label: 'Retry',          sublabel: 'Try again — e.g. VPN just connected', value: 'retry'  },
   { label: 'Switch profile', sublabel: 'Use a different Jira profile',         value: 'switch' },
@@ -351,10 +480,51 @@ export async function run(args, envOrOpts = process.env, fetcher = globalThis.fe
     const execFn = opts.execFn ?? spawnSync;
     const cwd = process.cwd();
 
+    const sErr = createStyler({ isTTY: process.stderr.isTTY });
+
+    // Validate flags before any git work
+    const reviewFlags = args.slice(1);
+    const VALID_REVIEW_FLAG = /^(--base=.+|--profile=.+)$/;
+    for (const flag of reviewFlags) {
+      if (!flag.startsWith('-')) continue;
+      if (VALID_REVIEW_FLAG.test(flag)) continue;
+      // Detect --profile-NAME typo (dash instead of =)
+      const profileDashM = flag.match(/^--profile-(.+)$/);
+      if (profileDashM) {
+        process.stderr.write(`${sErr.red('✖')} Unknown flag: ${sErr.bold(flag)}\n  Did you mean ${sErr.cyan(`--profile=${profileDashM[1]}`)}?\n`);
+        process.exitCode = 1;
+        return;
+      }
+      const baseDashM = flag.match(/^--base-(.+)$/);
+      if (baseDashM) {
+        process.stderr.write(`${sErr.red('✖')} Unknown flag: ${sErr.bold(flag)}\n  Did you mean ${sErr.cyan(`--base=${baseDashM[1]}`)}?\n`);
+        process.exitCode = 1;
+        return;
+      }
+      process.stderr.write(`${sErr.red('✖')} Unknown flag: ${sErr.bold(flag)}\n  Usage: ${sErr.cyan('ticketlens review [--base=BRANCH] [--profile=NAME]')}\n`);
+      process.exitCode = 1;
+      return;
+    }
+
+    const spinner = makeSpinner(sErr);
+    const stderrNotes = [];
+
     // Resolve base branch: --base=BRANCH or auto-detect main/master/develop
-    const baseArg = args.find(a => a.startsWith('--base='));
+    const baseArg = reviewFlags.find(a => a.startsWith('--base='));
     let baseBranch = baseArg ? baseArg.split('=')[1] : null;
-    if (!baseBranch) {
+
+    spinner.update('Scanning branch…');
+
+    if (baseBranch) {
+      // Explicit --base: verify the branch exists
+      const verifyR = execFn('git', ['rev-parse', '--verify', baseBranch], { encoding: 'utf8', cwd, timeout: 5_000 });
+      if (verifyR.status !== 0) {
+        spinner.done();
+        process.stderr.write(`${sErr.red('✖')} Branch "${baseBranch}" not found in this repository.\n`);
+        process.exitCode = 1;
+        return;
+      }
+    } else {
       for (const candidate of ['main', 'master', 'develop']) {
         const r = execFn('git', ['rev-parse', '--verify', candidate], { encoding: 'utf8', cwd, timeout: 5_000 });
         if (r.status === 0) { baseBranch = candidate; break; }
@@ -362,28 +532,47 @@ export async function run(args, envOrOpts = process.env, fetcher = globalThis.fe
       baseBranch = baseBranch ?? 'main';
     }
 
-    // Current branch name
     const headResult = execFn('git', ['branch', '--show-current'], { encoding: 'utf8', cwd, timeout: 5_000 });
     const headBranch = headResult.status === 0 ? (headResult.stdout.trim() || null) : null;
 
-    // Commits in range
+    if (headBranch && headBranch === baseBranch) {
+      stderrNotes.push(
+        `  ${sErr.yellow('⚠')}  You are on ${sErr.cyan(headBranch)} — switch to a feature branch for meaningful output.`
+      );
+    }
+
     const logResult = execFn('git', ['log', '--oneline', `${baseBranch}..HEAD`], { encoding: 'utf8', cwd, timeout: 10_000 });
     const commitMessages = logResult.status === 0 ? (logResult.stdout ?? '') : '';
 
-    // Diff between base and HEAD
     const diffResult = execFn('git', ['diff', `${baseBranch}..HEAD`], { encoding: 'utf8', cwd, timeout: 30_000 });
     const diff = diffResult.status === 0 ? (diffResult.stdout || null) : null;
 
-    // Extract ticket keys from branch name + commit messages
     const allText = [headBranch ?? '', commitMessages].join('\n');
     const ticketKeys = extractTicketKeys(allText);
 
-    // Fetch tickets (best-effort — gracefully degrade if no credentials)
-    const profileArgR = args.find(a => a.startsWith('--profile='));
+    const profileArgR = reviewFlags.find(a => a.startsWith('--profile='));
     const profileNameR = profileArgR ? profileArgR.split('=')[1] : undefined;
+
+    // Validate explicit --profile exists before attempting any fetch
+    if (profileNameR) {
+      const profiles = loadProfiles(resolvedConfigDir);
+      if (!profiles?.profiles?.[profileNameR]) {
+        spinner.done();
+        process.stderr.write(`${sErr.red('✖')} Profile "${profileNameR}" not found.\n`);
+        const names = Object.keys(profiles?.profiles ?? {});
+        if (names.length > 0) process.stderr.write(`  ${sErr.dim('Available:')} ${names.join(', ')}\n`);
+        else process.stderr.write(`  Run ${sErr.cyan('ticketlens init')} to configure a profile.\n`);
+        process.exitCode = 1;
+        return;
+      }
+    }
+
+    // Fetch tickets (best-effort) — start animation here since fetch is async
     const tickets = [];
 
     if (ticketKeys.length > 0) {
+      spinner.update(`Fetching ticket context (${ticketKeys.length} key${ticketKeys.length > 1 ? 's' : ''})…`);
+      spinner.startAnim();
       const connR = resolveConnection(ticketKeys[0], {
         env,
         configDir: resolvedConfigDir,
@@ -398,15 +587,24 @@ export async function run(args, envOrOpts = process.env, fetcher = globalThis.fe
         for (const key of ticketKeys) {
           try {
             tickets.push(await adapterR.fetchTicket(key, { depth: 0 }));
-          } catch { /* non-fatal — skip ticket */ }
+          } catch (err) {
+            stderrNotes.push(`  ${sErr.yellow('⚠')} ${key}: ${err.message ?? 'fetch failed'}`);
+          }
         }
       } else {
-        process.stderr.write(
-          `Note: Found tickets [${ticketKeys.join(', ')}] but no profile configured. Run 'ticketlens init' to set up.\n`
+        stderrNotes.push(
+          `  ${sErr.yellow('○')} Found tickets [${ticketKeys.join(', ')}] but no profile configured. Run 'ticketlens init' to set up.`
         );
       }
+    } else if (profileNameR) {
+      stderrNotes.push(
+        `  ${sErr.dim('Note:')} --profile=${profileNameR} specified but no ticket keys found in branch or commits.`
+      );
     }
 
+    spinner.done();
+    for (const note of stderrNotes) process.stderr.write(note + '\n');
+
     const isLic = opts.isLicensedFn ?? ((tier) => isLicensed(tier, resolvedConfigDir));
     const assembleFn = opts.assemblePrReviewFn ?? assemblePrReview;
 
@@ -419,7 +617,9 @@ export async function run(args, envOrOpts = process.env, fetcher = globalThis.fe
       analyzeDiffFn: analyzeDiff,
       extractRequirementsFn: extractRequirements,
     });
-    printFn(md + '\n');
+
+    const sOut = createStyler({ isTTY: process.stdout.isTTY });
+    printFn((sOut.enabled ? styleReviewMd(md, sOut) : md) + '\n');
     return;
   }
 

package/skills/jtb/scripts/lib/cli.mjs

@@ -82,6 +82,10 @@ export function parseCommand(args) {
     return { command: 'compliance', args: args.slice(1) };
   }
 
+  if (first === 'review') {
+    return { command: 'review', args: args.slice(1) };
+  }
+
   if (first === 'login') {
     return { command: 'login', args: args.slice(1) };
   }