ti2-tourplan 1.0.40 → 1.0.42

package/index.js

@@ -104,6 +104,11 @@ class Plugin {
         regExp: /.+/,
       },
     });
+    this.cacheSettings = {
+      bookingsProductSearch: {
+        skipTTL: true,
+      },
+    };
     this.callTourplan = async ({
       model,
       endpoint,
@@ -165,13 +170,14 @@ class Plugin {
       }
       const requestType = R.keys(model)[0];
       if (!replyObj) throw new Error(`${requestType} failed: ${errorStr || 'no reply object'}`);
-      const error = replyObj.error || R.path(['Reply', 'ErrorReply', 'Error'], replyObj);
+      let error = replyObj.error || R.path(['Reply', 'ErrorReply', 'Error'], replyObj);
       if (error) {
-        if (error.indexOf('2050 SCN Request denied for TEST connecting from') > -1
-          && requestType === 'OptionInfoRequest'
-          && endpoint.indexOf('actour') > -1
-        ) {
-          return 'useFixture';
+        if (error.includes('DateFrom in the past')) {
+          error = '1002 - Date is in the past';
+        } else if (error.includes('1052 SCN')) {
+          error = '1052 - OptionId not found(Check if it is Internet Enabled)';
+        } else if (error.includes('SCN Server overloaded')) {
+          error = "2051 - The Tourplan server is unavailable. Please wait a minute and try again. If you keep getting this error, please contact your team's Tourplan administrator or Tourplan support."
         }
         throw new Error(`${requestType} failed: ${error}`);
       }
@@ -437,57 +443,57 @@ class Plugin {
       xmlOptions: hostConnectXmlOptions,
     };
     // use cache if we are getting the full list
+    // for example: for searchInput (backend search), we shouldn't get the full list from 
+    // tourplan each time user search
     const replyObj = optionId
       ? await this.callTourplan(payload)
       : await this.cache.getOrExec({
         fnParams: [model],
         fn: () => this.callTourplan(payload),
-        ttl: 60 * 60 * 24, // 24 hours
+        ttl: 60 * 60 * 2, // 2 hours
         forceRefresh: Boolean(forceRefresh),
       });
-    let products = [];
-    if (replyObj === 'useFixture') {
-      products = require('./__fixtures__/fullacoptionlist.json');
-    } else {
-      products = R.call(R.compose(
-        R.map(optionsGroupedBySupplierId => {
-          const OptGeneral = R.pathOr({}, [0, 'OptGeneral'], optionsGroupedBySupplierId);
-          const supplierData = {
-            supplierId: R.path(['SupplierId'], OptGeneral),
-            supplierName: R.path(['SupplierName'], OptGeneral),
-            supplierAddress: `${R.pathOr('', ['Address1'], OptGeneral)}, ${R.pathOr('', ['Address2'], OptGeneral)},  ${R.pathOr('', ['Address3'], OptGeneral)}, ${R.pathOr('', ['Address4'], OptGeneral)}, ${R.pathOr('', ['Address5'], OptGeneral)}`,
-            serviceTypes: R.uniq(optionsGroupedBySupplierId.map(R.path(['OptGeneral', 'ButtonName']))),
-          };
-          return translateTPOption({
-            supplierData,
-            optionsGroupedBySupplierId,
-            typeDefs: productTypeDefs,
-            query: productQuery,
-          });
-        }),
-        R.values,
-        R.groupBy(R.path(['OptGeneral', 'SupplierId'])),
-        root => {
-          if (!searchInput) return root;
-          const getFullSearchStr = o => {
-            const fullPptionName = `${R.path(['OptGeneral', 'Description'], o) || ''}-${R.path(['OptGeneral', 'Comment'], o) || ''}`;
-            return `${R.path(['OptGeneral', 'SupplierName'], o) || ''} ${fullPptionName} ${R.path(['Opt'], o)} ${R.path(['OptGeneral', 'SupplierId'], o) || ''}`;
-          };
-          const inputValueLower = searchInput.trim().toLowerCase();
-          const parts = inputValueLower.split(' ').filter(Boolean); // Filter out any empty strings just in case
-          return root.filter(option => {
-            const fullSearchStr = getFullSearchStr(option).toLowerCase();
-            return parts.every(part => fullSearchStr.includes(part));
-          });
-        },
-        root => {
-          const options = R.pathOr([], ['OptionInfoReply', 'Option'], root);
-          // due to the new parser, single option will be returned as an object
-          // instead of an array
-          if (Array.isArray(options)) return options;
-          return [options];
-        },
-      ), replyObj);
+    const products = R.call(R.compose(
+      R.map(optionsGroupedBySupplierId => {
+        const OptGeneral = R.pathOr({}, [0, 'OptGeneral'], optionsGroupedBySupplierId);
+        const supplierData = {
+          supplierId: R.path(['SupplierId'], OptGeneral),
+          supplierName: R.path(['SupplierName'], OptGeneral),
+          supplierAddress: `${R.pathOr('', ['Address1'], OptGeneral)}, ${R.pathOr('', ['Address2'], OptGeneral)},  ${R.pathOr('', ['Address3'], OptGeneral)}, ${R.pathOr('', ['Address4'], OptGeneral)}, ${R.pathOr('', ['Address5'], OptGeneral)}`,
+          serviceTypes: R.uniq(optionsGroupedBySupplierId.map(R.path(['OptGeneral', 'ButtonName']))),
+        };
+        return translateTPOption({
+          supplierData,
+          optionsGroupedBySupplierId,
+          typeDefs: productTypeDefs,
+          query: productQuery,
+        });
+      }),
+      R.values,
+      R.groupBy(R.path(['OptGeneral', 'SupplierId'])),
+      root => {
+        if (!searchInput) return root;
+        const getFullSearchStr = o => {
+          const fullPptionName = `${R.path(['OptGeneral', 'Description'], o) || ''}-${R.path(['OptGeneral', 'Comment'], o) || ''}`;
+          return `${R.path(['OptGeneral', 'SupplierName'], o) || ''} ${fullPptionName} ${R.path(['Opt'], o)} ${R.path(['OptGeneral', 'SupplierId'], o) || ''}`;
+        };
+        const inputValueLower = searchInput.trim().toLowerCase();
+        const parts = inputValueLower.split(' ').filter(Boolean); // Filter out any empty strings just in case
+        return root.filter(option => {
+          const fullSearchStr = getFullSearchStr(option).toLowerCase();
+          return parts.every(part => fullSearchStr.includes(part));
+        });
+      },
+      root => {
+        const options = R.pathOr([], ['OptionInfoReply', 'Option'], root);
+        // due to the new parser, single option will be returned as an object
+        // instead of an array
+        if (Array.isArray(options)) return options;
+        return [options];
+      },
+    ), replyObj);
+    if (!(products && products.length)) {
+      throw new Error('No products found');
     }
     return {
       products,
@@ -675,8 +681,7 @@ class Plugin {
           ...(puInfo.time && puInfo.time.replace(/\D/g, '') ? {
             puTime: puInfo.time.replace(/\D/g, ''),
           } : {}),
-          puRemark: this.escapeInvalidXmlChars(`${puInfo.time ? `Time: ${puInfo.time || 'NA'},` : ''}
-          ${puInfo.location ? `Location: ${puInfo.location || 'NA'},` : ''}
+          puRemark: this.escapeInvalidXmlChars(`${puInfo.location ? `Location: ${puInfo.location || 'NA'},` : ''}
           ${puInfo.flightDetails ? `Flight: ${puInfo.flightDetails || 'NA'},` : ''}
           `),
         } : {}),
@@ -685,8 +690,7 @@ class Plugin {
           ...(doInfo.time && doInfo.time.replace(/\D/g, '') ? {
             doTime: doInfo.time.replace(/\D/g, ''),
           } : {}),
-          doRemark: this.escapeInvalidXmlChars(`${doInfo.time ? `Time: ${doInfo.time || 'NA'},` : ''}
-          ${doInfo.location ? `Location: ${doInfo.location || 'NA'},` : ''}
+          doRemark: this.escapeInvalidXmlChars(`${doInfo.location ? `Location: ${doInfo.location || 'NA'},` : ''}
           ${doInfo.flightDetails ? `Flight: ${doInfo.flightDetails || 'NA'},` : ''}
           `),
         } : {}),

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ti2-tourplan",
-  "version": "1.0.40",
+  "version": "1.0.42",
   "description": "Tourplan's TI2 Plugin",
   "main": "index.js",
   "scripts": {