thurview 0.14.0 → 0.16.0

package/dist/ui/app.js

@@ -1135,6 +1135,7 @@
     root.appendChild(
       kind() === "explainer" ? coveragePanel(state.data?.coverage ?? null) : interfaceDelta(doc.interfaces)
     );
+    if (kind() === "review") root.appendChild(securityPanel(doc.security));
     const layout = h("div", { class: "doc-layout" });
     const toc = h(
       "nav",
@@ -1208,6 +1209,7 @@
   }
   var DELTA_BLOCK = "interface-delta";
   var COVERAGE_BLOCK = "coverage";
+  var SECURITY_BLOCK = "security";
   var DELTA_SHOWN = 12;
   var CHANGE_CLASS = {
     removed: "del",
@@ -1350,6 +1352,80 @@
       wrap.appendChild(h("div", { class: "thread-pins" }, threads.map(threadPinRow)));
     return wrap;
   }
+  function securityPanel(sec) {
+    const wrap = h("div", { class: "block ifd", "data-block": SECURITY_BLOCK });
+    const threads = threadsFor((t) => t.type === "document" && t.blockId === SECURITY_BLOCK);
+    if (threads.length) wrap.classList.add("has-threads");
+    const actions = h(
+      "div",
+      { class: "block-actions" },
+      h(
+        "button",
+        {
+          class: threads.length ? "count" : "",
+          title: "Comment on the trust boundaries",
+          onclick: (e) => {
+            if (state.viewingRevision !== null) return;
+            popover(commentPopover({ type: "document", blockId: SECURITY_BLOCK }), {
+              x: e.pageX + 10,
+              y: e.pageY
+            });
+          }
+        },
+        threads.length ? String(threads.length) : "+"
+      )
+    );
+    const body = h("div", { class: "ifd-body" });
+    const toggle = h("span", { class: "heading-toggle" }, "hide");
+    toggle.addEventListener("click", () => {
+      const hidden = body.hidden;
+      body.hidden = !hidden;
+      toggle.textContent = hidden ? "hide" : "show";
+    });
+    const badge = !sec ? null : sec.state === "none" ? h("span", { class: "badge ok" }, "none") : sec.state === "pending" ? h("span", { class: "badge warn" }, "not assessed") : h("span", { class: "badge warn" }, `${sec.crossings.length} crossed`);
+    wrap.appendChild(
+      h(
+        "div",
+        { class: "ifd-head" },
+        h("span", { class: "t" }, "Trust boundaries"),
+        badge,
+        h("span", { class: "spacer" }),
+        toggle,
+        actions
+      )
+    );
+    body.appendChild(
+      h(
+        "p",
+        { class: "ifd-verdict" },
+        sec ? sec.verdict : "Unavailable: this revision carries no security dimension."
+      )
+    );
+    for (const c of sec?.crossings ?? []) {
+      const anchor = state.data?.document?.anchors[c.anchor];
+      if (!anchor) continue;
+      body.appendChild(
+        h(
+          "div",
+          {
+            class: "ifd-entry",
+            title: `Open ${anchor.title}`,
+            onclick: () => openAnchorPeek(anchor)
+          },
+          h("div", { class: "ifd-what" }, h("div", { class: "ifd-cap" }, c.boundary)),
+          h(
+            "span",
+            { class: "ifd-where mono" },
+            anchor.peek ? `${anchor.peek.file}:${anchor.peek.from}` : anchor.title
+          )
+        )
+      );
+    }
+    wrap.appendChild(body);
+    if (threads.length)
+      wrap.appendChild(h("div", { class: "thread-pins" }, threads.map(threadPinRow)));
+    return wrap;
+  }
   function interfaceRow(e) {
     const anchor = kind() === "design" && e.anchor ? state.data?.document?.anchors[e.anchor] : null;
     return h(
@@ -2646,18 +2722,9 @@
   async function home() {
     clear(app);
     const reviews = await api.reviews();
-    const el = h("div", { class: "home" }, h("h2", null, "Reviews, explainers and designs"));
+    const el = h("div", { class: "home" }, h("h2", null, "Queue"));
     const active = reviews.filter((r) => !r.dismissed);
     const dismissed = reviews.filter((r) => r.dismissed);
-    const item = (r) => h(
-      "div",
-      { class: "item", onclick: () => location.href = `/review/${r.id}` },
-      h("span", { class: "t" }, r.title),
-      h("span", { class: `badge ${statusClass2(r.status)}` }, r.status),
-      r.openThreads ? h("span", { class: "badge accent" }, `${r.openThreads} open`) : null,
-      h("span", { class: "muted mono", style: { fontSize: "12px" } }, bindingLabel(r)),
-      h("span", { class: "muted", style: { fontSize: "12px" } }, timeAgo(r.updatedAt))
-    );
     if (!active.length)
       el.appendChild(
         h(
@@ -2666,13 +2733,75 @@
           "Nothing published yet. Ask your agent for a review of a change, an explainer of the codebase, or a design of what to build next."
         )
       );
-    active.forEach((r) => el.appendChild(item(r)));
+    const groups = /* @__PURE__ */ new Map();
+    for (const r of active) groups.set(r.queue.repo, [...groups.get(r.queue.repo) ?? [], r]);
+    for (const [repo, rows] of groups) {
+      const yours = rows.filter((r) => r.queue.turn === "you").length;
+      el.appendChild(
+        h(
+          "h3",
+          { class: "repo" },
+          repo,
+          yours ? h("span", { class: "badge accent" }, `${yours} your turn`) : null
+        )
+      );
+      rows.forEach((r) => el.appendChild(queueItem(r)));
+    }
     if (dismissed.length) {
       el.appendChild(h("h3", { class: "muted" }, "Dismissed"));
-      dismissed.forEach((r) => el.appendChild(item(r)));
+      dismissed.forEach((r) => el.appendChild(queueItem(r)));
     }
     app.appendChild(el);
   }
+  var TURN = { you: "your turn", agent: "agent", nobody: "nobody" };
+  var DECISION = { approve: "approved", "request-changes": "changes requested", close: "closed" };
+  function queueItem(r) {
+    const q = r.queue;
+    const cr = q.change;
+    const age = q.factsAt ? `forge read ${timeAgo(q.factsAt)}` : cr ? "forge not read yet" : "";
+    return h(
+      "div",
+      { class: "item", onclick: () => location.href = `/review/${r.id}` },
+      h("span", { class: `badge turn ${q.turn === "you" ? "accent" : ""}` }, TURN[q.turn]),
+      h(
+        "span",
+        { class: "t" },
+        r.title,
+        h("span", { class: "why" }, [r.kind ?? "review", q.why, age].filter(Boolean).join(" \xB7 "))
+      ),
+      cr ? h(
+        "a",
+        {
+          class: "mono muted cr",
+          href: cr.url ?? void 0,
+          target: "_blank",
+          rel: "noopener",
+          onclick: (e) => e.stopPropagation()
+        },
+        `#${cr.number}${cr.state && cr.state !== "open" ? ` ${cr.state}` : ""}`
+      ) : h("span", { class: "mono muted" }, bindingLabel(r)),
+      r.openThreads ? h("span", { class: "badge accent" }, `${r.openThreads} open`) : null,
+      q.pin ? h(
+        "span",
+        { class: `badge ${q.pin === "behind" ? "warn" : "ok"}` },
+        q.pin === "behind" ? "pin behind head" : "at head"
+      ) : null,
+      q.decision ? h(
+        "span",
+        {
+          class: `badge ${q.decision.posted === false ? "warn" : ""}`,
+          title: q.decision.posted === null ? null : q.decision.posted ? "posted to the change request" : "not posted to the change request yet"
+        },
+        DECISION[q.decision.decision] + (q.decision.posted === null ? "" : q.decision.posted ? " \xB7 posted" : " \xB7 not posted")
+      ) : null,
+      q.ci ? h(
+        "span",
+        { class: `badge ${q.ci.trustworthy ? "ok" : "warn"}`, title: q.ci.verdict },
+        q.ci.trustworthy ? "CI gates" : "CI not a gate"
+      ) : null,
+      h("span", { class: "muted", style: { fontSize: "12px" } }, timeAgo(r.updatedAt))
+    );
+  }
   function bindingLabel(r) {
     if (r.binding.kind === "pr") return `PR #${r.binding.name}`;
     if (r.binding.kind === "codebase") return r.binding.name === "**" ? "codebase" : r.binding.name;