thurview 0.11.1 → 0.13.0

package/dist/ui/app.js

@@ -165,10 +165,12 @@
   // src/ui/state.ts
   var VIEWS = {
     review: ["review", "commits", "files", "map"],
-    explainer: ["review", "map", "coverage"]
+    explainer: ["review", "map", "coverage"],
+    design: ["review", "map"]
   };
   function kind() {
-    return state.data?.review.kind === "explainer" ? "explainer" : "review";
+    const k = state.data?.review.kind;
+    return k === "explainer" || k === "design" ? k : "review";
   }
   function view() {
     const allowed = VIEWS[kind()];
@@ -268,7 +270,8 @@
   }
   function commentPopover(target, quote) {
     const ta = h("textarea", { placeholder: "Comment, or a question for the agent\u2026" });
-    const held = kind() === "explainer" ? "Add to my notes" : "Add to the review";
+    const k = kind();
+    const held = k === "explainer" ? "Add to my notes" : k === "design" ? "Add to my decision" : "Add to the review";
     const submit = async (mode) => {
       const body = ta.value.trim();
       if (!body) return;
@@ -315,7 +318,7 @@
         h(
           "div",
           null,
-          `${held} \u2014 held until you ${kind() === "explainer" ? "send the document back or finish" : "submit the review"}.`
+          `${held} \u2014 held until you ${k === "explainer" ? "send the document back or finish" : k === "design" ? "approve the design or send it back" : "submit the review"}.`
         )
       )
     );
@@ -541,8 +544,9 @@
   }
   function submitDialog() {
     const pending = (state.data?.threads ?? []).filter((t) => !t.submitted).length;
-    const explainer = kind() === "explainer";
-    const words = explainer ? { title: "Send this back or finish", accept: "Done reading", back: "Send it back" } : { title: "Submit review", accept: "Approve", back: "Request changes" };
+    const k = kind();
+    const explainer = k === "explainer";
+    const words = k === "explainer" ? { title: "Send this back or finish", accept: "Done reading", back: "Send it back" } : k === "design" ? { title: "Decide on this design", accept: "Approve the design", back: "Send it back" } : { title: "Submit review", accept: "Approve", back: "Request changes" };
     const ta = h("textarea", { rows: 4, placeholder: "Summary for the agent (optional)" });
     const d = dialog(
       h(
@@ -562,7 +566,7 @@
           h(
             "button",
             {
-              title: explainer ? "End it without reading it through" : "End the review without approving it",
+              title: explainer ? "End it without reading it through" : k === "design" ? "Drop this design without deciding on it" : "End the review without approving it",
               onclick: () => decide("close")
             },
             "Close"
@@ -803,6 +807,8 @@
     const p = current;
     if (!p) return;
     const inChanges = !!state.data?.changes.some((c) => c.path === p.path);
+    const hasFiles = VIEWS[kind()].includes("files");
+    const openFile = () => navigate("files", { path: p.path, line: p.highlightLine ?? p.from, side: p.graph });
     const head = h(
       "div",
       { class: "side-head" },
@@ -813,23 +819,20 @@
         h(
           "div",
           {
-            class: "path",
+            class: `path${hasFiles ? "" : " inert"}`,
             title: p.path,
-            onclick: () => navigate("files", { path: p.path, line: p.highlightLine ?? p.from, side: p.graph })
+            ...hasFiles ? { onclick: openFile } : {}
           },
           `${p.path}:${p.from}-${p.to}`,
           " ",
           h("span", { class: `badge ${p.graph === "base" ? "del" : ""}` }, p.graph)
         )
       ),
-      h(
+      hasFiles ? h(
         "button",
-        {
-          class: "small",
-          onclick: () => navigate("files", { path: p.path, line: p.highlightLine ?? p.from, side: p.graph })
-        },
+        { class: "small", onclick: openFile },
         inChanges ? "Open in Files" : "Open file"
-      ),
+      ) : null,
       h(
         "button",
         {
@@ -1212,6 +1215,7 @@
     added: "ok"
   };
   function interfaceDelta(delta) {
+    const design = kind() === "design";
     const wrap = h("div", { class: "block ifd", "data-block": DELTA_BLOCK });
     const threads = threadsFor((t) => t.type === "document" && t.blockId === DELTA_BLOCK);
     if (threads.length) wrap.classList.add("has-threads");
@@ -1222,7 +1226,7 @@
         "button",
         {
           class: threads.length ? "count" : "",
-          title: "Comment on the interface delta",
+          title: design ? "Comment on what this design proposes" : "Comment on the interface delta",
           onclick: (e) => {
             if (state.viewingRevision !== null) return;
             popover(commentPopover({ type: "document", blockId: DELTA_BLOCK }), {
@@ -1246,7 +1250,7 @@
       h(
         "div",
         { class: "ifd-head" },
-        h("span", { class: "t" }, "Interface delta"),
+        h("span", { class: "t" }, design ? "What this design proposes" : "Interface delta"),
         counts.map(([c, n]) => h("span", { class: `badge ${CHANGE_CLASS[c]}` }, `${n} ${c}`)),
         h("span", { class: "spacer" }),
         toggle,
@@ -1257,7 +1261,7 @@
       h(
         "p",
         { class: "ifd-verdict" },
-        delta ? delta.verdict : "Unavailable: the code graph could not be built for these commits."
+        delta ? delta.verdict : design ? "Unavailable: this revision declared no proposal." : "Unavailable: the code graph could not be built for these commits."
       )
     );
     const entries = delta?.entries ?? [];
@@ -1347,12 +1351,13 @@
     return wrap;
   }
   function interfaceRow(e) {
+    const anchor = kind() === "design" && e.anchor ? state.data?.document?.anchors[e.anchor] : null;
     return h(
       "div",
       {
         class: `ifd-entry ifd-${e.change}`,
-        title: "Open in Files",
-        onclick: () => navigate("files", { path: e.file, line: e.line, side: e.graph })
+        title: anchor ? `Open ${anchor.title}` : "Open in Files",
+        onclick: () => anchor ? openAnchorPeek(anchor) : navigate("files", { path: e.file, line: e.line, side: e.graph })
       },
       h("span", { class: `badge ${CHANGE_CLASS[e.change]}` }, e.change),
       h(
@@ -1362,7 +1367,11 @@
         h("code", { class: "ifd-name" }, e.name),
         e.capability ? h("div", { class: "ifd-cap" }, e.capability) : null
       ),
-      h("span", { class: "ifd-where mono" }, `${e.file}:${e.line}`)
+      h(
+        "span",
+        { class: "ifd-where mono", title: anchor ? "Where it lands in the code today" : null },
+        `${anchor ? "at " : ""}${e.file}:${e.line}`
+      )
     );
   }
   function scrollToBlock(id) {
@@ -1415,9 +1424,12 @@
                 "div",
                 { class: "frame-head" },
                 h("span", { class: "title" }, a.title),
+                // Only a review has a Files tab; on the other kinds this would
+                // navigate to a tab that does not exist and bounce the reader to
+                // the document, so it offers nothing rather than offering that.
                 h(
                   "span",
-                  {
+                  VIEWS[kind()].includes("files") ? {
                     class: "path",
                     title: "Open in Files",
                     onclick: () => navigate("files", {
@@ -1425,7 +1437,7 @@
                       line: a.peek.from,
                       side: a.peek.graph
                     })
-                  },
+                  } : { class: "path inert" },
                   `${a.peek.file}:${a.peek.from}-${a.peek.to}`
                 ),
                 h("span", { class: `badge ${a.peek.graph === "base" ? "del" : ""}` }, a.peek.graph),
@@ -2009,6 +2021,7 @@
   function renderMap(root) {
     const map = state.data?.map;
     const explainer = kind() === "explainer";
+    const design = kind() === "design";
     if (!map || !map.head.nodes.length) {
       append(root, [
         explainer ? h(
@@ -2025,17 +2038,17 @@
         ) : h(
           "div",
           { class: "empty-state" },
-          h("p", null, "No map in this review."),
+          h("p", null, design ? "No map in this design." : "No map in this review."),
           h(
             "p",
             null,
-            "The map places a change inside the system and shows what sits next to it. ",
-            "A change that lands in one place, where the Files tab already answers that, ships without one."
+            design ? "The map is where a design shows the shape it proposes: the parts it would add, change or remove, beside the structure as it stands. A design that changes one part in place ships without one." : "The map places a change inside the system and shows what sits next to it. A change that lands in one place, where the Files tab already answers that, ships without one."
           )
         )
       ]);
       return;
     }
+    const unmarked = design && !map.base;
     const headNodes = new Map(map.head.nodes.map((n) => [n.id, n]));
     const baseNodes = new Map((map.base?.nodes ?? []).map((n) => [n.id, n]));
     const all = collect(map);
@@ -2083,18 +2096,20 @@
       return h(
         "div",
         { class: "map-intro" },
-        h("h2", null, "Where the change landed"),
+        h("h2", null, design ? "The shape this design proposes" : "Where the change landed"),
         h(
           "p",
           null,
-          "The Files tab has the lines. This has the parts of the system they landed in, and what",
-          " those parts connect to \u2014 the neighbours a diff never names. Marked parts are the change;",
-          " the rest is the context you need to judge it."
+          unmarked ? "These are the parts the design proposes. Nothing is marked added, changed or removed: the document declares no structure as it stands to compare them against." : design ? "Marked parts are what the design would add, change or remove; the rest is the structure as it stands, which is what it has to fit." : "The Files tab has the lines. This has the parts of the system they landed in, and what those parts connect to \u2014 the neighbours a diff never names. Marked parts are the change; the rest is the context you need to judge it."
         ),
         h(
           "div",
           { class: "map-route" },
-          marks.length ? marks.map(([n, cls, word]) => h("span", { class: `badge ${cls}` }, `${n} ${word}`)) : h("span", { class: "muted" }, "This change touched no part of the map."),
+          marks.length ? marks.map(([n, cls, word]) => h("span", { class: `badge ${cls}` }, `${n} ${word}`)) : unmarked ? null : h(
+            "span",
+            { class: "muted" },
+            design ? "This design changes no part of the map." : "This change touched no part of the map."
+          ),
           route ? h(
             "button",
             {
@@ -2103,7 +2118,9 @@
             },
             `Start at ${route.label} \u203A`
           ) : null,
-          map.base ? null : h(
+          // On a design the paragraph above already says this, so saying it again
+          // two lines down is the same sentence twice.
+          map.base || unmarked ? null : h(
             "span",
             { class: "muted" },
             "No base map, so changed means touched by the diff and nothing reads as added or removed."
@@ -2129,7 +2146,7 @@
       return h(
         "div",
         {
-          class: `map-node ${n.status} ${explainer || touched(all, n) ? "" : "quiet"} ${n.id === selected ? "selected" : ""}`,
+          class: `map-node ${n.status} ${explainer || unmarked || touched(all, n) ? "" : "quiet"} ${n.id === selected ? "selected" : ""}`,
           onclick: () => navigate("map", { node: n.id }),
           ondblclick: () => inside && openLevel(n.id)
         },
@@ -2167,19 +2184,26 @@
         title ? h("h3", null, title) : null,
         h("div", { class: "map-grid" }, items.map(card))
       ) : null;
-      if (explainer) return group(null, kids) ?? h("div", null);
+      if (explainer || unmarked) return group(null, kids) ?? h("div", null);
       if (!hot.length)
         return h(
           "div",
           null,
-          h("div", { class: "map-note muted" }, "Nothing here was touched. The change is elsewhere."),
+          h(
+            "div",
+            { class: "map-note muted" },
+            design ? "Nothing here changes. The design is elsewhere." : "Nothing here was touched. The change is elsewhere."
+          ),
           group(null, cold)
         );
       return h(
         "div",
         null,
-        group(cold.length ? "What the change touched" : null, hot),
-        group("Context \u2014 unchanged here", cold)
+        group(
+          cold.length ? design ? "What the design changes" : "What the change touched" : null,
+          hot
+        ),
+        group(design ? "Context \u2014 untouched by the design" : "Context \u2014 unchanged here", cold)
       );
     };
     const links2 = () => {
@@ -2206,7 +2230,7 @@
         h(
           "div",
           { class: "muted map-note" },
-          explainer ? "A link is a dependency the parts have on each other, drawn as the author declared it." : "A link touching a changed part is where the two sides can fall out of step."
+          explainer ? "A link is a dependency the parts have on each other, drawn as the author declared it." : unmarked ? "A link is a dependency the design says the parts would have on each other." : design ? "A link touching a part the design changes is where the two sides can fall out of step." : "A link touching a changed part is where the two sides can fall out of step."
         ),
         rankEdges(folded, all).map(
           ({ edge, touchesChange }) => h(
@@ -2241,7 +2265,7 @@
           h(
             "div",
             { class: "muted" },
-            explainer ? "Pick a part to see what it owns, the code behind it, and what it connects to." : "Pick a part to see what changed in it, the code behind it, and what it connects to."
+            explainer || unmarked ? "Pick a part to see what it owns, the code behind it, and what it connects to." : design ? "Pick a part to see what the design changes in it, the code behind it, and what it connects to." : "Pick a part to see what changed in it, the code behind it, and what it connects to."
           )
         );
         return;
@@ -2622,7 +2646,7 @@
   async function home() {
     clear(app);
     const reviews = await api.reviews();
-    const el = h("div", { class: "home" }, h("h2", null, "Reviews and explainers"));
+    const el = h("div", { class: "home" }, h("h2", null, "Reviews, explainers and designs"));
     const active = reviews.filter((r) => !r.dismissed);
     const dismissed = reviews.filter((r) => r.dismissed);
     const item = (r) => h(
@@ -2639,7 +2663,7 @@
         h(
           "div",
           { class: "empty-state" },
-          "Nothing published yet. Ask your agent for a review of a change, or an explainer of the codebase."
+          "Nothing published yet. Ask your agent for a review of a change, an explainer of the codebase, or a design of what to build next."
         )
       );
     active.forEach((r) => el.appendChild(item(r)));
@@ -2693,9 +2717,9 @@
     const r = d.review;
     const pending = d.threads.filter((t) => !t.submitted).length;
     const open = d.threads.filter((t) => t.status === "open").length;
-    const explainer = kind() === "explainer";
+    const k = kind();
     const labels = {
-      review: explainer ? "Explainer" : "Review",
+      review: k === "explainer" ? "Explainer" : k === "design" ? "Design" : "Review",
       commits: "Commits",
       files: `Files${d.changes.length ? ` (${d.changes.length})` : ""}`,
       map: "Map",
@@ -2826,7 +2850,7 @@
       h(
         "div",
         { class: "item muted" },
-        kind() === "explainer" ? `commit ${r.pins.head.slice(0, 12)}` : `base ${r.pins.base.slice(0, 12)} \xB7 head ${r.pins.head.slice(0, 12)}`
+        kind() === "review" ? `base ${r.pins.base.slice(0, 12)} \xB7 head ${r.pins.head.slice(0, 12)}` : `commit ${r.pins.head.slice(0, 12)}`
       ),
       h(
         "div",