thurview 0.1.4 → 0.2.0

package/dist/ui/app.css

@@ -261,23 +261,45 @@ kbd {
   background: var(--bg2);
 }
 
+/* 100dvh, not 100%: mobile browser chrome shrinks the viewport as it scrolls. */
 #app {
   display: flex;
   flex-direction: column;
-  height: 100%;
+  height: 100dvh;
 }
-/* HUD top bar */
+/* HUD top bar: an identity row that truncates over an actions row that never does. */
 .topbar {
   display: flex;
-  align-items: center;
-  gap: 12px;
-  padding: 0 16px;
-  height: 52px;
+  flex-direction: column;
   background: var(--hud-bg);
   border-bottom: 2px solid var(--hud-deep);
   box-shadow: inset 0 -1px 0 0 rgb(232 24 11 / 0.45);
-  flex-wrap: nowrap;
-  overflow: hidden;
+}
+.bar-row {
+  display: flex;
+  align-items: center;
+  gap: 12px;
+  padding: 0 16px;
+  min-height: 44px;
+  min-width: 0;
+}
+.bar-identity {
+  border-bottom: 1px solid var(--line2);
+}
+.bar-actions {
+  gap: 8px;
+  overflow-x: auto;
+  scrollbar-width: none;
+}
+.bar-actions::-webkit-scrollbar {
+  display: none;
+}
+.bar-more {
+  margin-left: 0;
+}
+.bar-identity > *,
+.bar-actions > * {
+  flex: none;
 }
 .topbar .brand {
   font-family: var(--font-display);
@@ -287,12 +309,14 @@ kbd {
   text-shadow: var(--glow-red);
   letter-spacing: 0.02em;
   white-space: nowrap;
+  flex: none;
 }
 .topbar .brand:hover {
   text-shadow:
     var(--glow-red),
     0 0 20px rgb(255 59 48 / 0.6);
 }
+/* Grows into the space it has, truncating only when it must; full text in the tooltip. */
 .topbar .title {
   font-family: var(--font-mono);
   font-weight: 700;
@@ -300,19 +324,12 @@ kbd {
   white-space: nowrap;
   overflow: hidden;
   text-overflow: ellipsis;
-  max-width: 28vw;
-}
-.topbar > * {
-  flex: none;
-}
-.topbar .title {
-  flex: 0 1 auto;
-  min-width: 60px;
+  flex: 1 1 auto;
+  min-width: 3rem;
 }
 .topbar .tabs {
   display: flex;
   gap: 2px;
-  margin-left: 8px;
 }
 .tabs button {
   border: none;
@@ -1413,3 +1430,213 @@ kbd {
   font-family: var(--font-mono);
   font-size: 13px;
 }
+
+/* ---- Small screens ----
+   One column below 900px: the table-of-contents rail, the split diff and the
+   docked side panel all assume a second column that is not there. Touch has no
+   hover either, so anything revealed by hovering is made permanent instead. */
+@media (max-width: 900px) {
+  .bar-row {
+    gap: 8px;
+    padding: 0 10px;
+    min-height: 40px;
+  }
+  .topbar .title {
+    font-size: 13px;
+  }
+  .bar-binding {
+    display: none;
+  }
+  /* Only the tabs scroll: Threads and the decision must stay reachable without
+     the reader discovering that the bar scrolls sideways. */
+  .bar-actions {
+    overflow: visible;
+  }
+  .bar-actions .tabs {
+    flex: 1 1 auto;
+    min-width: 0;
+    overflow-x: auto;
+    scrollbar-width: none;
+  }
+  .bar-actions .tabs::-webkit-scrollbar {
+    display: none;
+  }
+  .bar-actions .spacer {
+    display: none;
+  }
+  button {
+    padding: 7px 9px;
+  }
+  button.small {
+    padding: 5px 7px;
+  }
+
+  /* The rail is dropped rather than squeezed; headings stay reachable by scrolling. */
+  .doc-layout {
+    grid-template-columns: minmax(0, 1fr);
+    gap: 0;
+    padding: 16px 14px 64px;
+  }
+  .toc {
+    display: none;
+  }
+  .doc h1 {
+    font-size: clamp(0.62rem, 3.4vw, 0.95rem);
+    line-height: 1.7;
+  }
+  .doc h2 {
+    font-size: clamp(0.55rem, 2.8vw, 0.8rem);
+    margin-top: 28px;
+  }
+  /* Right-aligned control strip: a left gutter would sit off-screen, and a
+     column of buttons down the left of every paragraph is noise. */
+  .block > .block-actions {
+    position: static;
+    display: flex;
+    justify-content: flex-end;
+    opacity: 0.75;
+    margin: 0 0 2px;
+  }
+  .block-actions button {
+    width: auto;
+    height: 22px;
+    padding: 0 8px;
+    font-size: 0.45rem;
+  }
+
+  /* A peek or a thread takes the screen; both already carry a close button. */
+  .side {
+    position: fixed;
+    inset: 0;
+    width: auto;
+    max-width: none;
+    min-width: 0;
+    z-index: 40;
+    border-left: none;
+  }
+  .resizer {
+    display: none;
+  }
+  /* The sheet's only way out, so it gets a real touch target. */
+  .side-head {
+    min-height: 44px;
+  }
+  .side-head button.ghost {
+    min-width: 40px;
+    font-size: 0.7rem;
+  }
+
+  /* Files: the list becomes a strip above the diff. */
+  .files-layout {
+    flex-direction: column;
+  }
+  .file-list {
+    width: 100%;
+    min-width: 0;
+    max-height: 30vh;
+    border-right: none;
+    border-bottom: 1px solid var(--hud-edge);
+  }
+  .file-view .file-head {
+    flex-wrap: wrap;
+    gap: 6px 10px;
+    padding: 8px 10px;
+  }
+  .file-head .hint {
+    display: none;
+  }
+
+  /* Map: the inspector stacks under the board. */
+  .map-layout {
+    flex-direction: column;
+  }
+  .map-canvas {
+    padding: 14px;
+  }
+  .map-side {
+    width: 100%;
+    border-left: none;
+    border-top: 1px solid var(--hud-edge);
+  }
+  .map-grid {
+    grid-template-columns: minmax(0, 1fr);
+  }
+
+  .commits {
+    padding: 14px;
+  }
+  .home {
+    padding: 18px 14px;
+  }
+  .home .item {
+    flex-wrap: wrap;
+    gap: 6px 10px;
+  }
+  .dblens .body {
+    grid-template-columns: minmax(0, 1fr);
+  }
+  .dialog {
+    padding: 14px;
+  }
+  .comment-popover {
+    width: min(92vw, 400px);
+  }
+  .thread-pin {
+    flex-wrap: wrap;
+  }
+}
+
+/* Phones: frames give back their outer margin so the content keeps the width. */
+@media (max-width: 520px) {
+  .doc-layout {
+    padding: 12px 10px 56px;
+  }
+  .code-frame,
+  .diagram {
+    margin-left: -4px;
+    margin-right: -4px;
+  }
+  .bar-rev,
+  .topbar select {
+    display: none;
+  }
+  .doc h3 {
+    font-size: 14px;
+  }
+  /* Give the title the space the brand and the status chip do not need. */
+  .topbar .brand {
+    font-size: 0.6rem;
+  }
+  .bar-identity .badge {
+    font-size: 10px;
+    padding: 1px 5px;
+  }
+}
+
+/* Coarse pointers cannot hover, so affordances are shown outright. */
+@media (hover: none) {
+  .block > .block-actions {
+    opacity: 1;
+  }
+  .code td.ln::after {
+    content: none;
+  }
+}
+
+/* Wide enough for one bar: the second row would only add height. */
+@media (min-width: 1100px) {
+  .topbar {
+    flex-direction: row;
+    align-items: stretch;
+  }
+  .bar-identity {
+    border-bottom: none;
+    flex: 1 1 auto;
+    min-width: 0;
+  }
+  .bar-actions {
+    flex: none;
+    padding-left: 0;
+    overflow: visible;
+  }
+}

package/dist/ui/app.js

@@ -162,6 +162,10 @@
   init_dom();
 
   // src/ui/state.ts
+  var NARROW = "(max-width: 900px)";
+  function isNarrow() {
+    return window.matchMedia(NARROW).matches;
+  }
   var state = {
     id: "",
     data: null,
@@ -1352,6 +1356,7 @@
       return;
     }
     view.innerHTML = "";
+    const split = state.splitDiff && inChanges && !isNarrow();
     const toggle = h(
       "button",
       {
@@ -1391,7 +1396,7 @@
           },
           fileThreads.length ? `File comments (${fileThreads.length})` : "Comment on file"
         ) : null,
-        inChanges ? toggle : h("span", { class: "badge" }, `full file at ${side2}`)
+        inChanges ? isNarrow() ? null : toggle : h("span", { class: "badge" }, `full file at ${side2}`)
       )
     );
     if (fileThreads.length)
@@ -1409,7 +1414,7 @@
     const threads = (state.data?.threads ?? []).filter(
       (t) => t.target.type === "file" && t.target.path === path
     );
-    const el = state.splitDiff && inChanges ? splitView(d, threads) : unifiedView(d, threads);
+    const el = split ? splitView(d, threads) : unifiedView(d, threads);
     view.appendChild(el);
     codeSelectionHandler(view);
     if (line) {
@@ -2043,20 +2048,22 @@
           `rev ${n}${n === r.revision ? " (current)" : ""}`
         )
       );
-    append(topbar, [
+    const identity = h("div", { class: "bar-row bar-identity" }, [
       h("a", { href: "/", class: "brand", title: "All reviews" }, "thurview"),
-      h("span", { class: "title" }, r.title),
+      h("span", { class: "title", title: r.title }, r.title),
       h("span", { class: `badge ${statusClass(r.status)}` }, r.status),
-      r.revision > 1 ? revSel : h("span", { class: "badge" }, `rev ${r.revision}`),
+      r.revision > 1 ? revSel : h("span", { class: "badge bar-rev" }, `rev ${r.revision}`),
       h(
         "span",
         {
-          class: "muted mono",
+          class: "muted mono bar-binding",
           style: { fontSize: "12px" },
           title: `${r.pins.base} \u2192 ${r.pins.head}`
         },
         r.binding.kind === "pr" ? `PR #${r.binding.name}` : r.binding.name
-      ),
+      )
+    ]);
+    const actions = h("div", { class: "bar-row bar-actions" }, [
       h(
         "div",
         { class: "tabs" },
@@ -2079,10 +2086,15 @@
       isTerminal() || state.viewingRevision !== null ? null : h(
         "button",
         { class: pending ? "primary" : "ok", onclick: () => submitDialog() },
-        pending ? `Submit review (${pending})` : "Approve / Request changes"
+        pending ? `Submit${pending ? ` (${pending})` : ""}` : "Decide"
       ),
-      h("button", { class: "ghost", title: "More", onclick: (e) => moreMenu(e) }, "\u22EF")
+      h(
+        "button",
+        { class: "ghost bar-more", title: "More", onclick: (e) => moreMenu(e) },
+        "\u22EF"
+      )
     ]);
+    append(topbar, [identity, actions]);
   }
   function moreMenu(e) {
     const r = state.data.review;
@@ -2293,6 +2305,7 @@
       readHash();
       emit("view");
     });
+    window.matchMedia(NARROW).addEventListener("change", () => emit("view"));
     emit("data");
     connectEvents();
   }