thumbgate 1.34.2 → 1.35.0

package/server.json

@@ -8,13 +8,13 @@
     "source": "github",
     "url": "https://github.com/IgorGanapolsky/ThumbGate"
   },
-  "version": "1.34.2",
+  "version": "1.35.0",
   "packages": [
     {
       "registryType": "npm",
       "registryBaseUrl": "https://registry.npmjs.org",
       "identifier": "thumbgate",
-      "version": "1.34.2",
+      "version": "1.35.0",
       "runtimeHint": "npx",
       "runtimeArguments": [
         {

package/src/api/server.js

@@ -195,6 +195,10 @@ const {
   writeDashboardReviewState,
   collectAllFeedbackEntries,
 } = require('../../scripts/dashboard');
+const {
+  isDashboardDataLimitError,
+  formatDashboardLimitDetail,
+} = require('../../scripts/dashboard-limits');
 const {
   collectAggregateLogEntries,
   computeAggregateFeedbackStats,
@@ -883,7 +887,7 @@ function hashDataIdentity(prefix, value) {
 }
 
 function buildHostedTenantIdentity(validation = {}) {
-  if (!validation || validation.valid !== true || !validation.customerId) return null;
+  if (validation?.valid !== true || !validation.customerId) return null;
   const tenantSeed = validation.customerId;
   const principalSeed = validation.installId || tenantSeed;
   const tenantId = hashDataIdentity('tenant', tenantSeed);
@@ -1820,11 +1824,20 @@ function buildWorkflowIntakeQueue(parsed, workflowSprintIntake, feedbackDir, opt
 }
 
 function sendInvalidAnalyticsWindowProblem(res, title, err) {
+  if (isDashboardDataLimitError(err)) {
+    sendProblem(res, {
+      type: PROBLEM_TYPES.INTERNAL,
+      title: 'Dashboard data too large',
+      status: 503,
+      detail: formatDashboardLimitDetail(err, { phase: 'assembly' }),
+    });
+    return;
+  }
   sendProblem(res, {
     type: PROBLEM_TYPES.INVALID_REQUEST,
     title,
     status: 400,
-    detail: err?.message ? err.message : 'Invalid analytics window request.',
+    detail: err && err.message ? err.message : 'Invalid analytics window request.',
   });
 }
 
@@ -2775,32 +2788,37 @@ function getTrackedLinkTarget(slug) {
     : null;
 }
 
-function appendTrackedLinkQueryParams(destinationUrl, parsed, target) {
-  const params = parsed.searchParams;
+function applyTrackedLinkDefaults(destinationUrl, target) {
   for (const [key, value] of Object.entries(target.defaults || {})) {
     if (!destinationUrl.searchParams.has(key)) {
       appendQueryParam(destinationUrl, key, value);
     }
   }
+}
+
+function applyTrackedLinkQueryKeys(destinationUrl, params) {
   for (const key of TRACKED_LINK_QUERY_KEYS) {
     const value = params.get(key);
-    if (value && value.trim()) {
-      const normalizedValue = key === 'utm_campaign'
-        ? normalizeCampaignId(value)
-        : value.trim();
-      destinationUrl.searchParams.set(key, normalizedValue);
-    }
-  }
-  if (target.allowCustomerEmail) {
-    const customerEmail = normalizeCheckoutCustomerEmail(params.get('customer_email'));
-    if (customerEmail) {
-      appendQueryParam(
-        destinationUrl,
-        target.prefillStripeEmail ? 'prefilled_email' : 'customer_email',
-        customerEmail
-      );
-    }
+    if (!value || !value.trim()) continue;
+    const normalizedValue = key === 'utm_campaign'
+      ? normalizeCampaignId(value)
+      : value.trim();
+    destinationUrl.searchParams.set(key, normalizedValue);
   }
+}
+
+function applyTrackedLinkCustomerEmail(destinationUrl, params, target) {
+  if (!target.allowCustomerEmail) return;
+  const customerEmail = normalizeCheckoutCustomerEmail(params.get('customer_email'));
+  if (!customerEmail) return;
+  appendQueryParam(
+    destinationUrl,
+    target.prefillStripeEmail ? 'prefilled_email' : 'customer_email',
+    customerEmail,
+  );
+}
+
+function applyTrackedLinkCtaDefaults(destinationUrl, target) {
   if (!destinationUrl.searchParams.has('cta_id')) {
     appendQueryParam(destinationUrl, 'cta_id', target.ctaId);
   }
@@ -2812,6 +2830,14 @@ function appendTrackedLinkQueryParams(destinationUrl, parsed, target) {
   }
 }
 
+function appendTrackedLinkQueryParams(destinationUrl, parsed, target) {
+  const params = parsed.searchParams;
+  applyTrackedLinkDefaults(destinationUrl, target);
+  applyTrackedLinkQueryKeys(destinationUrl, params);
+  applyTrackedLinkCustomerEmail(destinationUrl, params, target);
+  applyTrackedLinkCtaDefaults(destinationUrl, target);
+}
+
 function buildTrackedLinkDestination(target, hostedConfig, parsed) {
   const configuredHref = target.configUrlKey ? hostedConfig[target.configUrlKey] : null;
   const href = target.href || configuredHref || target.fallbackHref;
@@ -3006,7 +3032,21 @@ function resolveCheckoutOfferSummary(metadata = {}) {
 
 function sendJson(res, statusCode, payload, extraHeaders = {}, options = {}) {
   const { headOnly = false } = options;
-  const body = JSON.stringify(payload);
+  let body;
+  try {
+    body = JSON.stringify(payload);
+  } catch (err) {
+    if (isDashboardDataLimitError(err)) {
+      sendProblem(res, {
+        type: PROBLEM_TYPES.INTERNAL,
+        title: 'Dashboard response too large',
+        status: 503,
+        detail: formatDashboardLimitDetail(err, { phase: 'stringify' }),
+      });
+      return;
+    }
+    throw err;
+  }
   res.writeHead(statusCode, {
     'Content-Type': 'application/json; charset=utf-8',
     'X-Content-Type-Options': 'nosniff',
@@ -5169,6 +5209,23 @@ function isBillingSummaryAuthorized(req, expectedAdminKey, expectedOperatorKey)
   return false;
 }
 
+/** Read-only paths the operator key may access (CLI dashboard / CFO / north-star). */
+const OPERATOR_READONLY_GET_PATHS = new Set([
+  '/v1/billing/summary',
+  '/v1/dashboard',
+  '/v1/dashboard/render-spec',
+  '/v1/dashboard/ai-inventory',
+  '/v1/dashboard/review-state',
+  '/v1/intake/workflow-sprint/queue',
+  '/v1/task-outcomes/monitor',
+]);
+
+function isOperatorReadonlyGet(req, expectedOperatorKey, pathname) {
+  if (!expectedOperatorKey || req.method !== 'GET') return false;
+  if (!OPERATOR_READONLY_GET_PATHS.has(pathname)) return false;
+  return safeKeyEqual(extractApiKey(req), expectedOperatorKey);
+}
+
 function extractTags(input) {
   if (Array.isArray(input)) return input;
   if (typeof input === 'string') {
@@ -8736,19 +8793,8 @@ a{color:#8b9}</style></head><body><form class="card" method="post" action="/oaut
       return;
     }
 
-    // Operator key is allowed to bypass the general admin gate for dedicated
-    // read-only operational endpoints.
-    const _reqToken = extractApiKey(req);
-    const isOperatorReadRequest = Boolean(expectedOperatorKey)
-      && safeKeyEqual(_reqToken, expectedOperatorKey)
-      && req.method === 'GET'
-      && [
-        '/v1/billing/summary',
-        '/v1/intake/workflow-sprint/queue',
-        '/v1/task-outcomes/monitor',
-      ].includes(pathname);
-
-    if (!isOperatorReadRequest && !isAuthorized(req, expectedApiKey)) {
+    // Operator key: read-only operational endpoints only (see OPERATOR_READONLY_GET_PATHS).
+    if (!isOperatorReadonlyGet(req, expectedOperatorKey, pathname) && !isAuthorized(req, expectedApiKey)) {
       sendProblem(res, {
         type: PROBLEM_TYPES.UNAUTHORIZED,
         title: 'Unauthorized',