thumbgate 1.31.0 → 1.34.0

package/scripts/vector-store.js

@@ -10,6 +10,7 @@ const {
 } = require('./local-model-profile');
 const {
   prepareEmbeddingText,
+  normalizeEmbeddingKind,
   resolveGeminiEmbeddingConfig,
   resolveGeminiModelResource,
   resolveGeminiTaskType,
@@ -110,7 +111,7 @@ function hasSemanticEmbeddingProvider() {
   if (hasLocalTransformerProvider()) return true;
   try {
     const config = resolveGeminiEmbeddingConfig();
-    return config.provider === 'coreai' || Boolean(config.enabled && config.apiKey);
+    return config.provider === 'coreai' || Boolean(config.apiKey);
   } catch {
     return false;
   }
@@ -211,7 +212,7 @@ async function embedWithGemini(text, options = {}) {
   }
 
   if (typeof fetch !== 'function') {
-    throw new Error('Gemini embeddings require global fetch. Use Node 18.18+ or the local embedding provider.');
+    throw new TypeError('Gemini embeddings require global fetch. Use Node 18.18+ or the local embedding provider.');
   }
 
   const modelResource = resolveGeminiModelResource(config.model);
@@ -291,7 +292,18 @@ async function embedWithOllama(text, options = {}) {
     throw new Error('Ollama embeddings require THUMBGATE_OLLAMA_EMBED_MODEL');
   }
   if (typeof fetch !== 'function') {
-    throw new Error('Ollama embeddings require global fetch. Use Node 18.18+.');
+    throw new TypeError('Ollama embeddings require global fetch. Use Node 18.18+.');
+  }
+
+  // Apply Nomic-style asymmetric prefixes. nomic-embed-text was trained
+  // with "search_query:" / "search_document:" role prefixes, which improve
+  // query-document matching fidelity on the dense retrieval path.
+  const kind = normalizeEmbeddingKind(options.kind);
+  let inputText = String(text || '');
+  if (kind === 'query') {
+    inputText = `search_query: ${inputText}`;
+  } else if (kind === 'document') {
+    inputText = `search_document: ${inputText}`;
   }
 
   let response;
@@ -301,7 +313,7 @@ async function embedWithOllama(text, options = {}) {
       headers: { 'Content-Type': 'application/json' },
       body: JSON.stringify({
         model: config.model,
-        input: String(text || ''),
+        input: inputText,
         truncate: true,
         dimensions: options.outputDimensionality || undefined,
       }),
@@ -322,6 +334,39 @@ async function embedWithOllama(text, options = {}) {
   return vector.map(Number);
 }
 
+async function tryGeminiManagedEmbedding(text, options, geminiConfig) {
+  if (!geminiConfig.apiKey && !_geminiEmbedderForTests) {
+    return null;
+  }
+  try {
+    const vector = await embedWithGemini(text, options);
+    _lastEmbeddingProfile = {
+      generatedAt: new Date().toISOString(),
+      source: 'managed',
+      activeProfile: {
+        id: 'gemini',
+        model: geminiConfig.model,
+        outputDimensionality: geminiConfig.outputDimensionality,
+        task: options.task || geminiConfig.defaultTask,
+        rationale: geminiConfig.enabled
+          ? 'Managed Gemini Embedding 2 path with task-specific query/document prefixes.'
+          : 'Managed Gemini Embedding 2 fallback after local providers exhausted.',
+      },
+      fallbackUsed: !geminiConfig.enabled,
+      ...(!geminiConfig.enabled ? { fallbackReason: 'local_providers_exhausted' } : {}),
+    };
+    return vector;
+  } catch (geminiError) {
+    if (!geminiConfig.fallbackToLocal) {
+      throw geminiError;
+    }
+    // Do not log raw provider/user-controlled error text (Sonar jssecurity:S5145).
+    const code = geminiError && (geminiError.code || geminiError.name || 'Error');
+    console.warn(`Gemini embedding fallback: ${code}`);
+    return null;
+  }
+}
+
 async function embed(text, options = {}) {
   if (process.env.THUMBGATE_VECTOR_STUB_EMBED === 'true') {
     // Deterministic 384-dim unit vector: first element = 1.0, rest = 0.0
@@ -373,29 +418,8 @@ async function embed(text, options = {}) {
     }
   }
   if (geminiConfig.enabled) {
-    try {
-      const vector = await embedWithGemini(text, options);
-      _lastEmbeddingProfile = {
-        generatedAt: new Date().toISOString(),
-        source: 'managed',
-        activeProfile: {
-          id: 'gemini',
-          model: geminiConfig.model,
-          outputDimensionality: geminiConfig.outputDimensionality,
-          task: options.task || geminiConfig.defaultTask,
-          rationale: 'Managed Gemini Embedding 2 path with task-specific query/document prefixes.',
-        },
-        fallbackUsed: false,
-      };
-      return vector;
-    } catch (geminiError) {
-      if (!geminiConfig.fallbackToLocal) {
-        throw geminiError;
-      }
-      // Do not log raw provider/user-controlled error text (Sonar jssecurity:S5145).
-      const code = geminiError && (geminiError.code || geminiError.name || 'Error');
-      console.warn(`Gemini embedding fallback: ${code}`);
-    }
+    const vector = await tryGeminiManagedEmbedding(text, options, geminiConfig);
+    if (vector) return vector;
   }
   if (hasLocalTransformerProvider()) {
     try {
@@ -410,6 +434,14 @@ async function embed(text, options = {}) {
     }
   }
 
+  // Gemini managed fallback — only when API key present but Gemini is not the
+  // explicitly selected provider. Honors fallbackToLocal in the catch block
+  // so that THUMBGATE_GEMINI_EMBED_FALLBACK_LOCAL=false makes Gemini mandatory.
+  if (geminiConfig.apiKey && !geminiConfig.enabled) {
+    const vector = await tryGeminiManagedEmbedding(text, options, geminiConfig);
+    if (vector) return vector;
+  }
+
   const vector = embedWithFeatureHash(text);
   // Feature-hash is a last-resort degrade, not production semantic quality.
   // Callers (prove/eval/chat health) must treat quality_tier=degraded.
@@ -536,6 +568,7 @@ module.exports = {
   TABLE_NAME,
   getEmbeddingConfig,
   getLastEmbeddingProfile,
+  getActiveEmbeddingProfile: getLastEmbeddingProfile,
   setPipelineLoaderForTests,
   setLanceLoaderForTests,
   setGeminiEmbedderForTests,

package/scripts/workflow-sentinel.js

@@ -22,6 +22,11 @@ const {
   buildWorkflowControl,
   normalizeProviderAction,
 } = require('./provider-action-normalizer');
+const {
+  detectEconomicAction,
+  evaluateFinancialControl,
+  getFinancialControlRuntimeOptions,
+} = require('./financial-control-plane');
 
 const GOVERNANCE_STATE_PATH = path.join(process.env.HOME || '/tmp', '.thumbgate', 'governance-state.json');
 const DEFAULT_PROTECTED_FILE_GLOBS = [
@@ -40,7 +45,6 @@ const DEFAULT_PROTECTED_FILE_GLOBS = [
 const EDIT_LIKE_TOOLS = new Set(['Edit', 'Write', 'MultiEdit']);
 const HIGH_RISK_BASH_PATTERN = /\b(?:git\s+(?:add|commit|push)|gh\s+(?:pr\s+(?:create|merge)|workflow\s+run|release\s+create)|npm\s+publish|yarn\s+publish|pnpm\s+publish|rm\s+-rf)\b/i;
 const BACKGROUND_AGENT_PATTERN = /\b(?:async(?:-job|-task)?|autonomous|background|cron|dispatch|heartbeat|job runner|job-runner|queue|queued|schedule|scheduled|worker|workflow run)\b/i;
-const ECONOMIC_ACTION_PATTERN = /\b(?:billing|charge|credit memo|invoice|payment(?: link|s)?|payout|refund|stripe|subscription(?:s| creation| update| cancel| delete)?|top-?up)\b/i;
 const CUSTOMER_SYSTEM_PATTERN = /\b(?:crm|customer|email|hubspot|intercom|mailgun|resend|salesforce|support|zendesk)\b/i;
 
 const SURFACE_RULES = [
@@ -259,7 +263,7 @@ function classifyActionProfile(toolInput = {}) {
   const economicAction = Boolean(
     toolInput.economicAction === true
       || metadata.economicAction === true
-      || ECONOMIC_ACTION_PATTERN.test(combined)
+      || detectEconomicAction('', { ...toolInput, metadata: { ...metadata, context: combined } })
   );
   const customerSystemAction = Boolean(
     toolInput.customerSystemAction === true
@@ -573,6 +577,7 @@ function scoreRisk({
   taskScopeViolation,
   protectedSurface,
   costControl,
+  financialControl,
   workflowControl,
   workflowContract,
   actionProfile,
@@ -692,6 +697,15 @@ function scoreRisk({
       { mode: costControl.mode, reasons: costControl.reasons }
     );
   }
+  if (financialControl?.mode === 'block') {
+    addDriver(
+      drivers,
+      'financial_control',
+      0.65,
+      'Deterministic purchase controls rejected the economic action.',
+      { reasonCodes: financialControl.reasonCodes }
+    );
+  }
   if (workflowControl && workflowControl.workflow && workflowControl.workflow.pattern !== 'single_action') {
     const workflow = workflowControl.workflow;
     if (workflow.pattern === 'agent') {
@@ -814,6 +828,7 @@ function buildEvidence({
   protectedSurface,
   normalizedAction,
   costControl,
+  financialControl,
   workflowControl,
   workflowContract,
   actionProfile,
@@ -827,6 +842,13 @@ function buildEvidence({
   if (costControl && costControl.mode && costControl.mode !== 'allow') {
     evidence.push(`Cost control ${costControl.mode}: ${costControl.reasons.join(' ')}`);
   }
+  if (financialControl?.economicAction) {
+    evidence.push(
+      financialControl.mode === 'allow'
+        ? `Financial control allow: approved reservation ${financialControl.authorization?.reservationId || 'unknown'}.`
+        : `Financial control block: ${financialControl.reasons.join(' ')}`
+    );
+  }
   if (workflowControl && workflowControl.workflow && workflowControl.workflow.pattern !== 'single_action') {
     const workflow = workflowControl.workflow;
     evidence.push(
@@ -960,6 +982,7 @@ function buildRemediations({
   learnedPolicy,
   executionSurface,
   costControl,
+  financialControl,
   workflowControl,
   workflowContract,
   actionProfile,
@@ -1000,10 +1023,10 @@ function buildRemediations({
   }
   if (actionProfile && actionProfile.economicAction) {
     push(
-      'economic_action_approval',
-      'Require operator approval for money movement',
-      'Require an explicit operator checkpoint before refunds, payouts, invoice sends, or subscription changes execute.',
-      'Money-touching actions are costly to reverse and need a clear human owner.'
+      'financial_requisition_lifecycle',
+      'Complete the purchase-control lifecycle',
+      'Create a purchase requisition, obtain independent human approval through the reviewer API, reserve its exact budget, and attach the matching source-message scope before retrying.',
+      'Money-touching actions require a single-use, auditable authorization instead of an advisory checkpoint.'
     );
   }
   if (actionProfile && actionProfile.customerSystemAction) {
@@ -1064,6 +1087,14 @@ function buildRemediations({
       'High token or cost estimates should be reviewed before the model/tool loop continues.'
     );
   }
+  if (financialControl?.mode === 'block' && financialControl.reasonCodes.includes('zero_spend_budget')) {
+    push(
+      'honor_zero_spend_budget',
+      'Honor the zero-spend budget',
+      'Use a no-cost path. Do not add a card, start a paid trial, buy credits, or upgrade a plan.',
+      'An explicit $0 budget is a hard prohibition, not an omitted configuration value.'
+    );
+  }
   if (workflowContract?.active && workflowContract.violations.length > 0) {
     const codes = new Set(workflowContract.violations.map((violation) => violation.code));
     if (codes.has('missing_required_evidence')) {
@@ -1145,6 +1176,13 @@ function buildReasoning(report) {
   if (report.costControl && report.costControl.mode !== 'allow') {
     lines.push(`Cost control: ${report.costControl.mode} — ${report.costControl.reasons.join(' ')}`);
   }
+  if (report.financialControl?.economicAction) {
+    lines.push(
+      report.financialControl.mode === 'allow'
+        ? `Financial control: approved reservation ${report.financialControl.authorization?.reservationId || 'unknown'}.`
+        : `Financial control: block — ${report.financialControl.reasons.join(' ')}`
+    );
+  }
   if (report.workflowControl && report.workflowControl.workflow.pattern !== 'single_action') {
     lines.push(
       `Workflow control: ${report.workflowControl.mode} for ${report.workflowControl.workflow.pattern} with inspection ${report.workflowControl.workflow.hasInspectionEvidence ? 'present' : 'missing'}.`
@@ -1255,6 +1293,7 @@ function buildDecisionControl({
   integrity,
   protectedSurface,
   costControl,
+  financialControl,
   workflowControl,
   workflowContract,
   actionProfile,
@@ -1269,6 +1308,7 @@ function buildDecisionControl({
   const hasOperationalBlockers = Boolean(integrity?.blockers?.length);
   const hasCostWarning = costControl?.mode === 'warn';
   const hasCostBlock = costControl?.mode === 'block';
+  const hasFinancialBlock = financialControl?.mode === 'block';
   const hasWorkflowWarning = workflowControl?.mode === 'warn';
   const hasWorkflowBlock = workflowControl?.mode === 'block';
   const hasContractWarning = workflowContract?.mode === 'warn';
@@ -1277,6 +1317,7 @@ function buildDecisionControl({
     || (decision === 'allow' && (reversibility !== 'two_way_door' || hasOperationalBlockers || hasCostWarning || hasWorkflowWarning || hasContractWarning));
   const executionMode = decision === 'deny'
     || hasCostBlock
+    || hasFinancialBlock
     || hasWorkflowBlock
     || hasContractBlock
     ? 'blocked'
@@ -1302,7 +1343,7 @@ function buildDecisionControl({
     decisionOwner,
     reversibility,
     deliberation,
-    requiresHumanApproval: (executionMode === 'checkpoint_required' && decisionOwner !== 'agent') || hasCostBlock || hasWorkflowBlock || hasContractBlock,
+    requiresHumanApproval: (executionMode === 'checkpoint_required' && decisionOwner !== 'agent') || hasCostBlock || hasFinancialBlock || hasWorkflowBlock || hasContractBlock,
     recommendedAction: executionMode === 'blocked'
       ? 'halt'
       : executionMode === 'checkpoint_required'
@@ -1379,8 +1420,8 @@ function hasSoftControlWarning({ workflowContract, workflowControl, costControl,
     || (learnedRecall && riskScore >= 0.34);
 }
 
-function chooseDecision({ riskScore, integrity, memoryGuard, learnedPolicy, blastRadius, command, costControl, workflowControl, workflowContract, actionProfile }) {
-  if (costControl?.mode === 'block' || workflowControl?.mode === 'block' || workflowContract?.mode === 'block') {
+function chooseDecision({ riskScore, integrity, memoryGuard, learnedPolicy, blastRadius, command, costControl, financialControl, workflowControl, workflowContract, actionProfile }) {
+  if (financialControl?.mode === 'block' || costControl?.mode === 'block' || workflowControl?.mode === 'block' || workflowContract?.mode === 'block') {
     return 'deny';
   }
 
@@ -1406,7 +1447,7 @@ function chooseDecision({ riskScore, integrity, memoryGuard, learnedPolicy, blas
     return 'deny';
   }
 
-  if (actionProfile?.economicAction || (actionProfile?.backgroundAgent && riskScore >= 0.3)) {
+  if ((actionProfile?.economicAction && financialControl?.mode !== 'allow') || (actionProfile?.backgroundAgent && riskScore >= 0.3)) {
     return 'warn';
   }
 
@@ -1448,7 +1489,26 @@ function evaluateWorkflowSentinel(toolName, toolInput = {}, options = {}) {
   const affectedFiles = Array.isArray(options.affectedFiles)
     ? options.affectedFiles.map((filePath) => normalizePosix(filePath)).filter(Boolean)
     : collectAffectedFiles(normalizedToolName, normalizedToolInput, repoRoot);
-  const actionProfile = classifyActionProfile(normalizedToolInput);
+  let actionProfile = classifyActionProfile(normalizedToolInput);
+  const financialControl = evaluateFinancialControl({
+    toolName: normalizedToolName,
+    toolInput: normalizedToolInput,
+    actionProfile,
+    costControl,
+    budget: options.budget || toolInput.budget || {},
+    financialControl: options.financialControl || toolInput.financialControl,
+  }, getFinancialControlRuntimeOptions({
+    feedbackDir: options.feedbackDir
+      || process.env.THUMBGATE_FEEDBACK_DIR
+      || (repoRoot ? path.join(repoRoot, '.thumbgate') : null),
+  }));
+  // The financial detector has additional fail-closed classifiers for opaque
+  // browser/computer mutations. Reflect its verdict in the shared action
+  // profile so downstream learning, risk scoring, and reporting cannot treat
+  // a blocked financial action as non-economic.
+  if (financialControl.economicAction && !actionProfile.economicAction) {
+    actionProfile = { ...actionProfile, economicAction: true };
+  }
   const highRiskAction = isHighRiskAction(normalizedToolName, normalizedToolInput, affectedFiles);
   const baseBranch = options.baseBranch
     || (governanceState.branchGovernance && governanceState.branchGovernance.baseBranch)
@@ -1540,6 +1600,7 @@ function evaluateWorkflowSentinel(toolName, toolInput = {}, options = {}) {
     taskScopeViolation,
     protectedSurface: protectedSurfaceForRisk,
     costControl,
+    financialControl,
     workflowControl,
     workflowContract,
     actionProfile,
@@ -1567,6 +1628,7 @@ function evaluateWorkflowSentinel(toolName, toolInput = {}, options = {}) {
     },
     command: normalizedToolInput.command || '',
     costControl,
+    financialControl,
     workflowControl,
     workflowContract,
     actionProfile,
@@ -1580,6 +1642,7 @@ function evaluateWorkflowSentinel(toolName, toolInput = {}, options = {}) {
     protectedSurface: protectedSurfaceForRisk,
     normalizedAction,
     costControl,
+    financialControl,
     workflowControl,
     workflowContract,
     actionProfile,
@@ -1593,6 +1656,7 @@ function evaluateWorkflowSentinel(toolName, toolInput = {}, options = {}) {
     learnedPolicy,
     executionSurface,
     costControl,
+    financialControl,
     workflowControl,
     workflowContract,
     actionProfile,
@@ -1607,6 +1671,7 @@ function evaluateWorkflowSentinel(toolName, toolInput = {}, options = {}) {
     toolName: normalizedToolName,
     normalizedAction,
     costControl,
+    financialControl,
     workflowControl,
     workflowContract,
     decision,
@@ -1643,6 +1708,7 @@ function evaluateWorkflowSentinel(toolName, toolInput = {}, options = {}) {
     integrity,
     protectedSurface: protectedSurfaceForRisk,
     costControl,
+    financialControl,
     workflowControl,
     workflowContract,
     actionProfile,

package/server.json

@@ -8,13 +8,13 @@
     "source": "github",
     "url": "https://github.com/IgorGanapolsky/ThumbGate"
   },
-  "version": "1.31.0",
+  "version": "1.34.0",
   "packages": [
     {
       "registryType": "npm",
       "registryBaseUrl": "https://registry.npmjs.org",
       "identifier": "thumbgate",
-      "version": "1.31.0",
+      "version": "1.34.0",
       "runtimeHint": "npx",
       "runtimeArguments": [
         {

package/src/api/server.js

@@ -9453,6 +9453,7 @@ a{color:#8b9}</style></head><body><form class="card" method="post" action="/oaut
             escalationId,
           }, {
             authenticatedActor,
+            approvalSigningKey: humanReviewerConfig.key,
             feedbackDir: requestFeedbackDir,
           }));
         } catch (error) {
@@ -10577,6 +10578,7 @@ a{color:#8b9}</style></head><body><form class="card" method="post" action="/oaut
           params: body.params,
           mcp: body.mcp,
           mcpToolCall: body.mcpToolCall,
+          financialControl: body.financialControl || body.financial_control,
           budget: body.budget,
           usage: body.usage,
         };