thuban 0.3.1 → 0.3.3

package/packages/scanner/tech-debt-analyzer.js

@@ -17,6 +17,31 @@ const DependencyGraph = require('./dependency-graph');
 const DriftDetector = require('./drift-detector');
 const WidgetGenerator = require('./widget-generator');
 
+/**
+ * Convert a JSDoc-style /** ... * / widget string to the appropriate comment
+ * style for the target file's language.
+ */
+function formatWidgetComment(jsDocWidget, filePath) {
+  const ext = path.extname(filePath).toLowerCase();
+  if (ext === '.py') {
+    return jsDocWidget
+      .replace(/^\/\*\*\n/, '')
+      .replace(/\s*\*\/\s*$/, '')
+      .split('\n')
+      .map(l => l.replace(/^\s*\*\s?/, '# '))
+      .join('\n');
+  } else if (ext === '.go') {
+    return jsDocWidget
+      .replace(/^\/\*\*\n/, '')
+      .replace(/\s*\*\/\s*$/, '')
+      .split('\n')
+      .map(l => l.replace(/^\s*\*\s?/, '// '))
+      .join('\n');
+  }
+  // JS, TS, Java, C# — keep /** */ format
+  return jsDocWidget;
+}
+
 class TechDebtAnalyzer {
   constructor(config = {}) {
     this.config = {
@@ -81,18 +106,14 @@ class TechDebtAnalyzer {
 
     // ─── 1. Security Debt ───────────────────────────────────
     const securityIssues = [];
-    for (const [file, result] of Object.entries(scanResults)) {
-      if (result.issues) {
-        for (const issue of result.issues) {
-          if (issue.id?.startsWith('SEC') || issue.category === 'security') {
-            securityIssues.push({
-              file: path.relative(this.config.rootPath, file),
-              ...issue,
-              fixable: issue.id === 'SEC001' || issue.id === 'SEC002', // Can extract to env vars
-              fixAction: issue.id === 'SEC001' ? 'extract_to_env' : issue.id === 'SEC002' ? 'extract_to_env' : null,
-            });
-          }
-        }
+    for (const issue of (scanResults.issues || [])) {
+      if (issue.id?.startsWith('SEC') || issue.category === 'security') {
+        securityIssues.push({
+          file: path.relative(this.config.rootPath, issue.file),
+          ...issue,
+          fixable: issue.id === 'SEC001' || issue.id === 'SEC002', // Can extract to env vars
+          fixAction: issue.id === 'SEC001' ? 'extract_to_env' : issue.id === 'SEC002' ? 'extract_to_env' : null,
+        });
       }
     }
     debt.scores.security = Math.max(0, 100 - (securityIssues.filter(i => i.severity === 'critical').length * 25) - (securityIssues.filter(i => i.severity === 'high').length * 10));
@@ -182,18 +203,14 @@ class TechDebtAnalyzer {
       }
     }
 
-    for (const [file, result] of Object.entries(scanResults)) {
-      if (result.issues) {
-        for (const issue of result.issues) {
-          if (issue.id?.startsWith('QUAL') || issue.category === 'quality' || issue.category === 'maintainability') {
-            qualityIssues.push({
-              file: path.relative(this.config.rootPath, file),
-              ...issue,
-              fixable: ['QUAL001', 'QUAL003', 'QUAL005'].includes(issue.id), // console.log removal, etc.
-              fixAction: issue.id === 'QUAL001' ? 'remove_console_log' : null,
-            });
-          }
-        }
+    for (const issue of (scanResults.issues || [])) {
+      if (issue.id?.startsWith('QUAL') || issue.category === 'quality' || issue.category === 'maintainability') {
+        qualityIssues.push({
+          file: path.relative(this.config.rootPath, issue.file),
+          ...issue,
+          fixable: ['QUAL001', 'QUAL003', 'QUAL005'].includes(issue.id), // console.log removal, etc.
+          fixAction: issue.id === 'QUAL001' ? 'remove_console_log' : null,
+        });
       }
     }
     debt.scores.codeQuality = Math.max(0, 100 - (qualityIssues.filter(i => i.severity === 'high').length * 5) - (qualityIssues.filter(i => i.severity === 'medium').length * 2));
@@ -319,7 +336,8 @@ class TechDebtAnalyzer {
             const content = fs.readFileSync(fullPath, 'utf-8');
             const widget = await this.widgetGen.generateWidget(fullPath, content);
             if (widget && widget.widgetString) {
-              fs.writeFileSync(fullPath, widget.widgetString + '\n\n' + content, 'utf-8');
+              const commentBlock = formatWidgetComment(widget.widgetString, fullPath);
+              fs.writeFileSync(fullPath, commentBlock + '\n\n' + content, 'utf-8');
               fixes.push({ ...item, status: 'fixed' });
             }
             break;
@@ -333,7 +351,8 @@ class TechDebtAnalyzer {
             // Generate new widget with current state
             const widget = await this.widgetGen.generateWidget(fullPath, stripped);
             if (widget && widget.widgetString) {
-              fs.writeFileSync(fullPath, widget.widgetString + '\n\n' + stripped, 'utf-8');
+              const commentBlock = formatWidgetComment(widget.widgetString, fullPath);
+              fs.writeFileSync(fullPath, commentBlock + '\n\n' + stripped, 'utf-8');
               fixes.push({ ...item, status: 'fixed' });
             }
             break;
@@ -364,8 +383,7 @@ class TechDebtAnalyzer {
             content = content.replace(/require\(['"]sys['"]\)/g, "require('util')");
             // util.isArray() → Array.isArray()
             content = content.replace(/util\.isArray\(/g, 'Array.isArray(');
-            // util.isFunction() → typeof x === 'function'
-            content = content.replace(/util\.isFunction\(([^)]+)\)/g, "typeof $1 === 'function'");
+            // util.isFunction() is skipped — regex cannot safely handle arrow function arguments
             // fs.exists() callback → fs.existsSync or fs.access
             content = content.replace(/fs\.exists\(([^,]+),\s*/g, 'fs.access($1, ');
             if (content !== before) {