throughline 0.6.2 → 0.7.0

package/src/turn-processor.test.mjs

@@ -1,10 +1,17 @@
 import { test } from 'node:test';
 import assert from 'node:assert/strict';
 import { DatabaseSync } from 'node:sqlite';
+import { appendFileSync, mkdtempSync, readFileSync, rmSync, statSync, writeFileSync } from 'node:fs';
+import { tmpdir } from 'node:os';
+import { join } from 'node:path';
 import {
   L2_WINDOW,
+  CLAUDE_STOP_TRANSCRIPT_FLUSH_INTERVAL_MS,
+  CLAUDE_STOP_TRANSCRIPT_FLUSH_TIMEOUT_MS,
   countDistinctBodyTurns,
   pickOldestUnsummarizedTurn,
+  publishCapturedClaudeCompletionReceipt,
+  waitForClaudeStopTranscriptFlush,
 } from './turn-processor.mjs';
 
 function makeDb() {
@@ -54,6 +61,140 @@ test('L2_WINDOW is 20', () => {
   assert.equal(L2_WINDOW, 20);
 });
 
+test('Claude Stop flush barrierはlatest userの遅延assistantを待ち、過去の同文answerを採用しない', async () => {
+  const root = mkdtempSync(join(tmpdir(), 'throughline-stop-flush-'));
+  const transcriptPath = join(root, 'transcript.jsonl');
+  const answer = 'same answer';
+  let elapsed = 0;
+  let waits = 0;
+  try {
+    writeFileSync(
+      transcriptPath,
+      [
+        { type: 'user', message: { role: 'user', content: 'old question' } },
+        { type: 'assistant', message: { role: 'assistant', content: [{ type: 'text', text: answer }] } },
+        { type: 'user', message: { role: 'user', content: 'current question' } },
+      ].map((entry) => JSON.stringify(entry)).join('\n'),
+      'utf8',
+    );
+    const result = await waitForClaudeStopTranscriptFlush({
+      transcriptPath,
+      lastAssistantMessage: answer,
+      timeoutMs: 100,
+      intervalMs: 10,
+      now: () => elapsed,
+      wait: async (milliseconds) => {
+        elapsed += milliseconds;
+        waits++;
+        if (waits === 1) {
+          appendFileSync(
+            transcriptPath,
+            `\n${JSON.stringify({
+              type: 'assistant',
+              message: { role: 'assistant', content: [{ type: 'text', text: answer }] },
+            })}`,
+            'utf8',
+          );
+        }
+      },
+    });
+    assert.deepEqual(result, { status: 'ready', userTurnNumber: 2, assistantTurnNumber: 3 });
+    assert.equal(waits, 1, 'past identical answer must not satisfy the current user group');
+  } finally {
+    rmSync(root, { recursive: true, force: true });
+  }
+});
+
+test('Claude Stop flush barrierはmarker不一致をdeadlineで明示失敗する', async () => {
+  let elapsed = 0;
+  await assert.rejects(
+    waitForClaudeStopTranscriptFlush({
+      transcriptPath: '/missing',
+      lastAssistantMessage: 'expected',
+      timeoutMs: 30,
+      intervalMs: 10,
+      readCompletion: () => ({ userTurnNumber: 4, assistantTurnNumber: null, assistantContent: null }),
+      now: () => elapsed,
+      wait: async (milliseconds) => { elapsed += milliseconds; },
+    }),
+    /not visible before deadline/,
+  );
+  assert.equal(elapsed, 30);
+});
+
+test('Claude Stop flush barrierはmarkerなし旧payloadをone-shot互換へ残す', async () => {
+  let reads = 0;
+  const result = await waitForClaudeStopTranscriptFlush({
+    transcriptPath: '/unused',
+    lastAssistantMessage: undefined,
+    readCompletion: () => { reads++; return null; },
+  });
+  assert.deepEqual(result, { status: 'marker_unavailable' });
+  assert.equal(reads, 0);
+  assert.equal(CLAUDE_STOP_TRANSCRIPT_FLUSH_TIMEOUT_MS, 2_000);
+  assert.equal(CLAUDE_STOP_TRANSCRIPT_FLUSH_INTERVAL_MS, 25);
+});
+
+test('publishCapturedClaudeCompletionReceipt: L2 capture済みpairをL1/L3より先にprivate receiptへ固定する', () => {
+  const db = makeDb();
+  const root = mkdtempSync(join(tmpdir(), 'throughline-turn-receipt-'));
+  const storePath = join(root, 'state', 'completed-turn-receipts.json');
+  try {
+    insertTurn(db, { session: 'target', origin: 'origin', turn: 7, createdAt: 1234 });
+    db.prepare(
+      `UPDATE bodies SET text = CASE role WHEN 'user' THEN ' request\r\n' ELSE 'answer' END
+       WHERE session_id = 'target' AND origin_session_id = 'origin' AND turn_number = 7`,
+    ).run();
+    const first = publishCapturedClaudeCompletionReceipt(db, {
+      target: 'target', origin: 'origin', turnNumber: 7, projectPath: '/repo',
+      receiptOptions: { storePath },
+    });
+    const second = publishCapturedClaudeCompletionReceipt(db, {
+      target: 'target', origin: 'origin', turnNumber: 7, projectPath: '/repo',
+      receiptOptions: { storePath },
+    });
+    assert.equal(first.sequence, 1);
+    assert.deepEqual(second, first, 'Stop retry must return the original receipt');
+    assert.equal(first.completed_at, 1234);
+    if (process.platform !== 'win32') {
+      // POSIX permission 契約。Windows の stat mode は 0o666 系で chmod 契約を
+      // 表現できない (receipt store の Windows private 化は runtime-error-store の
+      // ACL 方式に倣う Observer 側の未着手課題)。
+      assert.equal(statSync(join(root, 'state')).mode & 0o777, 0o700);
+      assert.equal(statSync(storePath).mode & 0o777, 0o600);
+    }
+    const bytes = readFileSync(storePath, 'utf8');
+    assert.doesNotMatch(bytes, /request|answer|\/repo/);
+    assert.match(bytes, /"host":"claude"/);
+  } finally {
+    db.close();
+    rmSync(root, { recursive: true, force: true });
+  }
+});
+
+test('publishCapturedClaudeCompletionReceipt: incomplete DB pairはreceiptを作らず失敗する', () => {
+  const db = makeDb();
+  const root = mkdtempSync(join(tmpdir(), 'throughline-turn-receipt-'));
+  const storePath = join(root, 'state', 'completed-turn-receipts.json');
+  try {
+    db.prepare(
+      `INSERT INTO bodies (session_id, origin_session_id, turn_number, role, text, token_count, created_at)
+       VALUES ('target', 'origin', 8, 'user', 'only user', 1, 1)`,
+    ).run();
+    assert.throws(
+      () => publishCapturedClaudeCompletionReceipt(db, {
+        target: 'target', origin: 'origin', turnNumber: 8, projectPath: '/repo',
+        receiptOptions: { storePath },
+      }),
+      /completed pair was not captured/,
+    );
+    assert.throws(() => statSync(storePath), { code: 'ENOENT' });
+  } finally {
+    db.close();
+    rmSync(root, { recursive: true, force: true });
+  }
+});
+
 test('countDistinctBodyTurns: 2 ロール行 = 1 ターンとして数える', () => {
   const db = makeDb();
   insertTurn(db, { session: 'S', origin: 'S', turn: 1, createdAt: 100 });

package/src/windows-acl-test-helper.mjs

@@ -27,3 +27,32 @@ if($isDir){[System.IO.Directory]::SetAccessControl($target,$acl)}else{[System.IO
   });
   if (result.status !== 0) throw new Error(result.stderr || 'Windows ACL fixture setup failed');
 }
+
+export function verifyWindowsPrivateAcl(path, directory = false) {
+  if (process.platform !== 'win32') return;
+  const script = String.raw`
+$ErrorActionPreference='Stop'
+$target=$env:THROUGHLINE_TEST_ACL_PATH; $isDir=$env:THROUGHLINE_TEST_ACL_DIRECTORY -eq '1'
+$sid=[System.Security.Principal.WindowsIdentity]::GetCurrent().User.Value
+$acl=if($isDir){[System.IO.Directory]::GetAccessControl($target)}else{[System.IO.File]::GetAccessControl($target)}
+$owner=$acl.GetOwner([System.Security.Principal.SecurityIdentifier]).Value
+if($owner -ne $sid){exit 41}
+$rules=@($acl.GetAccessRules($true,$true,[System.Security.Principal.SecurityIdentifier]))
+if($rules.Count -ne 1){exit 42}
+$rule=$rules[0]
+if($rule.IdentityReference.Value -ne $sid -or $rule.AccessControlType -ne 'Allow' -or $rule.IsInherited -or ($rule.FileSystemRights -band [System.Security.AccessControl.FileSystemRights]::FullControl) -ne [System.Security.AccessControl.FileSystemRights]::FullControl){exit 43}
+`;
+  const result = spawnSync('powershell.exe', [
+    '-NoProfile', '-NonInteractive', '-Command', script,
+  ], {
+    encoding: 'utf8',
+    timeout: 3_000,
+    windowsHide: true,
+    env: {
+      ...process.env,
+      THROUGHLINE_TEST_ACL_PATH: path,
+      THROUGHLINE_TEST_ACL_DIRECTORY: directory ? '1' : '0',
+    },
+  });
+  if (result.status !== 0) throw new Error(result.stderr || 'Windows ACL fixture verification failed');
+}