throughline 0.3.24 → 0.3.25

package/src/vscode-task.mjs

@@ -239,7 +239,12 @@ export function buildSetupNotice(action) {
   return null;
 }
 
-function emitSetupNotice(action) {
+function shouldEmitNotices(env) {
+  return env.THROUGHLINE_SUPPRESS_VSCODE_NOTICES !== '1';
+}
+
+function emitSetupNotice(action, env) {
+  if (!shouldEmitNotices(env)) return;
   const text = buildSetupNotice(action);
   if (text) process.stdout.write(text);
 }
@@ -279,9 +284,18 @@ export function shouldRecommendGitignore(cwd) {
   return true;
 }
 
-function emitGitignoreRecommendationOnce(vscodeDir) {
+function emitGitignoreRecommendationOnce(vscodeDir, env) {
   const markerPath = join(vscodeDir, GITIGNORE_MARKER_FILENAME);
   if (existsSync(markerPath)) return;
+  if (!shouldEmitNotices(env)) {
+    try {
+      writeFileSync(markerPath, `${new Date().toISOString()}\n`);
+    } catch (err) {
+      const msg = err instanceof Error ? err.message : 'unknown';
+      process.stderr.write(`[throughline] failed to write gitignore marker: ${msg}\n`);
+    }
+    return;
+  }
   process.stdout.write(
     '<system-reminder>\n' +
     'Throughline ヒント: .vscode/tasks.json には現環境の絶対パス (node 実行ファイル / throughline.mjs)\n' +
@@ -305,9 +319,18 @@ function emitGitignoreRecommendationOnce(vscodeDir) {
   }
 }
 
-function emitJsoncGuidanceOnce(vscodeDir) {
+function emitJsoncGuidanceOnce(vscodeDir, env) {
   const markerPath = join(vscodeDir, JSONC_MARKER_FILENAME);
   if (existsSync(markerPath)) return;
+  if (!shouldEmitNotices(env)) {
+    try {
+      writeFileSync(markerPath, `${new Date().toISOString()}\n`);
+    } catch (err) {
+      const msg = err instanceof Error ? err.message : 'unknown';
+      process.stderr.write(`[throughline] failed to write JSONC marker: ${msg}\n`);
+    }
+    return;
+  }
   process.stderr.write(
     `[throughline] .vscode/tasks.json contains JSONC features (comments or trailing commas). ` +
       `Auto-edit is unsafe on this file — add the Throughline Monitor task manually. ` +
@@ -363,15 +386,15 @@ export function ensureMonitorTaskFile(opts = {}) {
     if (!existsSync(vscodeDir)) mkdirSync(vscodeDir, { recursive: true });
     const obj = { version: '2.0.0', tasks: [buildMonitorTask(bin)] };
     atomicWrite(tasksPath, JSON.stringify(obj, null, 2) + '\n');
-    emitSetupNotice('created');
-    if (shouldRecommendGitignore(cwd)) emitGitignoreRecommendationOnce(vscodeDir);
+    emitSetupNotice('created', env);
+    if (shouldRecommendGitignore(cwd)) emitGitignoreRecommendationOnce(vscodeDir, env);
     return { action: 'created', path: tasksPath };
   }
 
   const text = readFileSync(tasksPath, 'utf8');
 
   if (detectJsoncFeatures(text)) {
-    emitJsoncGuidanceOnce(vscodeDir);
+    emitJsoncGuidanceOnce(vscodeDir, env);
     return { action: 'skipped', reason: 'jsonc_unsupported', path: tasksPath };
   }
 
@@ -398,8 +421,8 @@ export function ensureMonitorTaskFile(opts = {}) {
       nextTasks[existingIdx] = repaired;
       const nextObj = { ...obj, version: obj.version ?? '2.0.0', tasks: nextTasks };
       atomicWrite(tasksPath, JSON.stringify(nextObj, null, indent) + '\n');
-      emitSetupNotice('repaired');
-      if (shouldRecommendGitignore(cwd)) emitGitignoreRecommendationOnce(vscodeDir);
+      emitSetupNotice('repaired', env);
+      if (shouldRecommendGitignore(cwd)) emitGitignoreRecommendationOnce(vscodeDir, env);
       return { action: 'repaired', path: tasksPath };
     }
     return { action: 'already_present', path: tasksPath };
@@ -412,7 +435,7 @@ export function ensureMonitorTaskFile(opts = {}) {
     tasks: [...(Array.isArray(obj.tasks) ? obj.tasks : []), buildMonitorTask(bin)],
   };
   atomicWrite(tasksPath, JSON.stringify(nextObj, null, indent) + '\n');
-  emitSetupNotice('merged');
-  if (shouldRecommendGitignore(cwd)) emitGitignoreRecommendationOnce(vscodeDir);
+  emitSetupNotice('merged', env);
+  if (shouldRecommendGitignore(cwd)) emitGitignoreRecommendationOnce(vscodeDir, env);
   return { action: 'merged', path: tasksPath };
 }

package/src/vscode-task.test.mjs

@@ -16,7 +16,13 @@ import {
   shouldRecommendGitignore,
 } from './vscode-task.mjs';
 
-const VSCODE_ENV = { TERM_PROGRAM: 'vscode' };
+const VSCODE_ENV = {
+  TERM_PROGRAM: 'vscode',
+  THROUGHLINE_SUPPRESS_VSCODE_NOTICES: '1',
+};
+// Production notices are Claude-facing additional context. Tests keep them
+// silent by default and opt in only when asserting notice text.
+const VSCODE_NOTICE_ENV = { TERM_PROGRAM: 'vscode' };
 // 実在する絶対パスを使う。`isMonitorTaskBroken` が「絶対パス + 非存在」で broken 判定するので、
 // 架空パスを使うと意図せず repaired ブランチに落ちてしまう。
 const FAKE_BIN = process.execPath;
@@ -436,7 +442,11 @@ test('ensureMonitorTaskFile: already_present when command references throughline
         {
           label: 'My Custom Monitor',
           type: 'process',
-          command: '/usr/bin/node',
+          // 実在する絶対パスを使う。`/usr/bin/node` は WSL2 では実在するが
+          // CI runner (Linux/macOS は /opt/hostedtoolcache, Windows は別) では
+          // 存在しないので isMonitorTaskBroken が true になり repaired ブランチに落ちる。
+          // process.execPath なら「いま走らせている node 自身の絶対パス」なので必ず実在する。
+          command: process.execPath,
           // 相対パスにして broken 判定を避ける（このテストは「label renamed でも検出できるか」だけが論点）
           args: ['./throughline.mjs', 'monitor'],
         },
@@ -573,7 +583,7 @@ test('ensureMonitorTaskFile: created emits gitignore recommendation when .git ex
     mkdirSync(join(dir, '.git'));
     const result = ensureMonitorTaskFile({
       cwd: dir,
-      env: VSCODE_ENV,
+      env: VSCODE_NOTICE_ENV,
       throughlineBin: FAKE_BIN,
     });
     assert.equal(result.action, 'created');
@@ -597,7 +607,7 @@ test('ensureMonitorTaskFile: created does NOT emit gitignore recommendation when
   try {
     const result = ensureMonitorTaskFile({
       cwd: dir,
-      env: VSCODE_ENV,
+      env: VSCODE_NOTICE_ENV,
       throughlineBin: FAKE_BIN,
     });
     assert.equal(result.action, 'created');
@@ -624,7 +634,7 @@ test('ensureMonitorTaskFile: gitignore recommendation is emitted only once per p
       // 1 回目: created → gitignore 推奨が出る
       const r1 = ensureMonitorTaskFile({
         cwd: dir,
-        env: VSCODE_ENV,
+        env: VSCODE_NOTICE_ENV,
         throughlineBin: FAKE_BIN,
       });
       assert.equal(r1.action, 'created');
@@ -791,7 +801,7 @@ test('ensureMonitorTaskFile: repaired emits notice on stdout', () => {
 
     const result = ensureMonitorTaskFile({
       cwd: dir,
-      env: VSCODE_ENV,
+      env: VSCODE_NOTICE_ENV,
       throughlineBin: FAKE_BIN,
     });
     assert.equal(result.action, 'repaired');
@@ -867,7 +877,7 @@ test('ensureMonitorTaskFile: jsonc_unsupported marker suppresses stderr on 2nd c
     try {
       const r1 = ensureMonitorTaskFile({
         cwd: dir,
-        env: VSCODE_ENV,
+        env: VSCODE_NOTICE_ENV,
         throughlineBin: FAKE_BIN,
       });
       assert.equal(r1.action, 'skipped');
@@ -956,13 +966,13 @@ test('buildSetupNotice: ensureMonitorTaskFile writes notice to stdout on first c
   try {
     const r1 = ensureMonitorTaskFile({
       cwd: dir,
-      env: VSCODE_ENV,
+      env: VSCODE_NOTICE_ENV,
       throughlineBin: FAKE_BIN,
     });
     assert.equal(r1.action, 'created');
     const r2 = ensureMonitorTaskFile({
       cwd: dir,
-      env: VSCODE_ENV,
+      env: VSCODE_NOTICE_ENV,
       throughlineBin: FAKE_BIN,
     });
     assert.equal(r2.action, 'already_present');