throughline 0.14.2 → 0.14.3

package/CHANGELOG.md

@@ -10,6 +10,20 @@ shipped to npm but were not individually tagged on GitHub.
 
 ## [Unreleased]
 
+## [0.14.3] — 2026-10-05
+
+### 修正
+
+- Windowsで、同じhookが2本同時に走った時に、片方が`Windows owner-only ACL verification failed`で失敗することがあった不具合を直す。Cursorは同じStop hookを2本ほぼ同時に起動する。新しいフォルダでの最初の応答では、1本目が受領記録のlockファイルを作り、その後で所有者だけの権限（ACL）を付けていた。権限を付け終わるまでの約1秒、lockファイルはフォルダから継承した権限のまま見える。2本目がその間に権限を検証して落ち、`HOOK_PROCESS_TURN_FAILED`に数えられていた。会話の保存は同じStopで済んでいて、失われていない。
+- lockファイルは、別名で作って権限を付け、検証してから、hard linkで最終の場所へ出す。最終の場所に現れた時点で、所有者だけの権限が付いている。先に出した側が勝ち、後から来た側は既にあるlockを検証して使う。
+- 実行時エラーの記録（`runtime-errors`）のlockファイルも同じ作りだったので、同じ形に直す。
+- macOSとLinuxの動作は変わらない（作る時点で`0600`を指定しているので、この隙間は無い）。既にあるlockファイルの検証は変えていない。
+
+### 確認した範囲
+
+- Windows 11（10.0.26200）の実機。0.14.2では、lockファイルが作られて権限がまだ付いていない状態で2本目を走らせると、Cursorの実際の失敗と同じ文面・同じ呼び出し位置で落ちる。0.14.3は、同じ場面（1本目が別名を作った直後）で2本とも成功し、lockファイルと受領記録の権限は所有者だけになる。
+- 同じ実機で、新しい置き場に2本・4本を同時に起動する確認を、受領記録で51回、実行時エラーの記録で15回行い、失敗0。0.14.2は同じ確認18回のうち1回で失敗した。
+
 ## [0.14.2] — 2026-10-05
 
 ### 修正
@@ -1710,7 +1724,8 @@ two attempts, instrument first instead of patching again.
 
 ---
 
-[Unreleased]: https://github.com/kitepon/Throughline/compare/v0.14.2...HEAD
+[Unreleased]: https://github.com/kitepon/Throughline/compare/v0.14.3...HEAD
+[0.14.3]: https://github.com/kitepon/Throughline/compare/v0.14.2...v0.14.3
 [0.14.2]: https://github.com/kitepon/Throughline/compare/v0.14.1...v0.14.2
 [0.14.1]: https://github.com/kitepon/Throughline/compare/v0.14.0...v0.14.1
 [0.14.0]: https://github.com/kitepon/Throughline/compare/v0.13.0...v0.14.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "throughline",
-  "version": "0.14.2",
+  "version": "0.14.3",
   "type": "module",
   "description": "Persistent memory hooks for Claude Code, Codex, Grok, and Cursor (/clear-safe context compression)",
   "keywords": [

package/src/completed-turn-receipts.mjs

@@ -2,6 +2,7 @@ import { createHash, randomBytes } from 'node:crypto';
 import { CLAUDE_HOST } from './hosts/identity.mjs';
 import {
   chmodSync,
+  existsSync,
   lstatSync,
   mkdirSync,
   readFileSync,
@@ -13,7 +14,7 @@ import { dirname, join } from 'node:path';
 import { DatabaseSync } from 'node:sqlite';
 import { hashAuditorBody } from './body-digest.mjs';
 import { normalizeProjectPathForCompare } from './project-path.mjs';
-import { applyAndVerifyWindowsAcl, isWindows, verifyWindowsAcl } from './os/windows-acl.mjs';
+import { applyAndVerifyWindowsAcl, createWindowsPrivateFile, isWindows, verifyWindowsAcl } from './os/windows-acl.mjs';
 import { windowsLocalAppData, xdgStateHome } from './os/app-dirs.mjs';
 
 export const COMPLETED_TURN_RECEIPT_STORE_SCHEMA = 'throughline.completed_turn_receipts.v1';
@@ -157,15 +158,16 @@ function withStoreLock(normalized, options, operation) {
   ensurePrivateDirectory(directory, options.env);
   const lockPath = `${storePath}.lock.sqlite`;
   let created = false;
-  try {
-    writeFileSync(lockPath, '', { encoding: 'utf8', mode: 0o600, flag: 'wx' });
-    created = true;
-  } catch (error) {
-    if (error?.code !== 'EEXIST') throw error;
-  }
-  if (created) {
-    if (isWindows(options.env)) applyAndVerifyWindowsAcl(lockPath, false);
-    else chmodSync(lockPath, 0o600);
+  if (isWindows(options.env)) {
+    created = !existsSync(lockPath) && createWindowsPrivateFile(lockPath);
+  } else {
+    try {
+      writeFileSync(lockPath, '', { encoding: 'utf8', mode: 0o600, flag: 'wx' });
+      created = true;
+    } catch (error) {
+      if (error?.code !== 'EEXIST') throw error;
+    }
+    if (created) chmodSync(lockPath, 0o600);
   }
   if (created && isWindows(options.env)) assertPrivateFileShape(lstatSync(lockPath));
   else assertPrivateFile(lstatSync(lockPath), options.env, lockPath);

package/src/completed-turn-receipts.test.mjs

@@ -1,7 +1,7 @@
 import { test } from 'node:test';
 import assert from 'node:assert/strict';
 import childProcess from 'node:child_process';
-import { mkdtempSync, mkdirSync, readFileSync, rmSync, statSync, symlinkSync, writeFileSync } from 'node:fs';
+import { existsSync, mkdtempSync, mkdirSync, readFileSync, readdirSync, rmSync, statSync, symlinkSync, writeFileSync } from 'node:fs';
 import { tmpdir } from 'node:os';
 import { dirname, join } from 'node:path';
 import {
@@ -159,6 +159,29 @@ test('completed turn receipt: one Windows mutation spends ACL processes only on
   }
 });
 
+test('completed turn receipt: Windows lock file reaches its final path only after its ACL is applied', (t) => {
+  const box = sandbox();
+  const env = { OS: 'Windows_NT', HOME: box.root, USERPROFILE: box.root };
+  const lockPath = `${box.storePath}.lock.sqlite`;
+  const applied = new Set();
+  const exposed = [];
+  // 同時に走る別のhookは、lockが見えた時点でそのACLを検証する。ACL processの起動を、その検証が入りうる瞬間として見る。
+  t.mock.method(childProcess, 'spawnSync', (command, args, options) => {
+    if (existsSync(lockPath) && !applied.has(statSync(lockPath, { bigint: true }).ino)) exposed.push(options.env.THROUGHLINE_ACL_PATH);
+    if (args.at(-1).includes('Set-Acl')) applied.add(statSync(options.env.THROUGHLINE_ACL_PATH, { bigint: true }).ino);
+    return { status: 0, signal: null, error: undefined };
+  });
+
+  try {
+    writeCompletedTurnReceipt(input(1), { env, storePath: box.storePath });
+    assert.deepEqual(exposed, [], 'the lock must not be visible with an inherited ACL');
+    assert.ok(applied.has(statSync(lockPath, { bigint: true }).ino));
+    assert.deepEqual(readdirSync(dirname(lockPath)).filter((name) => name.endsWith('.tmp')), []);
+  } finally {
+    rmSync(box.root, { recursive: true, force: true });
+  }
+});
+
 test('completed turn receipt: Windows temporary ACL failure leaves the previous atomic store intact', (t) => {
   const box = sandbox();
   const env = { OS: 'Windows_NT', HOME: box.root, USERPROFILE: box.root };

package/src/os/windows-acl.mjs

@@ -16,6 +16,8 @@
  * export 経由で mock するため、named import に変えないこと。
  */
 import childProcess from 'node:child_process';
+import { randomBytes } from 'node:crypto';
+import { linkSync, rmSync, writeFileSync } from 'node:fs';
 import { platform as hostPlatform } from 'node:os';
 
 export const WINDOWS_ACL_TIMEOUT_MS = 15_000;
@@ -32,6 +34,31 @@ export function verifyWindowsAcl(path, directory) {
   runWindowsAclScript(path, directory, WINDOWS_ACL_VERIFY_SCRIPT);
 }
 
+/**
+ * owner-only ACL の付いた空 file を、最終 path へ排他的に作る。作れたら true、既に在れば false。
+ *
+ * 最終 path へ作ってから ACL を適用すると、適用が終わるまで (PowerShell の起動で 1 秒前後)
+ * 継承 ACL のまま見える。同時に走った別 process がその間に verify して落ちた
+ * (fox 2026-10-05、Cursor が同じ Stop hook を 2 本同時に起動)。別名で作って ACL を
+ * 適用・検証し、hard link で公開する。hard link は同じ file なので ACL はそのまま付く。
+ */
+export function createWindowsPrivateFile(path) {
+  const temporary = `${path}.${process.pid}.${randomBytes(6).toString('hex')}.tmp`;
+  try {
+    writeFileSync(temporary, '', { encoding: 'utf8', flag: 'wx' });
+    applyAndVerifyWindowsAcl(temporary, false);
+    try {
+      linkSync(temporary, path);
+      return true;
+    } catch (error) {
+      if (error?.code !== 'EEXIST') throw error;
+      return false;
+    }
+  } finally {
+    rmSync(temporary, { force: true, maxRetries: 3, retryDelay: 50 });
+  }
+}
+
 function runWindowsAclScript(path, directory, script) {
   const result = childProcess.spawnSync('pwsh.exe', ['-NoProfile', '-NonInteractive', '-Command', script], {
     env: { ...process.env, THROUGHLINE_ACL_PATH: path, THROUGHLINE_ACL_DIRECTORY: directory ? '1' : '0' },

package/src/runtime-error-store.mjs

@@ -15,7 +15,7 @@ import { dirname, join } from 'node:path';
 import { createRequire } from 'node:module';
 import { fileURLToPath } from 'node:url';
 import { DatabaseSync } from 'node:sqlite';
-import { applyAndVerifyWindowsAcl, isWindows, verifyWindowsAcl } from './os/windows-acl.mjs';
+import { applyAndVerifyWindowsAcl, createWindowsPrivateFile, isWindows, verifyWindowsAcl } from './os/windows-acl.mjs';
 import { windowsLocalAppData, xdgConfigHome, xdgStateHome } from './os/app-dirs.mjs';
 
 const require = createRequire(import.meta.url);
@@ -419,15 +419,16 @@ function withStoreLock(options, operation) {
   ensurePrivateStoreDirectory(directory, options.env);
   const lockPath = `${storePath}.lock.sqlite`;
   let created = false;
-  try {
-    writeFileSync(lockPath, '', { encoding: 'utf8', mode: 0o600, flag: 'wx' });
-    created = true;
-  } catch (error) {
-    if (error?.code !== 'EEXIST') throw error;
-  }
-  if (created) {
-    if (isWindows(options.env)) applyAndVerifyWindowsAcl(lockPath, false);
-    else chmodSync(lockPath, 0o600);
+  if (isWindows(options.env)) {
+    created = !existsSync(lockPath) && createWindowsPrivateFile(lockPath);
+  } else {
+    try {
+      writeFileSync(lockPath, '', { encoding: 'utf8', mode: 0o600, flag: 'wx' });
+      created = true;
+    } catch (error) {
+      if (error?.code !== 'EEXIST') throw error;
+    }
+    if (created) chmodSync(lockPath, 0o600);
   }
   if (created && isWindows(options.env)) assertPrivateStoreFileShape(lstatSync(lockPath));
   else assertPrivateStoreFile(lstatSync(lockPath), options.env, lockPath);

package/src/runtime-error-store.test.mjs

@@ -1,7 +1,7 @@
 import { test } from 'node:test';
 import assert from 'node:assert/strict';
 import childProcess, { spawn } from 'node:child_process';
-import { chmodSync, mkdtempSync, mkdirSync, readFileSync, readdirSync, statSync, writeFileSync } from 'node:fs';
+import { chmodSync, existsSync, mkdtempSync, mkdirSync, readFileSync, readdirSync, statSync, writeFileSync } from 'node:fs';
 import { tmpdir } from 'node:os';
 import { dirname, join } from 'node:path';
 
@@ -142,6 +142,27 @@ test('runtime error store: one Windows mutation spends ACL processes only on dis
   assert.ok(calls.every((call) => call.options.timeout === 15_000));
 });
 
+test('runtime error store: Windows lock file reaches its final path only after its ACL is applied', (t) => {
+  const box = sandbox();
+  box.env.OS = 'Windows_NT';
+  enableCollection(box);
+  const lockPath = `${box.storePath}.lock.sqlite`;
+  const applied = new Set();
+  const exposed = [];
+  // 同時に走る別のhookは、lockが見えた時点でそのACLを検証する。ACL processの起動を、その検証が入りうる瞬間として見る。
+  t.mock.method(childProcess, 'spawnSync', (command, args, options) => {
+    if (existsSync(lockPath) && !applied.has(statSync(lockPath, { bigint: true }).ino)) exposed.push(options.env.THROUGHLINE_ACL_PATH);
+    if (args.at(-1).includes('Set-Acl')) applied.add(statSync(options.env.THROUGHLINE_ACL_PATH, { bigint: true }).ino);
+    return { status: 0, signal: null, error: undefined };
+  });
+  const options = { env: box.env, configPath: box.configPath, storePath: box.storePath };
+
+  assert.equal(observeRuntimeError({ code: 'HOOK_CODEX_FAILED' }, options).status, 'recorded');
+  assert.deepEqual(exposed, [], 'the lock must not be visible with an inherited ACL');
+  assert.ok(applied.has(statSync(lockPath, { bigint: true }).ino));
+  assert.deepEqual(readdirSync(dirname(lockPath)).filter((name) => name.endsWith('.tmp')), []);
+});
+
 test('runtime error store: Windows temporary ACL failure leaves the previous atomic store intact', (t) => {
   const box = sandbox();
   box.env.OS = 'Windows_NT';